From nobody Fri Jan 2 13:58:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D31CD98E0 for ; Wed, 11 Oct 2023 01:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344585AbjJKBWO (ORCPT ); Tue, 10 Oct 2023 21:22:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344484AbjJKBWM (ORCPT ); Tue, 10 Oct 2023 21:22:12 -0400 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E134D8F for ; Tue, 10 Oct 2023 18:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Vr7Bs tkKmldss60EUl/n4EYbPgUE5JxJ5+BpG7bzkYQ=; b=AkSI/sGdPGFgpvQqRApYk DgNxb1fFcsvtgE0LcqGEn/AZs5OcgDhYyWCTyL4BOpUZvH2QgNicuZm0FdPNuFfS myzuCrppFgQiVngRc3p3b18bsUoa+53PmtDeQk6wGREuxjJKlEnNM9s4OfLyTojG MKBl4Cstx1ai+A4iEGXieg= Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by zwqz-smtp-mta-g2-4 (Coremail) with SMTP id _____wBHZiep+CVluP_jAA--.11044S4; Wed, 11 Oct 2023 09:21:54 +0800 (CST) From: Ma Ke To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH] drm/radeon: fix a possible null pointer dereference Date: Wed, 11 Oct 2023 09:21:43 +0800 Message-Id: <20231011012143.4091532-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBHZiep+CVluP_jAA--.11044S4 X-Coremail-Antispam: 1Uf129KBjvdXoWruryxAF1xKr4fJr13WFW7Arb_yoWDWrg_WF ykXa9rXa90vas5AF1UZFn7Jr9F9rW8ZFWkJw1fta4S9397tF1xCFW3GFWYv3y3Xay5AF98 Aw4rKr13CF4xKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKpBTDUUUUU== X-Originating-IP: [183.174.60.14] X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/xtbBFQUFC2B9odECqQABsZ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In radeon_tv_get_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid null point dereference. Signed-off-by: Ma Ke --- drivers/gpu/drm/radeon/radeon_connectors.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/r= adeon/radeon_connectors.c index d2f02c3dfce2..b84b58926106 100644 --- a/drivers/gpu/drm/radeon/radeon_connectors.c +++ b/drivers/gpu/drm/radeon/radeon_connectors.c @@ -1119,6 +1119,8 @@ static int radeon_tv_get_modes(struct drm_connector *= connector) else { /* only 800x600 is supported right now on pre-avivo chips */ tv_mode =3D drm_cvt_mode(dev, 800, 600, 60, false, false, false); + if (!tv_mode) + return 0; tv_mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; drm_mode_probed_add(connector, tv_mode); } --=20 2.37.2