From nobody Fri Jan 2 13:58:18 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5544CD98C0 for ; Tue, 10 Oct 2023 22:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343743AbjJJWqu (ORCPT ); Tue, 10 Oct 2023 18:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbjJJWqr (ORCPT ); Tue, 10 Oct 2023 18:46:47 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265279D; Tue, 10 Oct 2023 15:46:46 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-58974d4335aso598789a12.1; Tue, 10 Oct 2023 15:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696978005; x=1697582805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yfc2ApoKjWF5pFCF6Ncuv8BWtgDho+97WSMGGN/f+Hw=; b=anVlnXYDKoxrH3dpt/8b+McTGxFnk4kBeIk/7dP+Z6eRraqtvL6OhpXbkmi3zsB7xi xko4G0SpdOBOgh17tygxnKDESMsKFi20jFjSxjDDw93AoealRrAVghM6X5NvaB4MJqba HVH1i1pKJEtDH++r5/1LCuo3kfqDltCp0HIqq6SdR1TnsKwEHYwgmijGfwl+Um6gf/l8 yV5uq6iB5qSTWbGj6yAimugjntTFJt5d5miUsD185tLD0BRTG7BQuMBn5j+KdLi8nqqy dOjknak23IYC03odM2pA83nefeDJW9jnbjghOZ0Pk7I13pDPaoDvHFaXh7UXQnY/eLaC KzJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696978005; x=1697582805; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yfc2ApoKjWF5pFCF6Ncuv8BWtgDho+97WSMGGN/f+Hw=; b=Tw9/r718SaD4mf21OnNl0J8qUoHUQDKZ/c43JGWRB3NlNmRSZND4ET5ZlHXQRHSdAm YV6ytx5F3kCw4nm5BwnFdi4AvC8GgGA5EBIqT2OKjHABJnZfT+iSkl25HcvYrPMr2Hcb yach5JT3HMkT93glmJ0IA80SfLf7mbH4rKPRkXHuRTRjIaa5NKreMf8d3t9o+5csZ8pL 65C4hOfBsDc8p9Cm5H/C1TMxuKCtcPfVv3sw07afHl7bMUgFvdYIUeyn5B6HCLswEfXN g1KBn/MKyly+zYQKt3hv8HByLbfzjAXaO9kBrQIzrj9tvgXW2EMl2F9N6dWnGrsjcl2O c1HQ== X-Gm-Message-State: AOJu0YzNI8Dzqv4UeXYyBbXc3I8DJIlfhRJUXzZEbl0JK7FwTc32LiDk 502XVBjHqG6zPqxnYkmGDnw= X-Google-Smtp-Source: AGHT+IFt9Myk9KUHdeA/2gFtXuUyoJ9lWC8rmYSHPW2LIP7dUo+hLgSjBkzvVkLLobEJ++Viinf8Ew== X-Received: by 2002:a05:6a20:daa8:b0:171:947f:465b with SMTP id iy40-20020a056a20daa800b00171947f465bmr4587914pzb.4.1696978005607; Tue, 10 Oct 2023 15:46:45 -0700 (PDT) Received: from abhinav.. ([103.75.161.210]) by smtp.gmail.com with ESMTPSA id j13-20020a62b60d000000b0068fbaea118esm8692062pff.45.2023.10.10.15.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 15:46:45 -0700 (PDT) From: Abhinav Singh To: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Abhinav Singh Subject: [PATCH] Remove extra unlock for the mutex Date: Wed, 11 Oct 2023 04:16:30 +0530 Message-Id: <20231010224630.238254-1-singhabhinav9051571833@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is a double unlock on mutex. This can cause undefined behaviour. Signed-off-by: Abhinav Singh --- net/ipv4/inet_connection_sock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_soc= k.c index aeebe8816689..f11fe8c727a4 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -597,7 +597,6 @@ int inet_csk_get_port(struct sock *sk, unsigned short s= num) } if (head2_lock_acquired) spin_unlock(&head2->lock); - spin_unlock_bh(&head->lock); return ret; } EXPORT_SYMBOL_GPL(inet_csk_get_port); --=20 2.39.2