From nobody Thu Dec 18 08:16:29 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AFACD6910 for ; Tue, 10 Oct 2023 09:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230222AbjJJJWA (ORCPT ); Tue, 10 Oct 2023 05:22:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbjJJJV1 (ORCPT ); Tue, 10 Oct 2023 05:21:27 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57E5DB4; Tue, 10 Oct 2023 02:21:25 -0700 (PDT) Received: from kwepemm000012.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S4Vg73QQdzVlPW; Tue, 10 Oct 2023 17:17:55 +0800 (CST) Received: from build.huawei.com (10.175.101.6) by kwepemm000012.china.huawei.com (7.193.23.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 10 Oct 2023 17:21:23 +0800 From: Wenchao Hao To: "Martin K . Petersen" , Douglas Gilbert CC: "James E . J . Bottomley" , , , , Wenchao Hao Subject: [PATCH v6 09/10] scsi: scsi_debug: Add debugfs interface to fail target reset Date: Tue, 10 Oct 2023 17:20:50 +0800 Message-ID: <20231010092051.608007-10-haowenchao2@huawei.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20231010092051.608007-1-haowenchao2@huawei.com> References: <20231010092051.608007-1-haowenchao2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000012.china.huawei.com (7.193.23.142) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The interface is found at /sys/kernel/debug/scsi_debug/target/fail_reset where identifies the target to inject errors on. It's a simple bool type interface which would make this target's reset fail if set to 'Y'. Signed-off-by: Wenchao Hao --- drivers/scsi/scsi_debug.c | 114 +++++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index e54ba0bfa0d6..2743eb36c58e 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -42,6 +42,7 @@ #include #include #include +#include =20 #include =20 @@ -357,6 +358,11 @@ struct sdebug_dev_info { struct list_head inject_err_list; }; =20 +struct sdebug_target_info { + bool reset_fail; + struct dentry *debugfs_entry; +}; + struct sdebug_host_info { struct list_head host_list; int si_idx; /* sdeb_store_info (per host) xarray index */ @@ -1082,6 +1088,91 @@ static const struct file_operations sdebug_error_fop= s =3D { .release =3D single_release, }; =20 +static int sdebug_target_reset_fail_show(struct seq_file *m, void *p) +{ + struct scsi_target *starget =3D (struct scsi_target *)m->private; + struct sdebug_target_info *targetip =3D + (struct sdebug_target_info *)starget->hostdata; + + if (targetip) + seq_printf(m, "%c\n", targetip->reset_fail ? 'Y' : 'N'); + + return 0; +} + +static int sdebug_target_reset_fail_open(struct inode *inode, struct file = *file) +{ + return single_open(file, sdebug_target_reset_fail_show, inode->i_private); +} + +static ssize_t sdebug_target_reset_fail_write(struct file *file, + const char __user *ubuf, size_t count, loff_t *ppos) +{ + int ret; + struct scsi_target *starget =3D + (struct scsi_target *)file->f_inode->i_private; + struct sdebug_target_info *targetip =3D + (struct sdebug_target_info *)starget->hostdata; + + if (targetip) { + ret =3D kstrtobool_from_user(ubuf, count, &targetip->reset_fail); + return ret < 0 ? ret : count; + } + return -ENODEV; +} + +static const struct file_operations sdebug_target_reset_fail_fops =3D { + .open =3D sdebug_target_reset_fail_open, + .read =3D seq_read, + .write =3D sdebug_target_reset_fail_write, + .release =3D single_release, +}; + +static int sdebug_target_alloc(struct scsi_target *starget) +{ + struct sdebug_target_info *targetip; + struct dentry *dentry; + + targetip =3D kzalloc(sizeof(struct sdebug_target_info), GFP_KERNEL); + if (!targetip) + return -ENOMEM; + + targetip->debugfs_entry =3D debugfs_create_dir(dev_name(&starget->dev), + sdebug_debugfs_root); + if (IS_ERR_OR_NULL(targetip->debugfs_entry)) + pr_info("%s: failed to create debugfs directory for target %s\n", + __func__, dev_name(&starget->dev)); + + debugfs_create_file("fail_reset", 0600, targetip->debugfs_entry, starget, + &sdebug_target_reset_fail_fops); + if (IS_ERR_OR_NULL(dentry)) + pr_info("%s: failed to create fail_reset file for target %s\n", + __func__, dev_name(&starget->dev)); + + starget->hostdata =3D targetip; + + return 0; +} + +static void sdebug_tartget_cleanup_async(void *data, async_cookie_t cookie) +{ + struct sdebug_target_info *targetip =3D data; + + debugfs_remove(targetip->debugfs_entry); + kfree(targetip); +} + +static void sdebug_target_destroy(struct scsi_target *starget) +{ + struct sdebug_target_info *targetip; + + targetip =3D (struct sdebug_target_info *)starget->hostdata; + if (targetip) { + starget->hostdata =3D NULL; + async_schedule(sdebug_tartget_cleanup_async, targetip); + } +} + /* Only do the extra work involved in logical block provisioning if one or * more of the lbpu, lbpws or lbpws10 parameters are given and we are doing * real reads and writes (i.e. not skipping them for speed). @@ -5642,11 +5733,25 @@ static int scsi_debug_device_reset(struct scsi_cmnd= *SCpnt) return SUCCESS; } =20 +static int sdebug_fail_target_reset(struct scsi_cmnd *cmnd) +{ + struct scsi_target *starget =3D scsi_target(cmnd->device); + struct sdebug_target_info *targetip =3D + (struct sdebug_target_info *)starget->hostdata; + + if (targetip) + return targetip->reset_fail; + + return 0; +} + static int scsi_debug_target_reset(struct scsi_cmnd *SCpnt) { struct scsi_device *sdp =3D SCpnt->device; struct sdebug_host_info *sdbg_host =3D shost_to_sdebug_host(sdp->host); struct sdebug_dev_info *devip; + u8 *cmd =3D SCpnt->cmnd; + u8 opcode =3D cmd[0]; int k =3D 0; =20 ++num_target_resets; @@ -5664,6 +5769,12 @@ static int scsi_debug_target_reset(struct scsi_cmnd = *SCpnt) sdev_printk(KERN_INFO, sdp, "%s: %d device(s) found in target\n", __func__, k); =20 + if (sdebug_fail_target_reset(SCpnt)) { + scmd_printk(KERN_INFO, SCpnt, "fail target reset 0x%x\n", + opcode); + return FAILED; + } + return SUCCESS; } =20 @@ -8119,7 +8230,6 @@ static int sdebug_init_cmd_priv(struct Scsi_Host *sho= st, struct scsi_cmnd *cmd) return 0; } =20 - static struct scsi_host_template sdebug_driver_template =3D { .show_info =3D scsi_debug_show_info, .write_info =3D scsi_debug_write_info, @@ -8149,6 +8259,8 @@ static struct scsi_host_template sdebug_driver_templa= te =3D { .track_queue_depth =3D 1, .cmd_size =3D sizeof(struct sdebug_scsi_cmd), .init_cmd_priv =3D sdebug_init_cmd_priv, + .target_alloc =3D sdebug_target_alloc, + .target_destroy =3D sdebug_target_destroy, }; =20 static int sdebug_driver_probe(struct device *dev) --=20 2.32.0