From nobody Fri Jan 2 17:12:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DEFCD613A for ; Mon, 9 Oct 2023 21:14:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378669AbjJIVOS (ORCPT ); Mon, 9 Oct 2023 17:14:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378652AbjJIVOO (ORCPT ); Mon, 9 Oct 2023 17:14:14 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB6392; Mon, 9 Oct 2023 14:14:13 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57DD6C433C8; Mon, 9 Oct 2023 21:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696886052; bh=i4X/vNFkCjPk4yHPDzSDoFpjb66LQuRc1sygQ/O3xKM=; h=From:To:Cc:Subject:Date:From; b=CWIri7A6oxBeh3cQs4ZB5m0ts1YQvjE5P9iz31i0NipnWDBTs7+naZtGVs65xxfkl kgpZL2e0OX3vuBf17HFaK1XPJEjDnx3Ozn2ApWwGs/eeWs4azGMEuBBo4iWEN+BurE X9+/s974r6WMrtu+ckgRIGvIcofTS8g2B2aMC9+VnFTdZTsntHH1tVrNhBXgybZ0o7 upVTLfCaAwkj3MMNcz8+yzCJfJEwgvYfERDgyTRU2LdKHjyIC9oD8yxMGJL4N52EZi fQWJH3ETj1Jlk0woqkHXUKsVGLnIifv3gQJV5MV3G3AevO2IWGp0IrZl5++rDEavUr fX7VpxSmKpxYw== Received: (nullmailer pid 3245330 invoked by uid 1000); Mon, 09 Oct 2023 21:14:08 -0000 From: Rob Herring To: Lee Jones , Chen-Yu Tsai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Tony Lindgren Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH] mfd: Use device_get_match_data() Date: Mon, 9 Oct 2023 16:13:33 -0500 Message-ID: <20231009211356.3242037-3-robh@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring Reviewed-by: Chen-Yu Tsai --- drivers/mfd/axp20x.c | 22 +++------------------- drivers/mfd/hi6421-pmic-core.c | 9 +++------ drivers/mfd/mxs-lradc.c | 9 ++------- drivers/mfd/qcom-spmi-pmic.c | 6 ++++-- drivers/mfd/qcom_rpm.c | 8 ++++---- drivers/mfd/tps65910.c | 11 ++--------- drivers/mfd/twl4030-power.c | 9 +++------ drivers/mfd/twl6030-irq.c | 10 +++++----- 8 files changed, 26 insertions(+), 58 deletions(-) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index d93189b0230d..deaa969bab4e 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -22,7 +22,8 @@ #include #include #include -#include +#include +#include #include #include #include @@ -1131,27 +1132,10 @@ static int axp20x_power_off(struct sys_off_data *da= ta) int axp20x_match_device(struct axp20x_dev *axp20x) { struct device *dev =3D axp20x->dev; - const struct acpi_device_id *acpi_id; - const struct of_device_id *of_id; const struct mfd_cell *cells_no_irq =3D NULL; int nr_cells_no_irq =3D 0; =20 - if (dev->of_node) { - of_id =3D of_match_device(dev->driver->of_match_table, dev); - if (!of_id) { - dev_err(dev, "Unable to match OF ID\n"); - return -ENODEV; - } - axp20x->variant =3D (long)of_id->data; - } else { - acpi_id =3D acpi_match_device(dev->driver->acpi_match_table, dev); - if (!acpi_id || !acpi_id->driver_data) { - dev_err(dev, "Unable to match ACPI ID and data\n"); - return -ENODEV; - } - axp20x->variant =3D (long)acpi_id->driver_data; - } - + axp20x->variant =3D (long)device_get_match_data(dev); switch (axp20x->variant) { case AXP152_ID: axp20x->nr_cells =3D ARRAY_SIZE(axp152_cells); diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c index a6a890537a1e..5af24a438329 100644 --- a/drivers/mfd/hi6421-pmic-core.c +++ b/drivers/mfd/hi6421-pmic-core.c @@ -15,8 +15,9 @@ #include #include #include -#include +#include #include +#include #include =20 static const struct mfd_cell hi6421_devs[] =3D { @@ -50,16 +51,12 @@ MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match); static int hi6421_pmic_probe(struct platform_device *pdev) { struct hi6421_pmic *pmic; - const struct of_device_id *id; const struct mfd_cell *subdevs; enum hi6421_type type; void __iomem *base; int n_subdevs, ret; =20 - id =3D of_match_device(of_hi6421_pmic_match, &pdev->dev); - if (!id) - return -EINVAL; - type =3D (uintptr_t)id->data; + type =3D (uintptr_t)device_get_match_data(&pdev->dev); =20 pmic =3D devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL); if (!pmic) diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c index 21f3033d6eb5..ec1b356562b9 100644 --- a/drivers/mfd/mxs-lradc.c +++ b/drivers/mfd/mxs-lradc.c @@ -16,8 +16,8 @@ #include #include #include -#include #include +#include #include =20 #define ADC_CELL 0 @@ -125,7 +125,6 @@ MODULE_DEVICE_TABLE(of, mxs_lradc_dt_ids); =20 static int mxs_lradc_probe(struct platform_device *pdev) { - const struct of_device_id *of_id; struct device *dev =3D &pdev->dev; struct device_node *node =3D dev->of_node; struct mxs_lradc *lradc; @@ -138,11 +137,7 @@ static int mxs_lradc_probe(struct platform_device *pde= v) if (!lradc) return -ENOMEM; =20 - of_id =3D of_match_device(mxs_lradc_dt_ids, &pdev->dev); - if (!of_id) - return -EINVAL; - - lradc->soc =3D (uintptr_t)of_id->data; + lradc->soc =3D (enum mxs_lradc_id)device_get_match_data(&pdev->dev); =20 lradc->clk =3D devm_clk_get(&pdev->dev, NULL); if (IS_ERR(lradc->clk)) { diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c index 7e2cd79d17eb..4899af64bf10 100644 --- a/drivers/mfd/qcom-spmi-pmic.c +++ b/drivers/mfd/qcom-spmi-pmic.c @@ -8,10 +8,12 @@ #include #include #include +#include +#include +#include #include #include #include -#include #include =20 #define PMIC_REV2 0x101 @@ -236,7 +238,7 @@ static int pmic_spmi_probe(struct spmi_device *sdev) if (!ctx) return -ENOMEM; =20 - ctx->num_usids =3D (uintptr_t)of_device_get_match_data(&sdev->dev); + ctx->num_usids =3D (uintptr_t)device_get_match_data(&sdev->dev); =20 /* Only the first slave id for a PMIC contains this information */ if (sdev->usid % ctx->num_usids =3D=3D 0) { diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c index 086611322874..27446f43e3f3 100644 --- a/drivers/mfd/qcom_rpm.c +++ b/drivers/mfd/qcom_rpm.c @@ -7,6 +7,8 @@ =20 #include #include +#include +#include #include #include #include @@ -528,7 +530,6 @@ static irqreturn_t qcom_rpm_wakeup_interrupt(int irq, v= oid *dev) =20 static int qcom_rpm_probe(struct platform_device *pdev) { - const struct of_device_id *match; struct device_node *syscon_np; struct qcom_rpm *rpm; u32 fw_version[3]; @@ -570,10 +571,9 @@ static int qcom_rpm_probe(struct platform_device *pdev) if (irq_wakeup < 0) return irq_wakeup; =20 - match =3D of_match_device(qcom_rpm_of_match, &pdev->dev); - if (!match) + rpm->data =3D device_get_match_data(&pdev->dev); + if (!rpm->data) return -ENODEV; - rpm->data =3D match->data; =20 rpm->status_regs =3D devm_platform_get_and_ioremap_resource(pdev, 0, NULL= ); if (IS_ERR(rpm->status_regs)) diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c index 41408df1712f..dce6ad668dbf 100644 --- a/drivers/mfd/tps65910.c +++ b/drivers/mfd/tps65910.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include =20 static const struct resource rtc_resources[] =3D { { @@ -374,16 +374,9 @@ static struct tps65910_board *tps65910_parse_dt(struct= i2c_client *client, struct device_node *np =3D client->dev.of_node; struct tps65910_board *board_info; unsigned int prop; - const struct of_device_id *match; int ret; =20 - match =3D of_match_device(tps65910_of_match, &client->dev); - if (!match) { - dev_err(&client->dev, "Failed to find matching dt id\n"); - return NULL; - } - - *chip_id =3D (unsigned long)match->data; + *chip_id =3D (unsigned long)device_get_match_data(&client->dev); =20 board_info =3D devm_kzalloc(&client->dev, sizeof(*board_info), GFP_KERNEL); diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index e35b0f788c50..1595e9c76132 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -27,8 +27,8 @@ #include #include #include +#include #include -#include =20 #include =20 @@ -883,7 +883,6 @@ static int twl4030_power_probe(struct platform_device *= pdev) { const struct twl4030_power_data *pdata =3D dev_get_platdata(&pdev->dev); struct device_node *node =3D pdev->dev.of_node; - const struct of_device_id *match; int err =3D 0; int err2 =3D 0; u8 val; @@ -904,10 +903,8 @@ static int twl4030_power_probe(struct platform_device = *pdev) return err; } =20 - match =3D of_match_device(of_match_ptr(twl4030_power_of_match), - &pdev->dev); - if (match && match->data) - pdata =3D match->data; + if (node) + pdata =3D device_get_match_data(&pdev->dev); =20 if (pdata) { err =3D twl4030_power_configure_scripts(pdata); diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index 3c03681c124c..f9fce8408c2c 100644 --- a/drivers/mfd/twl6030-irq.c +++ b/drivers/mfd/twl6030-irq.c @@ -24,10 +24,10 @@ #include #include #include +#include #include #include #include -#include =20 #include "twl-core.h" =20 @@ -368,10 +368,10 @@ int twl6030_init_irq(struct device *dev, int irq_num) int nr_irqs; int status; u8 mask[3]; - const struct of_device_id *of_id; + const int *irq_tbl; =20 - of_id =3D of_match_device(twl6030_of_match, dev); - if (!of_id || !of_id->data) { + irq_tbl =3D device_get_match_data(dev); + if (!irq_tbl) { dev_err(dev, "Unknown TWL device model\n"); return -EINVAL; } @@ -409,7 +409,7 @@ int twl6030_init_irq(struct device *dev, int irq_num) =20 twl6030_irq->pm_nb.notifier_call =3D twl6030_irq_pm_notifier; atomic_set(&twl6030_irq->wakeirqs, 0); - twl6030_irq->irq_mapping_tbl =3D of_id->data; + twl6030_irq->irq_mapping_tbl =3D irq_tbl; =20 twl6030_irq->irq_domain =3D irq_domain_add_linear(node, nr_irqs, --=20 2.42.0