From nobody Fri Jan 2 18:50:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B96B9E95A96 for ; Mon, 9 Oct 2023 12:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376340AbjJIMXQ (ORCPT ); Mon, 9 Oct 2023 08:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376343AbjJIMXO (ORCPT ); Mon, 9 Oct 2023 08:23:14 -0400 Received: from out-193.mta0.migadu.com (out-193.mta0.migadu.com [91.218.175.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB83EDF for ; Mon, 9 Oct 2023 05:23:12 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696854190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5KeMaN6CEe65Ia/B/zeGHWtr7cEhMkoaCHnrN7qH3bE=; b=KyNPi4ZPdRkBQpIl20IRIwS+EB8A7MQgNse6+LNWkkktoKu4w46pHWKcQ5ksWzBkcfWRGN Mc6feowEsmRGQNnq4HKLyttGGKy6umm6s0y55370vDHFSdeyswl30IM76j6vxKY0gA42ih Y7oXmTMWQpQLh4MdUJhf7i/cX0KGu0I= From: Yajun Deng To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH v7 1/3] sched/rt: Introduce for_each_sched_rt_entity_back() & use it Date: Mon, 9 Oct 2023 20:22:42 +0800 Message-Id: <20231009122244.2394336-2-yajun.deng@linux.dev> In-Reply-To: <20231009122244.2394336-1-yajun.deng@linux.dev> References: <20231009122244.2394336-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Introduce for_each_sched_rt_entity_back() & use it, because it's safe to call it whether CONFIG_RT_GROUP_SCHED is enabled or disabled. No functional changes. Signed-off-by: Yajun Deng --- v7: Same with v6. v6: Independent patch. v5: Resend it. v4: Missed rt_se =3D root in dequeue_rt_stack(). v3: Keep parent is NULL in init_tg_rt_entry(). v2: Add WARN_ON_ONCE in init_tg_rt_entry(). v1: https://lore.kernel.org/all/20230801062714.3424299-1-yajun.deng@linux.d= ev/ --- kernel/sched/rt.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 88fc98601413..642edbd24ffb 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -520,6 +520,9 @@ static inline struct task_group *next_task_group(struct= task_group *tg) #define for_each_sched_rt_entity(rt_se) \ for (; rt_se; rt_se =3D rt_se->parent) =20 +#define for_each_sched_rt_entity_back(rt_se) \ + for (; rt_se; rt_se =3D rt_se->back) + static inline struct rt_rq *group_rt_rq(struct sched_rt_entity *rt_se) { return rt_se->my_q; @@ -625,6 +628,9 @@ typedef struct rt_rq *rt_rq_iter_t; #define for_each_sched_rt_entity(rt_se) \ for (; rt_se; rt_se =3D NULL) =20 +#define for_each_sched_rt_entity_back(rt_se) \ + for_each_sched_rt_entity(rt_se) + static inline struct rt_rq *group_rt_rq(struct sched_rt_entity *rt_se) { return NULL; @@ -1445,7 +1451,8 @@ static void dequeue_rt_stack(struct sched_rt_entity *= rt_se, unsigned int flags) =20 rt_nr_running =3D rt_rq_of_se(back)->rt_nr_running; =20 - for (rt_se =3D back; rt_se; rt_se =3D rt_se->back) { + rt_se =3D back; + for_each_sched_rt_entity_back(rt_se) { if (on_rt_rq(rt_se)) __dequeue_rt_entity(rt_se, flags); } --=20 2.25.1 From nobody Fri Jan 2 18:50:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097FAE95A8E for ; Mon, 9 Oct 2023 12:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376352AbjJIMX2 (ORCPT ); Mon, 9 Oct 2023 08:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346541AbjJIMXY (ORCPT ); Mon, 9 Oct 2023 08:23:24 -0400 Received: from out-206.mta0.migadu.com (out-206.mta0.migadu.com [91.218.175.206]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB02E4 for ; Mon, 9 Oct 2023 05:23:21 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696854199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YTkuKu1fmFP1M034eiGkI3GZ+Be2ZuV6kkNwoobSAUo=; b=ljkycbSmLqUGFWruU2fcp9eRmUqqUsv6xbsMmGj/kikBW3o8UHJ0nwJvd+X5KfoA7JXFUi Rw/aqMblSuY+wXWtnCDmJ1dfy1A0prXXDaqMfgUtD8pvSrx6JRmiz4OOktns3TICPmxN+1 T1L2gPv2+mRV0MLQucM79pD2L5N7dmI= From: Yajun Deng To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH v7 2/3] sched/rt: Init 'back' in init_tg_rt_entry Date: Mon, 9 Oct 2023 20:22:43 +0800 Message-Id: <20231009122244.2394336-3-yajun.deng@linux.dev> In-Reply-To: <20231009122244.2394336-1-yajun.deng@linux.dev> References: <20231009122244.2394336-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The member 'back' in struct sched_rt_entity only related to CONFIG_RT_GROUP_SCHED, so there is no need to init it in dequeue_rt_stack. Init the member 'back' in init_tg_rt_entry. Signed-off-by: Yajun Deng --- v7: Init 'back' in init_tg_rt_entry. v6: Independent patch. v5: Resend it. v4: Missed rt_se =3D root in dequeue_rt_stack(). v3: Keep parent is NULL in init_tg_rt_entry(). v2: Add WARN_ON_ONCE in init_tg_rt_entry(). v1: https://lore.kernel.org/all/20230801062714.3424299-1-yajun.deng@linux.d= ev/ --- kernel/sched/rt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 642edbd24ffb..0d9e83c6fb71 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -233,8 +233,10 @@ void init_tg_rt_entry(struct task_group *tg, struct rt= _rq *rt_rq, =20 if (!parent) rt_se->rt_rq =3D &rq->rt; - else + else { rt_se->rt_rq =3D parent->my_q; + parent->back =3D rt_se; + } =20 rt_se->my_q =3D rt_rq; rt_se->parent =3D parent; @@ -1444,10 +1446,8 @@ static void dequeue_rt_stack(struct sched_rt_entity = *rt_se, unsigned int flags) struct sched_rt_entity *back =3D NULL; unsigned int rt_nr_running; =20 - for_each_sched_rt_entity(rt_se) { - rt_se->back =3D back; + for_each_sched_rt_entity(rt_se) back =3D rt_se; - } =20 rt_nr_running =3D rt_rq_of_se(back)->rt_nr_running; =20 --=20 2.25.1 From nobody Fri Jan 2 18:50:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E60E95A8E for ; Mon, 9 Oct 2023 12:23:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376405AbjJIMXd (ORCPT ); Mon, 9 Oct 2023 08:23:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376364AbjJIMXa (ORCPT ); Mon, 9 Oct 2023 08:23:30 -0400 Received: from out-208.mta0.migadu.com (out-208.mta0.migadu.com [91.218.175.208]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 517D899 for ; Mon, 9 Oct 2023 05:23:27 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696854206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pOSdnU//ZRui2s27MXfjnW8MdGjzkW8wxZ4C5+bH6Oo=; b=PvcXroXrprpbYbEiTKcBlDzrNxIHYqJQlTyn41kwGmaXE3WAnFw/W12yM8Dh7G5G4p9n2L jiy/MdWQj2Dwe14V1229DeYuc5rdV+oVyf0hmEy6v2/e7BhMxMMHD/GGn6i4bULZTecDms H99KLe2PP7QMZU3Xvyx79kfOGc5Jwgk= From: Yajun Deng To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH v7 3/3] sched/headers: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block Date: Mon, 9 Oct 2023 20:22:44 +0800 Message-Id: <20231009122244.2394336-4-yajun.deng@linux.dev> In-Reply-To: <20231009122244.2394336-1-yajun.deng@linux.dev> References: <20231009122244.2394336-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We already remove the call to the 'back' member when CONFIG_RT_GROUP_SCHED is disabled. It's safe to move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block, it would save a few bytes. Signed-off-by: Yajun Deng --- v7: Only move back under the CONFIG_RT_GROUP_SCHED block. v6: Independent patch. v5: Resend it. v4: Missed rt_se =3D root in dequeue_rt_stack(). v3: Keep parent is NULL in init_tg_rt_entry(). v2: Add WARN_ON_ONCE in init_tg_rt_entry(). v1: https://lore.kernel.org/all/20230801062714.3424299-1-yajun.deng@linux.d= ev/ --- include/linux/sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 292c31697248..d0fe56603e60 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -597,8 +597,8 @@ struct sched_rt_entity { unsigned short on_rq; unsigned short on_list; =20 - struct sched_rt_entity *back; #ifdef CONFIG_RT_GROUP_SCHED + struct sched_rt_entity *back; struct sched_rt_entity *parent; /* rq on which this entity is (to be) queued: */ struct rt_rq *rt_rq; --=20 2.25.1