From nobody Fri Jan 2 19:07:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857A1E95A91 for ; Mon, 9 Oct 2023 09:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345797AbjJIJGR (ORCPT ); Mon, 9 Oct 2023 05:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345626AbjJIJF4 (ORCPT ); Mon, 9 Oct 2023 05:05:56 -0400 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A6394135 for ; Mon, 9 Oct 2023 02:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=6yXs2 gkpjduwZ+P2UYJQXSGNeyBU1a+rkA4sXx35cEE=; b=UEfNIjZvRWTQeoH2s4czH pOgcfYRoOxkamqTgznWzuY2Yq6Ef11BENiwff2ewdEpW9Ul0CghJ8i5AWc8N3goU 0wzYzJqVlbSUIVh4rpA6AEyFjUf9dNb05pY2+luBn5LY6KX/xrIrvhFCDIbCKp7L AzxEk7v2aLAtI+wGkMrS1s= Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by zwqz-smtp-mta-g2-3 (Coremail) with SMTP id _____wDnLyQwwiNlJnJJAA--.42078S4; Mon, 09 Oct 2023 17:04:55 +0800 (CST) From: Ma Ke To: linus.walleij@linaro.org, neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Date: Mon, 9 Oct 2023 17:04:46 +0800 Message-Id: <20231009090446.4043798-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnLyQwwiNlJnJJAA--.42078S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF1rZr4fAFyxJw4kuFyDWrg_yoWfKwc_W3 W8XasrurW7uas7CF4Iva13Ar9IyFs8ZF4kZ3WSka4IkrykGF43XrZ8Wr909a4UuF17uFZ8 Aa4xCF1YvFnrGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKLvK7UUUUU== X-Originating-IP: [183.174.60.14] X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/1tbivhgEC1ZcjCSMGAAAsf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In tpg110_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/pan= el/panel-tpo-tpg110.c index 845304435e23..f6a212e542cb 100644 --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c @@ -379,6 +379,8 @@ static int tpg110_get_modes(struct drm_panel *panel, connector->display_info.bus_flags =3D tpg->panel_mode->bus_flags; =20 mode =3D drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode); + if (!mode) + return -ENOMEM; drm_mode_set_name(mode); mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; =20 --=20 2.37.2