From nobody Fri Jan 2 22:09:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A615E81E14 for ; Sat, 7 Oct 2023 03:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343514AbjJGDbj (ORCPT ); Fri, 6 Oct 2023 23:31:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343492AbjJGDbf (ORCPT ); Fri, 6 Oct 2023 23:31:35 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AEDFABD for ; Fri, 6 Oct 2023 20:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=4RsFb 4cDEF9CsE4C+nnjJIb297G75Zf5+DKvSCmQ53c=; b=mREDyS4DY/EfF2DRysC/g LAjiSHvUCiXp3JpUOjVjNculFvsl1pUPYNsYJrxEtuuJWJgFtnwiq48c/kLsl5ZX Jn+lHoMmc0gXes/GfPzSIzbD1vkb1si4J/5q8LOBUNXS7qd/6WEmK+rdt8MuqOrd SMZ8xhwuqVQkjynucmYzNU= Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by zwqz-smtp-mta-g4-0 (Coremail) with SMTP id _____wDHeIn60CBlKTcrEA--.50449S4; Sat, 07 Oct 2023 11:31:15 +0800 (CST) From: Ma Ke To: linus.walleij@linaro.org, neil.armstrong@linaro.org, sam@ravnborg.org, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH] drm/panel: fix a possible null pointer dereference Date: Sat, 7 Oct 2023 11:31:05 +0800 Message-Id: <20231007033105.3997998-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDHeIn60CBlKTcrEA--.50449S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF1rZr4fAF1DGF47Cry8Zrb_yoWDWwb_Gr 18Xasrur4UX3WxursFyw15Aryayrs5ZF4kuw1Ska42kr9rGr13XFn2gryUua4UZF17AryD u343ZFyY9FsrGjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKzVbJUUUUU== X-Originating-IP: [183.174.60.14] X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/1tbiyAMCC1p7MCCE3AAAsr Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In versatile_panel_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Signed-off-by: Ma Ke Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-arm-versatile.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-arm-versatile.c b/drivers/gpu/drm/= panel/panel-arm-versatile.c index abb0788843c6..1811bfaeb9c7 100644 --- a/drivers/gpu/drm/panel/panel-arm-versatile.c +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c @@ -267,6 +267,8 @@ static int versatile_panel_get_modes(struct drm_panel *= panel, connector->display_info.bus_flags =3D vpanel->panel_type->bus_flags; =20 mode =3D drm_mode_duplicate(connector->dev, &vpanel->panel_type->mode); + if (!mode) + return -ENOMEM; drm_mode_set_name(mode); mode->type =3D DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; =20 --=20 2.37.2