From nobody Tue Dec 16 21:51:00 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEF4E81DF5 for ; Fri, 6 Oct 2023 13:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232300AbjJFNE4 (ORCPT ); Fri, 6 Oct 2023 09:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232178AbjJFNEw (ORCPT ); Fri, 6 Oct 2023 09:04:52 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347B7DB for ; Fri, 6 Oct 2023 06:04:50 -0700 (PDT) Received: from francesco-nb.corp.toradex.com (unknown [201.82.41.210]) by mail11.truemail.it (Postfix) with ESMTPA id 9027A20F4D; Fri, 6 Oct 2023 15:04:41 +0200 (CEST) From: Francesco Dolcini To: Sebastian Reichel Cc: Stefan Eichenberger , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: [PATCH v2 1/4] power: reset: gpio-poweroff: use a struct to store the module variables Date: Fri, 6 Oct 2023 10:04:25 -0300 Message-Id: <20231006130428.11259-2-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231006130428.11259-1-francesco@dolcini.it> References: <20231006130428.11259-1-francesco@dolcini.it> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Stefan Eichenberger Use a struct to store the module variables. This is required to later move to notifier_blocks where we can have several instances. Signed-off-by: Stefan Eichenberger Signed-off-by: Francesco Dolcini --- drivers/power/reset/gpio-poweroff.c | 48 +++++++++++++++++++---------- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio= -poweroff.c index b28f24da1b3c..dea550e422f3 100644 --- a/drivers/power/reset/gpio-poweroff.c +++ b/drivers/power/reset/gpio-poweroff.c @@ -17,32 +17,37 @@ #include =20 #define DEFAULT_TIMEOUT_MS 3000 + +struct gpio_poweroff { + struct gpio_desc *reset_gpio; + u32 timeout_ms; + u32 active_delay_ms; + u32 inactive_delay_ms; +}; + /* * Hold configuration here, cannot be more than one instance of the driver * since pm_power_off itself is global. */ -static struct gpio_desc *reset_gpio; -static u32 timeout =3D DEFAULT_TIMEOUT_MS; -static u32 active_delay =3D 100; -static u32 inactive_delay =3D 100; +static struct gpio_poweroff *gpio_poweroff; =20 static void gpio_poweroff_do_poweroff(void) { - BUG_ON(!reset_gpio); + BUG_ON(!gpio_poweroff); =20 /* drive it active, also inactive->active edge */ - gpiod_direction_output(reset_gpio, 1); - mdelay(active_delay); + gpiod_direction_output(gpio_poweroff->reset_gpio, 1); + mdelay(gpio_poweroff->active_delay_ms); =20 /* drive inactive, also active->inactive edge */ - gpiod_set_value_cansleep(reset_gpio, 0); - mdelay(inactive_delay); + gpiod_set_value_cansleep(gpio_poweroff->reset_gpio, 0); + mdelay(gpio_poweroff->inactive_delay_ms); =20 /* drive it active, also inactive->active edge */ - gpiod_set_value_cansleep(reset_gpio, 1); + gpiod_set_value_cansleep(gpio_poweroff->reset_gpio, 1); =20 /* give it some time */ - mdelay(timeout); + mdelay(gpio_poweroff->timeout_ms); =20 WARN_ON(1); } @@ -60,20 +65,29 @@ static int gpio_poweroff_probe(struct platform_device *= pdev) return -EBUSY; } =20 + gpio_poweroff =3D devm_kzalloc(&pdev->dev, sizeof(*gpio_poweroff), GFP_KE= RNEL); + if (!gpio_poweroff) + return -ENOMEM; + input =3D device_property_read_bool(&pdev->dev, "input"); if (input) flags =3D GPIOD_IN; else flags =3D GPIOD_OUT_LOW; =20 - device_property_read_u32(&pdev->dev, "active-delay-ms", &active_delay); + + gpio_poweroff->active_delay_ms =3D 100; + gpio_poweroff->inactive_delay_ms =3D 100; + gpio_poweroff->timeout_ms =3D DEFAULT_TIMEOUT_MS; + + device_property_read_u32(&pdev->dev, "active-delay-ms", &gpio_poweroff->a= ctive_delay_ms); device_property_read_u32(&pdev->dev, "inactive-delay-ms", - &inactive_delay); - device_property_read_u32(&pdev->dev, "timeout-ms", &timeout); + &gpio_poweroff->inactive_delay_ms); + device_property_read_u32(&pdev->dev, "timeout-ms", &gpio_poweroff->timeou= t_ms); =20 - reset_gpio =3D devm_gpiod_get(&pdev->dev, NULL, flags); - if (IS_ERR(reset_gpio)) - return PTR_ERR(reset_gpio); + gpio_poweroff->reset_gpio =3D devm_gpiod_get(&pdev->dev, NULL, flags); + if (IS_ERR(gpio_poweroff->reset_gpio)) + return PTR_ERR(gpio_poweroff->reset_gpio); =20 pm_power_off =3D &gpio_poweroff_do_poweroff; return 0; --=20 2.25.1