From nobody Sat Jan 3 06:31:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808ECE936F1 for ; Thu, 5 Oct 2023 01:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244492AbjJEBwx (ORCPT ); Wed, 4 Oct 2023 21:52:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244354AbjJEBwq (ORCPT ); Wed, 4 Oct 2023 21:52:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5919D9 for ; Wed, 4 Oct 2023 18:52:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B09CC433C9; Thu, 5 Oct 2023 01:52:42 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qoDYl-005FK4-1H; Wed, 04 Oct 2023 21:53:51 -0400 Message-ID: <20231005015351.211648665@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 04 Oct 2023 21:53:14 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Beau Belgrave Subject: [for-next][PATCH 4/7] selftests/user_events: Test persist flag cases References: <20231005015310.859143353@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Beau Belgrave Now that we have exposed USER_EVENT_REG_PERSIST events can persist both via the ABI and in the /sys/kernel/tracing/dynamic_events file. Ensure both the ABI and DYN cases work by calling both during the parse tests. Add new flags test that ensures only USER_EVENT_REG_PERSIST is honored and any other flag is invalid. Link: https://lkml.kernel.org/r/20230912180704.1284-3-beaub@linux.microsoft= .com Signed-off-by: Beau Belgrave Signed-off-by: Steven Rostedt (Google) --- .../testing/selftests/user_events/abi_test.c | 55 ++++++++++++++++++- .../testing/selftests/user_events/dyn_test.c | 54 +++++++++++++++++- 2 files changed, 107 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/user_events/abi_test.c b/tools/testing= /selftests/user_events/abi_test.c index 8202f1327c39..3d539e556dcd 100644 --- a/tools/testing/selftests/user_events/abi_test.c +++ b/tools/testing/selftests/user_events/abi_test.c @@ -24,6 +24,18 @@ const char *data_file =3D "/sys/kernel/tracing/user_events_data"; const char *enable_file =3D "/sys/kernel/tracing/events/user_events/__abi_= event/enable"; =20 +static bool event_exists(void) +{ + int fd =3D open(enable_file, O_RDWR); + + if (fd < 0) + return false; + + close(fd); + + return true; +} + static int change_event(bool enable) { int fd =3D open(enable_file, O_RDWR); @@ -47,7 +59,22 @@ static int change_event(bool enable) return ret; } =20 -static int reg_enable(long *enable, int size, int bit) +static int event_delete(void) +{ + int fd =3D open(data_file, O_RDWR); + int ret; + + if (fd < 0) + return -1; + + ret =3D ioctl(fd, DIAG_IOCSDEL, "__abi_event"); + + close(fd); + + return ret; +} + +static int reg_enable_flags(long *enable, int size, int bit, int flags) { struct user_reg reg =3D {0}; int fd =3D open(data_file, O_RDWR); @@ -58,6 +85,7 @@ static int reg_enable(long *enable, int size, int bit) =20 reg.size =3D sizeof(reg); reg.name_args =3D (__u64)"__abi_event"; + reg.flags =3D flags; reg.enable_bit =3D bit; reg.enable_addr =3D (__u64)enable; reg.enable_size =3D size; @@ -69,6 +97,11 @@ static int reg_enable(long *enable, int size, int bit) return ret; } =20 +static int reg_enable(long *enable, int size, int bit) +{ + return reg_enable_flags(enable, size, bit, 0); +} + static int reg_disable(long *enable, int bit) { struct user_unreg reg =3D {0}; @@ -126,6 +159,26 @@ TEST_F(user, enablement) { ASSERT_EQ(0, change_event(false)); } =20 +TEST_F(user, flags) { + /* USER_EVENT_REG_PERSIST is allowed */ + ASSERT_EQ(0, reg_enable_flags(&self->check, sizeof(int), 0, + USER_EVENT_REG_PERSIST)); + ASSERT_EQ(0, reg_disable(&self->check, 0)); + + /* Ensure it exists after close and disable */ + ASSERT_TRUE(event_exists()); + + /* Ensure we can delete it */ + ASSERT_EQ(0, event_delete()); + + /* USER_EVENT_REG_MAX or above is not allowed */ + ASSERT_EQ(-1, reg_enable_flags(&self->check, sizeof(int), 0, + USER_EVENT_REG_MAX)); + + /* Ensure it does not exist after invalid flags */ + ASSERT_FALSE(event_exists()); +} + TEST_F(user, bit_sizes) { /* Allow 0-31 bits for 32-bit */ ASSERT_EQ(0, reg_enable(&self->check, sizeof(int), 0)); diff --git a/tools/testing/selftests/user_events/dyn_test.c b/tools/testing= /selftests/user_events/dyn_test.c index a85980190bea..bdf9ab127488 100644 --- a/tools/testing/selftests/user_events/dyn_test.c +++ b/tools/testing/selftests/user_events/dyn_test.c @@ -17,9 +17,25 @@ #include "../kselftest_harness.h" #include "user_events_selftests.h" =20 +const char *dyn_file =3D "/sys/kernel/tracing/dynamic_events"; const char *abi_file =3D "/sys/kernel/tracing/user_events_data"; const char *enable_file =3D "/sys/kernel/tracing/events/user_events/__test= _event/enable"; =20 +static int event_delete(void) +{ + int fd =3D open(abi_file, O_RDWR); + int ret; + + if (fd < 0) + return -1; + + ret =3D ioctl(fd, DIAG_IOCSDEL, "__test_event"); + + close(fd); + + return ret; +} + static bool wait_for_delete(void) { int i; @@ -64,7 +80,31 @@ static int unreg_event(int fd, int *check, int bit) return ioctl(fd, DIAG_IOCSUNREG, &unreg); } =20 -static int parse(int *check, const char *value) +static int parse_dyn(const char *value) +{ + int fd =3D open(dyn_file, O_RDWR | O_APPEND); + int len =3D strlen(value); + int ret; + + if (fd =3D=3D -1) + return -1; + + ret =3D write(fd, value, len); + + if (ret =3D=3D len) + ret =3D 0; + else + ret =3D -1; + + close(fd); + + if (ret =3D=3D 0) + event_delete(); + + return ret; +} + +static int parse_abi(int *check, const char *value) { int fd =3D open(abi_file, O_RDWR); int ret; @@ -90,6 +130,18 @@ static int parse(int *check, const char *value) return ret; } =20 +static int parse(int *check, const char *value) +{ + int abi_ret =3D parse_abi(check, value); + int dyn_ret =3D parse_dyn(value); + + /* Ensure both ABI and DYN parse the same way */ + if (dyn_ret !=3D abi_ret) + return -1; + + return dyn_ret; +} + static int check_match(int *check, const char *first, const char *second, = bool *match) { int fd =3D open(abi_file, O_RDWR); --=20 2.40.1