From nobody Wed Sep 10 02:01:39 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D81A0E7B604 for ; Wed, 4 Oct 2023 12:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242391AbjJDMfl (ORCPT ); Wed, 4 Oct 2023 08:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242353AbjJDMfc (ORCPT ); Wed, 4 Oct 2023 08:35:32 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E5EEC1 for ; Wed, 4 Oct 2023 05:35:29 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696422928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MAxMuF84OJMFwj1mVQcHjPmQ7zTcHiYKK0tzuJi+A1g=; b=NGiVHVMKQ89c2HqOfoJKJwMmDbG3+ohTltyLW1E7IzR22caosCulch2P490f0kWBtaRGbd KP5bDXJydfUfFPuGaFqTJoEaiU4X8XdW6VuMYFTjcxawK5VKBkZp+P2ru5yzT2IChIeBl2 h9hafLvRBdvbqm0ZSRTQGkIVtuQFJzvxqKInsDdDPIe81yEn0wy1tWSjjQPQSDbV/6nhi7 2FxeM2e2LTe97EvaNLypD/daOhdNiUaZmnv+Q8j7qp8W8Z9S7NKJCWlmEyeQhv7w42HX9O rLCLIWFywCAaqkpPlmTd+TFh4v4M0AjIXALAy3o2Gjit+veJaQMQ0+7mS/TAfg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696422928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MAxMuF84OJMFwj1mVQcHjPmQ7zTcHiYKK0tzuJi+A1g=; b=gKxbWVn7euG7rhu4l9t6pbj4lH9l8lg3FF9JrO40qXbMHGCaS/OLkU6TC5pL3M6jikIBzB /JJFsQ9FYtojaeBg== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Srinivas Pandruvada , K Prateek Nayak , Anna-Maria Behnsen Subject: [PATCH v8 04/25] timer: Move store of next event into __next_timer_interrupt() Date: Wed, 4 Oct 2023 14:34:33 +0200 Message-Id: <20231004123454.15691-5-anna-maria@linutronix.de> In-Reply-To: <20231004123454.15691-1-anna-maria@linutronix.de> References: <20231004123454.15691-1-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Both call sites of __next_timer_interrupt() store return value directly in base->next_expiry. Move the store into __next_timer_interrupt() and to make its purpose more clear, rename function to next_expiry_recalc(). No functional change. Signed-off-by: Anna-Maria Behnsen Reviewed-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker --- v6: Fix typos in commit message and drop not required return as suggested by Peter Zijlstra v4: rename function as suggested by Frederic Weisbecker --- kernel/time/timer.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 7d06351aff54..5e17244a9465 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -1800,8 +1800,10 @@ static int next_pending_bucket(struct timer_base *ba= se, unsigned offset, /* * Search the first expiring timer in the various clock levels. Caller must * hold base->lock. + * + * Store next expiry time in base->next_expiry. */ -static unsigned long __next_timer_interrupt(struct timer_base *base) +static void next_expiry_recalc(struct timer_base *base) { unsigned long clk, next, adj; unsigned lvl, offset =3D 0; @@ -1867,10 +1869,9 @@ static unsigned long __next_timer_interrupt(struct t= imer_base *base) clk +=3D adj; } =20 + base->next_expiry =3D next; base->next_expiry_recalc =3D false; base->timers_pending =3D !(next =3D=3D base->clk + NEXT_TIMER_MAX_DELTA); - - return next; } =20 #ifdef CONFIG_NO_HZ_COMMON @@ -1930,7 +1931,7 @@ u64 get_next_timer_interrupt(unsigned long basej, u64= basem) =20 raw_spin_lock(&base->lock); if (base->next_expiry_recalc) - base->next_expiry =3D __next_timer_interrupt(base); + next_expiry_recalc(base); nextevt =3D base->next_expiry; =20 /* @@ -2013,7 +2014,7 @@ static inline void __run_timers(struct timer_base *ba= se) WARN_ON_ONCE(!levels && !base->next_expiry_recalc && base->timers_pending); base->clk++; - base->next_expiry =3D __next_timer_interrupt(base); + next_expiry_recalc(base); =20 while (levels--) expire_timers(base, heads + levels); --=20 2.39.2