From nobody Wed Sep 10 02:01:38 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A080E7B604 for ; Wed, 4 Oct 2023 12:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242542AbjJDMgV (ORCPT ); Wed, 4 Oct 2023 08:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242425AbjJDMfp (ORCPT ); Wed, 4 Oct 2023 08:35:45 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76ED111D for ; Wed, 4 Oct 2023 05:35:39 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696422938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KnlNVqR9WmkhQaFL3egg7gM5XjHK7g3gYDo7hW6w0sA=; b=2TZ9kJex3ROSXsaXZ7E6YlGyRhNQcoeofEqkGjEFrQtNA9JI7/+5BOxaf2P5Qtw7d4zpO+ G9MR1zjHfkvsM/a4vDvRz7ReaEAwvgoe3n9HMc9v4xD1vanpbtMRDsIj9wGujTkHP3gOUG gruyK2jWfbvnZEOMbkyXr1voAKd0tCNCb9FxxoTmzb9N1M5GXMzEPBwEQ+3Wd8unB0QEfn y6GK7wMm4vbwVbFIhiAutGYsQHZhE74BiYMb/GkfGbfrHSUfykP3IWSdlVVSIln5ixxECx 1YperYHSE3JgjrLQu+PGPrV3K/aXXfkCq7RCaTYE9KDf0CjzCDpIe7cxgzv5Tw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696422938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KnlNVqR9WmkhQaFL3egg7gM5XjHK7g3gYDo7hW6w0sA=; b=ls2cXdt0RpOukfXjfgEx4zuqZfQoPuAoG1FP29n6w5srR0nfJ/iEL78XXgngJh8lvaP0T8 GMX4WEeUul/0XzDQ== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Srinivas Pandruvada , K Prateek Nayak , Anna-Maria Behnsen Subject: [PATCH v8 21/25] timer: Check if timers base is handled already Date: Wed, 4 Oct 2023 14:34:50 +0200 Message-Id: <20231004123454.15691-22-anna-maria@linutronix.de> In-Reply-To: <20231004123454.15691-1-anna-maria@linutronix.de> References: <20231004123454.15691-1-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Due to the conversion of the NOHZ timer placement to a pull at expiry time model, the per CPU timer bases with non pinned timers are no longer handled only by the local CPU. In case a remote CPU already expires the non pinned timers base of the local cpu, nothing more needs to be done by the local CPU. A check at the begin of the expire timers routine is required, because timer base lock is dropped before executing the timer callback function. This is a preparatory work, but has no functional impact right now. Signed-off-by: Anna-Maria Behnsen --- v6: Drop double negation --- kernel/time/timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 8893f5dd1d66..7f06553e44de 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -2232,6 +2232,9 @@ static inline void __run_timers(struct timer_base *ba= se) =20 lockdep_assert_held(&base->lock); =20 + if (base->running_timer) + return; + while (time_after_eq(jiffies, base->clk) && time_after_eq(jiffies, base->next_expiry)) { levels =3D collect_expired_timers(base, heads); --=20 2.39.2