From nobody Fri Dec 19 17:51:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96356E776FF for ; Tue, 3 Oct 2023 04:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239083AbjJCEWJ (ORCPT ); Tue, 3 Oct 2023 00:22:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239045AbjJCEWG (ORCPT ); Tue, 3 Oct 2023 00:22:06 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CABBA4; Mon, 2 Oct 2023 21:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1696306923; x=1727842923; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UxIXasS2OTVy/F2KygXVSkU+5jJ464D8P3BNT5N73Ss=; b=BAmMgobZho0o5Stq1Q6KSwzl45QSDV4mxwJugROGmHRShDgPF5BOwMj8 MH2BGtkut6/ujAcjKkrIcZ17QdERfrVXswUq2rPqO2/5sUOrbGToBbzWU wfDhnEfw39lfWApyW1qE0v/txW1Sn/Istl0jrMqRqpK1ubJi+RmNmShCK 4Lx+Pro0tksrJIvpgxzCSwACHc9APNxXKp4U+OJYi1J+dqxSq/jVZNgw+ l3ffmzUz9uDeF+lpRTlvhrREVZG4hMAtUx3Ye0mOKSXr6U9Sp9lPwzya3 qlUIMwwVxiEUi3xy//Es5ghqHZivUHsmIWGSPX1iayxgctbD2fKfypwxy Q==; X-CSE-ConnectionGUID: CfTVgEzCTm6iPkFhghp5JA== X-CSE-MsgGUID: i4Wnc6pNSb+uhGmwA9d/zg== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="7623120" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 Oct 2023 21:22:02 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 2 Oct 2023 21:21:21 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 2 Oct 2023 21:21:16 -0700 From: shravan chippa To: , , , , , , CC: , , , , , , Subject: [PATCH v2 3/4] dmaengine: sf-pdma: add mpfs-pdma compatible name Date: Tue, 3 Oct 2023 09:52:14 +0530 Message-ID: <20231003042215.142678-4-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231003042215.142678-1-shravan.chippa@microchip.com> References: <20231003042215.142678-1-shravan.chippa@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Shravan Chippa Sifive platform dma does not allow out-of-order transfers, Add a PolarFire SoC specific compatible and code to support for out-of-order dma transfers Signed-off-by: Shravan Chippa --- drivers/dma/sf-pdma/sf-pdma.c | 27 ++++++++++++++++++++++++--- drivers/dma/sf-pdma/sf-pdma.h | 6 ++++++ 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c index 06a0912a12a1..a9ff319d4ca3 100644 --- a/drivers/dma/sf-pdma/sf-pdma.c +++ b/drivers/dma/sf-pdma/sf-pdma.c @@ -21,6 +21,7 @@ #include #include #include +#include #include =20 #include "sf-pdma.h" @@ -66,7 +67,7 @@ static struct sf_pdma_desc *sf_pdma_alloc_desc(struct sf_= pdma_chan *chan) static void sf_pdma_fill_desc(struct sf_pdma_desc *desc, u64 dst, u64 src, u64 size) { - desc->xfer_type =3D PDMA_FULL_SPEED; + desc->xfer_type =3D desc->chan->pdma->transfer_type; desc->xfer_size =3D size; desc->dst_addr =3D dst; desc->src_addr =3D src; @@ -520,6 +521,7 @@ static struct dma_chan *sf_pdma_of_xlate(struct of_phan= dle_args *dma_spec, =20 static int sf_pdma_probe(struct platform_device *pdev) { + const struct sf_pdma_driver_platdata *ddata; struct sf_pdma *pdma; int ret, n_chans; const enum dma_slave_buswidth widths =3D @@ -545,6 +547,14 @@ static int sf_pdma_probe(struct platform_device *pdev) =20 pdma->n_chans =3D n_chans; =20 + pdma->transfer_type =3D PDMA_FULL_SPEED; + + ddata =3D of_device_get_match_data(&pdev->dev); + if (ddata) { + if (ddata->quirks & NO_STRICT_ORDERING) + pdma->transfer_type &=3D ~(NO_STRICT_ORDERING); + } + pdma->membase =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pdma->membase)) return PTR_ERR(pdma->membase); @@ -632,11 +642,22 @@ static int sf_pdma_remove(struct platform_device *pde= v) return 0; } =20 +static const struct sf_pdma_driver_platdata mpfs_pdma =3D { + .quirks =3D NO_STRICT_ORDERING, +}; + static const struct of_device_id sf_pdma_dt_ids[] =3D { - { .compatible =3D "sifive,fu540-c000-pdma" }, - { .compatible =3D "sifive,pdma0" }, + { + .compatible =3D "sifive,fu540-c000-pdma", + }, { + .compatible =3D "sifive,pdma0", + }, { + .compatible =3D "microchip,mpfs-pdma", + .data =3D &mpfs_pdma, + }, {}, }; + MODULE_DEVICE_TABLE(of, sf_pdma_dt_ids); =20 static struct platform_driver sf_pdma_driver =3D { diff --git a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h index 5c398a83b491..3b16db4daa0b 100644 --- a/drivers/dma/sf-pdma/sf-pdma.h +++ b/drivers/dma/sf-pdma/sf-pdma.h @@ -49,6 +49,7 @@ =20 /* Transfer Type */ #define PDMA_FULL_SPEED 0xFF000008 +#define NO_STRICT_ORDERING BIT(3) =20 /* Error Recovery */ #define MAX_RETRY 1 @@ -112,8 +113,13 @@ struct sf_pdma { struct dma_device dma_dev; void __iomem *membase; void __iomem *mappedbase; + u32 transfer_type; u32 n_chans; struct sf_pdma_chan chans[]; }; =20 +struct sf_pdma_driver_platdata { + u32 quirks; +}; + #endif /* _SF_PDMA_H */ --=20 2.34.1