From nobody Mon Jan 5 11:18:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F15DE784B3 for ; Mon, 2 Oct 2023 14:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237621AbjJBOAX (ORCPT ); Mon, 2 Oct 2023 10:00:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237605AbjJBOAU (ORCPT ); Mon, 2 Oct 2023 10:00:20 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBF77B4 for ; Mon, 2 Oct 2023 07:00:16 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so21664307a12.2 for ; Mon, 02 Oct 2023 07:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1696255215; x=1696860015; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OHDvd7zBG9q3cQ18ekHgB5reLeuG+/B7KcSObggrkM4=; b=nufDdYmBcWVroR8Q1DIf+YtKnVhhivgaFyIXPqBmmbLkoDP8CGq5roitSrUYuM0OUQ XAGuCTmhjRPNE/1h4csUuMi6TRfgNxoGH/55wMFEezucepiDKNE00Kc89X4uX+qt4cnG hTlXZBAAfOIiJdkweZTKvoQlX8i7EqJibI9IzvnHjxyWZm0047SDBGtE5hp/iQhFPBxL MnPYJRvfdu+MQMLiZRrb3/IGxT0gEv9hDBuDjDBQLdCu+Qm04cMNbiE+1qV/iOs+30HQ LoqLNqDaGcgYfSSlEK4kTW5svnhBemJBpU7tDWKBwB4sEt2bpNH0QRxrdpQ8lHqqPuMT rqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696255215; x=1696860015; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OHDvd7zBG9q3cQ18ekHgB5reLeuG+/B7KcSObggrkM4=; b=WsEo+xA5MF+F6LFF58OCk373bHiaSUVj5hceyDc+suinYZ6Med7rkMPAltIzE81U+E ysH7kqerCPKmro+szV39pv3mSX4WMEoAu+19gyHLj+clgDJs9mM5ovjB+35uZbqK6mvR hb9iXpPnuOyRKPfupT5Fv8mlrrXTAizvPPGRnoQ+My3VCMNqYOJmrVFOMk7U5qMzc2cm HosOGmVxVASJvtKenC9Vjxe2OfDtq8QR645rsQIASDMW9UNPfPM9h9w36et7uMjYbBfB qODV/57asEp9n6Zyu3ELms5WO9X9PD6djx+bi+bz1i+24UFBwMdE5J+0gDkMjt+yq0Xf lGyg== X-Gm-Message-State: AOJu0YwsFTJFCKjuFDnTP6itf715JEwF1wmHG3lygfhHZ2eUOPTDXLJD tcVVapU1zHme7yEUl3j/ikMxsQ== X-Google-Smtp-Source: AGHT+IEqousXbP5TTb7EJHs1BpXBUU8/Elaw2Sux5vGT5VflP/hLFD6ub63JjLQUdQbLqXFQKsz1/Q== X-Received: by 2002:a05:6402:160b:b0:531:3e89:1bef with SMTP id f11-20020a056402160b00b005313e891befmr10451516edv.32.1696255215247; Mon, 02 Oct 2023 07:00:15 -0700 (PDT) Received: from otso.luca.vpn.lucaweiss.eu (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id q13-20020a056402518d00b005346925a474sm9350377edd.43.2023.10.02.07.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 07:00:14 -0700 (PDT) From: Luca Weiss Date: Mon, 02 Oct 2023 16:00:11 +0200 Subject: [PATCH v2 1/2] ASoC: dt-bindings: awinic,aw88395: Remove reset-gpios from AW88261 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231002-aw88261-reset-v2-1-837cb1e7b95c@fairphone.com> References: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> In-Reply-To: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> To: Weidong Wang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The AW88261 chip doesn't have a reset GPIO, so disallow providing reset-gpios. At the same time also don't keep reset-gpios required for AW88395. This is both because the Linux driver has it optional, and it also simplifies the bindings by not introducing another conditional. Signed-off-by: Luca Weiss --- .../devicetree/bindings/sound/awinic,aw88395.yaml | 16 ++++++++++++= ---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/= Documentation/devicetree/bindings/sound/awinic,aw88395.yaml index b977d3de87cb..5d5ebc72b721 100644 --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml @@ -14,9 +14,6 @@ description: digital Smart K audio amplifier with an integrated 10.25V smart boost convert. =20 -allOf: - - $ref: dai-common.yaml# - properties: compatible: enum: @@ -49,9 +46,20 @@ required: - compatible - reg - '#sound-dai-cells' - - reset-gpios - awinic,audio-channel =20 +allOf: + - $ref: dai-common.yaml# + - if: + properties: + compatible: + contains: + enum: + - awinic,aw88261 + then: + properties: + reset-gpios: false + unevaluatedProperties: false =20 examples: --=20 2.42.0 From nobody Mon Jan 5 11:18:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6970DE7849A for ; Mon, 2 Oct 2023 14:00:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237633AbjJBOAZ (ORCPT ); Mon, 2 Oct 2023 10:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237618AbjJBOAV (ORCPT ); Mon, 2 Oct 2023 10:00:21 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F57DC9 for ; Mon, 2 Oct 2023 07:00:18 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50305abe5f0so25238039e87.2 for ; Mon, 02 Oct 2023 07:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1696255216; x=1696860016; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=V2/riLchQZtPTs/BC596zGkjlTIrNRPztVzIEa24L10=; b=i4sYvwRvLnl2fno42q3AI9/S19leUfadmvKoHdGuwzX6j34KYZXQqXXbn627a26scC bv6hILU4ebmYE6vrRDC9+UxIkcSOZqUE60NHGRBNUSXQhJIUcYRafUa5+rg8MT6kbPsW UiAbo4dEqCgnaAteu6F2H+fWWCHABXV+9M5EFLUHDqmwYcOhB6kY/8UfnqvLXb3+BxB4 c+uerfuYPQRAqZBr40qdw6F1hJBdBG3zKr+x/0cctJiEzo7mkI5OCXnYWOn2YcQQX2j+ AT9TGk3rNNMIQihCH+zJu7E0lAEqhkfUcTrchpcsP+q5k9ZIHDk94l7pj0NbUy9xKI06 yuJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696255216; x=1696860016; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V2/riLchQZtPTs/BC596zGkjlTIrNRPztVzIEa24L10=; b=DnMersAiIbL/pg0AyZYjUYjksR+8G8Ob5bKg9C8wLwoVmH4dv+zEryfGk//4GX3tty C0cMtxLhSVZg3KeO498agYqACmwJ5v3MpGfq+xPHWrdsFdhfDSA7f/NqmNXh2O9xHhM9 M1uPmW1NLRf1obYSxhsDZz66UbWHAJBoE4dMCGocvCS5KjzB6CHagxCaSoSvawynDG+P cVugTZlecUx/JltvDRqdwpQLufAWowhYvUU7+cMvy8mkE4wqHp1Tz5ZSiZ4rjOs0yABq S7FGyIv3RqoQv/LfxoBCqCrVPC+N9dKcuWP52z1kGc06Y9edUDtNNowLEHgZpEQpFz3I xR+g== X-Gm-Message-State: AOJu0Yxi7umG8RkS8mPhYwre0RvCrS/Y5OIGDOG7suGYKDIvUPUurv2S H23VKoCnjxydgxi6Nm3KHWidEQ== X-Google-Smtp-Source: AGHT+IFYahe9QM9GSXykZIjClH00JSYu2bdXsSeQxdK1Yb2R7fBZkn9KvfTGct/URjQfs9lMQOMdJQ== X-Received: by 2002:a05:6512:617:b0:503:19d9:4b6f with SMTP id b23-20020a056512061700b0050319d94b6fmr8505095lfe.0.1696255216212; Mon, 02 Oct 2023 07:00:16 -0700 (PDT) Received: from otso.luca.vpn.lucaweiss.eu (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id q13-20020a056402518d00b005346925a474sm9350377edd.43.2023.10.02.07.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 07:00:15 -0700 (PDT) From: Luca Weiss Date: Mon, 02 Oct 2023 16:00:12 +0200 Subject: [PATCH v2 2/2] ASoC: codecs: aw88261: Remove non-existing reset gpio MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231002-aw88261-reset-v2-2-837cb1e7b95c@fairphone.com> References: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> In-Reply-To: <20231002-aw88261-reset-v2-0-837cb1e7b95c@fairphone.com> To: Weidong Wang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the AW88261 datasheet (V1.1) and device schematics I have access to, there is no reset gpio present on the AW88261. Remove it. Signed-off-by: Luca Weiss --- sound/soc/codecs/aw88261.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 45eaf931a69c..e7683f70c2ef 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -10,7 +10,6 @@ =20 #include #include -#include #include #include #include "aw88261.h" @@ -1175,14 +1174,6 @@ static const struct snd_soc_component_driver soc_cod= ec_dev_aw88261 =3D { .remove =3D aw88261_codec_remove, }; =20 -static void aw88261_hw_reset(struct aw88261 *aw88261) -{ - gpiod_set_value_cansleep(aw88261->reset_gpio, 0); - usleep_range(AW88261_1000_US, AW88261_1000_US + 10); - gpiod_set_value_cansleep(aw88261->reset_gpio, 1); - usleep_range(AW88261_1000_US, AW88261_1000_US + 10); -} - static void aw88261_parse_channel_dt(struct aw88261 *aw88261) { struct aw_device *aw_dev =3D aw88261->aw_pa; @@ -1254,12 +1245,6 @@ static int aw88261_i2c_probe(struct i2c_client *i2c) =20 i2c_set_clientdata(i2c, aw88261); =20 - aw88261->reset_gpio =3D devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD= _OUT_LOW); - if (IS_ERR(aw88261->reset_gpio)) - dev_info(&i2c->dev, "reset gpio not defined\n"); - else - aw88261_hw_reset(aw88261); - aw88261->regmap =3D devm_regmap_init_i2c(i2c, &aw88261_remap_config); if (IS_ERR(aw88261->regmap)) { ret =3D PTR_ERR(aw88261->regmap); --=20 2.42.0