From nobody Tue Dec 16 19:55:09 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CE1E732C7 for ; Thu, 28 Sep 2023 12:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbjI1Maq (ORCPT ); Thu, 28 Sep 2023 08:30:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231344AbjI1Mal (ORCPT ); Thu, 28 Sep 2023 08:30:41 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F46019E; Thu, 28 Sep 2023 05:30:39 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c00df105f8so213609031fa.2; Thu, 28 Sep 2023 05:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695904237; x=1696509037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YUX/UAbHIqbeqOjhPaMPY2ZesCBPS6XxII45ueUUUxU=; b=np8USWsFOoMH2vGtTbeiRnbNSOsfiAPf47QI9II9wmR7ydPLsajNUkq6JERvz+SH8R E/5zow53dJj6WzDoBgHni7kM7lWzkmbCtL54ZRB/gLZmpZRR5MdI5rAn64tj07gA5eYF PDcylxsF1SRqBEYMZ1yrNlSNB6HNun18BtweRlD2Z/tPVZJO4H1WEbkRI0lrETHlVb0w Vxc4vvnrHqRHVCax9NpespaPqg+oeXQsg5F2ww1NELM9yW9MHnb0K7+WuoDUeN2oSBOJ Ab0dmuqBlAAkk0PNIw4QKX8BdlHlezRtuoRP+Jl6QXMaAexAjQKhoPRWOS+keEF5srwr R9Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695904237; x=1696509037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YUX/UAbHIqbeqOjhPaMPY2ZesCBPS6XxII45ueUUUxU=; b=LhjbZFj16c/ZAIfCN7TZ0o3463Wcghhui/b5j9W0CGJS6IcjbmYjfigfbuu7sOLZs6 WrwjIb7B3ZkyXQLpVrQFL2hh4JlUWjzrJeH/QRy1FcRgsfBInI1w8bnUSM57Bw1zxAq+ 9H6wLisbkLo7Y1dmVMlFqdu2PTlYhlM3g76jFq0dnGkvl+EQuiOaHJ6njxn0BjUK0tua bsBJpuKMGwzDVK/Wcy+xkumeVQ/X8OlnFhxVFpHboGk+3BVzDDCqbSLo0i+N2ZWNhSc/ o8gmWJFA4QgJZjuvGShlQXthG8qohzTWOdrPPCu3+n3aKIRUbV61MyWIrpXNcVRxaPHn XiiQ== X-Gm-Message-State: AOJu0Yxgqxsd5Ux1XOwiH/cN2zdRPFNtdu8s0OS/ObvbSBT3QhoQIRlC dkABA1s8HZZd28gc4PCLgevpD5ZlP6BvbtcOL24= X-Google-Smtp-Source: AGHT+IHOoVrnykSWjbCmQfiEGZtmRDV+0Xk3hQX2T+BQSwnmo0QhwPppf4zwYYCAZaxFOF6wP63EgQ== X-Received: by 2002:a2e:8448:0:b0:2c0:1982:3893 with SMTP id u8-20020a2e8448000000b002c019823893mr887770ljh.16.1695904237031; Thu, 28 Sep 2023 05:30:37 -0700 (PDT) Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x6-20020a2e9c86000000b002ba045496d0sm3588724lji.125.2023.09.28.05.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 05:30:36 -0700 (PDT) From: Konstantin Aladyshev Cc: minyard@acm.org, joel@jms.id.au, andrew@aj.id.au, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, aladyshev22@gmail.com, jk@codeconstruct.com.au, matt@codeconstruct.com.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH 1/3] ipmi: Move KCS headers to common include folder Date: Thu, 28 Sep 2023 15:30:07 +0300 Message-Id: <20230928123009.2913-2-aladyshev22@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230928123009.2913-1-aladyshev22@gmail.com> References: <20230928123009.2913-1-aladyshev22@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The current KCS header files can be utilized by both IPMI drivers (drivers/char/ipmi) and MCTP driver (drivers/net/mctp). To be able to use them in both cases move the headers to 'include/linux' folder. Signed-off-by: Konstantin Aladyshev --- drivers/char/ipmi/kcs_bmc.c | 8 +++----- drivers/char/ipmi/kcs_bmc_aspeed.c | 3 +-- drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 2 +- drivers/char/ipmi/kcs_bmc_npcm7xx.c | 2 +- drivers/char/ipmi/kcs_bmc_serio.c | 2 +- {drivers/char/ipmi =3D> include/linux}/kcs_bmc.h | 0 {drivers/char/ipmi =3D> include/linux}/kcs_bmc_client.h | 3 +-- {drivers/char/ipmi =3D> include/linux}/kcs_bmc_device.h | 3 +-- 8 files changed, 9 insertions(+), 14 deletions(-) rename {drivers/char/ipmi =3D> include/linux}/kcs_bmc.h (100%) rename {drivers/char/ipmi =3D> include/linux}/kcs_bmc_client.h (97%) rename {drivers/char/ipmi =3D> include/linux}/kcs_bmc_device.h (96%) diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c index 8b1161d5194a..d29a8505d6ed 100644 --- a/drivers/char/ipmi/kcs_bmc.c +++ b/drivers/char/ipmi/kcs_bmc.c @@ -5,15 +5,13 @@ */ =20 #include +#include +#include +#include #include #include #include =20 -#include "kcs_bmc.h" - -/* Implement both the device and client interfaces here */ -#include "kcs_bmc_device.h" -#include "kcs_bmc_client.h" =20 /* Record registered devices and drivers */ static DEFINE_MUTEX(kcs_bmc_lock); diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc= _aspeed.c index 72640da55380..3dc0dfb448f5 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -21,8 +22,6 @@ #include #include =20 -#include "kcs_bmc_device.h" - =20 #define DEVICE_NAME "ast-kcs-bmc" =20 diff --git a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c b/drivers/char/ipmi/kcs_= bmc_cdev_ipmi.c index cf670e891966..bf1001130a6c 100644 --- a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c +++ b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -17,7 +18,6 @@ #include #include =20 -#include "kcs_bmc_client.h" =20 /* Different phases of the KCS BMC module. * KCS_PHASE_IDLE: diff --git a/drivers/char/ipmi/kcs_bmc_npcm7xx.c b/drivers/char/ipmi/kcs_bm= c_npcm7xx.c index 7961fec56476..160553248a93 100644 --- a/drivers/char/ipmi/kcs_bmc_npcm7xx.c +++ b/drivers/char/ipmi/kcs_bmc_npcm7xx.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -17,7 +18,6 @@ #include #include =20 -#include "kcs_bmc_device.h" =20 #define DEVICE_NAME "npcm-kcs-bmc" #define KCS_CHANNEL_MAX 3 diff --git a/drivers/char/ipmi/kcs_bmc_serio.c b/drivers/char/ipmi/kcs_bmc_= serio.c index 1793358be782..24df7144a189 100644 --- a/drivers/char/ipmi/kcs_bmc_serio.c +++ b/drivers/char/ipmi/kcs_bmc_serio.c @@ -5,12 +5,12 @@ #include #include #include +#include #include #include #include #include =20 -#include "kcs_bmc_client.h" =20 struct kcs_bmc_serio { struct list_head entry; diff --git a/drivers/char/ipmi/kcs_bmc.h b/include/linux/kcs_bmc.h similarity index 100% rename from drivers/char/ipmi/kcs_bmc.h rename to include/linux/kcs_bmc.h diff --git a/drivers/char/ipmi/kcs_bmc_client.h b/include/linux/kcs_bmc_cli= ent.h similarity index 97% rename from drivers/char/ipmi/kcs_bmc_client.h rename to include/linux/kcs_bmc_client.h index 6fdcde0a7169..f6350c9366dd 100644 --- a/drivers/char/ipmi/kcs_bmc_client.h +++ b/include/linux/kcs_bmc_client.h @@ -5,8 +5,7 @@ #define __KCS_BMC_CONSUMER_H__ =20 #include - -#include "kcs_bmc.h" +#include =20 struct kcs_bmc_driver_ops { int (*add_device)(struct kcs_bmc_device *kcs_bmc); diff --git a/drivers/char/ipmi/kcs_bmc_device.h b/include/linux/kcs_bmc_dev= ice.h similarity index 96% rename from drivers/char/ipmi/kcs_bmc_device.h rename to include/linux/kcs_bmc_device.h index 17c572f25c54..65333b68c0af 100644 --- a/drivers/char/ipmi/kcs_bmc_device.h +++ b/include/linux/kcs_bmc_device.h @@ -5,8 +5,7 @@ #define __KCS_BMC_DEVICE_H__ =20 #include - -#include "kcs_bmc.h" +#include =20 struct kcs_bmc_device_ops { void (*irq_mask_update)(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 enabl= e); --=20 2.25.1 From nobody Tue Dec 16 19:55:09 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17FFE732C8 for ; Thu, 28 Sep 2023 12:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232515AbjI1Mau (ORCPT ); Thu, 28 Sep 2023 08:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232434AbjI1Mam (ORCPT ); Thu, 28 Sep 2023 08:30:42 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F250519F; Thu, 28 Sep 2023 05:30:39 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c12fc235fbso149514121fa.0; Thu, 28 Sep 2023 05:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695904238; x=1696509038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yp1yNMJhm0Xmlti2S7KpcZZ4ydY0GaIDDg/yGsmahK4=; b=F6P6Y2hZpn8LhiWBUIDZ4N0kqPsAUIRWpsKBeCuEWuEFbjuGEMi48RcdK0L+T0md91 YjUD1+6Qtm/ApPtWuqVqxfTD4TWyQOFHceAyPEGDB2cUO2Afs2vis1LEquHJI9Wu3/gk MCDC1PmgM0toyKeyWG3Z9xEGJ0/EuIKS7dLVlEmOprQW4MDastv70ctgXGQKE+eVpyJ3 6E2pqAtsOylPqEAisILTguCNX4qo2asfsZUi95/we8UfdbARvdi/Mx7YQ6qKvua1MCvJ 6K+NkczFZxrWwxkwNVfNiLqBhQW1XAYO/SW43Jvg+IyCpXPbhpYYygRz6mr/FpJJmYGB RnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695904238; x=1696509038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yp1yNMJhm0Xmlti2S7KpcZZ4ydY0GaIDDg/yGsmahK4=; b=COKljX0xTFzt/gteWlAZu2JnN9ggQBSiWNedueCypzcCZoomqSBvoGd9Qcj3XIedsu h/VX0P7ivcb7zmCds4XnbIt70p1ZbGg/SOnqc3DMZwgtZhrAtATLdE7lDuwy5Be/RL2Z FvpjKynqePzlOspaF4P4Ka1BTVu3FmrMP4JC2B4c47wiqPmOjsClGe7Y7OBSsWhnypkK 9rdX1vva+yNWO5W3nGUdvBR7tk3hmEBd3TvOgL+AJEd4andr+5rRUzDb8sXBTd4Im9fr yx3hH1WtsgRgguelliQYzKvv8FIjkWwdPakMCMcKjujDqDiS8fvfOyDsLKLV7ysotxdO Wgdw== X-Gm-Message-State: AOJu0YyDUiWbx684UYkB5ulg2vXQ5xC7MnuuDRInkWsVhtdjCaLDOsxU 8bhsEBxGFj+xZtQ9u287yCU= X-Google-Smtp-Source: AGHT+IFCJ5uhFMa9UQBccJQFldcy0wGcJJMreMajDOT+ujV7O+GPfiBD+Y9Nm99019ZGG8zjba2oyA== X-Received: by 2002:a2e:80ca:0:b0:2bf:f985:7729 with SMTP id r10-20020a2e80ca000000b002bff9857729mr876605ljg.17.1695904238108; Thu, 28 Sep 2023 05:30:38 -0700 (PDT) Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x6-20020a2e9c86000000b002ba045496d0sm3588724lji.125.2023.09.28.05.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 05:30:37 -0700 (PDT) From: Konstantin Aladyshev Cc: minyard@acm.org, joel@jms.id.au, andrew@aj.id.au, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, aladyshev22@gmail.com, jk@codeconstruct.com.au, matt@codeconstruct.com.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH 2/3] ipmi: Create header with KCS interface defines Date: Thu, 28 Sep 2023 15:30:08 +0300 Message-Id: <20230928123009.2913-3-aladyshev22@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230928123009.2913-1-aladyshev22@gmail.com> References: <20230928123009.2913-1-aladyshev22@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some definitions from the current kcs_bmc_cdev_ipmi driver can be also utilized by the MTCP KCS binding driver. Move such definitions to the common header file. Signed-off-by: Konstantin Aladyshev --- drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 71 +----------------------- include/linux/ipmi_kcs.h | 80 +++++++++++++++++++++++++++ 2 files changed, 81 insertions(+), 70 deletions(-) create mode 100644 include/linux/ipmi_kcs.h diff --git a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c b/drivers/char/ipmi/kcs_= bmc_cdev_ipmi.c index bf1001130a6c..f158f676114c 100644 --- a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c +++ b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -19,53 +20,6 @@ #include =20 =20 -/* Different phases of the KCS BMC module. - * KCS_PHASE_IDLE: - * BMC should not be expecting nor sending any data. - * KCS_PHASE_WRITE_START: - * BMC is receiving a WRITE_START command from system software. - * KCS_PHASE_WRITE_DATA: - * BMC is receiving a data byte from system software. - * KCS_PHASE_WRITE_END_CMD: - * BMC is waiting a last data byte from system software. - * KCS_PHASE_WRITE_DONE: - * BMC has received the whole request from system software. - * KCS_PHASE_WAIT_READ: - * BMC is waiting the response from the upper IPMI service. - * KCS_PHASE_READ: - * BMC is transferring the response to system software. - * KCS_PHASE_ABORT_ERROR1: - * BMC is waiting error status request from system software. - * KCS_PHASE_ABORT_ERROR2: - * BMC is waiting for idle status afer error from system softwa= re. - * KCS_PHASE_ERROR: - * BMC has detected a protocol violation at the interface level. - */ -enum kcs_ipmi_phases { - KCS_PHASE_IDLE, - - KCS_PHASE_WRITE_START, - KCS_PHASE_WRITE_DATA, - KCS_PHASE_WRITE_END_CMD, - KCS_PHASE_WRITE_DONE, - - KCS_PHASE_WAIT_READ, - KCS_PHASE_READ, - - KCS_PHASE_ABORT_ERROR1, - KCS_PHASE_ABORT_ERROR2, - KCS_PHASE_ERROR -}; - -/* IPMI 2.0 - Table 9-4, KCS Interface Status Codes */ -enum kcs_ipmi_errors { - KCS_NO_ERROR =3D 0x00, - KCS_ABORTED_BY_COMMAND =3D 0x01, - KCS_ILLEGAL_CONTROL_CODE =3D 0x02, - KCS_LENGTH_ERROR =3D 0x06, - KCS_UNSPECIFIED_ERROR =3D 0xFF -}; - struct kcs_bmc_ipmi { struct list_head entry; =20 @@ -95,29 +49,6 @@ struct kcs_bmc_ipmi { =20 #define KCS_MSG_BUFSIZ 1000 =20 -#define KCS_ZERO_DATA 0 - -/* IPMI 2.0 - Table 9-1, KCS Interface Status Register Bits */ -#define KCS_STATUS_STATE(state) (state << 6) -#define KCS_STATUS_STATE_MASK GENMASK(7, 6) -#define KCS_STATUS_CMD_DAT BIT(3) -#define KCS_STATUS_SMS_ATN BIT(2) -#define KCS_STATUS_IBF BIT(1) -#define KCS_STATUS_OBF BIT(0) - -/* IPMI 2.0 - Table 9-2, KCS Interface State Bits */ -enum kcs_states { - IDLE_STATE =3D 0, - READ_STATE =3D 1, - WRITE_STATE =3D 2, - ERROR_STATE =3D 3, -}; - -/* IPMI 2.0 - Table 9-3, KCS Interface Control Codes */ -#define KCS_CMD_GET_STATUS_ABORT 0x60 -#define KCS_CMD_WRITE_START 0x61 -#define KCS_CMD_WRITE_END 0x62 -#define KCS_CMD_READ_BYTE 0x68 =20 static inline void set_state(struct kcs_bmc_ipmi *priv, u8 state) { diff --git a/include/linux/ipmi_kcs.h b/include/linux/ipmi_kcs.h new file mode 100644 index 000000000000..30c4b6e4d689 --- /dev/null +++ b/include/linux/ipmi_kcs.h @@ -0,0 +1,80 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2015-2018, Intel Corporation. + */ + +#ifndef __IPMI_KCS_H__ +#define __IPMI_KCS_H__ + +/* Different phases of the KCS BMC module. + * KCS_PHASE_IDLE: + * BMC should not be expecting nor sending any data. + * KCS_PHASE_WRITE_START: + * BMC is receiving a WRITE_START command from system software. + * KCS_PHASE_WRITE_DATA: + * BMC is receiving a data byte from system software. + * KCS_PHASE_WRITE_END_CMD: + * BMC is waiting a last data byte from system software. + * KCS_PHASE_WRITE_DONE: + * BMC has received the whole request from system software. + * KCS_PHASE_WAIT_READ: + * BMC is waiting the response from the upper IPMI service. + * KCS_PHASE_READ: + * BMC is transferring the response to system software. + * KCS_PHASE_ABORT_ERROR1: + * BMC is waiting error status request from system software. + * KCS_PHASE_ABORT_ERROR2: + * BMC is waiting for idle status afer error from system softwa= re. + * KCS_PHASE_ERROR: + * BMC has detected a protocol violation at the interface level. + */ +enum kcs_ipmi_phases { + KCS_PHASE_IDLE, + + KCS_PHASE_WRITE_START, + KCS_PHASE_WRITE_DATA, + KCS_PHASE_WRITE_END_CMD, + KCS_PHASE_WRITE_DONE, + + KCS_PHASE_WAIT_READ, + KCS_PHASE_READ, + + KCS_PHASE_ABORT_ERROR1, + KCS_PHASE_ABORT_ERROR2, + KCS_PHASE_ERROR +}; + +/* IPMI 2.0 - Table 9-4, KCS Interface Status Codes */ +enum kcs_ipmi_errors { + KCS_NO_ERROR =3D 0x00, + KCS_ABORTED_BY_COMMAND =3D 0x01, + KCS_ILLEGAL_CONTROL_CODE =3D 0x02, + KCS_LENGTH_ERROR =3D 0x06, + KCS_UNSPECIFIED_ERROR =3D 0xFF +}; + +#define KCS_ZERO_DATA 0 + +/* IPMI 2.0 - Table 9-1, KCS Interface Status Register Bits */ +#define KCS_STATUS_STATE(state) (state << 6) +#define KCS_STATUS_STATE_MASK GENMASK(7, 6) +#define KCS_STATUS_CMD_DAT BIT(3) +#define KCS_STATUS_SMS_ATN BIT(2) +#define KCS_STATUS_IBF BIT(1) +#define KCS_STATUS_OBF BIT(0) + +/* IPMI 2.0 - Table 9-2, KCS Interface State Bits */ +enum kcs_states { + IDLE_STATE =3D 0, + READ_STATE =3D 1, + WRITE_STATE =3D 2, + ERROR_STATE =3D 3, +}; + +/* IPMI 2.0 - Table 9-3, KCS Interface Control Codes */ +#define KCS_CMD_GET_STATUS_ABORT 0x60 +#define KCS_CMD_WRITE_START 0x61 +#define KCS_CMD_WRITE_END 0x62 +#define KCS_CMD_READ_BYTE 0x68 + +#endif /* __IPMI_KCS_H__ */ --=20 2.25.1 From nobody Tue Dec 16 19:55:09 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE318E732C7 for ; Thu, 28 Sep 2023 12:30:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbjI1May (ORCPT ); Thu, 28 Sep 2023 08:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbjI1Mao (ORCPT ); Thu, 28 Sep 2023 08:30:44 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE743194; Thu, 28 Sep 2023 05:30:41 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c131ddfeb8so200310511fa.3; Thu, 28 Sep 2023 05:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695904240; x=1696509040; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v8bEPLu88XlbtZrHeRFjJDnxYP+p2U4qtN1tZXYLux8=; b=dltiHfERwcpGYvZVkWhpMQii1ZzAznwJKGX5a7eDz6aXKZN0/aYVhyRwyQ5eJlG7Xk rYThIvsJiMjcUpB+FTrOo22H6BbbyHgaJCh/dtBxSwPSQxiYrxbn33+zAAgcaGiS5Ne+ EKmaY2Go5zOMbcg3xwcD3c4XT+q6SyjmB9yPMHBrCMu5HDZ2hyVoIfDuFMidK+Va6pbo IUR7xgFOEGjLp9+erysxHUcCWsusAvdudF8CDgL1f5CBO711C6SDFTNRaUIUkiH7XeI7 lg6nH2PgdN/0wv9tKl24ucHW99cgyTvRs93Ht32Dyssd4ldi1eAkd5HGMJBFC/GgJ60R lfxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695904240; x=1696509040; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8bEPLu88XlbtZrHeRFjJDnxYP+p2U4qtN1tZXYLux8=; b=XqYudmoWfv85zG5YXRCtcJOg5v7sLJ2HPSPCi9/AuzdCI9g6gH8obGpq5eeBmoql2n 5PJHOcHFLfXOtI6qeEtpUgF2/DDGxrxagtYHLRKbHegg3Gzw1D/32tWvYM4yu2bvkcvt YR3u7IR9eCWvaTtul7a4FY6ufM1WUvV8xcHsHLSytmxWiOYW4ETNedsj+9Z46R/e85DT /PzyrBXNNvA4d8nu6zWVLvsixPmIAqhE0tfQMendJJ2GjxDR1lcGH5f89p1IDtZcGMyd jyXlE8+siU7al2J6id0zLJ8ubvlrxkTfPCBOm5cuvGLBjXrInYBQEGfAx/G07nMTstcV QrHQ== X-Gm-Message-State: AOJu0YzsoBoWDb2fNOfshcIN3jmkvQeZvLhjcI/g9mtvFjPmOenMgDvs tyGXdMc04ZSWbz+Az6XXW5Y= X-Google-Smtp-Source: AGHT+IGS//svrMT7du1L7hYPkMRlMw1w7II57mr4+UTXDM+X00YZpYf17P/sIlbIMWbEpqCB7Ct4cw== X-Received: by 2002:a05:651c:223:b0:2ba:18e5:1063 with SMTP id z3-20020a05651c022300b002ba18e51063mr665784ljn.50.1695904239195; Thu, 28 Sep 2023 05:30:39 -0700 (PDT) Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x6-20020a2e9c86000000b002ba045496d0sm3588724lji.125.2023.09.28.05.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 05:30:38 -0700 (PDT) From: Konstantin Aladyshev Cc: minyard@acm.org, joel@jms.id.au, andrew@aj.id.au, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, aladyshev22@gmail.com, jk@codeconstruct.com.au, matt@codeconstruct.com.au, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH 3/3] mctp: Add MCTP-over-KCS transport binding Date: Thu, 28 Sep 2023 15:30:09 +0300 Message-Id: <20230928123009.2913-4-aladyshev22@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230928123009.2913-1-aladyshev22@gmail.com> References: <20230928123009.2913-1-aladyshev22@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This change adds a MCTP KCS transport binding, as defined by the DMTF specificiation DSP0254 - "MCTP KCS Transport Binding". A MCTP protocol network device is created for each KCS channel found in the system. The interrupt code for the KCS state machine is based on the current IPMI KCS driver. Signed-off-by: Konstantin Aladyshev --- drivers/net/mctp/Kconfig | 8 + drivers/net/mctp/Makefile | 1 + drivers/net/mctp/mctp-kcs.c | 624 ++++++++++++++++++++++++++++++++++++ 3 files changed, 633 insertions(+) create mode 100644 drivers/net/mctp/mctp-kcs.c diff --git a/drivers/net/mctp/Kconfig b/drivers/net/mctp/Kconfig index dc71657d9184..a37f7ba947c0 100644 --- a/drivers/net/mctp/Kconfig +++ b/drivers/net/mctp/Kconfig @@ -33,6 +33,14 @@ config MCTP_TRANSPORT_I2C from DMTF specification DSP0237. A MCTP protocol network device is created for each I2C bus that has been assigned a mctp-i2c device. =20 +config MCTP_TRANSPORT_KCS + tristate "MCTP KCS transport" + depends on IPMI_KCS_BMC + help + Provides a driver to access MCTP devices over KCS transport, from + DMTF specification DSP0254. A MCTP protocol network device is + created for each KCS channel found in the system. + endmenu =20 endif diff --git a/drivers/net/mctp/Makefile b/drivers/net/mctp/Makefile index 1ca3e6028f77..885339a40f22 100644 --- a/drivers/net/mctp/Makefile +++ b/drivers/net/mctp/Makefile @@ -1,2 +1,3 @@ obj-$(CONFIG_MCTP_SERIAL) +=3D mctp-serial.o obj-$(CONFIG_MCTP_TRANSPORT_I2C) +=3D mctp-i2c.o +obj-$(CONFIG_MCTP_TRANSPORT_KCS) +=3D mctp-kcs.o diff --git a/drivers/net/mctp/mctp-kcs.c b/drivers/net/mctp/mctp-kcs.c new file mode 100644 index 000000000000..8d8b77ad709c --- /dev/null +++ b/drivers/net/mctp/mctp-kcs.c @@ -0,0 +1,624 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Management Component Transport Protocol (MCTP) KCS transport binding. + * This driver is an implementation of the DMTF specificiation + * "DSP0254 - Management Component Transport Protocol (MCTP) KCS Transport + * Binding", available at: + * + * https://www.dmtf.org/sites/default/files/standards/documents/DSP0254_1.= 0.0.pdf + * + * This driver provides DSP0254-type MCTP-over-KCS transport using a Linux + * KCS client subsystem. + * + * Copyright (c) 2023 Konstantin Aladyshev + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MCTP_KCS_MTU 64 +#define KCS_MSG_BUFSIZ 1000 + +struct mctp_kcs { + struct list_head entry; + + /* protects rx & tx state machines */ + spinlock_t lock; + + struct kcs_bmc_client client; + struct net_device *netdev; + + enum kcs_ipmi_phases phase; + enum kcs_ipmi_errors error; + + int data_in_idx; + u8 *data_in; + + int data_out_idx; + int data_out_len; + u8 *data_out; + + struct work_struct rx_work; +}; + +struct mctp_kcs_header { + u8 netfn_lun; + u8 defining_body; + u8 len; +} __packed; + +struct mctp_kcs_trailer { + u8 pec; +} __packed; + +// According to SMBUS spec, the polynomial is: +// // C(x) =3D X^8 + X^2 + X^1 + 1, which is 0x107, +// // just ignore bit8 in definition. +#define MCTP_KCS_PACKET_ERROR_CODE_POLY 0x07 +// +#define MCTP_KCS_NETFN_LUN 0xb0 +#define DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP 0x01 + +static u8 generate_crc8(u8 polynomial, u8 crc_init_val, u8 *buffer, u32 le= n) +{ + u8 bit_index; + u32 buffer_index; + u8 crc =3D crc_init_val; + + buffer_index =3D 0; + while (buffer_index < len) { + crc =3D crc ^ *(buffer + buffer_index); + buffer_index++; + + for (bit_index =3D 0; bit_index < 8; bit_index++) { + if ((crc & 0x80) !=3D 0) + crc =3D (crc << 1) ^ polynomial; + else + crc <<=3D 1; + } + } + return crc; +} + +static u8 generate_pec(u8 *buffer, u32 len) +{ + return generate_crc8(MCTP_KCS_PACKET_ERROR_CODE_POLY, 0, buffer, len); +} + +static int mctp_kcs_validate_data(struct mctp_kcs *mkcs, + struct mctp_kcs_header *hdr, int len) +{ + struct net_device *ndev =3D mkcs->netdev; + struct mctp_kcs_trailer *tlr; + u8 pec; + + if (hdr->netfn_lun !=3D MCTP_KCS_NETFN_LUN) { + dev_err(mkcs->client.dev->dev, + "%s: KCS binding header error! netfn_lun =3D 0x%02x, but should be 0x%0= 2x", + __func__, hdr->netfn_lun, MCTP_KCS_NETFN_LUN); + ndev->stats.rx_dropped++; + return -EINVAL; + } + if (hdr->defining_body !=3D DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP) { + dev_err(mkcs->client.dev->dev, + "%s: KCS binding header error! defining_body =3D 0x%02x, but should be = 0x%02x", + __func__, hdr->defining_body, + DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP); + ndev->stats.rx_dropped++; + return -EINVAL; + } + if (hdr->len !=3D (len - sizeof(struct mctp_kcs_header) - + sizeof(struct mctp_kcs_trailer))) { + dev_err(mkcs->client.dev->dev, + "%s: KCS binding header error! len =3D 0x%02x, but should be 0x%02x", + __func__, hdr->len, + (len - sizeof(struct mctp_kcs_header) - + sizeof(struct mctp_kcs_trailer))); + ndev->stats.rx_length_errors++; + return -EINVAL; + } + + pec =3D generate_pec((u8 *)(hdr + 1), hdr->len); + tlr =3D (struct mctp_kcs_trailer *)((u8 *)(hdr + 1) + hdr->len); + if (pec !=3D tlr->pec) { + dev_err(mkcs->client.dev->dev, + "%s: PEC error! Packet value=3D0x%02x, calculated value=3D0x%02x", + __func__, tlr->pec, pec); + ndev->stats.rx_crc_errors++; + return -EINVAL; + } + return 0; +} + +static void mctp_kcs_rx_work(struct work_struct *work) +{ + struct mctp_kcs *mkcs =3D container_of(work, struct mctp_kcs, rx_work); + struct mctp_skb_cb *cb; + struct sk_buff *skb; + unsigned long flags; + int rc; + int i; + struct mctp_kcs_header *kcs_header; + int data_len; + int data_in_idx; + + spin_lock_irqsave(&mkcs->lock, flags); + for (i =3D 0; i < (mkcs->data_in_idx); i++) + dev_dbg(mkcs->client.dev->dev, "%s: data_in[%d]=3D0x%02x", + __func__, i, mkcs->data_in[i]); + + data_len =3D mkcs->data_in_idx - sizeof(struct mctp_kcs_header) - + sizeof(struct mctp_kcs_trailer); + if (mkcs->phase !=3D KCS_PHASE_WRITE_DONE) { + dev_err(mkcs->client.dev->dev, + "%s: error! Wrong KCS stage at the end of data read (phase=3D%d)", + __func__, mkcs->phase); + mkcs->netdev->stats.rx_dropped++; + spin_unlock_irqrestore(&mkcs->lock, flags); + return; + } + + mkcs->phase =3D KCS_PHASE_WAIT_READ; + data_in_idx =3D mkcs->data_in_idx; + mkcs->data_in_idx =3D 0; + + skb =3D netdev_alloc_skb(mkcs->netdev, data_len); + if (!skb) { + mkcs->netdev->stats.rx_dropped++; + spin_unlock_irqrestore(&mkcs->lock, flags); + return; + } + + kcs_header =3D (struct mctp_kcs_header *)mkcs->data_in; + rc =3D mctp_kcs_validate_data(mkcs, kcs_header, data_in_idx); + if (rc) { + dev_err(mkcs->client.dev->dev, + "%s: error! Binding validation failed", __func__); + dev_kfree_skb(skb); + spin_unlock_irqrestore(&mkcs->lock, flags); + return; + } + + skb->protocol =3D htons(ETH_P_MCTP); + skb_put_data(skb, mkcs->data_in + sizeof(struct mctp_kcs_header), + data_len); + spin_unlock_irqrestore(&mkcs->lock, flags); + skb_reset_network_header(skb); + + cb =3D __mctp_cb(skb); + cb->halen =3D 0; + + netif_rx(skb); + mkcs->netdev->stats.rx_packets++; + mkcs->netdev->stats.rx_bytes +=3D data_len; +} + +static netdev_tx_t mctp_kcs_start_xmit(struct sk_buff *skb, + struct net_device *ndev) +{ + struct mctp_kcs_header *kcs_header; + unsigned long flags; + int i; + struct mctp_kcs *mkcs =3D netdev_priv(ndev); + + if (skb->len > MCTP_KCS_MTU) { + dev_err(&ndev->dev, "%s: error! skb len is bigger than MTU", + __func__); + ndev->stats.tx_dropped++; + goto out; + } + + spin_lock_irqsave(&mkcs->lock, flags); + if (mkcs->phase !=3D KCS_PHASE_WAIT_READ) { + dev_err(&ndev->dev, + "%s: error! Wrong KCS stage at the start of data write (phase=3D%d)", + __func__, mkcs->phase); + dev_kfree_skb(skb); + spin_unlock_irqrestore(&mkcs->lock, flags); + return NETDEV_TX_BUSY; + } + + netif_stop_queue(ndev); + mkcs->phase =3D KCS_PHASE_READ; + kcs_header =3D (struct mctp_kcs_header *)mkcs->data_out; + kcs_header->netfn_lun =3D MCTP_KCS_NETFN_LUN; + kcs_header->defining_body =3D DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP; + kcs_header->len =3D skb->len; + skb_copy_bits(skb, 0, kcs_header + 1, skb->len); + mkcs->data_out[sizeof(struct mctp_kcs_header) + skb->len] =3D + generate_pec((u8 *)(kcs_header + 1), skb->len); + mkcs->data_out_idx =3D 1; + mkcs->data_out_len =3D skb->len + sizeof(struct mctp_kcs_header) + + sizeof(struct mctp_kcs_trailer); + + for (i =3D 0; i < (mkcs->data_out_len); i++) + dev_dbg(&ndev->dev, "%s: data_out[%d]=3D0x%02x", __func__, i, + mkcs->data_out[i]); + + // Write first data byte to initialize transmission + kcs_bmc_write_data(mkcs->client.dev, mkcs->data_out[0]); + + spin_unlock_irqrestore(&mkcs->lock, flags); +out: + dev_kfree_skb(skb); + return NETDEV_TX_OK; +} + +static inline void set_state(struct mctp_kcs *mkcs, u8 state) +{ + dev_dbg(mkcs->client.dev->dev, "%s: state=3D0x%02x", __func__, state); + kcs_bmc_update_status(mkcs->client.dev, KCS_STATUS_STATE_MASK, + KCS_STATUS_STATE(state)); +} + +static int mctp_kcs_ndo_open(struct net_device *ndev) +{ + struct mctp_kcs *mkcs; + + mkcs =3D netdev_priv(ndev); + dev_info(&ndev->dev, "Open MCTP over KCS channel %d", + mkcs->client.dev->channel); + return kcs_bmc_enable_device(mkcs->client.dev, &mkcs->client); +} + +static int mctp_kcs_ndo_stop(struct net_device *ndev) +{ + struct mctp_kcs *mkcs; + + mkcs =3D netdev_priv(ndev); + dev_info(&ndev->dev, "Stop MCTP over KCS channel %d", + mkcs->client.dev->channel); + mkcs->data_in_idx =3D 0; + mkcs->data_out_idx =3D 0; + mkcs->data_out_len =3D 0; + mkcs->phase =3D KCS_PHASE_IDLE; + set_state(mkcs, IDLE_STATE); + kcs_bmc_disable_device(mkcs->client.dev, &mkcs->client); + return 0; +} + +static const struct net_device_ops mctp_kcs_netdev_ops =3D { + .ndo_start_xmit =3D mctp_kcs_start_xmit, + .ndo_open =3D mctp_kcs_ndo_open, + .ndo_stop =3D mctp_kcs_ndo_stop, +}; + +static void mctp_kcs_setup(struct net_device *ndev) +{ + ndev->type =3D ARPHRD_MCTP; + + /* we limit at the fixed MTU, which is also the MCTP-standard + * baseline MTU, so is also our minimum + */ + ndev->mtu =3D MCTP_KCS_MTU; + ndev->max_mtu =3D MCTP_KCS_MTU; + ndev->min_mtu =3D MCTP_KCS_MTU; + + ndev->hard_header_len =3D 0; + ndev->addr_len =3D 0; + ndev->tx_queue_len =3D DEFAULT_TX_QUEUE_LEN; + ndev->flags =3D IFF_NOARP; + ndev->netdev_ops =3D &mctp_kcs_netdev_ops; + ndev->needs_free_netdev =3D true; +} + +static void kcs_bmc_ipmi_force_abort(struct mctp_kcs *mkcs) +{ + dev_err(mkcs->client.dev->dev, + "Error! Force abort on KCS communication"); + set_state(mkcs, ERROR_STATE); + kcs_bmc_read_data(mkcs->client.dev); + kcs_bmc_write_data(mkcs->client.dev, KCS_ZERO_DATA); + mkcs->phase =3D KCS_PHASE_ERROR; + mkcs->data_in_idx =3D 0; +} + +static void kcs_bmc_ipmi_handle_data(struct mctp_kcs *mkcs) +{ + struct kcs_bmc_device *dev; + u8 data; + + dev =3D mkcs->client.dev; + + switch (mkcs->phase) { + case KCS_PHASE_WRITE_START: + dev_dbg(dev->dev, "%s: KCS_PHASE_WRITE_START", __func__); + mkcs->phase =3D KCS_PHASE_WRITE_DATA; + fallthrough; + + case KCS_PHASE_WRITE_DATA: + dev_dbg(dev->dev, "%s: KCS_PHASE_WRITE_DATA", __func__); + if (mkcs->data_in_idx < KCS_MSG_BUFSIZ) { + set_state(mkcs, WRITE_STATE); + kcs_bmc_write_data(dev, KCS_ZERO_DATA); + mkcs->data_in[mkcs->data_in_idx++] =3D + kcs_bmc_read_data(dev); + dev_dbg(dev->dev, + "%s: KCS_PHASE_WRITE_DATA: data_in[%d]=3D0x%02x", + __func__, mkcs->data_in_idx - 1, + mkcs->data_in[mkcs->data_in_idx - 1]); + } else { + kcs_bmc_ipmi_force_abort(mkcs); + mkcs->error =3D KCS_LENGTH_ERROR; + } + break; + + case KCS_PHASE_WRITE_END_CMD: + dev_dbg(dev->dev, "%s: KCS_PHASE_WRITE_END_CMD", __func__); + if (mkcs->data_in_idx < KCS_MSG_BUFSIZ) { + set_state(mkcs, READ_STATE); + mkcs->data_in[mkcs->data_in_idx++] =3D + kcs_bmc_read_data(dev); + dev_dbg(dev->dev, + "%s: KCS_PHASE_WRITE_END_CMD: data_in[%d]=3D0x%02x", + __func__, mkcs->data_in_idx - 1, + mkcs->data_in[mkcs->data_in_idx - 1]); + mkcs->phase =3D KCS_PHASE_WRITE_DONE; + schedule_work(&mkcs->rx_work); + } else { + kcs_bmc_ipmi_force_abort(mkcs); + mkcs->error =3D KCS_LENGTH_ERROR; + } + break; + + case KCS_PHASE_READ: + dev_dbg(dev->dev, + "%s: KCS_PHASE_READ, data_out_idx=3D%d, data_out_len=3D%d", + __func__, mkcs->data_out_idx, mkcs->data_out_len); + if (mkcs->data_out_idx =3D=3D mkcs->data_out_len) + set_state(mkcs, IDLE_STATE); + + data =3D kcs_bmc_read_data(dev); + if (data !=3D KCS_CMD_READ_BYTE) { + dev_dbg(dev->dev, + "%s: error! data is not equal to KCS_CMD_READ_BYTE", + __func__); + set_state(mkcs, ERROR_STATE); + kcs_bmc_write_data(dev, KCS_ZERO_DATA); + break; + } + + if (mkcs->data_out_idx =3D=3D mkcs->data_out_len) { + kcs_bmc_write_data(dev, KCS_ZERO_DATA); + mkcs->netdev->stats.tx_bytes +=3D mkcs->data_out_len; + mkcs->netdev->stats.tx_packets++; + mkcs->phase =3D KCS_PHASE_IDLE; + if (netif_queue_stopped(mkcs->netdev)) + netif_start_queue(mkcs->netdev); + break; + } + + dev_dbg(dev->dev, "%s: KCS_PHASE_READ: data_out[%d]=3D0x%02x", + __func__, mkcs->data_out_idx, + mkcs->data_out[mkcs->data_out_idx]); + kcs_bmc_write_data(dev, mkcs->data_out[mkcs->data_out_idx++]); + break; + + case KCS_PHASE_ABORT_ERROR1: + dev_dbg(dev->dev, "%s: KCS_PHASE_ABORT_ERROR1", __func__); + set_state(mkcs, READ_STATE); + kcs_bmc_read_data(dev); + kcs_bmc_write_data(dev, mkcs->error); + mkcs->phase =3D KCS_PHASE_ABORT_ERROR2; + break; + + case KCS_PHASE_ABORT_ERROR2: + dev_dbg(dev->dev, "%s: KCS_PHASE_ABORT_ERROR2", __func__); + set_state(mkcs, IDLE_STATE); + kcs_bmc_read_data(dev); + kcs_bmc_write_data(dev, KCS_ZERO_DATA); + mkcs->phase =3D KCS_PHASE_IDLE; + break; + + default: + dev_dbg(dev->dev, "%s: unknown KCS phase", __func__); + kcs_bmc_ipmi_force_abort(mkcs); + break; + } +} + +static void kcs_bmc_ipmi_handle_cmd(struct mctp_kcs *mkcs) +{ + struct kcs_bmc_device *dev; + u8 cmd; + + dev =3D mkcs->client.dev; + + set_state(mkcs, WRITE_STATE); + kcs_bmc_write_data(mkcs->client.dev, KCS_ZERO_DATA); + + cmd =3D kcs_bmc_read_data(mkcs->client.dev); + switch (cmd) { + case KCS_CMD_WRITE_START: + dev_dbg(dev->dev, "%s: KCS_CMD_WRITE_START", __func__); + mkcs->phase =3D KCS_PHASE_WRITE_START; + mkcs->error =3D KCS_NO_ERROR; + mkcs->data_in_idx =3D 0; + break; + + case KCS_CMD_WRITE_END: + dev_dbg(dev->dev, "%s: KCS_CMD_WRITE_END", __func__); + if (mkcs->phase !=3D KCS_PHASE_WRITE_DATA) { + kcs_bmc_ipmi_force_abort(mkcs); + break; + } + mkcs->phase =3D KCS_PHASE_WRITE_END_CMD; + break; + + case KCS_CMD_GET_STATUS_ABORT: + dev_dbg(dev->dev, "%s: KCS_CMD_GET_STATUS_ABORT", __func__); + if (mkcs->error =3D=3D KCS_NO_ERROR) + mkcs->error =3D KCS_ABORTED_BY_COMMAND; + + mkcs->phase =3D KCS_PHASE_ABORT_ERROR1; + mkcs->data_in_idx =3D 0; + break; + + default: + dev_dbg(dev->dev, "%s: unknown KCS command", __func__); + kcs_bmc_ipmi_force_abort(mkcs); + mkcs->error =3D KCS_ILLEGAL_CONTROL_CODE; + break; + } +} + +static inline struct mctp_kcs *client_to_mctp_kcs(struct kcs_bmc_client *c= lient) +{ + return container_of(client, struct mctp_kcs, client); +} + +static irqreturn_t kcs_bmc_mctp_event(struct kcs_bmc_client *client) +{ + struct mctp_kcs *mkcs; + u8 status; + int ret; + + mkcs =3D client_to_mctp_kcs(client); + if (!mkcs) { + dev_err(client->dev->dev, + "%s: error! can't find mctp_kcs from KCS client", + __func__); + return IRQ_NONE; + } + + spin_lock(&mkcs->lock); + + status =3D kcs_bmc_read_status(client->dev); + if (status & KCS_STATUS_IBF) { + if (status & KCS_STATUS_CMD_DAT) + kcs_bmc_ipmi_handle_cmd(mkcs); + else + kcs_bmc_ipmi_handle_data(mkcs); + + ret =3D IRQ_HANDLED; + } else { + ret =3D IRQ_NONE; + } + + spin_unlock(&mkcs->lock); + + return ret; +} + +static const struct kcs_bmc_client_ops kcs_bmc_mctp_client_ops =3D { + .event =3D kcs_bmc_mctp_event, +}; + +static DEFINE_SPINLOCK(kcs_bmc_mctp_instances_lock); +static LIST_HEAD(kcs_bmc_mctp_instances); + +static int kcs_bmc_mctp_add_device(struct kcs_bmc_device *kcs_bmc) +{ + struct mctp_kcs *mkcs; + struct net_device *ndev; + char name[32]; + int rc; + + snprintf(name, sizeof(name), "mctpkcs%d", kcs_bmc->channel); + + ndev =3D alloc_netdev(sizeof(*mkcs), name, NET_NAME_ENUM, mctp_kcs_setup); + if (!ndev) { + dev_err(kcs_bmc->dev, + "alloc_netdev failed for KCS channel %d\n", + kcs_bmc->channel); + rc =3D -ENOMEM; + goto err; + } + + mkcs =3D netdev_priv(ndev); + mkcs->netdev =3D ndev; + mkcs->client.dev =3D kcs_bmc; + mkcs->client.ops =3D &kcs_bmc_mctp_client_ops; + mkcs->data_in =3D devm_kmalloc(kcs_bmc->dev, KCS_MSG_BUFSIZ, GFP_KERNEL); + mkcs->data_out =3D devm_kmalloc(kcs_bmc->dev, KCS_MSG_BUFSIZ, GFP_KERNEL); + if (!mkcs->data_in || !mkcs->data_out) { + dev_err(kcs_bmc->dev, + "failed to allocate data buffers for KCS channel %d\n", + kcs_bmc->channel); + rc =3D -ENOMEM; + goto free_netdev; + } + + INIT_WORK(&mkcs->rx_work, mctp_kcs_rx_work); + + rc =3D register_netdev(ndev); + if (rc) + goto free_netdev; + + spin_lock_irq(&kcs_bmc_mctp_instances_lock); + list_add(&mkcs->entry, &kcs_bmc_mctp_instances); + spin_unlock_irq(&kcs_bmc_mctp_instances_lock); + + dev_info(kcs_bmc->dev, "Add MCTP client for the KCS channel %d", + kcs_bmc->channel); + return 0; + +free_netdev: + if (ndev) + free_netdev(ndev); + +err: + return rc; +} + +static int kcs_bmc_mctp_remove_device(struct kcs_bmc_device *kcs_bmc) +{ + struct mctp_kcs *mkcs =3D NULL, *pos; + + dev_info(kcs_bmc->dev, "Remove MCTP client for the KCS channel %d", + kcs_bmc->channel); + spin_lock_irq(&kcs_bmc_mctp_instances_lock); + list_for_each_entry(pos, &kcs_bmc_mctp_instances, entry) { + if (pos->client.dev =3D=3D kcs_bmc) { + mkcs =3D pos; + list_del(&pos->entry); + break; + } + } + spin_unlock_irq(&kcs_bmc_mctp_instances_lock); + + if (!mkcs) + return -ENODEV; + + unregister_netdev(mkcs->netdev); + free_netdev(mkcs->netdev); + kcs_bmc_disable_device(mkcs->client.dev, &mkcs->client); + devm_kfree(kcs_bmc->dev, mkcs->data_in); + devm_kfree(kcs_bmc->dev, mkcs->data_out); + return 0; +} + +static const struct kcs_bmc_driver_ops kcs_bmc_mctp_driver_ops =3D { + .add_device =3D kcs_bmc_mctp_add_device, + .remove_device =3D kcs_bmc_mctp_remove_device, +}; + +static struct kcs_bmc_driver kcs_bmc_mctp_driver =3D { + .ops =3D &kcs_bmc_mctp_driver_ops, +}; + +static int __init mctp_kcs_init(void) +{ + kcs_bmc_register_driver(&kcs_bmc_mctp_driver); + return 0; +} + +static void __exit mctp_kcs_exit(void) +{ + kcs_bmc_unregister_driver(&kcs_bmc_mctp_driver); +} + +module_init(mctp_kcs_init); +module_exit(mctp_kcs_exit); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Konstantin Aladyshev "); +MODULE_DESCRIPTION("MCTP KCS transport"); --=20 2.25.1