From nobody Fri Feb 13 10:59:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEB60E7D246 for ; Tue, 26 Sep 2023 07:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233381AbjIZHdt (ORCPT ); Tue, 26 Sep 2023 03:33:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjIZHds (ORCPT ); Tue, 26 Sep 2023 03:33:48 -0400 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B69D5DC for ; Tue, 26 Sep 2023 00:33:38 -0700 (PDT) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230926073334epoutp042093073dffa7b396fe32186d9e3f87cd~IYoxUNGKk2702727027epoutp04H for ; Tue, 26 Sep 2023 07:33:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230926073334epoutp042093073dffa7b396fe32186d9e3f87cd~IYoxUNGKk2702727027epoutp04H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695713614; bh=kMLO3gVzR9OmOkeO+X1L7iFxmq+nyJ0FFCBcvLMBvC4=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=C/dl4ilzLO0YHZTbbsBF6GIa9I6GWT5kgek1UZ804eiV+/5sikaic5CfLUflji3ys 8BBCF53iJ2ldi+UzXb5uhGort2cDTmVOC81PyK7V2LGlUeygdeuP8AbdRoEaD4xoKm LIuYHUWWFOZP3UwnxFiSBTBPFbpI0cDEWcy441E0= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230926073334epcas1p204f25b5e50bd7c9133b3682193498757~IYow18fyU3167231672epcas1p2n; Tue, 26 Sep 2023 07:33:34 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.222]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4Rvs194l8kz4x9Q5; Tue, 26 Sep 2023 07:33:33 +0000 (GMT) X-AuditID: b6c32a38-4dbf8700000027b3-81-6512894d9b7c Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 21.F2.10163.D4982156; Tue, 26 Sep 2023 16:33:33 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v4] vmscan: add trace events for lru_gen Reply-To: jaewon31.kim@samsung.com Sender: =?UTF-8?B?6rmA7J6s7JuQ?= From: =?UTF-8?B?6rmA7J6s7JuQ?= To: =?UTF-8?B?6rmA7J6s7JuQ?= , Yu Zhao CC: "rostedt@goodmis.org" , "tjmercier@google.com" , "kaleshsingh@google.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "hannes@cmpxchg.org" , "sj@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20230926051035epcms1p312b531bba2c17bb763b6f046a45c86da@epcms1p3> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230926073333epcms1p14c9798232b395007eb20becb5dbc4b4e@epcms1p1> Date: Tue, 26 Sep 2023 16:33:33 +0900 X-CMS-MailID: 20230926073333epcms1p14c9798232b395007eb20becb5dbc4b4e Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDJsWRmVeSWpSXmKPExsWy7bCmga5vp1CqwesORYs569ewWaze5GvR vXkmo0Xv+1dMFk37ZrJbXN41h83i3pr/rBZH1p9lsdjX8YDJ4vDXN0wW79Z/YbOY3djHaPFu whdWB16Pw2/eM3vsnHWX3aNl3y12jwWbSj02repk89j0aRK7x4kZv1k8+rasYvQ4s+AIu8fn TXIBXFHZNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlA tysplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJVSC1JyCswK9IoTc4tL89L18lJLrAwNDIxM gQoTsjOaZp5iLFhVXHH79RH2BsbOwC5GTg4JAROJv31HmbsYuTiEBHYwSjRMbWHvYuTg4BUQ lPi7QxikRljARmJyx2cWEFtIQEni7I8r7BBxa4n9i2YwgdhsApYS229OZASxRQTCJCYsm8gC MpNZYD2LxI/njxghlvFKzGh/ygJhS0tsX74VLM4p4Cdx5PxyNoi4qMTN1W/ZYez3x+ZD9YpI tN47ywxhC0o8+LmbEWbOn+PPoXqLJZZ1PmCCsGskVpxbBRU3l2h4u5IN4i9fidvtFiBhFgFV ien/10ONcZF4sG0HmM0sIC+x/e0cZpByZgFNifW79CFKFCV2/p4LVcIn8e5rDyvMVzvmPYHa qibR8uwrVFxG4u+/Z1C2h8SNp1OgwdzPJHF11VrGCYwKsxAhPQvJ5lkImxcwMq9iFEstKM5N Ty02LDCBR25yfu4mRnAy1rLYwTj37Qe9Q4xMHIyHGCU4mJVEeH8940sV4k1JrKxKLcqPLyrN SS0+xGgK9PNEZinR5HxgPsgriTc0sTQwMTMysTC2NDZTEuc99qo3RUggPbEkNTs1tSC1CKaP iYNTqoFJ0DfLemWIp4iY1ZSMiMmfJJM3TVRtkZnzmkvvCXtuv1bE+SW1ZqezH6uoPLj9dOWt VR7vv6x50z9hY8WhiHDvtbE2b+cZepg8TlSvlF52pF5YZ+ekBY1pQf87Xs+UsxTb1nfzg5qx UIZU7hen6jlfGLpSw5h+LN/ZnZ3odvRZV4Pzha3vluxetnPz/88mni8LVjYveBjxq6aiYqFO 0+EE220v5PpUTn14yNJ70GTTsqttbz/N88xoSLK0lPtY4PjXo6Q5rj3E/dK/v/sD9+643Pb+ +625M7d/vzh53e762bIJU0te9DHO3RW873av/+0v36/VSZvdXyU40frPb//3Fv9n3bLVa3vM IibCsXllixJLcUaioRZzUXEiABLf5XdPBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230926042019epcas1p11c28533f7b7db99db9f9d8a03ddd332c References: <20230926051035epcms1p312b531bba2c17bb763b6f046a45c86da@epcms1p3> <20230926042250.6028-1-jaewon31.kim@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>On Mon, Sep 25, 2023 at 10:20?PM Jaewon Kim wr= ote: >>> >>> As the legacy lru provides, the lru_gen needs some trace events for >>> debugging. >>> >>> This commit introduces 2 trace events. >>> trace_mm_vmscan_lru_gen_scan >>> trace_mm_vmscan_lru_gen_evict >>> >>> Each event is similar to the following legacy events. >>> trace_mm_vmscan_lru_isolate, >>> trace_mm_vmscan_lru_shrink_[in]active >> >>We should just reuse trace_mm_vmscan_lru_isolate and >>trace_mm_vmscan_lru_shrink_inactive instead of adding new tracepoints. >> >>To reuse trace_mm_vmscan_lru_isolate, we'd just need to append two new >>names to LRU_NAMES. >> >>The naming of trace_mm_vmscan_lru_shrink_inactive might seem confusing >>but it's how MGLRU maintains the compatibility, e.g., the existing >>active/inactive counters in /proc/vmstat. > > >Hello > >Actually I had tried to reuse them. But some value was not that compatible. >Let me try that way again. > >> Hello Yu Zhao Could you look into what I tried below? I reused the legacy trace events as= you recommened. For the nr_scanned for trace_mm_vmscan_lru_shrink_inactive, I just used the= scanned returned from isolate_folios. I thought this is right as scan_folios also uses its isolated. __count_vm_events(PGSCAN_ANON + type, isolated); But I guess the scanned in scan_folios is actually the one used in shrink_i= nactive_list I tested this on both 0 and 7 of /sys/kernel/mm/lru_gen/enabled diff --git a/mm/vmscan.c b/mm/vmscan.c index a4e44f1c97c1..b61a0156559c 100644 Acked-by: Yu Zhao --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4328,6 +4328,7 @@ static int scan_folios(struct lruvec *lruvec, struct = scan_control *sc, int sorted =3D 0; int scanned =3D 0; int isolated =3D 0; + int skipped =3D 0; int remaining =3D MAX_LRU_BATCH; struct lru_gen_folio *lrugen =3D &lruvec->lrugen; struct mem_cgroup *memcg =3D lruvec_memcg(lruvec); @@ -4341,7 +4342,7 @@ static int scan_folios(struct lruvec *lruvec, struct = scan_control *sc, =20 for (i =3D MAX_NR_ZONES; i > 0; i--) { LIST_HEAD(moved); - int skipped =3D 0; + int skipped_zone =3D 0; int zone =3D (sc->reclaim_idx + i) % MAX_NR_ZONES; struct list_head *head =3D &lrugen->folios[gen][type][zone]; =20 @@ -4363,16 +4364,17 @@ static int scan_folios(struct lruvec *lruvec, struc= t scan_control *sc, isolated +=3D delta; } else { list_move(&folio->lru, &moved); - skipped +=3D delta; + skipped_zone +=3D delta; } =20 - if (!--remaining || max(isolated, skipped) >=3D MIN= _LRU_BATCH) + if (!--remaining || max(isolated, skipped_zone) >= =3D MIN_LRU_BATCH) break; } =20 - if (skipped) { + if (skipped_zone) { list_splice(&moved, head); - __count_zid_vm_events(PGSCAN_SKIP, zone, skipped); + __count_zid_vm_events(PGSCAN_SKIP, zone, skipped_zo= ne); + skipped +=3D skipped_zone; } =20 if (!remaining || isolated >=3D MIN_LRU_BATCH) @@ -4387,6 +4389,9 @@ static int scan_folios(struct lruvec *lruvec, struct = scan_control *sc, __count_memcg_events(memcg, item, isolated); __count_memcg_events(memcg, PGREFILL, sorted); __count_vm_events(PGSCAN_ANON + type, isolated); + trace_mm_vmscan_lru_isolate(sc->reclaim_idx, sc->order, MAX_LRU_BAT= CH, + scanned, skipped, isolated, + type ? LRU_INACTIVE_FILE : LRU_INACTIVE= _ANON); =20 /* * There might not be eligible folios due to reclaim_idx. Check the @@ -4517,6 +4522,9 @@ static int evict_folios(struct lruvec *lruvec, struct= scan_control *sc, int swap retry: reclaimed =3D shrink_folio_list(&list, pgdat, sc, &stat, false); sc->nr_reclaimed +=3D reclaimed; + trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id, + scanned, reclaimed, &stat, sc->priority, + type ? LRU_INACTIVE_FILE : LRU_INACTIVE_ANON); =20 list_for_each_entry_safe_reverse(folio, next, &list, lru) { if (!folio_evictable(folio)) { >>> Here's an example >>> mm_vmscan_lru_gen_scan: classzone=3D2 order=3D0 nr_requested=3D4096 n= r_scanned=3D64 nr_skipped=3D0 nr_taken=3D64 lru=3Danon >>> mm_vmscan_lru_gen_evict: nid=3D0 nr_reclaimed=3D64 nr_dirty=3D0 nr_wr= iteback=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activ= ate_file=3D0 nr_ref_keep=3D0 nr_unmap_fail=3D0 priority=3D2 flags=3DRECLAIM= _WB_ANON|RECLAIM_WB_ASYNC >>> mm_vmscan_lru_gen_scan: classzone=3D1 order=3D0 nr_requested=3D4096 n= r_scanned=3D64 nr_skipped=3D0 nr_taken=3D64 lru=3Dfile >>> mm_vmscan_lru_gen_evict: nid=3D0 nr_reclaimed=3D64 nr_dirty=3D0 nr_wr= iteback=3D0 nr_congested=3D0 nr_immediate=3D0 nr_activate_anon=3D0 nr_activ= ate_file=3D0 nr_ref_keep=3D0 nr_unmap_fail=3D0 priority=3D12 flags=3DRECLAI= M_WB_FILE|RECLAIM_WB_ASYNC >>> >>> Signed-off-by: Jaewon Kim >>> --- >>> v4: wrap with #ifdef CONFIG_LRU_GEN >>> v3: change printk format >>> v2: use condition and make it aligned >>> v1: introduce trace events >>> --- >>> include/trace/events/mmflags.h | 9 ++++ >>> include/trace/events/vmscan.h | 96 ++++++++++++++++++++++++++++++++++ >>> mm/vmscan.c | 20 +++++-- >>> 3 files changed, 120 insertions(+), 5 deletions(-) >>> >>> diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmfl= ags.h >>> index 1478b9dd05fa..6dfe85bd4e81 100644 >>> --- a/include/trace/events/mmflags.h >>> +++ b/include/trace/events/mmflags.h >>> @@ -274,6 +274,12 @@ IF_HAVE_VM_SOFTDIRTY(VM_SOFTDIRTY, "softdirty" = ) \ >>> EM (LRU_ACTIVE_FILE, "active_file") \ >>> EMe(LRU_UNEVICTABLE, "unevictable") >>> >>> +#ifdef CONFIG_LRU_GEN >>> +#define LRU_GEN_NAMES \ >>> + EM (LRU_GEN_ANON, "anon") \ >>> + EMe(LRU_GEN_FILE, "file") >>> +#endif >>> + >>> /* >>> * First define the enums in the above macros to be exported to usersp= ace >>> * via TRACE_DEFINE_ENUM(). >>> @@ -288,6 +294,9 @@ COMPACTION_PRIORITY >>> /* COMPACTION_FEEDBACK are defines not enums. Not needed here. */ >>> ZONE_TYPE >>> LRU_NAMES >>> +#ifdef CONFIG_LRU_GEN >>> +LRU_GEN_NAMES >>> +#endif >>> >>> /* >>> * Now redefine the EM() and EMe() macros to map the enums to the stri= ngs >>> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmsca= n.h >>> index d2123dd960d5..2080ef742f89 100644 >>> --- a/include/trace/events/vmscan.h >>> +++ b/include/trace/events/vmscan.h >>> @@ -327,6 +327,102 @@ TRACE_EVENT(mm_vmscan_lru_isolate, >>> __print_symbolic(__entry->lru, LRU_NAMES)) >>> ); >>> >>> +#ifdef CONFIG_LRU_GEN >>> +TRACE_EVENT_CONDITION(mm_vmscan_lru_gen_scan, >>> + TP_PROTO(int highest_zoneidx, >>> + int order, >>> + unsigned long nr_requested, >>> + unsigned long nr_scanned, >>> + unsigned long nr_skipped, >>> + unsigned long nr_taken, >>> + int lru), >>> + >>> + TP_ARGS(highest_zoneidx, order, nr_requested, nr_scanned, nr_sk= ipped, nr_taken, lru), >>> + >>> + TP_CONDITION(nr_scanned), >>> + >>> + TP_STRUCT__entry( >>> + __field(int, highest_zoneidx) >>> + __field(int, order) >>> + __field(unsigned long, nr_requested) >>> + __field(unsigned long, nr_scanned) >>> + __field(unsigned long, nr_skipped) >>> + __field(unsigned long, nr_taken) >>> + __field(int, lru) >>> + ), >>> + >>> + TP_fast_assign( >>> + __entry->highest_zoneidx =3D highest_zoneidx; >>> + __entry->order =3D order; >>> + __entry->nr_requested =3D nr_requested; >>> + __entry->nr_scanned =3D nr_scanned; >>> + __entry->nr_skipped =3D nr_skipped; >>> + __entry->nr_taken =3D nr_taken; >>> + __entry->lru =3D lru; >>> + ), >>> + >>> + /* >>> + * classzone is previous name of the highest_zoneidx. >>> + * Reason not to change it is the ABI requirement of the tracep= oint. >>> + */ >>> + TP_printk("classzone=3D%d order=3D%d nr_requested=3D%lu nr_scan= ned=3D%lu nr_skipped=3D%lu nr_taken=3D%lu lru=3D%s", >>> + __entry->highest_zoneidx, >>> + __entry->order, >>> + __entry->nr_requested, >>> + __entry->nr_scanned, >>> + __entry->nr_skipped, >>> + __entry->nr_taken, >>> + __print_symbolic(__entry->lru, LRU_GEN_NAMES)) >>> +); >>> + >>> +TRACE_EVENT(mm_vmscan_lru_gen_evict, >>> + >>> + TP_PROTO(int nid, unsigned long nr_reclaimed, >>> + struct reclaim_stat *stat, int priority, int file), >>> + >>> + TP_ARGS(nid, nr_reclaimed, stat, priority, file), >>> + >>> + TP_STRUCT__entry( >>> + __field(unsigned long, nr_reclaimed) >>> + __field(unsigned long, nr_dirty) >>> + __field(unsigned long, nr_writeback) >>> + __field(unsigned long, nr_congested) >>> + __field(unsigned long, nr_immediate) >>> + __field(unsigned int, nr_activate0) >>> + __field(unsigned int, nr_activate1) >>> + __field(unsigned long, nr_ref_keep) >>> + __field(unsigned long, nr_unmap_fail) >>> + __field(int, nid) >>> + __field(int, priority) >>> + __field(int, reclaim_flags) >>> + ), >>> + >>> + TP_fast_assign( >>> + __entry->nid =3D nid; >>> + __entry->nr_reclaimed =3D nr_reclaimed; >>> + __entry->nr_dirty =3D stat->nr_dirty; >>> + __entry->nr_writeback =3D stat->nr_writeback; >>> + __entry->nr_congested =3D stat->nr_congested; >>> + __entry->nr_immediate =3D stat->nr_immediate; >>> + __entry->nr_activate0 =3D stat->nr_activate[0]; >>> + __entry->nr_activate1 =3D stat->nr_activate[1]; >>> + __entry->nr_ref_keep =3D stat->nr_ref_keep; >>> + __entry->nr_unmap_fail =3D stat->nr_unmap_fail; >>> + __entry->priority =3D priority; >>> + __entry->reclaim_flags =3D trace_reclaim_flags(file); >>> + ), >>> + >>> + TP_printk("nid=3D%d nr_reclaimed=3D%lu nr_dirty=3D%lu nr_writeb= ack=3D%lu nr_congested=3D%lu nr_immediate=3D%lu nr_activate_anon=3D%u nr_ac= tivate_file=3D%u nr_ref_keep=3D%lu nr_unmap_fail=3D%lu priority=3D%d flags= =3D%s", >>> + __entry->nid, __entry->nr_reclaimed, >>> + __entry->nr_dirty, __entry->nr_writeback, >>> + __entry->nr_congested, __entry->nr_immediate, >>> + __entry->nr_activate0, __entry->nr_activate1, >>> + __entry->nr_ref_keep, __entry->nr_unmap_fail, >>> + __entry->priority, >>> + show_reclaim_flags(__entry->reclaim_flags)) >>> +); >>> +#endif >>> + >>> TRACE_EVENT(mm_vmscan_write_folio, >>> >>> TP_PROTO(struct folio *folio), >>> diff --git a/mm/vmscan.c b/mm/vmscan.c >>> index 6f13394b112e..0c8b48bcb461 100644 >>> --- a/mm/vmscan.c >>> +++ b/mm/vmscan.c >>> @@ -5005,6 +5005,7 @@ static int scan_folios(struct lruvec *lruvec, str= uct scan_control *sc, >>> int sorted =3D 0; >>> int scanned =3D 0; >>> int isolated =3D 0; >>> + int skipped =3D 0; >>> int remaining =3D MAX_LRU_BATCH; >>> struct lru_gen_folio *lrugen =3D &lruvec->lrugen; >>> struct mem_cgroup *memcg =3D lruvec_memcg(lruvec); >>> @@ -5018,7 +5019,7 @@ static int scan_folios(struct lruvec *lruvec, str= uct scan_control *sc, >>> >>> for (i =3D MAX_NR_ZONES; i > 0; i--) { >>> LIST_HEAD(moved); >>> - int skipped =3D 0; >>> + int skipped_zone =3D 0; >>> int zone =3D (sc->reclaim_idx + i) % MAX_NR_ZONES; >>> struct list_head *head =3D &lrugen->folios[gen][type][z= one]; >>> >>> @@ -5040,16 +5041,17 @@ static int scan_folios(struct lruvec *lruvec, s= truct scan_control *sc, >>> isolated +=3D delta; >>> } else { >>> list_move(&folio->lru, &moved); >>> - skipped +=3D delta; >>> + skipped_zone +=3D delta; >>> } >>> >>> - if (!--remaining || max(isolated, skipped) >=3D= MIN_LRU_BATCH) >>> + if (!--remaining || max(isolated, skipped_zone)= >=3D MIN_LRU_BATCH) >>> break; >>> } >>> >>> - if (skipped) { >>> + if (skipped_zone) { >>> list_splice(&moved, head); >>> - __count_zid_vm_events(PGSCAN_SKIP, zone, skippe= d); >>> + __count_zid_vm_events(PGSCAN_SKIP, zone, skippe= d_zone); >>> + skipped +=3D skipped_zone; >>> } >>> >>> if (!remaining || isolated >=3D MIN_LRU_BATCH) >>> @@ -5065,6 +5067,10 @@ static int scan_folios(struct lruvec *lruvec, st= ruct scan_control *sc, >>> __count_memcg_events(memcg, PGREFILL, sorted); >>> __count_vm_events(PGSCAN_ANON + type, isolated); >>> >>> +#ifdef CONFIG_LRU_GEN >>> + trace_mm_vmscan_lru_gen_scan(sc->reclaim_idx, sc->order, MAX_LR= U_BATCH, >>> + scanned, skipped, isolated, type); >>> +#endif >> >>These functions are already within CONFIG_LRU_GEN. >> >>> /* >>> * There might not be eligible folios due to reclaim_idx. Check= the >>> * remaining to prevent livelock if it's not making progress. >>> @@ -5194,6 +5200,10 @@ static int evict_folios(struct lruvec *lruvec, s= truct scan_control *sc, int swap >>> retry: >>> reclaimed =3D shrink_folio_list(&list, pgdat, sc, &stat, false); >>> sc->nr_reclaimed +=3D reclaimed; >>> +#ifdef CONFIG_LRU_GEN >>> + trace_mm_vmscan_lru_gen_evict(pgdat->node_id, reclaimed, &stat, >>> + sc->priority, type); >>> +#endif >> >>Ditto.