From nobody Sun Nov 10 10:23:43 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07FFCE79A5 for ; Mon, 25 Sep 2023 22:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbjIYWBX (ORCPT ); Mon, 25 Sep 2023 18:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjIYWBV (ORCPT ); Mon, 25 Sep 2023 18:01:21 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3BA4112 for ; Mon, 25 Sep 2023 15:01:12 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3adf06730c4so4631018b6e.1 for ; Mon, 25 Sep 2023 15:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695679272; x=1696284072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f56JQlsSAmLM+rWl8eVCaUJ/LY2QFxeZQE+QgWmGsq0=; b=YoRyRJ9Giht3eW/Q610XE3F2Ud3rrWCyPsdIRd3z37dSf+q8+/GbTO7oIOYkm68NHD Um0RxXgS1al6+JEyF4ESYIb5DuJljtFqBzPpMsUTJUIAkqviGSrkvTidAx8m0dUuvVPZ y8vohGcTvi8Tbym221c1rZIrbnGTLHHYq6utw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695679272; x=1696284072; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f56JQlsSAmLM+rWl8eVCaUJ/LY2QFxeZQE+QgWmGsq0=; b=dHCStC753U4JnnVSsCxsYdxLZ61PqQ7inYAatetmC/fkJEgHR3exPv79k2hG6Yju/b yjU1pi+kboHtykrWwjiNAGR3SXDG7L3Ucu9oHRqqaxNLx/gNB3GGoe1ES4c99viRkm3L OIlLLVYQQMPKttAcBMaFnc/7/UztDyj4dmH+P+vQAwqFGD0wNDg6ZFHgq+eHknaihDvK zCqVP+al+wChNw3Q0ToB4dxTIsiTCWuulHrwNzu7x8DUziTpZUW4nEqOZoRbvvu7coKw caT3kzX3mNQqYFt9+EC/6JVXUuN1mvZWrAK+J22ROGDBO+sp6yAJVa0j8cmIFMqt9tsd ifOA== X-Gm-Message-State: AOJu0YxEcojLXJAIgch1woAQ7+imlkCzdhsxcLbly0vWE32mYzwH7vTb 62uKTCaNYIGTDOnLmt/v2Mbbng== X-Google-Smtp-Source: AGHT+IF1Hh6HqLLdCLMtBH4MBn5gTyDegFYkgrOxkSx/P6oII1rExFDnHQGDyN9+FIpRz6er1CzuVQ== X-Received: by 2002:a05:6808:1386:b0:3a7:38c5:bc18 with SMTP id c6-20020a056808138600b003a738c5bc18mr11073698oiw.32.1695679272043; Mon, 25 Sep 2023 15:01:12 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:f75d:a4e1:226a:3071]) by smtp.gmail.com with ESMTPSA id x23-20020a62fb17000000b00690f622d3cdsm8549874pfm.126.2023.09.25.15.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 15:01:11 -0700 (PDT) From: Douglas Anderson To: dri-devel@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org, Hsin-Yi Wang , matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Marek Szyprowski , Douglas Anderson , airlied@gmail.com, daniel@ffwll.ch, jitao.shi@mediatek.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com, sam@ravnborg.org Subject: [PATCH] drm/panel: Move AUX B116XW03 out of panel-edp back to panel-simple Date: Mon, 25 Sep 2023 15:00:11 -0700 Message-ID: <20230925150010.1.Iff672233861bcc4cf25a7ad0a81308adc3bda8a4@changeid> X-Mailer: git-send-email 2.42.0.515.g380fc7ccd1-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In commit 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") I moved a pile of panels out of panel-simple driver into the newly created panel-edp driver. One of those panels, however, shouldn't have been moved. As is clear from commit e35e305eff0f ("drm/panel: simple: Add AUO B116XW03 panel support"), AUX B116XW03 is an LVDS panel. It's used in exynos5250-snow and exynos5420-peach-pit where it's clear that the panel is hooked up with LVDS. Furthermore, searching for datasheets I found one that makes it clear that this panel is LVDS. As far as I can tell, I got confused because in commit 88d3457ceb82 ("drm/panel: auo,b116xw03: fix flash backlight when power on") Jitao Shi added "DRM_MODE_CONNECTOR_eDP". That seems wrong. Looking at the downstream ChromeOS trees, it seems like some Mediatek boards are using a panel that they call "auo,b116xw03" that's an eDP panel. The best I can guess is that they actually have a different panel that has similar timing. If so then the proper panel should be used or they should switch to the generic "edp-panel" compatible. When moving this back to panel-edp, I wasn't sure what to use for .bus_flags and .bus_format and whether to add the extra "enable" delay from commit 88d3457ceb82 ("drm/panel: auo,b116xw03: fix flash backlight when power on"). I've added formats/flags/delays based on my (inexpert) analysis of the datasheet. These are untested. NOTE: if/when this is backported to stable, we might run into some trouble. Specifically, before 474c162878ba ("arm64: dts: mt8183: jacuzzi: Move panel under aux-bus") this panel was used by "mt8183-kukui-jacuzzi", which assumed it was an eDP panel. I don't know what to suggest for that other than someone making up a bogus panel for jacuzzi that's just for the stable channel. Fixes: 88d3457ceb82 ("drm/panel: auo,b116xw03: fix flash backlight when pow= er on") Fixes: 5f04e7ce392d ("drm/panel-edp: Split eDP panels out of panel-simple") Signed-off-by: Douglas Anderson Acked-by: Hsin-Yi Wang Reviewed-by or Acked-by tag? Tested-by: Anton Bambura --- I haven't had a snow or peach-pit hooked up for debugging / testing for years. I presume that they must be broken and hope that this fixes them. drivers/gpu/drm/panel/panel-edp.c | 29 ----------------------- drivers/gpu/drm/panel/panel-simple.c | 35 ++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pane= l-edp.c index feb665df35a1..95c8472d878a 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -976,32 +976,6 @@ static const struct panel_desc auo_b116xak01 =3D { }, }; =20 -static const struct drm_display_mode auo_b116xw03_mode =3D { - .clock =3D 70589, - .hdisplay =3D 1366, - .hsync_start =3D 1366 + 40, - .hsync_end =3D 1366 + 40 + 40, - .htotal =3D 1366 + 40 + 40 + 32, - .vdisplay =3D 768, - .vsync_start =3D 768 + 10, - .vsync_end =3D 768 + 10 + 12, - .vtotal =3D 768 + 10 + 12 + 6, - .flags =3D DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, -}; - -static const struct panel_desc auo_b116xw03 =3D { - .modes =3D &auo_b116xw03_mode, - .num_modes =3D 1, - .bpc =3D 6, - .size =3D { - .width =3D 256, - .height =3D 144, - }, - .delay =3D { - .enable =3D 400, - }, -}; - static const struct drm_display_mode auo_b133han05_mode =3D { .clock =3D 142600, .hdisplay =3D 1920, @@ -1725,9 +1699,6 @@ static const struct of_device_id platform_of_match[] = =3D { }, { .compatible =3D "auo,b116xa01", .data =3D &auo_b116xak01, - }, { - .compatible =3D "auo,b116xw03", - .data =3D &auo_b116xw03, }, { .compatible =3D "auo,b133han05", .data =3D &auo_b133han05, diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/p= anel-simple.c index bb89e6d047bc..439d26928938 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -919,6 +919,38 @@ static const struct panel_desc auo_b101xtn01 =3D { }, }; =20 +static const struct drm_display_mode auo_b116xw03_mode =3D { + .clock =3D 70589, + .hdisplay =3D 1366, + .hsync_start =3D 1366 + 40, + .hsync_end =3D 1366 + 40 + 40, + .htotal =3D 1366 + 40 + 40 + 32, + .vdisplay =3D 768, + .vsync_start =3D 768 + 10, + .vsync_end =3D 768 + 10 + 12, + .vtotal =3D 768 + 10 + 12 + 6, + .flags =3D DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc auo_b116xw03 =3D { + .modes =3D &auo_b116xw03_mode, + .num_modes =3D 1, + .bpc =3D 6, + .size =3D { + .width =3D 256, + .height =3D 144, + }, + .delay =3D { + .prepare =3D 1, + .enable =3D 200, + .disable =3D 200, + .unprepare =3D 500, + }, + .bus_format =3D MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, + .bus_flags =3D DRM_BUS_FLAG_DE_HIGH, + .connector_type =3D DRM_MODE_CONNECTOR_LVDS, +}; + static const struct display_timing auo_g070vvn01_timings =3D { .pixelclock =3D { 33300000, 34209000, 45000000 }, .hactive =3D { 800, 800, 800 }, @@ -4128,6 +4160,9 @@ static const struct of_device_id platform_of_match[] = =3D { }, { .compatible =3D "auo,b101xtn01", .data =3D &auo_b101xtn01, + }, { + .compatible =3D "auo,b116xw03", + .data =3D &auo_b116xw03, }, { .compatible =3D "auo,g070vvn01", .data =3D &auo_g070vvn01, --=20 2.42.0.515.g380fc7ccd1-goog