From nobody Thu Nov 14 05:27:53 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6991CE7A96 for ; Mon, 25 Sep 2023 09:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjIYJ4t (ORCPT ); Mon, 25 Sep 2023 05:56:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbjIYJzy (ORCPT ); Mon, 25 Sep 2023 05:55:54 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A937CFE for ; Mon, 25 Sep 2023 02:55:47 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJc-0008AT-8C; Mon, 25 Sep 2023 11:55:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJb-008q0x-Rd; Mon, 25 Sep 2023 11:55:43 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJb-004dmk-Gk; Mon, 25 Sep 2023 11:55:43 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 37/40] soc/ti: pruss: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:28 +0200 Message-Id: <20230925095532.1984344-38-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1712; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=c709ql2KZbhU/Nl8vVPOXcOtp/pbM4UUu61jct04VQs=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlTBiMyND1a/8WSSXy+oJMj0pyN86clHNreORvveyv9cl /7uhH5KJ6MxCwMjF4OsmCKLfeOaTKsqucjOtf8uwwxiZQKZwsDFKQATmSnJ/k/HVTDCsJ2Zf9Ms mbz+CWt7NYPNpnZc1wlNS7rqNsdUeo9itffT18sDuj3DrzsWdspdirms+DQqvuhM32kVBW0ZMdd v33fVM9xu8dO9WDXLJ2lh1gqf3gOmER3/Df3s221rqkUEJBUytxWKvvjXJvLspN1fxsL3JWr7bb 4IF+iLz5itFf9lo+nL3ikrTsulil3U25ihd3pTo0UcSyXDj9yjG2candDx1quobVV/FlDCf7ggN OGndndt9fVTxnbhqXVWn9yPrJc+yv9+655fk1vlp35O4rjQ+mKD87L3Znbp73/f/T+L/ceikrhY ox82D5fssZV9sUX106eQyLdW864JBdxWKntx/E79QWkWAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/soc/ti/pruss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c index f49f8492dde5..24a42e0b645c 100644 --- a/drivers/soc/ti/pruss.c +++ b/drivers/soc/ti/pruss.c @@ -565,7 +565,7 @@ static int pruss_probe(struct platform_device *pdev) return ret; } =20 -static int pruss_remove(struct platform_device *pdev) +static void pruss_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; =20 @@ -573,8 +573,6 @@ static int pruss_remove(struct platform_device *pdev) =20 pm_runtime_put_sync(dev); pm_runtime_disable(dev); - - return 0; } =20 /* instance-specific driver private data */ @@ -610,7 +608,7 @@ static struct platform_driver pruss_driver =3D { .of_match_table =3D pruss_of_match, }, .probe =3D pruss_probe, - .remove =3D pruss_remove, + .remove_new =3D pruss_remove, }; module_platform_driver(pruss_driver); =20 --=20 2.40.1