From nobody Fri Sep 20 11:52:44 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF8C1CE7A81 for ; Mon, 25 Sep 2023 09:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbjIYJ53 (ORCPT ); Mon, 25 Sep 2023 05:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjIYJ4U (ORCPT ); Mon, 25 Sep 2023 05:56:20 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1618A13A for ; Mon, 25 Sep 2023 02:55:51 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJa-00081K-5h; Mon, 25 Sep 2023 11:55:42 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJZ-008q0H-HR; Mon, 25 Sep 2023 11:55:41 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJZ-004dm6-8N; Mon, 25 Sep 2023 11:55:41 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 27/40] soc/qcom: smp2p: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:18 +0200 Message-Id: <20230925095532.1984344-28-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1891; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Xs+opoIponkxHDRE3ORvSDT6IEXJd6McxyIMkPGK+D8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVheqoKnguqQNgbBYuCLhDeWAVPyN75Zdr8ZA g4zOlvqXyeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYXgAKCRCPgPtYfRL+ Tl2nB/9DgfJpqCbO4SqsCs95OR2K6HHgIzEdYgEC8EvrL2+u7ksyYaxsRkPQrbJ3Quhp9aNQr8D qXZbYrPyb58fP4w9LZe6Njol2pa4QmSeE6IAKVuv6X9NbtfsrtjivkKOtFnZPHTTINFZsXFdX6Y 4SjseFDArV0p7bd/S+kw9kuSp6eVtWYMfHmLAYswHfGwpSTBGsMcpiG0VHLijx99ljw4/NNYb3f 1HsR2er1TRL88e6toKpyhnL5fBlcCzIzB7P7sRJibrz1TfCJmh9zpdURbn4l852n6CsCrv31Ny0 lLkHnLuUQqknZYVUA00AR5tA+p2C462oS51jW48xTjOkn2lI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/soc/qcom/smp2p.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c index e9c8030d50ee..914b2246148f 100644 --- a/drivers/soc/qcom/smp2p.c +++ b/drivers/soc/qcom/smp2p.c @@ -660,7 +660,7 @@ static int qcom_smp2p_probe(struct platform_device *pde= v) return -EINVAL; } =20 -static int qcom_smp2p_remove(struct platform_device *pdev) +static void qcom_smp2p_remove(struct platform_device *pdev) { struct qcom_smp2p *smp2p =3D platform_get_drvdata(pdev); struct smp2p_entry *entry; @@ -676,8 +676,6 @@ static int qcom_smp2p_remove(struct platform_device *pd= ev) mbox_free_channel(smp2p->mbox_chan); =20 smp2p->out->valid_entries =3D 0; - - return 0; } =20 static const struct of_device_id qcom_smp2p_of_match[] =3D { @@ -688,7 +686,7 @@ MODULE_DEVICE_TABLE(of, qcom_smp2p_of_match); =20 static struct platform_driver qcom_smp2p_driver =3D { .probe =3D qcom_smp2p_probe, - .remove =3D qcom_smp2p_remove, + .remove_new =3D qcom_smp2p_remove, .driver =3D { .name =3D "qcom_smp2p", .of_match_table =3D qcom_smp2p_of_match, --=20 2.40.1