From nobody Fri Sep 20 11:48:07 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940B0CE7A95 for ; Mon, 25 Sep 2023 09:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjIYJz5 (ORCPT ); Mon, 25 Sep 2023 05:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjIYJzq (ORCPT ); Mon, 25 Sep 2023 05:55:46 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB011C6 for ; Mon, 25 Sep 2023 02:55:39 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJW-0007na-Ei; Mon, 25 Sep 2023 11:55:38 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJW-008pzG-2C; Mon, 25 Sep 2023 11:55:38 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJV-004dl4-PJ; Mon, 25 Sep 2023 11:55:37 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Krzysztof Halasa Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/40] soc/ixp4xx: ixp4xx-qmgr: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:02 +0200 Message-Id: <20230925095532.1984344-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1717; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=HudFbgOcgVWKgqxMtzAy+tK9o9GlSRRwK6tTBfx+JS4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhMmDxj6OX/DR/bhIvlFUD5d6B8TbKN3gQz7 EKAN2ByP9GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYTAAKCRCPgPtYfRL+ TgFYB/44oA3f0XXEXVKeBOSu5mPOcVc6nis5SiomTDO+TuP/3MPMHeLWmQ+omdc3yj6nDHwYnro Lp1nc8AmtBlXzlzkOTsAXKj/qJR6xBGZ+6lB1jZvR5pN2g6EcT3NbVOPl350D/wGi/4mmY1f4lm G8ozjN+5mkmY5g3ldYNKxVI/QyXtaazAzRd+QJ50nfwpLXc+eIVgoeXI/QonEE8185eaDHX+44+ 3LTGCTSFaMG3zbILZ0t6+hnZpluWiOrOQYHi3dHfEWbchWHi0cba1C8PjHJO4dczWPKxLKp+huA C/tu8Qaa7DEps5/HQWafKiLWkKMIhhnFl+xptdgYnE9mkLpR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/soc/ixp4xx/ixp4xx-qmgr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-q= mgr.c index 291086bb9313..244ad8d7e80b 100644 --- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c +++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c @@ -442,11 +442,10 @@ static int ixp4xx_qmgr_probe(struct platform_device *= pdev) return 0; } =20 -static int ixp4xx_qmgr_remove(struct platform_device *pdev) +static void ixp4xx_qmgr_remove(struct platform_device *pdev) { synchronize_irq(qmgr_irq_1); synchronize_irq(qmgr_irq_2); - return 0; } =20 static const struct of_device_id ixp4xx_qmgr_of_match[] =3D { @@ -462,7 +461,7 @@ static struct platform_driver ixp4xx_qmgr_driver =3D { .of_match_table =3D ixp4xx_qmgr_of_match, }, .probe =3D ixp4xx_qmgr_probe, - .remove =3D ixp4xx_qmgr_remove, + .remove_new =3D ixp4xx_qmgr_remove, }; module_platform_driver(ixp4xx_qmgr_driver); =20 --=20 2.40.1