From nobody Fri Sep 20 09:40:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9491BCE7A89 for ; Mon, 25 Sep 2023 09:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232943AbjIYJXV (ORCPT ); Mon, 25 Sep 2023 05:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233153AbjIYJXS (ORCPT ); Mon, 25 Sep 2023 05:23:18 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0205C0 for ; Mon, 25 Sep 2023 02:23:11 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50309daf971so9421108e87.3 for ; Mon, 25 Sep 2023 02:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695633790; x=1696238590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IDyabU/ctSGF4K3dTAmchO6EjvdapGJuzpqjXfhEki0=; b=USr70ALjq34CJviBj8kMoycih62RdwNPFTGT2aGyuSP4xNzALrY/0c90lS7sFv3rKf pD0+20MG7i/jGdwvDxef1ZWrHBdR51UufmRSrQQOZgxe0mM+zRDUx30PP9YSXGWKZ3ts G8FVuO5jlbhcuMI8jEFmvwKeXcSuW+3Z7qPrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695633790; x=1696238590; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IDyabU/ctSGF4K3dTAmchO6EjvdapGJuzpqjXfhEki0=; b=IkrU216go4ZM9s2Jf0pd7HxKfv9AQmEOMBXUBNPxzi8QIbTaUZ+byw+k4kt0OS3mH4 k2LDNiw/S8+8pLXdYnhqtrguX4QJ1nGYYAsJAEsSFaLL5vwT5qbg1rOALvFJs90RcXxQ 9v+6fOQ7+GpcUIfE4phqvKXGKsIWFVC5WumrCQXn+W3pEQBzBg9lLSdwUMzPpRnRqw0z NqQx+bmHdHYnmC2N6E6r85B6ibE5hbgpFd5ebg0CC2aGXWG8/ito6bVIFxckjY7MScsY I+7o90AOJIaEqHW6IsAEz8XedXODKyG6dqqu0xM8QNueiyCQCRLG8W/QAab1spsaXJYG qzqA== X-Gm-Message-State: AOJu0YzXFrMLJlXMksg4rFbcwu/xcm7uec4rhIQuN9gL5ViGwaY/BTQM eSggumTlVmjAJTCiV/2Rc3dY5w== X-Google-Smtp-Source: AGHT+IFdJhgh0QBpQXEzpkLS8WILLnuoY/8uaH456FPwyO42nXmJ7Ufixv3ar0REWsyD1mqtS+FBRg== X-Received: by 2002:a05:6512:b0a:b0:4fb:9fa7:dcda with SMTP id w10-20020a0565120b0a00b004fb9fa7dcdamr6155313lfu.26.1695633789773; Mon, 25 Sep 2023 02:23:09 -0700 (PDT) Received: from elfwind.c.googlers.com.com (49.240.189.35.bc.googleusercontent.com. [35.189.240.49]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c320500b003fc0505be19sm6494837wmp.37.2023.09.25.02.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 02:23:09 -0700 (PDT) From: Hubert Mazur To: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Bibby Hsieh , YT Shen , Daniel Kurtz , Michal Krawczyk , upstream@semihalf.com, Hubert Mazur Subject: [PATCH] drm/mediatek: Check GEM buffer size Date: Mon, 25 Sep 2023 09:22:49 +0000 Message-ID: <20230925092249.2228743-1-hmazur@chromium.org> X-Mailer: git-send-email 2.42.0.515.g380fc7ccd1-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The buffer size is derived from parameters supplied by the userspace. Having the size equal 0 causes allocation failure leading to kernel panic. Fix this by checking if size equals 0. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.= ") Signed-off-by: Hubert Mazur Reviewed-by: Michal Krawczyk --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/media= tek/mtk_drm_gem.c index 9f364df52478..3b985b99d5c6 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c @@ -62,6 +62,11 @@ struct mtk_drm_gem_obj *mtk_drm_gem_create(struct drm_de= vice *dev, struct drm_gem_object *obj; int ret; =20 + if (size =3D=3D 0) { + DRM_ERROR("Invalid allocation size: %zu", size); + return ERR_PTR(-EINVAL); + } + mtk_gem =3D mtk_drm_gem_init(dev, size); if (IS_ERR(mtk_gem)) return ERR_CAST(mtk_gem); --=20 2.42.0.515.g380fc7ccd1-goog