From nobody Sat Dec 6 07:46:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072BCCE7A89 for ; Mon, 25 Sep 2023 07:45:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232516AbjIYHpI (ORCPT ); Mon, 25 Sep 2023 03:45:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbjIYHox (ORCPT ); Mon, 25 Sep 2023 03:44:53 -0400 Received: from out30-118.freemail.mail.aliyun.com (out30-118.freemail.mail.aliyun.com [115.124.30.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9C64FC; Mon, 25 Sep 2023 00:44:45 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0Vsmvt.x_1695627880; Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0Vsmvt.x_1695627880) by smtp.aliyun-inc.com; Mon, 25 Sep 2023 15:44:41 +0800 From: Shuai Xue To: keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, rafael@kernel.org, lenb@kernel.org, james.morse@arm.com, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, robert.moore@intel.com Cc: linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, xueshuai@linux.alibaba.com, baolin.wang@linux.alibaba.com Subject: [RFC PATCH v2 5/9] ACPI: APEI: GHES: Use ERST to serialize APEI generic error before panic Date: Mon, 25 Sep 2023 15:44:22 +0800 Message-Id: <20230925074426.97856-6-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230925074426.97856-1-xueshuai@linux.alibaba.com> References: <20230925074426.97856-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In certain scenarios (ie. hosts/guests with root filesystems on NFS/iSCSI where networking software and/or hardware fails, and thus kdump fails), it is necessary to serialize hardware error information available for post-mortem debugging. Save the hardware error log into flash via ERST before go panic, the hardware error log can be gotten from the flash after system boot successful again, which is very useful in production. Signed-off-by: Shuai Xue --- drivers/acpi/apei/ghes.c | 44 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index d14e00751161..306bced16884 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -41,6 +41,7 @@ #include #include #include +#include =20 #include #include @@ -636,6 +637,43 @@ static void ghes_defer_non_standard_event(struct acpi_= hest_generic_data *gdata, schedule_work(&entry->work); } =20 +static int ghes_serialize_estatus(struct acpi_hest_generic_data *gdata, u8= notify_type) +{ + void *err =3D acpi_hest_get_payload(gdata); + int data_len =3D gdata->error_data_length; + struct cper_pstore_record *rcd; + int record_len =3D data_len + sizeof(*rcd); + + rcd =3D kmalloc(record_len, GFP_KERNEL); + memset(rcd, 0, sizeof(*rcd)); + + memcpy(rcd->hdr.signature, CPER_SIG_RECORD, CPER_SIG_SIZE); + rcd->hdr.revision =3D CPER_RECORD_REV; + rcd->hdr.signature_end =3D CPER_SIG_END; + rcd->hdr.section_count =3D 1; + rcd->hdr.error_severity =3D CPER_SEV_FATAL; + /* timestamp, platform_id, partition_id are all invalid */ + rcd->hdr.validation_bits =3D 0; + rcd->hdr.record_length =3D record_len; + rcd->hdr.creator_id =3D CPER_CREATOR_PSTORE; + rcd->hdr.notification_type =3D CPER_NOTIFY_MCE; + rcd->hdr.record_id =3D cper_next_record_id(); + rcd->hdr.flags =3D CPER_HW_ERROR_FLAGS_PREVERR; + + rcd->sec_hdr.section_offset =3D (void *)&rcd->data - (void *)&rcd; + rcd->sec_hdr.section_length =3D data_len; + rcd->sec_hdr.revision =3D CPER_SEC_REV; + /* ->ru_id and fru_text is invalid */ + rcd->sec_hdr.validation_bits =3D 0; + rcd->sec_hdr.flags =3D CPER_SEC_PRIMARY; + rcd->sec_hdr.section_type =3D gdata->section_type; + rcd->sec_hdr.section_severity =3D gdata->error_severity; + + memcpy(&rcd->data, err, data_len); + + return erst_write(&rcd->hdr); +} + static bool ghes_do_proc(struct ghes *ghes, const struct acpi_hest_generic_status *estatus) { @@ -861,10 +899,16 @@ static void __ghes_panic(struct ghes *ghes, struct acpi_hest_generic_status *estatus, u64 buf_paddr, enum fixed_addresses fixmap_idx) { + struct acpi_hest_generic_data *gdata; + u8 notify_type =3D ghes->generic->notify.type; + __ghes_print_estatus(KERN_EMERG, ghes->generic, estatus); =20 ghes_clear_estatus(ghes, estatus, buf_paddr, fixmap_idx); =20 + apei_estatus_for_each_section(estatus, gdata) + ghes_serialize_estatus(gdata, notify_type); + /* reboot to log the error! */ if (!panic_timeout) panic_timeout =3D ghes_panic_timeout; --=20 2.41.0