From nobody Fri Feb 13 17:33:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62028E7D0CF for ; Fri, 22 Sep 2023 06:27:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231159AbjIVG1U (ORCPT ); Fri, 22 Sep 2023 02:27:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbjIVG1P (ORCPT ); Fri, 22 Sep 2023 02:27:15 -0400 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06574CE for ; Thu, 21 Sep 2023 23:27:08 -0700 (PDT) Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20230922062706epoutp0166e89d99a99e0924e6291ba2b24d88ac~HJJlw_R6I2466924669epoutp01P for ; Fri, 22 Sep 2023 06:27:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20230922062706epoutp0166e89d99a99e0924e6291ba2b24d88ac~HJJlw_R6I2466924669epoutp01P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1695364026; bh=Hb4LK5km1WEqj6D7AXzSXon9Q0vrfwXxLWOoV26SQdE=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=EmAF6m7JoU8D2EZTeEB/Pa6OJhUy9xxH3BdYD+F4Jl+erdpmvzTGP2MwI9Zobpd5i NBxRaC8IdM8Wc+cmXqQigPl4xPJP1+eStz1Tozgpnu0iUGf7lwHp3sqRmwLXzAXUmm NcyJd7rhPPPLrydPqqj/df+MZ0xDxmcKIsP4HDfw= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20230922062705epcas1p34f0ace6c5a64263ee8e96a68e7bbcd4f~HJJlG8xmN3259332593epcas1p3J; Fri, 22 Sep 2023 06:27:05 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.38.242]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4RsMkK0hR2z4x9Pp; Fri, 22 Sep 2023 06:27:05 +0000 (GMT) X-AuditID: b6c32a38-4dbf8700000027b3-12-650d33b849f7 Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id FA.B9.10163.8B33D056; Fri, 22 Sep 2023 15:27:05 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH] mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_to_fit_type Reply-To: jason.sim@samsung.com Sender: Jaeseon Sim From: Jaeseon Sim To: "bhe@redhat.com" , "urezki@gmail.com" CC: "akpm@linux-foundation.org" , "hch@infradead.org" , "lstoakes@gmail.com" , Jaeseon Sim , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jaewon Kim X-Priority: 3 X-Content-Kind-Code: NORMAL X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230922062704epcms1p1722f24d4489a0435b339ce21db754ded@epcms1p1> Date: Fri, 22 Sep 2023 15:27:04 +0900 X-CMS-MailID: 20230922062704epcms1p1722f24d4489a0435b339ce21db754ded Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmk+LIzCtJLcpLzFFi42LZdlhTV3enMW+qwZPNTBZz1q9hszj/4Beb xekJi5gset+/YrJYdOASo8XlXXPYLO6t+c9qcefbPHaL1RdZHDg9ds66y+6xeYWWx6ZPk9g9 Tsz4zeLxft9VNo++LasYPT5vkgtgj8q2yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0 MFdSyEvMTbVVcvEJ0HXLzAE6TEmhLDGnFCgUkFhcrKRvZ1OUX1qSqpCRX1xiq5RakJJTYFag V5yYW1yal66Xl1piZWhgYGQKVJiQnfH2zhLmgkNSFRe/3WBsYGyQ7GLk5JAQMJHo//eerYuR i0NIYAejxKwPn5m6GDk4eAUEJf7uEAapERYIlph1eQkriC0kIC9xdksDI0RcW+LUyovMIDab gKZE14Ut7CC2iICPxLnvh8BmMgucZZJYevQMM8QyXokZ7U9ZIGxpie3LtzJC2KISN1e/ZYex 3x+bDxUXkWi9dxaqV1Diwc/dUHEpiTNtS6DmFEusX3OdCcKukTj6ZD9U3Fyi4e1KNohffCUW 7fMBCbMIqEr0LLzIBlHiItH2aivYX8xAvyxb+JoZpJwZ6Jf1u/QhShQldv6eywhRwifx7msP K8wnO+Y9gdqqLPHx2wVGkFYJAUmJCbvMIcIeEjufroSGWqDEu98n2Scwys9ChO0sJHtnIexd wMi8ilEstaA4Nz212LDABB6dyfm5mxjBqVLLYgfj3Lcf9A4xMnEwHmKU4GBWEuFN/sSVKsSb klhZlVqUH19UmpNafIjRFOjjicxSosn5wGSdVxJvaGJpYGJmZGJhbGlspiTOe+xVb4qQQHpi SWp2ampBahFMHxMHp1QD0/znP1/pvtq786jtVh3RglTHS2bOp4275zCozDJckHd48krf/3+u xT/KDl/mdvpqxAZG888JiwQnHGLSkW/o29h1TOkos8gxptTHu44Jv/q3XF84ZJmTbMifJ5cv eNoGGvZJp+fMMrhx7/TeiZ3aN+cG872OT+TeZsU598GCbuk9l+aeZTqjurg0Y3HL5KKqZ2WR uz/W3VNkz5CaJFp+KNT/HKuUxMKlv+8ELzqoLOp0ccNxq5znC6W/FJxpDs/5oiV0+nhv3azp uqIrmS5P6g4pm35T2L5KOludaSrj/47G7bmbjuvFSsecff7vUvd/iYNJhz33MB45WLiwfmFu aILorkfrVB/fOjY1aafhwc1KLMUZiYZazEXFiQBwXZhTHgQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230922061715epcms1p7cd5a37f4bba0abf4bc159b844bd8ee65 References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's panic issue as follows when do alloc_vmap_area: Kernel panic - not syncing: kernel: panic_on_warn set ... page allocation failure: order:0, mode:0x800(GFP_NOWAIT) Call Trace: warn_alloc+0xf4/0x190 __alloc_pages_slowpath+0xe0c/0xffc __alloc_pages+0x250/0x2d0 new_slab+0x17c/0x4e0 ___slab_alloc+0x4e4/0x8a8 __slab_alloc+0x34/0x6c kmem_cache_alloc+0x20c/0x2f0 adjust_va_to_fit_type __alloc_vmap_area alloc_vmap_area+0x298/0x7fc __get_vm_area_node+0x10c/0x1b4 __vmalloc_node_range+0x19c/0x7c0 Commit 1b23ff80b399 ("mm/vmalloc: invoke classify_va_fit_type() in adjust_va_to_fit_type()") moved classify_va_fit_type() into adjust_va_to_fit_type() and used WARN_ON_ONCE() to handle return value of adjust_va_to_fit_type(), just as classify_va_fit_type() was handled. There is another path in adjust_va_to_fit_type() which could return failure and will be handled in alloc_vmap_area(). Remove WARN_ON_ONCE() for this case. Fixes: 45c62fc2897d ("mm/vmalloc: Remove WARN_ON_ONCE related to adjust_va_= to_fit_type") Signed-off-by: Jaeseon Sim --- =C2=A0mm/vmalloc.c | 4 ++-- =C2=A01 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index ef8599d394fd..4a82b6525d48 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1522,7 +1522,7 @@ __alloc_vmap_area(struct rb_root *root, struct list_h= ead *head, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Update the free vmap_area. */ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D adjust_va_to_fit_type(root, head,= va, nva_start_addr, size); -=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (WARN_ON_ONCE(ret)) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ret) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return vend; =C2=A0 =C2=A0#if DEBUG_AUGMENT_LOWEST_MATCH_CHECK @@ -4143,7 +4143,7 @@ struct vm_struct **pcpu_get_vm_areas(const unsigned l= ong *offsets, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D adjus= t_va_to_fit_type(&free_vmap_area_root, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0&free_vmap_area_list, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0va, start, size); -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (WARN_ON_ONCE(u= nlikely(ret))) +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (unlikely(ret)) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0/* It is a BUG(), but trigger recovery instead. */ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0goto recovery; =C2=A0 --=C2=A0 2.17.1