From nobody Fri Feb 13 17:33:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DF7E7D0BB for ; Fri, 22 Sep 2023 01:31:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjIVBb7 (ORCPT ); Thu, 21 Sep 2023 21:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjIVBb4 (ORCPT ); Thu, 21 Sep 2023 21:31:56 -0400 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.220]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ADAD2F1 for ; Thu, 21 Sep 2023 18:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=KQLUY a3KKK3ZT24Fs/QQWKicsaIGPOdPCRwIWIKrD1s=; b=luycWt4Zg1BUPG+yqMYIe WfdPUppsH7JDy5y1wIqUg0z5/yC1zB5zfZl394OPmr8RPrvKJyewqc1BjXdl67D8 2uMBZUu+G7wZ8AyDo/e+xZ1q01c9vK/dSU4GWTC8PUIsVnMs0pDuD8tY5RK1+Mph f9caR/XRExSlgt2epdqVoQ= Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by zwqz-smtp-mta-g0-2 (Coremail) with SMTP id _____wB3fS5X7gxlowDGAw--.9931S4; Fri, 22 Sep 2023 09:31:15 +0800 (CST) From: Ma Ke To: alain.volmat@foss.st.com, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH] drm/sti: avoid potential dereference of error pointers Date: Fri, 22 Sep 2023 09:31:01 +0800 Message-Id: <20230922013101.3603005-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wB3fS5X7gxlowDGAw--.9931S4 X-Coremail-Antispam: 1Uf129KBjvdXoWruFyUWw4rGr43ZFW7Jw13Arb_yoW3trg_G3 WUXr1fKrWDKa1jqF4jyrn8JasY9rZ5XF48Xr1Iqas8ur4kAry8X347Wr1fWFyUWF18tFyq qa1xur90krn0kjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRNCzt7UUUUU== X-Originating-IP: [183.174.60.14] X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/xtbBFQXyC2B9oNhq-QAAsb Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_cursor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cur= sor.c index db0a1eb53532..e460f5ba2d87 100644 --- a/drivers/gpu/drm/sti/sti_cursor.c +++ b/drivers/gpu/drm/sti/sti_cursor.c @@ -200,6 +200,8 @@ static int sti_cursor_atomic_check(struct drm_plane *dr= m_plane, return 0; =20 crtc_state =3D drm_atomic_get_crtc_state(state, crtc); + if (IS_ERR(crtc_state)) + return PTR_ERR(crtc_state); mode =3D &crtc_state->mode; dst_x =3D new_plane_state->crtc_x; dst_y =3D new_plane_state->crtc_y; --=20 2.37.2