From nobody Fri Feb 13 19:27:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185BDE7D0A2 for ; Thu, 21 Sep 2023 20:03:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231655AbjIUUDR (ORCPT ); Thu, 21 Sep 2023 16:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbjIUUCk (ORCPT ); Thu, 21 Sep 2023 16:02:40 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5737257B0D for ; Thu, 21 Sep 2023 10:28:00 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-530e180ffcbso1381749a12.1 for ; Thu, 21 Sep 2023 10:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1695317276; x=1695922076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FFHoFBATjyYAR3S3Kihiw7DM+oB505Wu13vuO5lq7BQ=; b=W/ATYciTyI2eXLzb8z9l7I7kt+ECVbTH/WTc7rQ1iKlT/lMkmlSqQc8qOqRq8lBcRI myozTsm6nt+bUl3q88o6tY/LUiHjHY4avOyjTVInWlYHUuY0AgOvUCrsCviHKnm1n+64 YX3aINC2DkR64VeFN+EAjZAEJbQfUukoETSGWs8kzcCW5hOb8qP/1yEIT87WFPLB06YY 8oX5rbTR2EHMqpjBFRfhZ9kp/Bzgt4m5HyJlZiu9vZBXxDNIMSLeDzEbvblQuAI+ZQ59 S2+e401MNlAuiNfWYLASXD16wj3wKbqIMRwXctPljoAeaqhDJxPzC+Blh68BuVxyCx2C H0OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695317276; x=1695922076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FFHoFBATjyYAR3S3Kihiw7DM+oB505Wu13vuO5lq7BQ=; b=eG02j1a8WSvsBrMDiz+B5qwmdcoHEGsdxkjT2T1slt833sSVlHb4FPG4D44+D6mHpI DUD/mcIm2dYPxSXSwdGyMKsv2mgywII/3RDJhO/fPLN2H5F6ykYmGrLWkqx8BF0H35BT xMzCF2HDEekRbGnxMqeJRw7MnkzptcpRPs5FFINuG1Om+Yyhpx/95UtxbP5wu4kxbGwh H0LZs+DVzugK2s4eQYj2+usMIFRgjTwIb2dkmiCKqOQQeumtKSUXYZZ4FoLM4CAYzpyy S9tylnKhg5kDOe9mAG5+vB16c5GOwT2eonvzcy8xLCM0VC8baISD9eWhTQWb/jeTlwtQ rnTQ== X-Gm-Message-State: AOJu0YzEvtT7R+1KMPbvaKJiIsz8hzbSlOl9yGT35XNFWbSlG50L7Ced GvM0EoDYPR19pNDFAuPUHVYzcwq6BnpNrOdNOdunylab X-Google-Smtp-Source: AGHT+IFyRSQ9sVI6svVzHUR3normBxbHxw1ADHwq9tPPMiHuaAAm+CM2HzCwtdqMZnvyJVaEdPWyUw== X-Received: by 2002:a7b:ce15:0:b0:401:daf2:273b with SMTP id m21-20020a7bce15000000b00401daf2273bmr5282558wmc.12.1695307465779; Thu, 21 Sep 2023 07:44:25 -0700 (PDT) Received: from localhost.localdomain (abordeaux-655-1-129-86.w90-5.abo.wanadoo.fr. [90.5.10.86]) by smtp.gmail.com with ESMTPSA id s17-20020a1cf211000000b003fe2a40d287sm2125515wmc.1.2023.09.21.07.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 07:44:25 -0700 (PDT) From: David Lechner To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , =?UTF-8?q?Nuno=20S=C3=A1?= , Axel Haslam , Philip Molloy , David Lechner Subject: [PATCH v2 15/19] staging: iio: resolver: ad2s1210: read excitation frequency from control register Date: Thu, 21 Sep 2023 09:43:56 -0500 Message-Id: <20230921144400.62380-16-dlechner@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230921144400.62380-1-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This modifies the ad2s1210_show_fexcit() function to read the excitation frequency from the control register. This way we don't have to keep track of the value and don't risk returning a stale value. Signed-off-by: David Lechner --- drivers/staging/iio/resolver/ad2s1210.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/= resolver/ad2s1210.c index f1ffee34ebbc..27294eff99ef 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -78,7 +78,6 @@ struct ad2s1210_state { struct regmap *regmap; /** The external oscillator frequency in Hz. */ unsigned long fclkin; - unsigned int fexcit; u8 resolution; u8 rx[2] __aligned(IIO_DMA_MINALIGN); u8 tx[2]; @@ -202,8 +201,6 @@ static int ad2s1210_set_excitation_frequency(struct ad2= s1210_state *st, if (ret < 0) return ret; =20 - st->fexcit =3D fexcit; - /* software reset reinitializes the excitation frequency output */ return regmap_write(st->regmap, AD2S1210_REG_SOFT_RESET, 0); } @@ -225,8 +222,22 @@ static ssize_t ad2s1210_show_fexcit(struct device *dev, char *buf) { struct ad2s1210_state *st =3D iio_priv(dev_to_iio_dev(dev)); + unsigned int value; + u16 fexcit; + int ret; =20 - return sprintf(buf, "%u\n", st->fexcit); + mutex_lock(&st->lock); + ret =3D regmap_read(st->regmap, AD2S1210_REG_EXCIT_FREQ, &value); + if (ret < 0) + goto error_ret; + + fexcit =3D value * st->fclkin / (1 << 15); + + ret =3D sprintf(buf, "%u\n", fexcit); + +error_ret: + mutex_unlock(&st->lock); + return ret; } =20 static ssize_t ad2s1210_store_fexcit(struct device *dev, --=20 2.34.1