From nobody Tue Dec 16 12:34:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4727CC04FF6 for ; Wed, 20 Sep 2023 19:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbjITT3A (ORCPT ); Wed, 20 Sep 2023 15:29:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjITT2w (ORCPT ); Wed, 20 Sep 2023 15:28:52 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F72DC; Wed, 20 Sep 2023 12:28:38 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-503012f4e71so1568236e87.0; Wed, 20 Sep 2023 12:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695238116; x=1695842916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AdGvtIhnrYM49qOF0XUq1B70UdgD51RskmRPZFchMpY=; b=FBt9uxSi91J33FLj5glMQTZgds5i3ryEoDg4Xl57+ubzdKGL7/3C3+P19ty+qzCHrY XAS7Yln49MYlKGaoGxKmc+fjJbUkhbq818tm9Sskh62tPtv4bxIwO7QE7STeGpW82kNG 1f9oWOeU4DWqQidERbrkYhKQ+EjLhCBgPjTRgc9jvHsZgmFZcGbtNIahAX4wSL6EMWNg hgE4dG3RijF8wcJhKr6XzRQ2HCvlI5x1okZnq8g7BXRQClAGhzH7s3P8b98E5+ja3n/b GlYUP9OUJqn0G15oUHTxRVhPgO7mq2Fovv5CRRy6k2BEcjGnPnnAY0CN8KL4NZjDGkH9 uRag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695238116; x=1695842916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AdGvtIhnrYM49qOF0XUq1B70UdgD51RskmRPZFchMpY=; b=szeJF7nu3CrGcmjKF3nrTzWw/rkiQG156MkM46i2y1vWbb2ObFccJRSre17oBMCEjw 2NJxIKWVBWaADv7pEZD9ImS0hrdEutq1x5yCjgSEh8w15IfTWj4m1io5lTk6OMyI6ixp JrcHwCb95mikApFTZZoCC/7BFE02fTGHsrWzUTrSay/dxp5/Bu0a8QPvZL5Vh21ESLuM Ug6AG8iqPrxRL5Nskvd1GbPuHF85LFMr51KKZxo21TCRpCj9Gr1L5FGYhN2fo3+ArSBg glrccTpHCbN/jgKmwu/SFMSCSvY1tEZdG9xcrVQKFW0+c7v1aFjcNsYXAPDBR5+HfucQ CjiA== X-Gm-Message-State: AOJu0Yw5A/VhRdRGJsERO6VYGlK94d9Q6qNzDwtp5fKiDqlcUYMuuufI hAAC/UPO4wx3afH/2E2dVko= X-Google-Smtp-Source: AGHT+IGvY2WjckLrqKF2TZ5J4zmwaRfWiTj3OXCSDcx1z66FZOZ2M7wBbipUU8euAtyWN4c2zI6iZQ== X-Received: by 2002:a05:6512:3d29:b0:502:d973:3206 with SMTP id d41-20020a0565123d2900b00502d9733206mr3053467lfv.6.1695238116092; Wed, 20 Sep 2023 12:28:36 -0700 (PDT) Received: from localhost ([85.140.0.70]) by smtp.gmail.com with ESMTPSA id p21-20020a19f015000000b00500a14a6659sm2769277lfc.51.2023.09.20.12.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:28:35 -0700 (PDT) From: Serge Semin To: Michal Simek , Alexander Stein , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter Cc: Serge Semin , Punnaiah Choudary Kalluri , Dinh Nguyen , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 06/18] EDAC/synopsys: Convert plat-data to plat-init function Date: Wed, 20 Sep 2023 22:26:51 +0300 Message-ID: <20230920192806.29960-7-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230920192806.29960-1-fancer.lancer@gmail.com> References: <20230920192806.29960-1-fancer.lancer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since DW uMCTL2 device info and capabilities infrastructure is now available there is no point in supporting an additional abstraction like platform quirks. Instead convert the already defined ZynqMP quirk to the ZynqMP-specific capability and add the platform-specific initialization function support. This function will be called after the device parameters are detected and thus fixing some of them if required. Note the new approach will provide a very flexible interface of the platform-specific setups. The platform-specific init() callback can be used not only for the capabilities flags modification, but for example for the resources requests or custom CSRs alterations. Signed-off-by: Serge Semin --- drivers/edac/synopsys_edac.c | 68 +++++++++++++++++++----------------- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index b830e4b4292d..b77bc84c0bb0 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -34,8 +34,8 @@ #define SNPS_EDAC_MOD_STRING "snps_edac" #define SNPS_EDAC_MOD_VER "1" =20 -/* DDR ECC Quirks */ -#define SNPS_ZYNQMP_IRQ_REGS BIT(0) +/* DDR capabilities */ +#define SNPS_CAP_ZYNQMP BIT(31) =20 /* Synopsys uMCTL2 DDR controller registers that are relevant to ECC */ =20 @@ -338,7 +338,6 @@ struct snps_ecc_status { * @reglock: Concurrent CSRs access lock. * @message: Buffer for framing the event specific info. * @stat: ECC status information. - * @p_data: Platform data. * @poison_addr: Data poison address. * @row_shift: Bit shifts for row bit. * @col_shift: Bit shifts for column bit. @@ -353,7 +352,6 @@ struct snps_edac_priv { spinlock_t reglock; char message[SNPS_EDAC_MSG_SIZE]; struct snps_ecc_status stat; - const struct snps_platform_data *p_data; #ifdef CONFIG_EDAC_DEBUG ulong poison_addr; u32 row_shift[18]; @@ -364,14 +362,6 @@ struct snps_edac_priv { #endif }; =20 -/** - * struct snps_platform_data - Synopsys uMCTL2 DDRC platform data. - * @quirks: IP-core specific quirks. - */ -struct snps_platform_data { - u32 quirks; -}; - /** * snps_get_error_info - Get the current ECC error info. * @priv: DDR memory controller private instance data. @@ -485,7 +475,7 @@ static void snps_enable_irq(struct snps_edac_priv *priv) unsigned long flags; =20 /* Enable UE/CE Interrupts */ - if (priv->p_data->quirks & SNPS_ZYNQMP_IRQ_REGS) { + if (priv->info.caps & SNPS_CAP_ZYNQMP) { writel(ZYNQMP_DDR_QOS_UE_MASK | ZYNQMP_DDR_QOS_CE_MASK, priv->baseaddr + ZYNQMP_DDR_QOS_IRQ_EN_OFST); =20 @@ -509,7 +499,7 @@ static void snps_disable_irq(struct snps_edac_priv *pri= v) unsigned long flags; =20 /* Disable UE/CE Interrupts */ - if (priv->p_data->quirks & SNPS_ZYNQMP_IRQ_REGS) { + if (priv->info.caps & SNPS_CAP_ZYNQMP) { writel(ZYNQMP_DDR_QOS_UE_MASK | ZYNQMP_DDR_QOS_CE_MASK, priv->baseaddr + ZYNQMP_DDR_QOS_IRQ_DB_OFST); =20 @@ -538,7 +528,7 @@ static irqreturn_t snps_irq_handler(int irq, void *dev_= id) =20 priv =3D mci->pvt_info; =20 - if (priv->p_data->quirks & SNPS_ZYNQMP_IRQ_REGS) { + if (priv->info.caps & SNPS_CAP_ZYNQMP) { regval =3D readl(priv->baseaddr + ZYNQMP_DDR_QOS_IRQ_STAT_OFST); regval &=3D (ZYNQMP_DDR_QOS_CE_MASK | ZYNQMP_DDR_QOS_UE_MASK); if (!(regval & ZYNQMP_DDR_QOS_IRQ_MASK)) @@ -551,7 +541,7 @@ static irqreturn_t snps_irq_handler(int irq, void *dev_= id) =20 snps_handle_error(mci, &priv->stat); =20 - if (priv->p_data->quirks & SNPS_ZYNQMP_IRQ_REGS) + if (priv->info.caps & SNPS_CAP_ZYNQMP) writel(regval, priv->baseaddr + ZYNQMP_DDR_QOS_IRQ_STAT_OFST); =20 return IRQ_HANDLED; @@ -575,16 +565,26 @@ static struct snps_edac_priv *snps_create_data(struct= platform_device *pdev) if (IS_ERR(priv->baseaddr)) return ERR_CAST(priv->baseaddr); =20 - priv->p_data =3D of_device_get_match_data(&pdev->dev); - if (!priv->p_data) - return ERR_PTR(-ENODEV); - priv->pdev =3D pdev; spin_lock_init(&priv->reglock); =20 return priv; } =20 +/* + * zynqmp_init_plat - ZynqMP-specific platform initialization. + * @priv: DDR memory controller private data. + * + * Return: always zero. + */ +static int zynqmp_init_plat(struct snps_edac_priv *priv) +{ + priv->info.caps |=3D SNPS_CAP_ZYNQMP; + priv->info.dq_width =3D SNPS_DQ_64; + + return 0; +} + /** * snps_get_dtype - Return the controller memory width. * @mstr: Master CSR value. @@ -718,7 +718,10 @@ static int snps_get_ddrc_info(struct snps_edac_priv *p= riv) =20 writel(1, priv->baseaddr + DDR_SWCTL); =20 - return 0; + /* Apply platform setups after all the configs auto-detection */ + init_plat =3D device_get_match_data(&priv->pdev->dev); + + return init_plat ? init_plat(priv) : 0; } =20 /** @@ -822,8 +825,6 @@ static void snps_mc_free(struct mem_ctl_info *mci) edac_mc_free(mci); } =20 - - static int snps_setup_irq(struct mem_ctl_info *mci) { struct snps_edac_priv *priv =3D mci->pvt_info; @@ -882,6 +883,15 @@ static int snps_ddrc_info_show(struct seq_file *s, voi= d *data) priv->info.ecc_mode =3D=3D SNPS_ECC_ADVX4X8 ? "Advanced X4/X8" : "Unknown"); =20 + seq_puts(s, "Caps:"); + if (priv->info.caps) { + if (priv->info.caps & SNPS_CAP_ZYNQMP) + seq_puts(s, " +ZynqMP"); + } else { + seq_puts(s, " -"); + } + seq_putc(s, '\n'); + return 0; } =20 @@ -1345,17 +1355,9 @@ static int snps_mc_remove(struct platform_device *pd= ev) return 0; } =20 -static const struct snps_platform_data zynqmp_edac_def =3D { - .quirks =3D SNPS_ZYNQMP_IRQ_REGS, -}; - -static const struct snps_platform_data snps_edac_def =3D { - .quirks =3D 0, -}; - static const struct of_device_id snps_edac_match[] =3D { - { .compatible =3D "xlnx,zynqmp-ddrc-2.40a", .data =3D &zynqmp_edac_def }, - { .compatible =3D "snps,ddrc-3.80a", .data =3D &snps_edac_def }, + { .compatible =3D "xlnx,zynqmp-ddrc-2.40a", .data =3D zynqmp_init_plat }, + { .compatible =3D "snps,ddrc-3.80a" }, { } }; MODULE_DEVICE_TABLE(of, snps_edac_match); --=20 2.41.0