From nobody Sat Feb 14 03:30:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60AFCE79A8 for ; Tue, 19 Sep 2023 17:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232079AbjISRmR (ORCPT ); Tue, 19 Sep 2023 13:42:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232477AbjISRlw (ORCPT ); Tue, 19 Sep 2023 13:41:52 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6B159197 for ; Tue, 19 Sep 2023 10:41:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A0770C15; Tue, 19 Sep 2023 10:42:12 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 551533F5A1; Tue, 19 Sep 2023 10:41:34 -0700 (PDT) From: Sudeep Holla Date: Tue, 19 Sep 2023 18:41:02 +0100 Subject: [PATCH RFT v2 14/18] firmware: arm_ffa: Simplify the computation of transmit and fragment length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230919-ffa_v1-1_notif-v2-14-6f3a3ca3923c@arm.com> References: <20230919-ffa_v1-1_notif-v2-0-6f3a3ca3923c@arm.com> In-Reply-To: <20230919-ffa_v1-1_notif-v2-0-6f3a3ca3923c@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla , Jens Wiklander , Marc Bonnici , Coboy Chen , Lorenzo Pieralisi , Olivier Deprez X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3428; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=PHZUUrZvOCnNHDI+i/Plgq+A2R5oHmSmqrncoEkZxGs=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBlCd0811YapzFopiMGNcOkCEDvNWtWDiwYdXrG3 kWMD0B7SwaJAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZQndPAAKCRAAQbq8MX7i mHA2D/9/hF3VaKABoZURL5PKUaLFVp4zmlY7MYesN4/HMnZgVyMesjmml5nF7p+NmU4bnmnlpeZ UwWEcZDjOrOsjw3HdtcCnYGUM/KfbefJ2BY5ZGCH+GSFDpARZUQc8mduZRjMi0AUdJCIMCzyEQo U65ki8FOQ3rx3LQdy+Z5hGX8QCnYp8moaUXIDEzlcQ2QWa5wJt01zOyPzzHG6ukiYth6jVU1uMN +fir+ORoT4ubFBBbMp1i5ZiIB4hmBx4FgziIeqNycD7x0z4wwA0lScBKVeolSwSpb1eFNMRXelZ Wn2gIDcMRL+iA2PLa6SsRbR0/HLVXiVQbYHAhAVqVJhgWLIglZF8sNlVVGlvydUXoNxpcZphc3b scodmQN0np1fqydWw3CqQKw7p5vvx3YlcqPa1mcc5hv0MoH5z9wCX0iF+vyUlg84LKEKupp9lI8 b9/nTJ+1VJvIfUDufNn1ZHBSKbv7t3kK0aFAVK8oQna3qtOB5XzPKIazmtxwmwGg33SeMFcSwcJ cA/uB6F9YxRy3h7bVeoglf9zZpncg2EJMh3dgBSzMG4NOQGbgLlw5PQspzg4Y2jA4Qpg4BPSFNP DrnnjTTKXSK9w5yq6tdmuJm434Fg43PhYgRbrXnYKwMRRuSktX/+PDLIVAhg4puIm5EAasb37OL nhMLLL13zDzsCbA== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The computation of endpoint memory access descriptor's composite memory region descriptor offset is using COMPOSITE_CONSTITUENTS_OFFSET which is unnecessary complicated. Composite memory region descriptor always follow the endpoint memory access descriptor array and hence it is computed accordingly. COMPOSITE_CONSTITUENTS_OFFSET is useless and wrong for any input other than endpoint memory access descriptor count. Let us drop the usage of COMPOSITE_CONSTITUENTS_OFFSET to simplify the computation of total transmit and fragment length in the memory transactions. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 14 ++++++++------ include/linux/arm_ffa.h | 2 -- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/d= river.c index 6312a7807d37..dadd56d17c20 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -443,23 +443,25 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32= max_fragsize, { int rc =3D 0; bool first =3D true; + u32 composite_offset; phys_addr_t addr =3D 0; + struct ffa_mem_region *mem_region =3D buffer; struct ffa_composite_mem_region *composite; struct ffa_mem_region_addr_range *constituents; struct ffa_mem_region_attributes *ep_mem_access; - struct ffa_mem_region *mem_region =3D buffer; u32 idx, frag_len, length, buf_sz =3D 0, num_entries =3D sg_nents(args->s= g); =20 mem_region->tag =3D args->tag; mem_region->flags =3D args->flags; mem_region->sender_id =3D drv_info->vm_id; mem_region->attributes =3D ffa_memory_attributes_get(func_id); - ep_mem_access =3D &mem_region->ep_mem_access[0]; + ep_mem_access =3D buffer + COMPOSITE_OFFSET(0); + composite_offset =3D COMPOSITE_OFFSET(args->nattrs); =20 for (idx =3D 0; idx < args->nattrs; idx++, ep_mem_access++) { ep_mem_access->receiver =3D args->attrs[idx].receiver; ep_mem_access->attrs =3D args->attrs[idx].attrs; - ep_mem_access->composite_off =3D COMPOSITE_OFFSET(args->nattrs); + ep_mem_access->composite_off =3D composite_offset; ep_mem_access->flag =3D 0; ep_mem_access->reserved =3D 0; } @@ -468,13 +470,13 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32= max_fragsize, mem_region->reserved_1 =3D 0; mem_region->ep_count =3D args->nattrs; =20 - composite =3D buffer + COMPOSITE_OFFSET(args->nattrs); + composite =3D buffer + composite_offset; composite->total_pg_cnt =3D ffa_get_num_pages_sg(args->sg); composite->addr_range_cnt =3D num_entries; composite->reserved =3D 0; =20 - length =3D COMPOSITE_CONSTITUENTS_OFFSET(args->nattrs, num_entries); - frag_len =3D COMPOSITE_CONSTITUENTS_OFFSET(args->nattrs, 0); + length =3D composite_offset + CONSTITUENTS_OFFSET(num_entries); + frag_len =3D composite_offset + CONSTITUENTS_OFFSET(0); if (frag_len > max_fragsize) return -ENXIO; =20 diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index f6df81f14b6d..748d0a83a4bc 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -356,8 +356,6 @@ struct ffa_mem_region { (offsetof(struct ffa_mem_region, ep_mem_access[x])) #define CONSTITUENTS_OFFSET(x) \ (offsetof(struct ffa_composite_mem_region, constituents[x])) -#define COMPOSITE_CONSTITUENTS_OFFSET(x, y) \ - (COMPOSITE_OFFSET(x) + CONSTITUENTS_OFFSET(y)) =20 struct ffa_mem_ops_args { bool use_txbuf; --=20 2.42.0