From nobody Thu Dec 18 08:39:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF80CA0ECA for ; Tue, 12 Sep 2023 08:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233233AbjILInM (ORCPT ); Tue, 12 Sep 2023 04:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233180AbjILIm7 (ORCPT ); Tue, 12 Sep 2023 04:42:59 -0400 Received: from mx0.infotecs.ru (mx0.infotecs.ru [91.244.183.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6487A1FE9; Tue, 12 Sep 2023 01:42:38 -0700 (PDT) Received: from mx0.infotecs-nt (localhost [127.0.0.1]) by mx0.infotecs.ru (Postfix) with ESMTP id D5FF21024CF9; Tue, 12 Sep 2023 11:42:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx0.infotecs.ru D5FF21024CF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infotecs.ru; s=mx; t=1694508155; bh=o5pd38GBTQwRmYAzeYxDd/4rQzPh+H8gE2oOiTG2l9k=; h=From:To:CC:Subject:Date:From; b=Cx8QQNHtsV5ufknr8Tny5cX0espXouYTxrAA/U/jNubsYan+ZWF/zWiBe2WEVIM8P j1tXgqFheYUZsP6p3dJuw3TWQKF6Pd8m20PFSm+r345Ccj8a7y3a20g7ZXL314Fytu GW70IbIuOTaOhc7srW2JCLpoeuAztQSeZ5m7xk1o= Received: from msk-exch-01.infotecs-nt (msk-exch-01.infotecs-nt [10.0.7.191]) by mx0.infotecs-nt (Postfix) with ESMTP id D2EB53000095; Tue, 12 Sep 2023 11:42:34 +0300 (MSK) From: Gavrilov Ilia To: "David S. Miller" CC: David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Thread-Topic: [PATCH net-next] ipv4: igmp: Remove redundant comparison in igmp_mcf_get_next() Thread-Index: AQHZ5VUTNq1uzE92eEGQ9QqcA3I0wA== Date: Tue, 12 Sep 2023 08:42:34 +0000 Message-ID: <20230912084039.1501984-1-Ilia.Gavrilov@infotecs.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.17.0.10] x-exclaimer-md-config: 208ac3cd-1ed4-4982-a353-bdefac89ac0a Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KLMS-Rule-ID: 5 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2023/09/12 07:28:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/09/12 03:38:00 #21880520 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The 'state->im' value will always be non-zero after the 'while' statement, so the check can be removed. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Gavrilov Ilia Reviewed-by: David Ahern --- Repost according to https://lore.kernel.org/all/fea6db56-3a01-b7c8-b800-a6c= 885e99feb@kernel.org/ net/ipv4/igmp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 418e5fb58fd3..76c3ea75b8dd 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -2944,8 +2944,6 @@ static struct ip_sf_list *igmp_mcf_get_next(struct se= q_file *seq, struct ip_sf_l continue; state->im =3D rcu_dereference(state->idev->mc_list); } - if (!state->im) - break; spin_lock_bh(&state->im->lock); psf =3D state->im->sources; } --=20 2.39.2