From nobody Fri Dec 19 04:49:14 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D58CA0ECA for ; Tue, 12 Sep 2023 07:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231840AbjILH7O (ORCPT ); Tue, 12 Sep 2023 03:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232090AbjILH6l (ORCPT ); Tue, 12 Sep 2023 03:58:41 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6DB2102 for ; Tue, 12 Sep 2023 00:58:12 -0700 (PDT) Message-ID: <20230912065501.838955709@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694505491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=o5K9GLXM3XJpdsaGpiBbbxvmmBIEGDFBMHADfwXSBVH3+l+2a6D+OMu0ia1mVRFIBR+2/W uqhaCgGahmSxDrsgnpSSfKNZgh2/GoQ9wgUxow4iRFVmePrffytWctRvaSFsl+96+kX74g zlJgwaZvvgCQmI6EiyN6ZGRhVwjXgtKyuA0JdnL86v769V7k0rqWg+VX12BZ81XK90BKrx UDfvQWrLaM5X5TCNsxvuQju+uFM5ejimEM0tmkqd6UFbmMKHK4NoN//og2uzek166vUZS3 SmYm44zVjymVBgVX0RHw8UiGBGFkOnvzrc5lpTvDA2aOkRo55AUu6Zu3sgCdLg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694505491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=29AYhkI+1B+aP2ulSjBZYvwAxHR9z6zN13x7VQxgXac=; b=KBTh1d6SrsaSukcbTTTJGUkoMfBfIkLyuLjz/8JnxI6kpyDX2Zvx2BOGrpl8ML2w5Q8AHK rbusKTV3I4h1YaDQ== From: Thomas Gleixner To: LKML Cc: x86@kernel.org, Borislav Petkov , "Chang S. Bae" , Arjan van de Ven , Nikolay Borisov Subject: [patch V3 17/30] x86/microcode: Clean up mc_cpu_down_prep() References: <20230912065249.695681286@linutronix.de> MIME-Version: 1.0 Date: Tue, 12 Sep 2023 09:58:10 +0200 (CEST) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner --- V2: New patch --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -569,16 +569,10 @@ static int mc_cpu_online(unsigned int cp =20 static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev =3D get_cpu_device(cpu); + struct device *dev =3D get_cpu_device(cpu); =20 microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }