From nobody Thu Dec 18 19:03:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D74CA0EC6 for ; Mon, 11 Sep 2023 22:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378784AbjIKWhR (ORCPT ); Mon, 11 Sep 2023 18:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236729AbjIKLQd (ORCPT ); Mon, 11 Sep 2023 07:16:33 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 605DC1A2 for ; Mon, 11 Sep 2023 04:16:29 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC056C433C8; Mon, 11 Sep 2023 11:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694430989; bh=O0faahUdqQERokNfZ+EUmG8INIrHP3lcwn9a1BQUUMs=; h=From:To:Cc:Subject:Date:From; b=L0cVj2WuHg3B0CGXWNUxoqjjcW+4HTa8vGmAffD5C/SBv14TyYtmaiHFR2LJPgEWM YidFmDOaYt+Q9OXh/CsuBLaUD5G/hzRtUg2s/djnySLcSQApiSITicoZxMfB51alYP TNDj4QBdYh2B8QaXRmklgjVw40dgr2D1uuYqgkqwzHJAaY1RzTHAMHh7YKSevIoI4+ pYXVgMMJbydnMb75aWwpkdxuwRcJ9Q40GcjPDaRoNzr0EQfZFJnCAFdzpfkKTGiOE9 6V09P1HI9YK25UcHxQ1OyQM5HSIhajT+pxtML0Pz4/ll5SEPP8r87HknPg18/YfbG4 4qq2U1QXku48g== From: Arnd Bergmann To: James Schulman , David Rhodes , Richard Fitzgerald , Lee Jones , Charles Keepax Cc: Arnd Bergmann , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: [PATCH] mtd: cs42l43: use modern PM macro helpers Date: Mon, 11 Sep 2023 13:16:15 +0200 Message-Id: <20230911111623.705640-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros required enclosing the function definitions in an #ifdef or marking them __maybe_unused: drivers/mfd/cs42l43.c:1138:12: error: 'cs42l43_runtime_resume' defined but = not used [-Werror=3Dunused-function] 1138 | static int cs42l43_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1124:12: error: 'cs42l43_runtime_suspend' defined but= not used [-Werror=3Dunused-function] 1124 | static int cs42l43_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1106:12: error: 'cs42l43_resume' defined but not used= [-Werror=3Dunused-function] 1106 | static int cs42l43_resume(struct device *dev) | ^~~~~~~~~~~~~~ drivers/mfd/cs42l43.c:1076:12: error: 'cs42l43_suspend' defined but not use= d [-Werror=3Dunused-function] 1076 | static int cs42l43_suspend(struct device *dev) | ^~~~~~~~~~~~~~~ Use the modern replacements to avoid the warnings without those annotations. Fixes: ace6d14481386 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Arnd Bergmann --- drivers/mfd/cs42l43.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 37b23e9bae823..7b6d07cbe6fc6 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev) } =20 EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) =3D { - SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume) - SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume) + RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL) }; =20 MODULE_DESCRIPTION("CS42L43 Core Driver"); --=20 2.39.2