From nobody Thu Sep 11 22:29:01 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88E4CA0ECE for ; Mon, 11 Sep 2023 22:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240104AbjIKWja (ORCPT ); Mon, 11 Sep 2023 18:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235904AbjIKJqR (ORCPT ); Mon, 11 Sep 2023 05:46:17 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9FCE40 for ; Mon, 11 Sep 2023 02:46:11 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c0efe0c4acso7083875ad.0 for ; Mon, 11 Sep 2023 02:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694425571; x=1695030371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r2z5ZP0td7rQio33ZrusFB6X25vGZrzEp4fIJ4zc7l4=; b=HSpP6V8JhO7VGQ498iaJcQvf8Rf9W7pEOTG1Ylcv2Z5iBXeI/rdJxydxeluCIFALFF hE3FoN2SSZFvLUUx5tuOuipaYQO4NG8Tj8eqJqZjzEO41XsOBWN8QW+qM5acytu3VIri m8ONKUMBc77sU11Nt9RAHikB/6NJkdOBnxfrX4sVFsa6KUYLDZyp+FJkmWucWmZTDeDP lC3rnkG5+7K/WokzPQTHdFqbe8ciitg2sgANNs4xKEDdcCLqHvtKaMvR5IOmXhXWgthz bMXrnaSNT7hOdAZOMwN7kklUzK0Pcl/OrFRkFJtCgij1xk9cfdi6EL71tlk7HOQ47nYH wScQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694425571; x=1695030371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r2z5ZP0td7rQio33ZrusFB6X25vGZrzEp4fIJ4zc7l4=; b=CnngHVoAwGkME7pMxRb5oCs35RSSuq1uYBlKl7nfw/e8ImsMNzcLIAXOD/3O1rtyfO VlziDzJsJL7p27/RXf8DD+wTgHuW34RvzfxneMxSD7hZwjRFhTgfqlN5LxBkBivq9xqS gdjMACCA/0YdOHtktN0YoyPuded+erSD5SK2VRHLdxnLuyFT+cZl+ueERBwt22+RO8H+ hE/PsMj6J77dZSPEuWXNYCOnqXShgYGRyuu+bpwF4UdvUUZ/3BKUoE8cmmnH9Cm8qZv2 VD3ECMA+AbYnH67n2XgCsZOOpHrW68pPj4Ni188fMu3hVqcoLCwjJujZ35rmMNCFZAHA XZdg== X-Gm-Message-State: AOJu0YwKpy/P8vVIQc5EK9qU210sqmmepdWI3s80y/KruCLTmJHY2gri VECkZ658ijTpKOwkZlEZcPb4Ag== X-Google-Smtp-Source: AGHT+IGMazOb/vYj+YAbB56aNimJAjHvQ95oEZj3vNPDNUhDjsPyS/sjYbZ6xZxadrVaoBmmMuhKhg== X-Received: by 2002:a17:902:da92:b0:1b8:2ba0:c9a8 with SMTP id j18-20020a170902da9200b001b82ba0c9a8mr11823440plx.2.1694425571312; Mon, 11 Sep 2023 02:46:11 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id az7-20020a170902a58700b001bdc2fdcf7esm5988188plb.129.2023.09.11.02.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 02:46:10 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Qi Zheng , Muchun Song , Chao Yu , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH v6 07/45] f2fs: dynamically allocate the f2fs-shrinker Date: Mon, 11 Sep 2023 17:44:06 +0800 Message-Id: <20230911094444.68966-8-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20230911094444.68966-1-zhengqi.arch@bytedance.com> References: <20230911094444.68966-1-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use new APIs to dynamically allocate the f2fs-shrinker. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Reviewed-by: Chao Yu CC: Jaegeuk Kim CC: linux-f2fs-devel@lists.sourceforge.net --- fs/f2fs/super.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index a8c8232852bb..fe25ff9cebbe 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -83,11 +83,26 @@ void f2fs_build_fault_attr(struct f2fs_sb_info *sbi, un= signed int rate, #endif =20 /* f2fs-wide shrinker description */ -static struct shrinker f2fs_shrinker_info =3D { - .scan_objects =3D f2fs_shrink_scan, - .count_objects =3D f2fs_shrink_count, - .seeks =3D DEFAULT_SEEKS, -}; +static struct shrinker *f2fs_shrinker_info; + +static int __init f2fs_init_shrinker(void) +{ + f2fs_shrinker_info =3D shrinker_alloc(0, "f2fs-shrinker"); + if (!f2fs_shrinker_info) + return -ENOMEM; + + f2fs_shrinker_info->count_objects =3D f2fs_shrink_count; + f2fs_shrinker_info->scan_objects =3D f2fs_shrink_scan; + + shrinker_register(f2fs_shrinker_info); + + return 0; +} + +static void f2fs_exit_shrinker(void) +{ + shrinker_free(f2fs_shrinker_info); +} =20 enum { Opt_gc_background, @@ -4944,7 +4959,7 @@ static int __init init_f2fs_fs(void) err =3D f2fs_init_sysfs(); if (err) goto free_garbage_collection_cache; - err =3D register_shrinker(&f2fs_shrinker_info, "f2fs-shrinker"); + err =3D f2fs_init_shrinker(); if (err) goto free_sysfs; err =3D register_filesystem(&f2fs_fs_type); @@ -4989,7 +5004,7 @@ static int __init init_f2fs_fs(void) f2fs_destroy_root_stats(); unregister_filesystem(&f2fs_fs_type); free_shrinker: - unregister_shrinker(&f2fs_shrinker_info); + f2fs_exit_shrinker(); free_sysfs: f2fs_exit_sysfs(); free_garbage_collection_cache: @@ -5021,7 +5036,7 @@ static void __exit exit_f2fs_fs(void) f2fs_destroy_post_read_processing(); f2fs_destroy_root_stats(); unregister_filesystem(&f2fs_fs_type); - unregister_shrinker(&f2fs_shrinker_info); + f2fs_exit_shrinker(); f2fs_exit_sysfs(); f2fs_destroy_garbage_collection_cache(); f2fs_destroy_extent_cache(); --=20 2.30.2