From nobody Thu Dec 18 08:10:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4801EEEB580 for ; Mon, 11 Sep 2023 08:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232419AbjIKIRG convert rfc822-to-8bit (ORCPT ); Mon, 11 Sep 2023 04:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjIKIRF (ORCPT ); Mon, 11 Sep 2023 04:17:05 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD16118 for ; Mon, 11 Sep 2023 01:16:58 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 4CE77820D; Mon, 11 Sep 2023 16:16:56 +0800 (CST) Received: from EXMBX066.cuchost.com (172.16.7.66) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 11 Sep 2023 16:16:56 +0800 Received: from localhost.localdomain (202.188.176.82) by EXMBX066.cuchost.com (172.16.6.66) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 11 Sep 2023 16:16:53 +0800 From: Joshua Yeong To: CC: , , , Joshua Yeong Subject: [PATCH 1/1] i3c: master: cdns: Fix reading status register Date: Mon, 11 Sep 2023 16:16:24 +0800 Message-ID: <20230911081623.21963-2-joshua.yeong@starfivetech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230911081623.21963-1-joshua.yeong@starfivetech.com> References: <20230911081623.21963-1-joshua.yeong@starfivetech.com> MIME-Version: 1.0 X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX066.cuchost.com (172.16.6.66) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IBIR_DEPTH and CMDR_DEPTH should read from status0 instead of status1 Signed-off-by: Joshua Yeong --- drivers/i3c/master/i3c-master-cdns.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-= master-cdns.c index 49551db71bc9..8f1fda3c7ac5 100644 --- a/drivers/i3c/master/i3c-master-cdns.c +++ b/drivers/i3c/master/i3c-master-cdns.c @@ -191,7 +191,7 @@ #define SLV_STATUS1_HJ_DIS BIT(18) #define SLV_STATUS1_MR_DIS BIT(17) #define SLV_STATUS1_PROT_ERR BIT(16) -#define SLV_STATUS1_DA(x) (((s) & GENMASK(15, 9)) >> 9) +#define SLV_STATUS1_DA(s) (((s) & GENMASK(15, 9)) >> 9) #define SLV_STATUS1_HAS_DA BIT(8) #define SLV_STATUS1_DDR_RX_FULL BIT(7) #define SLV_STATUS1_DDR_TX_FULL BIT(6) @@ -1623,13 +1623,13 @@ static int cdns_i3c_master_probe(struct platform_de= vice *pdev) /* Device ID0 is reserved to describe this master. */ master->maxdevs =3D CONF_STATUS0_DEVS_NUM(val); master->free_rr_slots =3D GENMASK(master->maxdevs, 1); + master->caps.ibirfifodepth =3D CONF_STATUS0_IBIR_DEPTH(val); + master->caps.cmdrfifodepth =3D CONF_STATUS0_CMDR_DEPTH(val); =20 val =3D readl(master->regs + CONF_STATUS1); master->caps.cmdfifodepth =3D CONF_STATUS1_CMD_DEPTH(val); master->caps.rxfifodepth =3D CONF_STATUS1_RX_DEPTH(val); master->caps.txfifodepth =3D CONF_STATUS1_TX_DEPTH(val); - master->caps.ibirfifodepth =3D CONF_STATUS0_IBIR_DEPTH(val); - master->caps.cmdrfifodepth =3D CONF_STATUS0_CMDR_DEPTH(val); =20 spin_lock_init(&master->ibi.lock); master->ibi.num_slots =3D CONF_STATUS1_IBI_HW_RES(val); --=20 2.25.1