From nobody Thu Dec 18 19:06:29 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B574CA0ECD for ; Mon, 11 Sep 2023 22:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359790AbjIKWfc (ORCPT ); Mon, 11 Sep 2023 18:35:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237362AbjIKMm4 (ORCPT ); Mon, 11 Sep 2023 08:42:56 -0400 Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC93ACEB for ; Mon, 11 Sep 2023 05:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1694436171; x=1725972171; h=from:date:subject:mime-version:content-transfer-encoding: message-id:to:cc; bh=iRWKgzYyApFXq9hIJlEr7x3MLl9rxdsbG3Nqgvq7fM4=; b=Pg2NjzVMf5xIU9kjje5DOQIAYpmuT0HXyONHVokdYME0Zah87IWOOiBi 35RVqE7OJHvFUJU/YK0QNg4iZUfxma4MTV9rba3F6ZlynaFh6+KAHmmYy pEiDKXKzLBiC17+7lOuwtwM9QzoQV2vIaraJ12kTzE2EofwlMvfa+3H6A MdkMFbumAB9jB2IEH+F6JBHd7ljo9Olr5zmx1AVqa5wP7OhrSUyVZIv4j bU9gyU7tqY8p1Eij1lvDxNYsHREW307huoXkl6859UJBl7KB8sMf+J1L7 8S5PiydxyYU2oGMIZE4f7etYWmXrR4dX+KvXtqrU8mO1klamVOufL/EHh w==; From: Vincent Whitchurch Date: Mon, 11 Sep 2023 14:42:47 +0200 Subject: [PATCH] regulator: Fix voltage range selection MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20230911-regulator-voltage-sel-v1-1-886eb1ade8d8@axis.com> X-B4-Tracking: v=1; b=H4sIAEYL/2QC/x2MQQqAMAzAviI9O2gnIvoV8TC2qoXhpFMRxL87P AaSPJBZhTMM1QPKl2RJWwGqK/Cr2xY2EgqDRdtgT2SUlzO6I6m5UjxcETJH03rCQD6g7RBKuyv Pcv/fcXrfDz1qBzVnAAAA To: Liam Girdwood , Mark Brown , Chen-Yu Tsai CC: , , Vincent Whitchurch X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the correct field to fix wrong voltage range selection on regulators such as tps6287x since the blamed commit. Fixes: 269cb04b601d ("regulator: Use bitfield values for range selectors") Signed-off-by: Vincent Whitchurch --- drivers/regulator/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index 5ad5f3b3a6b5..d49268336553 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -197,7 +197,7 @@ int regulator_set_voltage_sel_pickable_regmap(struct re= gulator_dev *rdev, sel +=3D rdev->desc->linear_ranges[i].min_sel; =20 range =3D rdev->desc->linear_range_selectors_bitfield[i]; - range <<=3D ffs(rdev->desc->vsel_mask) - 1; + range <<=3D ffs(rdev->desc->vsel_range_mask) - 1; =20 if (rdev->desc->vsel_reg =3D=3D rdev->desc->vsel_range_reg) { ret =3D regmap_update_bits(rdev->regmap, --- base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d change-id: 20230911-regulator-voltage-sel-5c10d1cd0270 Best regards, --=20 Vincent Whitchurch