From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B27EECA0EE2 for ; Mon, 11 Sep 2023 22:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358546AbjIKWLv (ORCPT ); Mon, 11 Sep 2023 18:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235231AbjIKIX7 (ORCPT ); Mon, 11 Sep 2023 04:23:59 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4370618D for ; Mon, 11 Sep 2023 01:23:52 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-502b1bbe5c3so1961387e87.1 for ; Mon, 11 Sep 2023 01:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420630; x=1695025430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b+8MTCJJPEn/JGBNuu906jziHv3DlZsxUiatrimUoug=; b=zdOr+da2+Y/aYSuIr42gW1N0c188zGDemgWKrDbKSawpkLKCoXoQ3s/ulGlmhhmW9A kvGU00vVrPLekvoZCcggVbbNlcuJPbFLI6nh9I+MT/i0Aobj7KeZ6cMcSlNHQ3h0wnwJ hrxPmgfamUCVbr5i9EXC6RU9cZyUKsrysdzC1UKMAzo9kFkbQdVAt2ypDicKaYAV+BzC zL17CbrSSb7rZhulYuJsBf/vXyg9IJFjsv1IIKv+K+jdOWVgbPuZhbR7fjTIj87JsIPX bi771YGfW5X+a2iQZjou7WU8dWJBKjIZe05QzflvVTQgmk3MXxk8ITqQ7ad4f3B8ZBDm luKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420630; x=1695025430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b+8MTCJJPEn/JGBNuu906jziHv3DlZsxUiatrimUoug=; b=JxuauutDI0gCMnPh6BKMGX4RE2mJT9zDkl9Vm1Rf7ZLSe7hBXIfJ5+YLQ/crchj8PN yQr0D+kpxODxb95hO2TopwOCP3n7qTZmrbd6YrtfCJi1NZ3o7KSMfhztZ+wjM6/Iq3UA eX7nuKABENrqcxrIbLB9zDMrGeTp9ZGsS8aqhx1Suh+EnAcBdXeG+gJIGI5PM/n/woy8 i8AmL0EDy6snUO5iXzE3jX8achGEWsPVwCrZv2IP/thr1tyMh7/wfT+yLaJe4kNRvpnN Rf0CwBEsgo3Ph2671XveLwN0aW/4ByK9ZyVXyZV7V1gMskgmyzBPVfOPNYtgxsjJzLmb fgYw== X-Gm-Message-State: AOJu0YxHqNuTVPhALZKX/TvKz3DTzImvvRsHqeqeWzUPQWbF0noUCO1W hdmfGXzYO2CzNJIK6oaYO6CFkA== X-Google-Smtp-Source: AGHT+IH2r7bEFi9jxVEwNGLaxc6z7Q9adp/d/GtZ3BsKXID0oUG7bLJPmPTXt/XXRsoZ48ICBEYqow== X-Received: by 2002:a05:6512:1185:b0:4f8:5cde:a44f with SMTP id g5-20020a056512118500b004f85cdea44fmr5691530lfr.10.1694420630585; Mon, 11 Sep 2023 01:23:50 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:50 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:48 +0200 Subject: [PATCH v2 1/7] ASoC: max9768: Convert to use GPIO descriptors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-1-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MAX9768 is pretty straight forward to convert to GPIO descriptors. To name the GPIO properties, I looke at the bindings in maxim,max9759.yaml which names these GPIO "mute" and "shutdown" respectively. No board files using platform data exist in the kernel, new users can use GPIO descriptor tables if desired. Signed-off-by: Linus Walleij --- include/sound/max9768.h | 4 ---- sound/soc/codecs/max9768.c | 45 +++++++++++++++++++++++-------------------= --- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/include/sound/max9768.h b/include/sound/max9768.h index 0f78b41d030e..8509ba0079b0 100644 --- a/include/sound/max9768.h +++ b/include/sound/max9768.h @@ -9,14 +9,10 @@ =20 /** * struct max9768_pdata - optional platform specific MAX9768 configuration - * @shdn_gpio: GPIO to SHDN pin. If not valid, pin must be hardwired HIGH - * @mute_gpio: GPIO to MUTE pin. If not valid, control for mute won't be a= dded * @flags: configuration flags, e.g. set classic PWM mode (check datasheet * regarding "filterless modulation" which is default). */ struct max9768_pdata { - int shdn_gpio; - int mute_gpio; unsigned flags; #define MAX9768_FLAG_CLASSIC_PWM (1 << 0) }; diff --git a/sound/soc/codecs/max9768.c b/sound/soc/codecs/max9768.c index d22b4ba51ed8..8d0ca1be99c0 100644 --- a/sound/soc/codecs/max9768.c +++ b/sound/soc/codecs/max9768.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include =20 #include @@ -27,8 +27,8 @@ =20 struct max9768 { struct regmap *regmap; - int mute_gpio; - int shdn_gpio; + struct gpio_desc *mute; + struct gpio_desc *shdn; u32 flags; }; =20 @@ -42,7 +42,7 @@ static int max9768_get_gpio(struct snd_kcontrol *kcontrol, { struct snd_soc_component *c =3D snd_soc_kcontrol_component(kcontrol); struct max9768 *max9768 =3D snd_soc_component_get_drvdata(c); - int val =3D gpio_get_value_cansleep(max9768->mute_gpio); + int val =3D gpiod_get_value_cansleep(max9768->mute); =20 ucontrol->value.integer.value[0] =3D !val; =20 @@ -55,7 +55,7 @@ static int max9768_set_gpio(struct snd_kcontrol *kcontrol, struct snd_soc_component *c =3D snd_soc_kcontrol_component(kcontrol); struct max9768 *max9768 =3D snd_soc_component_get_drvdata(c); =20 - gpio_set_value_cansleep(max9768->mute_gpio, !ucontrol->value.integer.valu= e[0]); + gpiod_set_value_cansleep(max9768->mute, !ucontrol->value.integer.value[0]= ); =20 return 0; } @@ -138,7 +138,7 @@ static int max9768_probe(struct snd_soc_component *comp= onent) return ret; } =20 - if (gpio_is_valid(max9768->mute_gpio)) { + if (max9768->mute) { ret =3D snd_soc_add_component_controls(component, max9768_mute, ARRAY_SIZE(max9768_mute)); if (ret) @@ -171,28 +171,29 @@ static int max9768_i2c_probe(struct i2c_client *clien= t) { struct max9768 *max9768; struct max9768_pdata *pdata =3D client->dev.platform_data; - int err; =20 max9768 =3D devm_kzalloc(&client->dev, sizeof(*max9768), GFP_KERNEL); if (!max9768) return -ENOMEM; =20 - if (pdata) { - /* Mute on powerup to avoid clicks */ - err =3D devm_gpio_request_one(&client->dev, pdata->mute_gpio, - GPIOF_INIT_HIGH, "MAX9768 Mute"); - max9768->mute_gpio =3D err ?: pdata->mute_gpio; - - /* Activate chip by releasing shutdown, enables I2C */ - err =3D devm_gpio_request_one(&client->dev, pdata->shdn_gpio, - GPIOF_INIT_HIGH, "MAX9768 Shutdown"); - max9768->shdn_gpio =3D err ?: pdata->shdn_gpio; - + /* Mute on powerup to avoid clicks */ + max9768->mute =3D devm_gpiod_get_optional(&client->dev, + "mute", + GPIOD_OUT_HIGH); + if (IS_ERR(max9768->mute)) + return PTR_ERR(max9768->mute); + gpiod_set_consumer_name(max9768->mute, "MAX9768 Mute"); + + /* Activate chip by releasing shutdown, enables I2C */ + max9768->shdn =3D devm_gpiod_get_optional(&client->dev, + "shutdown", + GPIOD_OUT_HIGH); + if (IS_ERR(max9768->shdn)) + return PTR_ERR(max9768->shdn); + gpiod_set_consumer_name(max9768->shdn, "MAX9768 Shutdown"); + + if (pdata) max9768->flags =3D pdata->flags; - } else { - max9768->shdn_gpio =3D -EINVAL; - max9768->mute_gpio =3D -EINVAL; - } =20 i2c_set_clientdata(client, max9768); =20 --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4170CCA0EC7 for ; Mon, 11 Sep 2023 21:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240459AbjIKU43 (ORCPT ); Mon, 11 Sep 2023 16:56:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235235AbjIKIYB (ORCPT ); Mon, 11 Sep 2023 04:24:01 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A0BA1A5 for ; Mon, 11 Sep 2023 01:23:53 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bf66a32f25so46836301fa.2 for ; Mon, 11 Sep 2023 01:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420631; x=1695025431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=CPJzVZwZ6nAd2/iVayrm1htU7ruJ2dUM+qm3kMCBvN3jMYuAPHPumDHMlAz26vUNj8 tF+rQaMr3pTdaBMkiY/0R5rbGkE4kZ3SsyT4Od3WQ6f+vRDRMZzSOWvF2RMSd6yXV13e UL9/lBGy7/czbaU4LLcoUfp1ykwdZjypNpCzZBz33nbT57UN72b1Ill3Vcz6WTY3yxGH IcDk4EzI4xH3xclNQX/bz3SOCz2umNk6OH41DUBO8aUSY46VActWS1PfmkyPYFc1Pw+x 2lWuCerU2PmJ1Bd9OgMPoxl7iKIUgnJSsHYius6PB549QFs7quA+kTVn89qHZDA5OVN5 RLiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420631; x=1695025431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=uAHdcnFn4z/ltNTVChu4QSBh0KKKwX2chyFApWXkbmw5621XD6CvakcqVGypzwAMnc OAszR0jjKznoH12j/l5GeZY32Ox/JKXJC0pDNlonDRJYVXItBAaJV8j4BBad9HT7xYtZ G7elNYQp3qWbFDelGRd0nCLX6HqDBWMp4bIHCtwdTMkBfPfoLsEMR990Q0uIRwBnzXse y76yXY6MTSQcGKEspulVsJ9kKtsDdEqV0Hs9QD7HGsRAthIMOPTFcMGc7qMw6ZPv5HK0 Gv9oL92VOXJlDK1ljmTEqhzNFwIyk6h9sVAsgRxXBnBfJK2Qy2yr4FMtgxsnqYfqPpFO AiyQ== X-Gm-Message-State: AOJu0YxhRPYn51foAFOqSvcQtxIH5vEaKdtRMoafwzhwgRjkDtSd1Plg D7k7kA/0PTsQiOdkTigR7YoQFg== X-Google-Smtp-Source: AGHT+IFktZEGzVQ79iSZyPcJk9XOSRsrzr5WoeyEli+ACNX43xpOf0axceLlu9TSC+4tN8O7hIKwQw== X-Received: by 2002:a05:6512:6ca:b0:4f6:3677:54e with SMTP id u10-20020a05651206ca00b004f63677054emr8794627lff.36.1694420631650; Mon, 11 Sep 2023 01:23:51 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:51 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:49 +0200 Subject: [PATCH v2 2/7] ASoC: max98357a: Drop pointless include MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-2-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98357a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 2a2b286f1747..cc811f58c9d2 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F677CA0ED7 for ; Mon, 11 Sep 2023 21:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354283AbjIKVxU (ORCPT ); Mon, 11 Sep 2023 17:53:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235242AbjIKIYB (ORCPT ); Mon, 11 Sep 2023 04:24:01 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827851AE for ; Mon, 11 Sep 2023 01:23:54 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2bf6b37859eso42824191fa.0 for ; Mon, 11 Sep 2023 01:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420632; x=1695025432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=P96L1DwRALMipzCmAmrjsw+0vvQD0bsjXOSKlPWzM7jf6rnYNzNuqj+aWicxDDIwf0 CbPmX4alid7an5iAvDv5Z5Kp5DVHfD2PgZjatyuMLRPsluDMxkhsOJHpHlbzTxBReSsm YPSR+tWiY69kcD1Z/r3a7kOnH2I3p4Us6VG/7xoeKIAYkmvLak8xSXHgDkoR8ucR93Cp tMuMJKdsiDqflhtqhRvHr1djZHhBCk3U7TvV+O6FAMADH3GcBQMbA2J6bpW9ARxLCsDK Mon8c4uzj15dBBwwtf+zYjL1qn8P8q5AW/rAcs7ojbV1VJbhSv6c5YVIik9HsZNIkQQz tQlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420632; x=1695025432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=OTkvt77R258RUkzDJq2f8J839UTxIKM4gJddRuYZyyhdAB/1uNSQErBIs67udk6fd4 xE+KCMTls0HLOVMvl+5zk0neJkEzGxqUe06gnbsxRuJ7bloe/BsWWjdixVA5wB1irBij EGBYJHOr0skmqI2ml+gypKP/6ONwhWIaIK4B2IdwZbMMivTT6+Cd7LLWu00n9f59nR+N K9MJ++ZPL+yIaBU4iCL2OHNt5kiK9ca8KTCB17aLIsyfXN612W8sXM6cdBK3akskHfjW UX9eO4txXhw8yRpCGdplWc9cip18maKziTo4lSnZM8oPqwCAeF0bRWgUrluonxfGDNxz 9jZQ== X-Gm-Message-State: AOJu0Yxo4vV4JD6OShEJCy1BhpWbSkax68gl/U3/NOOep1atXNB8KWKU /u+3gLxhkb+EjI5c7c8VnO1ZTw== X-Google-Smtp-Source: AGHT+IE795z4MeyvcfiIIYPz/bYjnDK/11+Ubx+DKYPxh6E6lvf7/Sxx7I8bOqlaNVa5jarhNcJo9w== X-Received: by 2002:a05:6512:398a:b0:4fd:d213:dfd4 with SMTP id j10-20020a056512398a00b004fdd213dfd4mr8795699lfu.20.1694420632485; Mon, 11 Sep 2023 01:23:52 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:52 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:50 +0200 Subject: [PATCH v2 3/7] ASoC: max98373: Convert to use GPIO descriptors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-3-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of relying on legacy interfaces, convert the driver to use GPIO descriptors. This is a straight-forward conversion, we support also sdw devices providing GPIO descriptor tables if they so desire. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98373-i2c.c | 17 ----------------- sound/soc/codecs/max98373.c | 35 +++++++++++++++++++---------------- sound/soc/codecs/max98373.h | 2 +- 3 files changed, 20 insertions(+), 34 deletions(-) diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2= c.c index 0fa5ceca62a2..e7ec7875c4a9 100644 --- a/sound/soc/codecs/max98373-i2c.c +++ b/sound/soc/codecs/max98373-i2c.c @@ -3,12 +3,10 @@ =20 #include #include -#include #include #include #include #include -#include #include #include #include @@ -560,21 +558,6 @@ static int max98373_i2c_probe(struct i2c_client *i2c) /* voltage/current slot & gpio configuration */ max98373_slot_config(&i2c->dev, max98373); =20 - /* Power on device */ - if (gpio_is_valid(max98373->reset_gpio)) { - ret =3D devm_gpio_request(&i2c->dev, max98373->reset_gpio, - "MAX98373_RESET"); - if (ret) { - dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", - __func__, max98373->reset_gpio); - return -EINVAL; - } - gpio_direction_output(max98373->reset_gpio, 0); - msleep(50); - gpio_direction_output(max98373->reset_gpio, 1); - msleep(20); - } - /* Check Revision ID */ ret =3D regmap_read(max98373->regmap, MAX98373_R21FF_REV_ID, ®); diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index fde055c6c894..33eb4576da23 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -12,9 +12,8 @@ #include #include #include -#include +#include #include -#include #include #include "max98373.h" =20 @@ -478,20 +477,24 @@ void max98373_slot_config(struct device *dev, max98373->i_slot =3D value & 0xF; else max98373->i_slot =3D 1; - if (dev->of_node) { - max98373->reset_gpio =3D of_get_named_gpio(dev->of_node, - "maxim,reset-gpio", 0); - if (!gpio_is_valid(max98373->reset_gpio)) { - dev_err(dev, "Looking up %s property in node %s failed %d\n", - "maxim,reset-gpio", dev->of_node->full_name, - max98373->reset_gpio); - } else { - dev_dbg(dev, "maxim,reset-gpio=3D%d", - max98373->reset_gpio); - } - } else { - /* this makes reset_gpio as invalid */ - max98373->reset_gpio =3D -1; + + /* This will assert RESET */ + max98373->reset =3D devm_gpiod_get_optional(dev, + "maxim,reset", + GPIOD_OUT_HIGH); + if (IS_ERR(max98373->reset)) { + dev_err(dev, "error %ld looking up RESET GPIO line\n", + PTR_ERR(max98373->reset)); + return; + } + + /* Cycle reset */ + if (max98373->reset) { + gpiod_set_consumer_name(max98373->reset ,"MAX98373_RESET"); + gpiod_direction_output(max98373->reset, 1); + msleep(50); + gpiod_direction_output(max98373->reset, 0); + msleep(20); } =20 if (!device_property_read_u32(dev, "maxim,spkfb-slot-no", &value)) diff --git a/sound/soc/codecs/max98373.h b/sound/soc/codecs/max98373.h index e1810b3b1620..af3b62217497 100644 --- a/sound/soc/codecs/max98373.h +++ b/sound/soc/codecs/max98373.h @@ -213,7 +213,7 @@ struct max98373_cache { =20 struct max98373_priv { struct regmap *regmap; - int reset_gpio; + struct gpio_desc *reset; unsigned int v_slot; unsigned int i_slot; unsigned int spkfb_slot; --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDB1CA0EEB for ; Mon, 11 Sep 2023 21:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354024AbjIKVwN (ORCPT ); Mon, 11 Sep 2023 17:52:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235244AbjIKIYC (ORCPT ); Mon, 11 Sep 2023 04:24:02 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23DDADC for ; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-502a25ab777so3860199e87.2 for ; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420633; x=1695025433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nZvQIqiJILx7Vu44bdAP6xXOlwSKHGpCyi7z1wxsqaw=; b=GGD1ZRhCBOJNxp6i0epWwNF8SZSiCOMtc3GUFqAEooW8pclhoupWqrAbmrApDeBwkZ o/F63LqUdl8hEZWOQY4+kV0AR6+Bwl+4NjXTJRl8rq4Y65temU2I2ziQCSLvFdwJlIOM J2UybqozivOJ1YxwA9tWYMkVZ3gIwKQCbBOU1vQIAMJW3apZyrXS8LVoHDFyU2jaVOm3 VY0tCVePA1gyMKpB4BH45hw4p+WK3HWWnt2bcwx7/0DCDqTdXptGVCNEzwtT/sSTca40 0KZAI/X+NbsC29p7EDF7cxQD2H7BlBzbKWp2xDP1CBbjSR5JHWbSDyKFK0d0Q4MhAQtm j/qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420633; x=1695025433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZvQIqiJILx7Vu44bdAP6xXOlwSKHGpCyi7z1wxsqaw=; b=Yt73h7StXQr8v+6RfP+neET6SlAKZTXiZzzgVJ4uPSMv0x9m0Z40+IsB+Qbvs6Qv7M AVPTSDRJv9X+3yJFqJ4TAzqF7Ohy9JvqUQQ5Tu+6SGlSK/gZqj4uiO04ul4iqCrXiCDB HmEvn31OUmEqz5l15t2IM3Tt0tLBOUTwDoMDSGzuJ+0lyQdHqBaQ483k3y9PPiC2tyyO UdfD8z8i1eT6/5C5n2DnOahl19cNCm3KFhgUjpY4+2xTDDxFjZB/wkTA+cfta0miAT98 xbrOoGMKLnFDjMd5J/+eLZXG9EVTB+EE5uHPRUoaRPtgQseWcOVLYRRX3WMO5BhDv/ep fB6Q== X-Gm-Message-State: AOJu0Yy59aqNt8e6r7PqHsnvkrhWPskO2QBmoRjzbHBASfNcr9RsKCC2 aCvjPztRcUZKLs1TOfgQEcXBVA== X-Google-Smtp-Source: AGHT+IHLa00uwx18Fzy5EPh4buiYBYfThSk+G9oIq720hxnYrYyiXAOCwPIUdXV/kNi+50d/4ljcyw== X-Received: by 2002:a19:c505:0:b0:500:b302:3281 with SMTP id w5-20020a19c505000000b00500b3023281mr6564384lfe.27.1694420633260; Mon, 11 Sep 2023 01:23:53 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:52 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:51 +0200 Subject: [PATCH v2 4/7] ASoC: max98388: Correct the includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-4-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MAX98388 driver is using the modern GPIO descriptor API but uses legacy includes. Include the proper header instead. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98388.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98388.c b/sound/soc/codecs/max98388.c index cde5e85946cb..078adec29312 100644 --- a/sound/soc/codecs/max98388.c +++ b/sound/soc/codecs/max98388.c @@ -3,12 +3,11 @@ =20 #include #include -#include +#include #include #include #include #include -#include #include #include #include --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9B2EEB598 for ; Mon, 11 Sep 2023 20:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235770AbjIKUt0 (ORCPT ); Mon, 11 Sep 2023 16:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235246AbjIKIYC (ORCPT ); Mon, 11 Sep 2023 04:24:02 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E72A6E7 for ; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500760b296aso5011465e87.0 for ; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420634; x=1695025434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=lj0YQGFIq7FIQU2MOO5aB8dJfDXuSnTHyoMj7VoaqzgqrKe59OzG2vKsCncZmCgr+b neDDyeCU2dN0VF4dWOappPBOvfIvBE2r/pHrbknBSvpkyZ0wLfrydDiEA+dRlUavHxH4 88uDXuw6FGskjVobA7Fjy8afBWi90huGWstsxjzx5SEyK65duQ0LUsF6B3hRXKN7LCSu n57g+G0ink+kHQMRzlfyeMo3sTF1vGF0NwZOV/5JCy28SkHqCHktGekfk3tqU4JJN3xS 4oQYX9Qm9f6vz9D2791RsH472FIumL8xGYEovrzVacIchCvwNb1YB0hVvt9UfI2XzNRh jCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420634; x=1695025434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=sDN49Pnuuh1kfwUvBBL8zicFwnRQuJGEGDgF6EMAb46f/koan+GQ9NtBBjX6ckpi3b K5gMAazSgexG/ePDxOvXNuI4ryWOQFCQn0/NUyZM7equNHsd8m03rf2Z7RYa1PBl/d49 o9FOMYzd5WRjniydLqDA+pQmTSRsiqJ7/xqWSAF2LSBNQBKEW9dTWm5xfUB78pqWjM+d nwvI6pF/srOby2PZfFBvI61ijm8Q8c2q0TEdeOVMamzNaozOPXKWj00T1fPnqNdlwMwE XT2mtGd3xuNsPFzD/c2JwOcXkgV2zxlj8jGlp2eDopxhb+RbryurSC04xTQGAWDLt+ZR 8Cgg== X-Gm-Message-State: AOJu0YxqDhM9X7JEXtSObkeNGXGiwXHSOdH4ALZA38KnII1OcLC9ODPf 5ePrmu3yDixXXbLykfDl57fZ+Q== X-Google-Smtp-Source: AGHT+IE6WCFsa0bFZLixppvL9WUrXFO38to59wdYHxNCXTqD4Xc/xeONINSL8v0RojtmsjmZbNdCFA== X-Received: by 2002:a05:6512:3f14:b0:500:d96e:f6eb with SMTP id y20-20020a0565123f1400b00500d96ef6ebmr3927961lfa.19.1694420634181; Mon, 11 Sep 2023 01:23:54 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:53 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:52 +0200 Subject: [PATCH v2 5/7] ASoC: max98396: Drop pointless include MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-5-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98396.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98396.c b/sound/soc/codecs/max98396.c index 3a1d8c211f3c..e52bb2266fa1 100644 --- a/sound/soc/codecs/max98396.c +++ b/sound/soc/codecs/max98396.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include "max98396.h" =20 --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F5DCA0EC6 for ; Mon, 11 Sep 2023 22:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378815AbjIKWhc (ORCPT ); Mon, 11 Sep 2023 18:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235247AbjIKIYC (ORCPT ); Mon, 11 Sep 2023 04:24:02 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8A8EE for ; Mon, 11 Sep 2023 01:23:56 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-500b66f8b27so7131210e87.3 for ; Mon, 11 Sep 2023 01:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420635; x=1695025435; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=44JIVg8xfT/EISToMUTEvN6PJWh2bmWBrdxrTpht5uo=; b=QJ1VSBmff0euU4IAwhttZNDXi1W15EZ1g5jY6xyLF1pjZ+T0Fr6EVWYjP2AZDYrBmw KOGROvfUQT+l9KuaJ7BGIo16lPx+IsNqbVWBEh+bKPI36zOsXMZOaKwCFw0ir+sIw8BG 4MEMMQdX6KeB0j1cJctOVgWq9lOpvtw8sqUC/oKDxCAPyZMo8ALGWS/FWFYQfgVsik4G 3plPvyqYz0uSQ62nfIcvgABWZRP8HNOeoXZoQAYv9F6YtAkQnewxorJG8i2OrzzdBYTJ ZYVZ9gO51PszqkwiUfpdd6STFaIrMVb5oZcyXBkdr29pUy5iIGuxZYkAsVAJGjc7lmfp AQuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420635; x=1695025435; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=44JIVg8xfT/EISToMUTEvN6PJWh2bmWBrdxrTpht5uo=; b=vPp7+iaLEiLmIWKpj0ODC+wVQYmNeq2+/Msg1R9OXKRtM5GmzK/Q5iVoARe4X7Es9E N1Ee1TZMuKitAw8s6+SASP4c+0dONnBYEQ2bZrjJMe0q7KoR26EWDN7dK5Ss+vTV0KPz DT4bJD3YRUCCqNoJX0Wakin3c/RSbE1dvAGTv6KscceNxpj+Nqdd+J+rvwzsWjYuhyop w9rWgv2L7xhisQMMOnrZnHye/TxAy4SHMJ+rERg8RKA0vhgn7di/VIoPKZk0cFAbbM/c oxtYFj1Vu2zAugF1HYYhVGAey0r8YJFha42XAn5MK1ejfLGBfZ3Nx5PNqYpxuOQTxk8z U8DQ== X-Gm-Message-State: AOJu0YwVACXDLEJQeD3YomB7Jk5FDVgwCCFS7s2816R3/Yvp2VyNdHFP J42eKg9gwV7BrEzK/li1YVYGPg== X-Google-Smtp-Source: AGHT+IEQ4w417/0zEAT3z1jUW5wv9C0zAydtmQXHmAkRjf5g/xJFpgA6Pz1UnIvmT0XiSUbE22ZM/Q== X-Received: by 2002:a05:6512:2211:b0:4fb:8939:d95c with SMTP id h17-20020a056512221100b004fb8939d95cmr9556754lfu.30.1694420635138; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:54 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:53 +0200 Subject: [PATCH v2 6/7] ASoC: max98520: Drop pointless includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-6-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy headers or . Drop them. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98520.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/max98520.c b/sound/soc/codecs/max98520.c index 8637fff307ad..edd05253d37c 100644 --- a/sound/soc/codecs/max98520.c +++ b/sound/soc/codecs/max98520.c @@ -11,10 +11,8 @@ #include #include #include -#include #include #include -#include #include #include "max98520.h" =20 --=20 2.34.1 From nobody Mon Feb 9 06:21:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDAE4CA0ED5 for ; Mon, 11 Sep 2023 21:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347964AbjIKVZa (ORCPT ); Mon, 11 Sep 2023 17:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235249AbjIKIYD (ORCPT ); Mon, 11 Sep 2023 04:24:03 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90EAB110 for ; Mon, 11 Sep 2023 01:23:57 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-500c37d479aso6641376e87.2 for ; Mon, 11 Sep 2023 01:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694420636; x=1695025436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RoFqFLIfT/Pj/zYgo2TV8TIm3I2iaBuNZRSIlIfashI=; b=Sz/xdsGbzAb50fv7LSSeYbW54cSwqmAfepV+Gf2mGArfvEdasNpls9WtoLKIdniGX5 cfxQooafGXPZsnvEui7qOTUTwEQ4MktL7ghgoFw1l6w8cqwIP7BNCNmLWCjY+S5QhACJ 2aC2MbhnlvDH5ehStWyoebIV+KleXYMwI0CyZ/DX+Y9XP/Mk9XtL3wIWyxz3E6hUIV3b 1xx9ubJ6K+2OGe+YR+2OX4reQqyUA/2RKic1Hya7qpzWCRrBdRmUwBwG2UxLuWlJj7Ji 4waq6AMRCKKm7iQ8JsPs5/e2l4PaKTABlZWUxDSXHrucnbS/HGYwrJVL73GS+iHLYcVi I00A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694420636; x=1695025436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RoFqFLIfT/Pj/zYgo2TV8TIm3I2iaBuNZRSIlIfashI=; b=lbriFiKUu8QCuZMuzguyMUHPKEr3A4RyYfV/74/rz8VKycAQRmPI2l0rpnfiCAjZ0A yC9SyWm/GD91W4Fe7G7KylxeQpESaEgQ3naLq6E0Rd18gU2I22Y1k3q5/WVXGQ4ldWpX hUTPpuAb3fp/NMj4IKkNqjFu2Glx5/1gzOYlgFZGPkTBzbzJo1bQ7jF4rNvF/Upc7rTP REMZOIBdcf/wtZnwJfzMn8/+el9l86MHWr2rcC+BdZTxap3lYneH1oWu2cvkyISKUoGk RGNtosoqwnZ0SGV8zZmd01pCOQdQeykzvi5th85eNYxEKxRvvitOsmvouL4n5MFJm+EO aHtw== X-Gm-Message-State: AOJu0YwiqlPEhsMJsOnYz6DW4RSUktjlI0g9nI3bU2T29Xg84vl0Ug/A KxmUPWFzEJdhU3NvzVtHyPi02Q== X-Google-Smtp-Source: AGHT+IH/CI+1Aa8xWX3l3qD+VArAvLQxWZ8YfL/GW2vDk7MBZhMam+A68zhQz0zu3t/vzQtZwPJeiA== X-Received: by 2002:ac2:4c48:0:b0:500:c765:bbe with SMTP id o8-20020ac24c48000000b00500c7650bbemr8797463lfk.0.1694420635941; Mon, 11 Sep 2023 01:23:55 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a8-20020a19f808000000b00500968ddca9sm1247712lff.136.2023.09.11.01.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 01:23:55 -0700 (PDT) From: Linus Walleij Date: Mon, 11 Sep 2023 10:23:54 +0200 Subject: [PATCH v2 7/7] ASoC: max98927: Drop pointless includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230911-descriptors-asoc-max-v2-7-b9d793fb768e@linaro.org> References: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> In-Reply-To: <20230911-descriptors-asoc-max-v2-0-b9d793fb768e@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy headers or . Drop them. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98927.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c index 776f23d38ac5..70db9d3ff5a5 100644 --- a/sound/soc/codecs/max98927.c +++ b/sound/soc/codecs/max98927.c @@ -15,9 +15,7 @@ #include #include #include -#include #include -#include #include #include "max98927.h" =20 --=20 2.34.1