From nobody Thu Dec 18 09:39:13 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13ED6EE3EC0 for ; Sat, 9 Sep 2023 16:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233094AbjIIQr0 (ORCPT ); Sat, 9 Sep 2023 12:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbjIIQrZ (ORCPT ); Sat, 9 Sep 2023 12:47:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B04B59C for ; Sat, 9 Sep 2023 09:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694277993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=OdCJqsKNdERpBnYU8M+NFHEJroll7Jtw77XwuC55ZyI=; b=U+DuKMgT0kCn5YjDI1flrK3XjMNIMM4bYvijXNcqiiCXs9ub1AuHRi2VlA19Bijw7e+woZ nGqRM+p1peqE5oS00hfCo9yf0dwrypXbyepRhXul6wzBie+Ik9rbPSpozJVcNkvnTJodfy H/bPweUACgxN8n2jPic//oFFFdg5/Cg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-508-ImDeTm9sOpabTVlGNMKkkw-1; Sat, 09 Sep 2023 12:46:30 -0400 X-MC-Unique: ImDeTm9sOpabTVlGNMKkkw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F90B380673F; Sat, 9 Sep 2023 16:46:30 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.36]) by smtp.corp.redhat.com (Postfix) with SMTP id 644542015CE0; Sat, 9 Sep 2023 16:46:29 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 9 Sep 2023 18:45:38 +0200 (CEST) Date: Sat, 9 Sep 2023 18:45:37 +0200 From: Oleg Nesterov To: Andrew Morton Cc: "Eric W. Biederman" , linux-kernel@vger.kernel.org Subject: [PATCH] signal: complete_signal: use __for_each_thread() Message-ID: <20230909164537.GA11633@redhat.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" do/while_each_thread should be avoided when possible. Signed-off-by: Oleg Nesterov --- kernel/signal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index fc276fc07d87..ccfc3ded5672 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -1058,12 +1058,11 @@ static void complete_signal(int sig, struct task_st= ruct *p, enum pid_type type) signal->flags =3D SIGNAL_GROUP_EXIT; signal->group_exit_code =3D sig; signal->group_stop_count =3D 0; - t =3D p; - do { + __for_each_thread(signal, t) { task_clear_jobctl_pending(t, JOBCTL_PENDING_MASK); sigaddset(&t->pending.signal, SIGKILL); signal_wake_up(t, 1); - } while_each_thread(p, t); + } return; } } --=20 2.25.1.362.g51ebf55