From nobody Fri Sep 20 11:45:40 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF962EE57CA for ; Fri, 8 Sep 2023 06:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238900AbjIHGVg (ORCPT ); Fri, 8 Sep 2023 02:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238621AbjIHGVb (ORCPT ); Fri, 8 Sep 2023 02:21:31 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3486619AE; Thu, 7 Sep 2023 23:21:26 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-1c0a4333e03so3964935ad.0; Thu, 07 Sep 2023 23:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694154085; x=1694758885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/1CF4SZe+j+A2vmx7gVT8aOLdHeQoN2UL8CkT5LKTRQ=; b=PK0+LWJ2c7FX+dS9YSV2wcADaZuhgctmF9WZeLx+SiqaDJtraSkockHzZynuaGfvHk Ms7zuKLFYgDk4UOzEyB+JP5uBO/NdV13zeD5UPErXgEztXqa54qrYhWIn5FJqR/RgzfI ex0Nj5dt83gtAiXeoMnNgCrauEoLeJ/sCGKKLJeTBF9BzXsA/kb0ebLUdNKAJbcmN06K NnzeNCvNCiJ4RKCuN+lFNmV/e7np1Fnf3YyU0wAS2I/jqFbYiGIurhdFXi31sdwL4wwN xEmQLXNdhYc38amnJx34udGFKm4MhSJPoRDYElu6GHpratnoqrf+mgT3+gEzZmfQpk6j JC/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694154085; x=1694758885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/1CF4SZe+j+A2vmx7gVT8aOLdHeQoN2UL8CkT5LKTRQ=; b=S39XlKXEfr6K0iSnirrNoldUKPs2agTWrloUn+neo+HuRIWf4ywP5uFFPB0Vctx6wi HE51xO4jw5Jmbeoy8uC86a2yGfLb530Grd2SH6JmoK2xKCDUWavQsVQPTnnGPWPN2e+2 3eTGLzfIEk7+ZEawapPu0idZkOesx5jf2x1/yYoab/qZsSw22N+yGVTwcGwRf0I7uL74 g5dyl6Xs+I6YaYQwKe5Yzzjb+pfiD+Z1ZAaXSVPSe80hjN60LTPoC5uBf2mB+0IWpQYf cj2Gr0qE9/5z3r0MvMP/Jm/e1cIegkOCo2ub8wOry2fOwTfQasGF5zieQQSNSyk7Itt8 Du5Q== X-Gm-Message-State: AOJu0YxFParytoTSsOpKSY39KPf94oVsQrNt5L5Yvh32GuihjXfc4Sln s3JCT86LxhSp2Roia06eLZk= X-Google-Smtp-Source: AGHT+IGST1hBLOHOHypmYgCJUMet9wuRE7B4sVnLN++DfxZqbuc1JkMedwhmLrS+9e0Rre5bDpEsow== X-Received: by 2002:a17:902:e54b:b0:1bb:d7d4:e2b with SMTP id n11-20020a170902e54b00b001bbd7d40e2bmr1895198plf.0.1694154085658; Thu, 07 Sep 2023 23:21:25 -0700 (PDT) Received: from hbh25y.mshome.net ([103.114.158.1]) by smtp.gmail.com with ESMTPSA id l7-20020a170902f68700b001b8c6890623sm768620plg.7.2023.09.07.23.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 23:21:24 -0700 (PDT) From: Hangyu Hua To: justin.chen@broadcom.com, florian.fainelli@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mw@semihalf.com, linux@armlinux.org.uk, nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, maxime.chevallier@bootlin.com, nelson.chang@mediatek.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hangyu Hua Subject: [PATCH v2 1/3] net: ethernet: bcmasp: fix possible OOB write in bcmasp_netfilt_get_all_active() Date: Fri, 8 Sep 2023 14:19:48 +0800 Message-Id: <20230908061950.20287-2-hbh25y@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230908061950.20287-1-hbh25y@gmail.com> References: <20230908061950.20287-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rule_locs is allocated in ethtool_get_rxnfc and the size is determined by rule_cnt from user space. So rule_cnt needs to be check before using rule_locs to avoid OOB writing or NULL pointer dereference. Fixes: c5d511c49587 ("net: bcmasp: Add support for wake on net filters") Signed-off-by: Hangyu Hua Reviewed-by: Simon Horman --- v2: use -EMSGSIZE instead of truncating the list sliently. drivers/net/ethernet/broadcom/asp2/bcmasp.c | 9 +++++++-- drivers/net/ethernet/broadcom/asp2/bcmasp.h | 4 ++-- drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethe= rnet/broadcom/asp2/bcmasp.c index d63d321f3e7b..e45e0ae932cc 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -528,13 +528,16 @@ void bcmasp_netfilt_suspend(struct bcmasp_intf *intf) ASP_RX_FILTER_BLK_CTRL); } =20 -void bcmasp_netfilt_get_all_active(struct bcmasp_intf *intf, u32 *rule_loc= s, - u32 *rule_cnt) +int bcmasp_netfilt_get_all_active(struct bcmasp_intf *intf, u32 *rule_locs, + u32 *rule_cnt) { struct bcmasp_priv *priv =3D intf->parent; int j =3D 0, i; =20 for (i =3D 0; i < NUM_NET_FILTERS; i++) { + if (j =3D=3D *rule_cnt) + return -EMSGSIZE; + if (!priv->net_filters[i].claimed || priv->net_filters[i].port !=3D intf->port) continue; @@ -548,6 +551,8 @@ void bcmasp_netfilt_get_all_active(struct bcmasp_intf *= intf, u32 *rule_locs, } =20 *rule_cnt =3D j; + + return 0; } =20 int bcmasp_netfilt_get_active(struct bcmasp_intf *intf) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.h b/drivers/net/ethe= rnet/broadcom/asp2/bcmasp.h index 5b512f7f5e94..ec90add6b03e 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.h +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.h @@ -577,8 +577,8 @@ void bcmasp_netfilt_release(struct bcmasp_intf *intf, =20 int bcmasp_netfilt_get_active(struct bcmasp_intf *intf); =20 -void bcmasp_netfilt_get_all_active(struct bcmasp_intf *intf, u32 *rule_loc= s, - u32 *rule_cnt); +int bcmasp_netfilt_get_all_active(struct bcmasp_intf *intf, u32 *rule_locs, + u32 *rule_cnt); =20 void bcmasp_netfilt_suspend(struct bcmasp_intf *intf); =20 diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c b/drivers/= net/ethernet/broadcom/asp2/bcmasp_ethtool.c index c4f1604d5ab3..ce6a3d56fb23 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c @@ -335,7 +335,7 @@ static int bcmasp_get_rxnfc(struct net_device *dev, str= uct ethtool_rxnfc *cmd, err =3D bcmasp_flow_get(intf, cmd); break; case ETHTOOL_GRXCLSRLALL: - bcmasp_netfilt_get_all_active(intf, rule_locs, &cmd->rule_cnt); + err =3D bcmasp_netfilt_get_all_active(intf, rule_locs, &cmd->rule_cnt); cmd->data =3D NUM_NET_FILTERS; break; default: --=20 2.34.1 From nobody Fri Sep 20 11:45:40 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE8BEE57CA for ; Fri, 8 Sep 2023 06:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241084AbjIHGVm (ORCPT ); Fri, 8 Sep 2023 02:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240720AbjIHGVk (ORCPT ); Fri, 8 Sep 2023 02:21:40 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449B31BE9; Thu, 7 Sep 2023 23:21:34 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id d9443c01a7336-1b89b0c73d7so3335215ad.1; Thu, 07 Sep 2023 23:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694154094; x=1694758894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EdlxO8xCKrQy/jRT0nkbbxVM9BFP+RkDY99mRvExc+k=; b=jVK9HFTeboxtCz+n9j5O0uYCYEiitQ2KcVh0a5q33dldLAdceiWj68Fh2pScdBaIoO PUoRytI0EEUi9TAIT/EIQuD4HHoHu2kI7nYOw+pjVbaEHPrOgxvxyBr5K/zpjD3o6Yns 8vSUbau21hI/mdYD7DXT769sftq1NLkYNan+n1cMxB0oc6fKaoiJ6nAHrBcdjm8doNXJ lKlC2b4MwC8Ev/ebjFpB0g9YJBZ65oyZUlF1fPb9R5Nq3GUT7NCSQSNYjRKhbjkRa5Zp b3HkKfJtie0mntKpWkqcc+y9OQHsd/PdKiHrYERTpbevatfncv8OeN4kh++A7WD1CPg4 qJyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694154094; x=1694758894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EdlxO8xCKrQy/jRT0nkbbxVM9BFP+RkDY99mRvExc+k=; b=i8MMo0lRWLPA1x9yzvZMX82dz2WKMMap01dU6kZt//fOxqhA9zTi5aEFLkflAbciPg 2wPLMzMXkqcn5VRzESjacGqkqR+ukcm4J360wtlVSMBaibsXKdnuwTyVzqGwlT4YTk0J 6RW7PGsAU9XnPpIcFnO/HvrqTNiow4QbYQf2MV4zK6tqSd5V9QmRqqcM9bYYz9glil05 GqomSyigUNQ7Fq1Q2T8FUTrCbgsnIfw2ReiMRyMzcb1eSmQ3kr+MhVn+YRVFubE34tzs IZy24BEpTQs+dmh4rZyFPP6984i6txRLfVBc0ZX8lzdIEfAmy6YQqommaUkHUhd/JH31 Y/qQ== X-Gm-Message-State: AOJu0Yz8FcjKBcZUgL2/uXpMKdV5AC4pq0UGKMtlaDwsi4kzJveuJMEH 1DDVoriauBspmMNYFv0iibQ= X-Google-Smtp-Source: AGHT+IFtdbDXX/f6kthEXzxe3IPBBobkRzWDXfCM/Z8uOIZugSIsTKjKzDPEZO02Vum21D08dqAq4A== X-Received: by 2002:a17:902:e751:b0:1c3:2af5:19f3 with SMTP id p17-20020a170902e75100b001c32af519f3mr1732109plf.5.1694154093626; Thu, 07 Sep 2023 23:21:33 -0700 (PDT) Received: from hbh25y.mshome.net ([103.114.158.1]) by smtp.gmail.com with ESMTPSA id l7-20020a170902f68700b001b8c6890623sm768620plg.7.2023.09.07.23.21.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 23:21:32 -0700 (PDT) From: Hangyu Hua To: justin.chen@broadcom.com, florian.fainelli@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mw@semihalf.com, linux@armlinux.org.uk, nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, maxime.chevallier@bootlin.com, nelson.chang@mediatek.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hangyu Hua Subject: [PATCH v2 2/3] net: ethernet: mvpp2_main: fix possible OOB write in mvpp2_ethtool_get_rxnfc() Date: Fri, 8 Sep 2023 14:19:49 +0800 Message-Id: <20230908061950.20287-3-hbh25y@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230908061950.20287-1-hbh25y@gmail.com> References: <20230908061950.20287-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rules is allocated in ethtool_get_rxnfc and the size is determined by rule_cnt from user space. So rule_cnt needs to be check before using rules to avoid OOB writing or NULL pointer dereference. Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support") Signed-off-by: Hangyu Hua Reviewed-by: Marcin Wojtas Reviewed-by: Russell King (Oracle) --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/= ethernet/marvell/mvpp2/mvpp2_main.c index eb74ccddb440..21c3f9b015c8 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -5586,6 +5586,11 @@ static int mvpp2_ethtool_get_rxnfc(struct net_device= *dev, break; case ETHTOOL_GRXCLSRLALL: for (i =3D 0; i < MVPP2_N_RFS_ENTRIES_PER_FLOW; i++) { + if (loc =3D=3D info->rule_cnt) { + ret =3D -EMSGSIZE; + break; + } + if (port->rfs_rules[i]) rules[loc++] =3D i; } --=20 2.34.1 From nobody Fri Sep 20 11:45:40 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273F1EE57CA for ; Fri, 8 Sep 2023 06:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237133AbjIHGVz (ORCPT ); Fri, 8 Sep 2023 02:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240720AbjIHGVw (ORCPT ); Fri, 8 Sep 2023 02:21:52 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE9FC1FCF; Thu, 7 Sep 2023 23:21:42 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-1c0a4333e03so3965505ad.0; Thu, 07 Sep 2023 23:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694154102; x=1694758902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wpl/wrF03hm1k33VtCn3Pp91tnDEn9HNqN0mbE6woR8=; b=F1TGyEr2w5SCtlnmOCcZga4UJAxD9AvFqNe0j6CQjgzM0U3KVGnwVwVyKmDA7vEbbg qZv4yQkcnyT65wPdRilNY9dNGeWsR/53LCoL2nVMe8Wi59k6ngJ6EjV/4cQt/oR6OXwb UxabhuHYM/FkGCU3+ELBEmoZR77KLmJ+1Vd7kn//vgV73zbZ3msWJJIPbmMa0hbBFNtb U0IlX/CcA/SJY/PCNo8qtbTtunHuXqApRvBgWe68QehBNQ/ibMKcAAM+aZoJ+Ldirn7L s3V9Gt01uUf3EOIiklYnis5OyYjlWSyxc9TceQORaQv8ZLAVvwDkQ0XzlyR0xrhUiDzK i9Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694154102; x=1694758902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wpl/wrF03hm1k33VtCn3Pp91tnDEn9HNqN0mbE6woR8=; b=Kg8/7x7K4Ngd+3qY7YplJSVvSrqlucuO6jN12oRU6hRNmSZGGEyYY3aP5K2ETszvfQ 2fkzrMxGg/neDLOX1mK72+CTqZdaohEn2cuGXWM1HXvd/QUHTCOqQRtWJRaC5b51rj9f J76TjfYQBe2v6j2Niq9fAKuivh/3tDeKVyd6rgZlwA/LW7RznVvLknsagdS8wIakcSUP ZkwbCUjytBhJeZBB0kezvd9PbWClgMO/+Jluw74UzsJJbQU0RbB+8yS+Dn1SUMSbwpgS v228XNypltyGjxaOHgOZ281D2HnHm0AJNms44O7Kd1hke7yAIYwgVFQ5tImq6vdBFBAq KiSQ== X-Gm-Message-State: AOJu0Yz/IA+EgzQsEdHL2eRSq8bzBPH9R3E9daw2ItVxSsLtgWHyuc5E 0FsWifxYH3cyQcPoj+St2L8= X-Google-Smtp-Source: AGHT+IEqN3LuOZvVGW/cDz1gygxDQXajdyrBxp5NvEo7QNyxpkquntuPCrDtubFkejvWG2NvFCobKg== X-Received: by 2002:a17:902:e54b:b0:1bb:d7d4:e2b with SMTP id n11-20020a170902e54b00b001bbd7d40e2bmr1895592plf.0.1694154101997; Thu, 07 Sep 2023 23:21:41 -0700 (PDT) Received: from hbh25y.mshome.net ([103.114.158.1]) by smtp.gmail.com with ESMTPSA id l7-20020a170902f68700b001b8c6890623sm768620plg.7.2023.09.07.23.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 23:21:41 -0700 (PDT) From: Hangyu Hua To: justin.chen@broadcom.com, florian.fainelli@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mw@semihalf.com, linux@armlinux.org.uk, nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, maxime.chevallier@bootlin.com, nelson.chang@mediatek.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hangyu Hua Subject: [PATCH v2 3/3] net: ethernet: mtk_eth_soc: fix possible NULL pointer dereference in mtk_hwlro_get_fdir_all() Date: Fri, 8 Sep 2023 14:19:50 +0800 Message-Id: <20230908061950.20287-4-hbh25y@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230908061950.20287-1-hbh25y@gmail.com> References: <20230908061950.20287-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rule_locs is allocated in ethtool_get_rxnfc and the size is determined by rule_cnt from user space. So rule_cnt needs to be check before using rule_locs to avoid NULL pointer dereference. Fixes: 7aab747e5563 ("net: ethernet: mediatek: add ethtool functions to con= figure RX flows of HW LRO") Signed-off-by: Hangyu Hua Reviewed-by: Simon Horman --- v2: drop the brackets. drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethe= rnet/mediatek/mtk_eth_soc.c index 6ad42e3b488f..2372ce8c2580 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -2994,6 +2994,9 @@ static int mtk_hwlro_get_fdir_all(struct net_device *= dev, int i; =20 for (i =3D 0; i < MTK_MAX_LRO_IP_CNT; i++) { + if (cnt =3D=3D cmd->rule_cnt) + return -EMSGSIZE; + if (mac->hwlro_ip[i]) { rule_locs[cnt] =3D i; cnt++; --=20 2.34.1