From nobody Fri Dec 19 09:43:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CAA3EE14D6 for ; Wed, 6 Sep 2023 19:02:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244019AbjIFTCm (ORCPT ); Wed, 6 Sep 2023 15:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243997AbjIFTCf (ORCPT ); Wed, 6 Sep 2023 15:02:35 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE19A172E for ; Wed, 6 Sep 2023 12:02:31 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7955636f500so4753239f.1 for ; Wed, 06 Sep 2023 12:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026951; x=1694631751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=eQmfVREsP9Dq6gULPu39MebcqIdDAv3hJLAxmDyZu87tgJJF4bE0wCanjLhIurVof0 buTFlHWTOEdriJ5TUTgwratI54GJe1DKmXJqZprcpPJ6TxITQIeKHflVsMBweM4naVhe 8X/PN8lwwWfsknnJplLM8a9tu51JNuBLFcM4UDCB4lHXi5G9D2lpl4XM5ipbSlF6utLb qoT8QF1+i3j/2TAXb7gL9dSmpW5q/vQjrBTyz0tXD2EBt+03wndLXy57jw0N7guH6Q3b fxum04Ga33K/ag3IBlmPG81s2eTqmJzEE6/q8WZzITCjKerGzLwKPgD1ik9iC47q5JWv eHWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026951; x=1694631751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=Skxhbk2T2MzVmOTlZIxzWKBZj9s1uPCP9Bd2r5GsYIyMUYtvIQ/W2aBTSB2zTvyrbp igVFO4XLWGUakiD5sOdyOxI/2TtubgCRg1A0TGvIjIO9Pw/ramEydDbhiCkx4dMH4lZ3 R5iJCXDQ6CjmBdP7rBx2xomlgRGlkRvqdmkp+xTVzJhrOThiWl2SVtQN66Ra6NNbldHp sxA1TzroQFPNEc2sY3cTMQ3xYNXoVdrFYWqQKsImtd/xHwFAWmIA4oNxAuRrWzitrFYH F3CXo4QjUma3UlW7aC0iXDZvqiFPXwvgI7c+kaKYiYlO/oaIIlLOJcsA47Xw9slli4jV qhpg== X-Gm-Message-State: AOJu0YwdR7CkmYkYIgt+pcPZGfGjr87+4ve89EFWIV5hZIyOvsBYDjaB igodUEvwQ1bfzYKmAZ7UO0IUeRtOkylkJQ== X-Google-Smtp-Source: AGHT+IEm+/duIejOs4uEx0V1ECGyB/EMXsZAKUYZsERs5kQRkhUOS9SyRyr5dfsXrmwu8JiEQjVuXQ== X-Received: by 2002:a6b:5c0c:0:b0:787:230f:55b1 with SMTP id z12-20020a6b5c0c000000b00787230f55b1mr18474144ioh.2.1694026950925; Wed, 06 Sep 2023 12:02:30 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:30 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:19 -0600 Message-ID: <20230906190224.583577-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index f28725736237..14020585bdc0 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, voi= d *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:= %s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); } =20 --=20 2.41.0 From nobody Fri Dec 19 09:43:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896B1EE14D3 for ; Wed, 6 Sep 2023 19:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244060AbjIFTDF (ORCPT ); Wed, 6 Sep 2023 15:03:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243995AbjIFTCh (ORCPT ); Wed, 6 Sep 2023 15:02:37 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26CB41B7 for ; Wed, 6 Sep 2023 12:02:33 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79565370aa3so5564239f.0 for ; Wed, 06 Sep 2023 12:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026952; x=1694631752; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=l7bUw00O7hX9W/k/qeYBNo2ag8y4j+NYyhtg5DnM/VAbDgD/eoKqPx1C7gciq2KddS oCAk8hs1w4N8oQa9L8EZD57ONP1xsQdBw6S4QQRKPjhYTFBQ8uKUbcR1UXbgT0MOKaZq Wp0MYKwwic7VhX6QD65foIplDNaeR4EDbo2OnMYenLVq9mgA9KOyDhsV9mfq/bW9+NeC JwGM54IyAWTtCqkeCm9ugNQdXL/Fn4kkT7wG85SL1k1RMIQNhIfPQ3IOhuzt8VZ6vqqz L7rs0o/TBZd3W22a2zqCpeygtfSRMF0O10pwQlItCl7MOEGa7eSVioR7C0jzOjr9SWoV WIIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026952; x=1694631752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=i2cNQ7T+RlAzl+9zWE7hFo1l8Ql7Ou5WXHbzwBsfF9XC4A8/HK/ShI5urivHgYMKxE RVRpJwXnkj9bGG+bh2D896+C5Z1VpkfFc3CxX7s9+pDC4J8buI5gCCgV0FXpAloIufHz b3bCOgxxefWOTwkp8OMcv4GDWrfgOYXVXRlD8ZEPb6gXoaIozibcPy3HD2xl3Xpijm38 Mm+TRbIKnYAHIgvpFRrBSNrImaFisLR5AhxFLyBuqfN++uzu/ZxGojwMmxNFz+ibFQEJ Ym2pXTdUJqtNCsQkuuM7wlmn9QZUyCqm11mRO+Xq1h6gedN//I9dAV8+RNKe4cnfvajQ 1spg== X-Gm-Message-State: AOJu0Yz+D/br8p57GRh3RsCaUXUb2/UBaENBzuGro8N24In3Dkx5x+J1 fTqCY4Vujf7TsUP2TuPTev8Et652LEK/Ow== X-Google-Smtp-Source: AGHT+IF9+5z8gW/L2WmhxsI+81BMma/N4jRZCRB7iE4meseUn0CUi23FnZlRHWkkTJI6XVkfvLHlSg== X-Received: by 2002:a5e:8913:0:b0:783:47cd:27b5 with SMTP id k19-20020a5e8913000000b0078347cd27b5mr18383468ioj.3.1694026952009; Wed, 06 Sep 2023 12:02:32 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:31 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Anitha Chrisanthus , Edmund Dea , David Airlie Subject: [PATCH v3 2/5] drm/kmb: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:20 -0600 Message-ID: <20230906190224.583577-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Acked-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch =3D 0; vm.hsync_len =3D 28; =20 - drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d", + drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp =3D mode->vsync_start - mode->vdisplay; =20 if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height =3D %d less than %d", + drm_dbg(dev, "height =3D %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width =3D %d less than %d", + drm_dbg(dev, "width =3D %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh =3D drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh =3D %d less than %d or greater than %d", + drm_dbg(dev, "refresh =3D %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } =20 if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp =3D %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp =3D %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } =20 diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plan= e.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *= plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format !=3D format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on\n"); return -EINVAL; } for (i =3D 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *pla= ne, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width !=3D fb->width || init_disp_cfg.height !=3D fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration\n"); return -EINVAL; } can_position =3D (plane->type =3D=3D DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *p= lane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); --=20 2.41.0 From nobody Fri Dec 19 09:43:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF7E9EE14D0 for ; Wed, 6 Sep 2023 19:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244119AbjIFTD0 (ORCPT ); Wed, 6 Sep 2023 15:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244009AbjIFTCh (ORCPT ); Wed, 6 Sep 2023 15:02:37 -0400 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CCECC7; Wed, 6 Sep 2023 12:02:34 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-792717ef3c9so4131539f.3; Wed, 06 Sep 2023 12:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026953; x=1694631753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Shuu74iNOrUzggTrIzmIdLUSQe5OqUirbEavz/33+0U=; b=FFEglAkon2EdUzMQJvIeUA9aHlG/CB49Uyjr0uPSrrlB4t6T0rRiuktA448p/b4INr lrXJ1Rg+dWq+mMVVjiMn+RRN2Tvxq3j4GpGBIlynaKdftvSiBcMi+nnOk3d92fX2CUbh MXIjBvTRkoxjkIsNa7JCMy/zZxN1JxG+IE1qCL1bV1f419//UoBb0muo2jtzJBb/Outz eeYLajpdOC5tuj6YI0LqqgF36/aoPGhLlC7P6BdrPDdMxiXPzn+zHZCDT2FocCyYnuUO ZMcYdp4ytHP7sLysdlXwhw9SN/2APpRda5Lm1l/q4fr7ro7odEG+Lnhae7a6ZU+taigu K5LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026953; x=1694631753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Shuu74iNOrUzggTrIzmIdLUSQe5OqUirbEavz/33+0U=; b=iEInu+Z1xorFODkfFogcDGtj5OfLOz93500m7/hn+ZcUXltS/heCRbBy3ZoM31XnYX S/JxPOcDYaP8kygAWSFptBLRF+phsUJY5XBwUMwRYCE1bAhOd42Wcra8zMOzJf7LkxgN QnU/mJAw8EuwnnYZIYEmvP7VEe55s9ypldYDMWkjQImvsal5lYdS/3ii678OVCX/RsmM zQGFWgesDsCX1Wh/ah2oR/vgFMVvRNWZmhbYEjS7T0M3Y2cjqQQaaQ+QF0KHqAlycZC7 JlBBg0j5XdaQhwmduHgvar3bmrY1KNMTCQqdebmQvNCIIvP5HVDpC5gbQQBgedmnxR76 e/xQ== X-Gm-Message-State: AOJu0YxpN9/rZ2/yvDr9LOcTLRHNayPYd6So/8uA3qVXjCwpkhpjTARY 2u3UPj7Y5BK8PRAL2HSBoYTqTCnfqXa44A== X-Google-Smtp-Source: AGHT+IG8dUwsOLP2n+Ukg0ohoD1JineJZS15vcrecPVQqbrwV1b9zykvv4DUg7GBrgG/kgmfyMJyGQ== X-Received: by 2002:a6b:dc17:0:b0:792:8d16:91ef with SMTP id s23-20020a6bdc17000000b007928d1691efmr16839930ioc.18.1694026953259; Wed, 06 Sep 2023 12:02:33 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:32 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH v3 3/5] drm/msm: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:21 -0600 Message-ID: <20230906190224.583577-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_fb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..88bb5fa23bb1 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, =20 for (i =3D 0; i < n; i++) { ret =3D msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,9 +176,9 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, const struct msm_format *format; int ret, i, n; =20 - drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)", - mode_cmd, mode_cmd->width, mode_cmd->height, - (char *)&mode_cmd->pixel_format); + drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)\n", + mode_cmd, mode_cmd->width, mode_cmd->height, + (char *)&mode_cmd->pixel_format); =20 n =3D info->num_planes; format =3D kms->funcs->get_format(kms, mode_cmd->pixel_format, @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, =20 refcount_set(&msm_fb->dirtyfb, 1); =20 - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); =20 return fb; =20 --=20 2.41.0 From nobody Fri Dec 19 09:43:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040A6EE14D3 for ; Wed, 6 Sep 2023 19:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbjIFTDM (ORCPT ); Wed, 6 Sep 2023 15:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244015AbjIFTCk (ORCPT ); Wed, 6 Sep 2023 15:02:40 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB931B7 for ; Wed, 6 Sep 2023 12:02:35 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-79545e141c7so3331939f.0 for ; Wed, 06 Sep 2023 12:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026954; x=1694631754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=VhiYRzrqvKBxeIkXtmhdECvVB0SQgUHOBovReJrTXn7y+2+xZBhrSiZhW8RhRspuZH UqMcPXZTbo3wAaQSOFXfBG4Os+8QBiVbTwxqXxt4jZ6Bv3kzvGOweAQeoPZgcATEQM0L b0jwDtoqQU70Vo8h202GNayhYZKWO4HAQ2LsDEMkxMQoUQzdfXPzCRM3fK4Hgab1b2Yd VRsp1Xg6mkWvMykt1ygxU0D6V1hrimmXH0ZpkmmA8XktbD9yXT3ijtgHyAtLEC0c4uJJ RHBDmFBg25ViyzCwKOnwLXLePzm8VHnUZ8MiAA7aSr10uHAkeWzqjP4Q7bcrN/ZjLiUs /9ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026954; x=1694631754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=NGMgZX9oEcnrE3lUK/OvPKwYvUPG0yKoeQ3sHIEDUxm0mszztAQxS8cAe0V0+IpBLE TQIdFfhbYJVu2y1akPdyBjr+drgcu3XHlnXNvZ0uEgESshK1fcx6dUJ3KPSrN9I5jKO+ jOo6zyA8qIImwjZFShnOB9Wnd8enKlpVZkeq7mCD7HLohGDG1fo7VPYFJrm+F/aaOlqM w+B+JBg/TmJLLkvJqOmNMB0SscYzUWH08lRgeN2asGHyKOKjS5/oCHWBgrpL5rkTTJRV neY5G8eVVfDFIv6QvDFu8fZ2ZhUGBogtEpQgiSqYPBQ8GMSprBZ9c9PxYBvvBnD0kEWK AGVw== X-Gm-Message-State: AOJu0Ywlk9ZgvnPRjaWIjisNkwSXykNNMgGXBvTq/I8ZQqfjUP3LzO0I +axyY2us/d+i4dEgCbhsSnyucGu61vw89g== X-Google-Smtp-Source: AGHT+IEerlB6JrUC+Z/0QRgCoRQoVs5aiPA8URhXDpxxGTJSTcPFuBIaCE9H+Uno/nfLK9zvHQVWkg== X-Received: by 2002:a5e:a718:0:b0:794:c9a8:27eb with SMTP id b24-20020a5ea718000000b00794c9a827ebmr544496iod.5.1694026954382; Wed, 06 Sep 2023 12:02:34 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:34 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Emma Anholt , Maxime Ripard , David Airlie Subject: [PATCH v3 4/5] drm/vc4: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:22 -0600 Message-ID: <20230906190224.583577-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Acked-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *cr= tc, struct drm_encoder *encoder =3D vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev =3D crtc->dev; =20 - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crt= c, struct vc4_encoder *vc4_encoder =3D to_vc4_encoder(encoder); int idx; =20 - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 if (!drm_dev_enter(dev, &idx)) --=20 2.41.0 From nobody Fri Dec 19 09:43:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B0AAEE14D0 for ; Wed, 6 Sep 2023 19:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244103AbjIFTDT (ORCPT ); Wed, 6 Sep 2023 15:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244016AbjIFTCk (ORCPT ); Wed, 6 Sep 2023 15:02:40 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0545198E for ; Wed, 6 Sep 2023 12:02:36 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34baf19955cso600355ab.2 for ; Wed, 06 Sep 2023 12:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026955; x=1694631755; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usLeqXzE5U9X3mWlGIhl2wkCPYgPL1jt55C0ImyryHk=; b=i6xDD73aweOnWOaN5tMndgFCj6NAz+oicYJ5DIF9MMMK+n2+ddEL+DnzirpCT9vk0e QnclEjO0AsZnbsyEtmMX8iqXJdQHL/5dc77Lp6YleG3/OnG6dvw76/TC11CqgtpTW32F c/gHsh/yxWDslbPecRrmW+lweZUfbWYDFxZdf3AZbFbe4FR/xpslSdWa6aiKJCwHsz05 JgQZ9egekvJGeQnDJriOwQR2YI5gSVzbcDanxyUOUpwriutDOay4ecr6m4pJEaplJPYH KXMGUh7k+o/Vi3I06BBmmobSleo1mmzAKypcuMC0w5VHW308+yt7MB1eFYWV5HHFj71v WZ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026955; x=1694631755; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=usLeqXzE5U9X3mWlGIhl2wkCPYgPL1jt55C0ImyryHk=; b=PGS5jK6qcr5t1BysDiF6FubnTLMePK029uoU5pcH0AQZ0AQHvpBQJGbq5zWyKXZGjd q7LGzIHH1ww+llJQASiQHp3JUtuZZ65I6LABMjzqOUHF4L5T28oJtyFOwS07B7wzLsg4 4H+cQruBuLZF+ouj7ym91dIzja7A83iGl9N3i0HSwHFC4cJMRhnfmustARkI/R6UGN4N na/5R8h3UUUteVucyyX1gkUklTjjUPxBp1W7I04N7avGUxTDi/jh+ngIWtylnxn6fr/4 rdar9UjpoxwdzGZk6gAMdjYNQxK+WOlxq2y5b2AAfjnu2p/zeTXMENmnw6t2UDXkxRQE hU6w== X-Gm-Message-State: AOJu0Yxzjol/csYhePZClnentwlIsd4/FF8hsmpHd/hS+EVKepTydQT4 LN+O5V8JArnxII8VJO3Pzl1IepNMBsPcgA== X-Google-Smtp-Source: AGHT+IFTPVrAnUWjjhREw0Hvr2AR0rY8UkvdcnI2CamAN17ipmhg22bz+NrpSLLjzXAWDFV8FZHQ6Q== X-Received: by 2002:a6b:dd0b:0:b0:791:16ba:d764 with SMTP id f11-20020a6bdd0b000000b0079116bad764mr18373492ioc.16.1694026955566; Wed, 06 Sep 2023 12:02:35 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:35 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Greg Kroah-Hartman Subject: [PATCH v3 5/5] drm/Makefile: use correct ccflags-y syntax Date: Wed, 6 Sep 2023 13:02:23 -0600 Message-ID: <20230906190224.583577-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE when needed, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=3DY CONFIG_DYNAMIC_DEBUG_CORE=3DY CONFIG_DYNAMIC_DEBUG=3DN Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factor= y macro") Signed-off-by: Jim Cromie --- drivers/gpu/drm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 7a09a89b493b..013cde886326 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -3,7 +3,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. =20 -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE =20 drm-y :=3D \ drm_aperture.o \ --=20 2.41.0