From nobody Mon Feb 9 15:26:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737B0C71153 for ; Tue, 5 Sep 2023 00:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242829AbjIEAK0 (ORCPT ); Mon, 4 Sep 2023 20:10:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242831AbjIEAKW (ORCPT ); Mon, 4 Sep 2023 20:10:22 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CBB31712 for ; Mon, 4 Sep 2023 17:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693872599; x=1725408599; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=gcIIuTgtOMJEZvwbXHJ6P3esiHEE8x1c6wWwwWr22zw=; b=HJyG8u4/2i6WVvniXCi7Cpzwa4w4oRLIoE1AmqCq6/1hs2Ng5Zr6HHHI yblRMAwganx+MhvBTtlr6kiOGoDtF7O6mK1dlUz4doFdecHFxtf6RN5vl FAM+6AgKTNc3j9takVUjHvgJPPFZsJu+Em4aoHeTag6D6OkRNqwiQUoL0 usIkKmAdPuwuu69Xs7ks00sAI/nN0DDPZLV0//CEmhc+8UmpDo1wndoTn JdrxrfRliDaSBlljIyAt6n/cR7aMp5UipRlrfjow16ssNAXB2Ml8jrD4K o3cWEculgdozj5LhqZNQf+bTvGJjbTYu1Yq6c+p5+zgYPjbb+PZDupEJe Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="463039963" X-IronPort-AV: E=Sophos;i="6.02,227,1688454000"; d="scan'208";a="463039963" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 17:09:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="884125114" X-IronPort-AV: E=Sophos;i="6.02,227,1688454000"; d="scan'208";a="884125114" Received: from kechen-optiplex-9020.bj.intel.com ([10.238.157.62]) by fmsmga001.fm.intel.com with ESMTP; 04 Sep 2023 17:09:50 -0700 From: Tina Zhang To: Jason Gunthorpe , Kevin Tian , Lu Baolu Cc: Michael Shavit , Vasant Hegde , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Tina Zhang Subject: [PATCH v3 2/6] iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm() Date: Tue, 5 Sep 2023 08:09:26 +0800 Message-Id: <20230905000930.24515-3-tina.zhang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230905000930.24515-1-tina.zhang@intel.com> References: <20230905000930.24515-1-tina.zhang@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The pasid is passed in as a parameter through .set_dev_pasid() callback. Thus, intel_sva_bind_mm() can directly use it instead of retrieving the pasid value from mm->pasid. Suggested-by: Lu Baolu Signed-off-by: Tina Zhang --- drivers/iommu/intel/svm.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index e95b339e9cdc..3527f8833d84 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -298,21 +298,22 @@ static int pasid_to_svm_sdev(struct device *dev, unsi= gned int pasid, } =20 static int intel_svm_bind_mm(struct intel_iommu *iommu, struct device *dev, - struct mm_struct *mm) + struct iommu_domain *domain, ioasid_t pasid) { struct device_domain_info *info =3D dev_iommu_priv_get(dev); + struct mm_struct *mm =3D domain->mm; struct intel_svm_dev *sdev; struct intel_svm *svm; unsigned long sflags; int ret =3D 0; =20 - svm =3D pasid_private_find(mm->pasid); + svm =3D pasid_private_find(pasid); if (!svm) { svm =3D kzalloc(sizeof(*svm), GFP_KERNEL); if (!svm) return -ENOMEM; =20 - svm->pasid =3D mm->pasid; + svm->pasid =3D pasid; svm->mm =3D mm; INIT_LIST_HEAD_RCU(&svm->devs); =20 @@ -350,7 +351,7 @@ static int intel_svm_bind_mm(struct intel_iommu *iommu,= struct device *dev, =20 /* Setup the pasid table: */ sflags =3D cpu_feature_enabled(X86_FEATURE_LA57) ? PASID_FLAG_FL5LP : 0; - ret =3D intel_pasid_setup_first_level(iommu, dev, mm->pgd, mm->pasid, + ret =3D intel_pasid_setup_first_level(iommu, dev, mm->pgd, pasid, FLPT_DEFAULT_DID, sflags); if (ret) goto free_sdev; @@ -364,7 +365,7 @@ static int intel_svm_bind_mm(struct intel_iommu *iommu,= struct device *dev, free_svm: if (list_empty(&svm->devs)) { mmu_notifier_unregister(&svm->notifier, mm); - pasid_private_remove(mm->pasid); + pasid_private_remove(pasid); kfree(svm); } =20 @@ -839,11 +840,10 @@ static int intel_svm_set_dev_pasid(struct iommu_domai= n *domain, { struct device_domain_info *info =3D dev_iommu_priv_get(dev); struct intel_iommu *iommu =3D info->iommu; - struct mm_struct *mm =3D domain->mm; int ret; =20 mutex_lock(&pasid_mutex); - ret =3D intel_svm_bind_mm(iommu, dev, mm); + ret =3D intel_svm_bind_mm(iommu, dev, domain, pasid); mutex_unlock(&pasid_mutex); =20 return ret; --=20 2.17.1