From nobody Mon Feb 9 01:00:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2558CC83F33 for ; Mon, 4 Sep 2023 08:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352645AbjIDI5F (ORCPT ); Mon, 4 Sep 2023 04:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352604AbjIDI46 (ORCPT ); Mon, 4 Sep 2023 04:56:58 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50F9A133; Mon, 4 Sep 2023 01:56:54 -0700 (PDT) Received: from dggpemm500012.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RfMrV1RfSzTm9p; Mon, 4 Sep 2023 16:54:18 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 4 Sep 2023 16:56:51 +0800 From: Xingui Yang To: , , , CC: , , , , , , , , , , , , , , , , Subject: [PATCH v5 1/3] seq_file: Add helper macro to define attribute for rw file Date: Mon, 4 Sep 2023 08:48:02 +0000 Message-ID: <20230904084804.39564-2-yangxingui@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230904084804.39564-1-yangxingui@huawei.com> References: <20230904084804.39564-1-yangxingui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute for read-only file, but many of drivers want a helper macro for read-write file too. So we add DEFINE_SHOW_STORE_ATTRIBUTE helper to reduce duplicated code. Signed-off-by: Luo Jiaxing Signed-off-by: Xingui Yang Reviewed-by: Andy Shevchenko --- include/linux/seq_file.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h index bd023dd38ae6..e400007e410c 100644 --- a/include/linux/seq_file.h +++ b/include/linux/seq_file.h @@ -207,6 +207,21 @@ static const struct file_operations __name ## _fops = =3D { \ .release =3D single_release, \ } =20 +#define DEFINE_SHOW_STORE_ATTRIBUTE(__name) \ +static int __name ## _open(struct inode *inode, struct file *file) \ +{ \ + return single_open(file, __name ## _show, inode->i_private); \ +} \ + \ +static const struct file_operations __name ## _fops =3D { \ + .owner =3D THIS_MODULE, \ + .open =3D __name ## _open, \ + .read =3D seq_read, \ + .write =3D __name ## _write, \ + .llseek =3D seq_lseek, \ + .release =3D single_release, \ +} + #define DEFINE_PROC_SHOW_ATTRIBUTE(__name) \ static int __name ## _open(struct inode *inode, struct file *file) \ { \ --=20 2.17.1 From nobody Mon Feb 9 01:00:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0BDC83F33 for ; Mon, 4 Sep 2023 08:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232757AbjIDI5A (ORCPT ); Mon, 4 Sep 2023 04:57:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238563AbjIDI45 (ORCPT ); Mon, 4 Sep 2023 04:56:57 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B67131; Mon, 4 Sep 2023 01:56:54 -0700 (PDT) Received: from dggpemm500012.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RfMsQ4lCtzrSSZ; Mon, 4 Sep 2023 16:55:06 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 4 Sep 2023 16:56:52 +0800 From: Xingui Yang To: , , , CC: , , , , , , , , , , , , , , , , Subject: [PATCH v5 2/3] scsi: hisi_sas: Use DEFINE_SHOW_STORE_ATTRIBUTE helper for debugfs Date: Mon, 4 Sep 2023 08:48:03 +0000 Message-ID: <20230904084804.39564-3-yangxingui@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230904084804.39564-1-yangxingui@huawei.com> References: <20230904084804.39564-1-yangxingui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use DEFINE_SHOW_STORE_ATTRIBUTE helper for read-write file to reduce some duplicated code. Signed-off-by: Luo Jiaxing Signed-off-by: Xingui Yang Reviewed-by: Andy Shevchenko --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 137 ++----------------------- 1 file changed, 9 insertions(+), 128 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index bbb64ee6afd7..5bb35c3ea4e5 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -3990,22 +3990,7 @@ static ssize_t debugfs_bist_linkrate_v3_hw_write(str= uct file *filp, =20 return count; } - -static int debugfs_bist_linkrate_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_linkrate_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_linkrate_v3_hw_fops =3D { - .open =3D debugfs_bist_linkrate_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_linkrate_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_linkrate_v3_hw); =20 static const struct { int value; @@ -4080,22 +4065,7 @@ static ssize_t debugfs_bist_code_mode_v3_hw_write(st= ruct file *filp, =20 return count; } - -static int debugfs_bist_code_mode_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_code_mode_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_code_mode_v3_hw_fops =3D { - .open =3D debugfs_bist_code_mode_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_code_mode_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_code_mode_v3_hw); =20 static ssize_t debugfs_bist_phy_v3_hw_write(struct file *filp, const char __user *buf, @@ -4129,22 +4099,7 @@ static int debugfs_bist_phy_v3_hw_show(struct seq_fi= le *s, void *p) =20 return 0; } - -static int debugfs_bist_phy_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_phy_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_phy_v3_hw_fops =3D { - .open =3D debugfs_bist_phy_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_phy_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_phy_v3_hw); =20 static ssize_t debugfs_bist_cnt_v3_hw_write(struct file *filp, const char __user *buf, @@ -4177,22 +4132,7 @@ static int debugfs_bist_cnt_v3_hw_show(struct seq_fi= le *s, void *p) =20 return 0; } - -static int debugfs_bist_cnt_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_cnt_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_cnt_v3_hw_ops =3D { - .open =3D debugfs_bist_cnt_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_cnt_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_cnt_v3_hw); =20 static const struct { int value; @@ -4256,22 +4196,7 @@ static ssize_t debugfs_bist_mode_v3_hw_write(struct = file *filp, =20 return count; } - -static int debugfs_bist_mode_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_mode_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_mode_v3_hw_fops =3D { - .open =3D debugfs_bist_mode_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_mode_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_mode_v3_hw); =20 static ssize_t debugfs_bist_enable_v3_hw_write(struct file *filp, const char __user *buf, @@ -4309,22 +4234,7 @@ static int debugfs_bist_enable_v3_hw_show(struct seq= _file *s, void *p) =20 return 0; } - -static int debugfs_bist_enable_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_bist_enable_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_bist_enable_v3_hw_fops =3D { - .open =3D debugfs_bist_enable_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_bist_enable_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_bist_enable_v3_hw); =20 static const struct { char *name; @@ -4362,21 +4272,7 @@ static int debugfs_v3_hw_show(struct seq_file *s, vo= id *p) =20 return 0; } - -static int debugfs_v3_hw_open(struct inode *inode, struct file *filp) -{ - return single_open(filp, debugfs_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_v3_hw_fops =3D { - .open =3D debugfs_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_v3_hw); =20 static ssize_t debugfs_phy_down_cnt_v3_hw_write(struct file *filp, const char __user *buf, @@ -4407,22 +4303,7 @@ static int debugfs_phy_down_cnt_v3_hw_show(struct se= q_file *s, void *p) =20 return 0; } - -static int debugfs_phy_down_cnt_v3_hw_open(struct inode *inode, - struct file *filp) -{ - return single_open(filp, debugfs_phy_down_cnt_v3_hw_show, - inode->i_private); -} - -static const struct file_operations debugfs_phy_down_cnt_v3_hw_fops =3D { - .open =3D debugfs_phy_down_cnt_v3_hw_open, - .read =3D seq_read, - .write =3D debugfs_phy_down_cnt_v3_hw_write, - .llseek =3D seq_lseek, - .release =3D single_release, - .owner =3D THIS_MODULE, -}; +DEFINE_SHOW_STORE_ATTRIBUTE(debugfs_phy_down_cnt_v3_hw); =20 enum fifo_dump_mode_v3_hw { FIFO_DUMP_FORVER =3D (1U << 0), @@ -4832,7 +4713,7 @@ static void debugfs_bist_init_v3_hw(struct hisi_hba *= hisi_hba) hisi_hba, &debugfs_bist_phy_v3_hw_fops); =20 debugfs_create_file("cnt", 0600, hisi_hba->debugfs_bist_dentry, - hisi_hba, &debugfs_bist_cnt_v3_hw_ops); + hisi_hba, &debugfs_bist_cnt_v3_hw_fops); =20 debugfs_create_file("loopback_mode", 0600, hisi_hba->debugfs_bist_dentry, --=20 2.17.1 From nobody Mon Feb 9 01:00:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5129CCA0FF7 for ; Mon, 4 Sep 2023 08:57:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352615AbjIDI5D (ORCPT ); Mon, 4 Sep 2023 04:57:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352617AbjIDI46 (ORCPT ); Mon, 4 Sep 2023 04:56:58 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4450312A; Mon, 4 Sep 2023 01:56:54 -0700 (PDT) Received: from dggpemm500012.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RfMsR4Ddgz1M93t; Mon, 4 Sep 2023 16:55:07 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 4 Sep 2023 16:56:52 +0800 From: Xingui Yang To: , , , CC: , , , , , , , , , , , , , , , , Subject: [PATCH v5 3/3] scsi: qla2xxx: Use DEFINE_SHOW_STORE_ATTRIBUTE helper for debugfs Date: Mon, 4 Sep 2023 08:48:04 +0000 Message-ID: <20230904084804.39564-4-yangxingui@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230904084804.39564-1-yangxingui@huawei.com> References: <20230904084804.39564-1-yangxingui@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use DEFINE_SHOW_STORE_ATTRIBUTE helper for read-write file to reduce some duplicated code and delete unused macros. Signed-off-by: Luo Jiaxing Signed-off-by: Xingui Yang --- drivers/scsi/qla2xxx/qla_dfs.c | 113 +-------------------------------- 1 file changed, 2 insertions(+), 111 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c index f060e593685d..fca01d551876 100644 --- a/drivers/scsi/qla2xxx/qla_dfs.c +++ b/drivers/scsi/qla2xxx/qla_dfs.c @@ -505,107 +505,6 @@ qla_dfs_naqp_show(struct seq_file *s, void *unused) return 0; } =20 -/* - * Helper macros for setting up debugfs entries. - * _name: The name of the debugfs entry - * _ctx_struct: The context that was passed when creating the debugfs file - * - * QLA_DFS_SETUP_RD could be used when there is only a show function. - * - show function take the name qla_dfs__show - * - * QLA_DFS_SETUP_RW could be used when there are both show and write funct= ions. - * - show function take the name qla_dfs__show - * - write function take the name qla_dfs__write - * - * To have a new debugfs entry, do: - * 1. Create a "struct dentry *" in the appropriate structure in the format - * dfs_ - * 2. Setup debugfs entries using QLA_DFS_SETUP_RD / QLA_DFS_SETUP_RW - * 3. Create debugfs file in qla2x00_dfs_setup() using QLA_DFS_CREATE_FILE - * or QLA_DFS_ROOT_CREATE_FILE - * 4. Remove debugfs file in qla2x00_dfs_remove() using QLA_DFS_REMOVE_FILE - * or QLA_DFS_ROOT_REMOVE_FILE - * - * Example for creating "TEST" sysfs file: - * 1. struct qla_hw_data { ... struct dentry *dfs_TEST; } - * 2. QLA_DFS_SETUP_RD(TEST, scsi_qla_host_t); - * 3. In qla2x00_dfs_setup(): - * QLA_DFS_CREATE_FILE(ha, TEST, 0600, ha->dfs_dir, vha); - * 4. In qla2x00_dfs_remove(): - * QLA_DFS_REMOVE_FILE(ha, TEST); - */ -#define QLA_DFS_SETUP_RD(_name, _ctx_struct) \ -static int \ -qla_dfs_##_name##_open(struct inode *inode, struct file *file) \ -{ \ - _ctx_struct *__ctx =3D inode->i_private; \ - \ - return single_open(file, qla_dfs_##_name##_show, __ctx); \ -} \ - \ -static const struct file_operations qla_dfs_##_name##_ops =3D { \ - .open =3D qla_dfs_##_name##_open, \ - .read =3D seq_read, \ - .llseek =3D seq_lseek, \ - .release =3D single_release, \ -}; - -#define QLA_DFS_SETUP_RW(_name, _ctx_struct) \ -static int \ -qla_dfs_##_name##_open(struct inode *inode, struct file *file) \ -{ \ - _ctx_struct *__ctx =3D inode->i_private; \ - \ - return single_open(file, qla_dfs_##_name##_show, __ctx); \ -} \ - \ -static const struct file_operations qla_dfs_##_name##_ops =3D { \ - .open =3D qla_dfs_##_name##_open, \ - .read =3D seq_read, \ - .llseek =3D seq_lseek, \ - .release =3D single_release, \ - .write =3D qla_dfs_##_name##_write, \ -}; - -#define QLA_DFS_ROOT_CREATE_FILE(_name, _perm, _ctx) \ - do { \ - if (!qla_dfs_##_name) \ - qla_dfs_##_name =3D debugfs_create_file(#_name, \ - _perm, qla2x00_dfs_root, _ctx, \ - &qla_dfs_##_name##_ops); \ - } while (0) - -#define QLA_DFS_ROOT_REMOVE_FILE(_name) \ - do { \ - if (qla_dfs_##_name) { \ - debugfs_remove(qla_dfs_##_name); \ - qla_dfs_##_name =3D NULL; \ - } \ - } while (0) - -#define QLA_DFS_CREATE_FILE(_struct, _name, _perm, _parent, _ctx) \ - do { \ - (_struct)->dfs_##_name =3D debugfs_create_file(#_name, \ - _perm, _parent, _ctx, \ - &qla_dfs_##_name##_ops) \ - } while (0) - -#define QLA_DFS_REMOVE_FILE(_struct, _name) \ - do { \ - if ((_struct)->dfs_##_name) { \ - debugfs_remove((_struct)->dfs_##_name); \ - (_struct)->dfs_##_name =3D NULL; \ - } \ - } while (0) - -static int -qla_dfs_naqp_open(struct inode *inode, struct file *file) -{ - struct scsi_qla_host *vha =3D inode->i_private; - - return single_open(file, qla_dfs_naqp_show, vha); -} - static ssize_t qla_dfs_naqp_write(struct file *file, const char __user *buffer, size_t count, loff_t *pos) @@ -653,15 +552,7 @@ qla_dfs_naqp_write(struct file *file, const char __use= r *buffer, kfree(buf); return rc; } - -static const struct file_operations dfs_naqp_ops =3D { - .open =3D qla_dfs_naqp_open, - .read =3D seq_read, - .llseek =3D seq_lseek, - .release =3D single_release, - .write =3D qla_dfs_naqp_write, -}; - +DEFINE_SHOW_STORE_ATTRIBUTE(qla_dfs_naqp); =20 int qla2x00_dfs_setup(scsi_qla_host_t *vha) @@ -707,7 +598,7 @@ qla2x00_dfs_setup(scsi_qla_host_t *vha) =20 if (IS_QLA27XX(ha) || IS_QLA83XX(ha) || IS_QLA28XX(ha)) { ha->tgt.dfs_naqp =3D debugfs_create_file("naqp", - 0400, ha->dfs_dir, vha, &dfs_naqp_ops); + 0400, ha->dfs_dir, vha, &qla_dfs_naqp_fops); if (!ha->tgt.dfs_naqp) { ql_log(ql_log_warn, vha, 0xd011, "Unable to create debugFS naqp node.\n"); --=20 2.17.1