From nobody Tue Dec 16 04:06:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40455CA0FE3 for ; Sun, 3 Sep 2023 21:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348870AbjICV3u (ORCPT ); Sun, 3 Sep 2023 17:29:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348523AbjICV3p (ORCPT ); Sun, 3 Sep 2023 17:29:45 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35EAC106 for ; Sun, 3 Sep 2023 14:29:41 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-500a398cda5so1459776e87.0 for ; Sun, 03 Sep 2023 14:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693776579; x=1694381379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OrvqJ3c9sQ1JCB3sZd7945Qvt9YqGwY/lI1sp/YeO8w=; b=XjK0ONzz5gTCLQ4AYbcq7YwbIx5fTfzQUkYCPVac5u7pF+90+zGoKb7BG+vfB8YR2/ 699RyqUqdXtN5JCtX4+kRmUUpPfvFpZNdBIIlREqVNJojdjgI0HSEGwwQ/4IlF8gmedz bid1WnciiddGdwUVA2wm8+cIYg1PIrxiKtRAUIcCpng3MlTqPUEybyzTaKUMz51v1q9a 9pghlNhecCIDNvPQLeXrFzdBJ/6pCFCOpGHh3NqGggvY7CF9tD0IFNL+2tvYTzBMemDK 11bN5ZxyI1lQ56vW85QLGtDRW9uQIkxAQ5u23QFUnXCU0JwK4tY5a7/nEx9ycZgE3QJH xEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693776579; x=1694381379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OrvqJ3c9sQ1JCB3sZd7945Qvt9YqGwY/lI1sp/YeO8w=; b=PIEFHi0jC4hc2HGQhgSTLFyAlXzbkoiAZ7pZPdEFjMi9XCDT2Ha5sXFsn2rXPkHhUB 3bV7C4RhaXi7Ttn1VUvV+V3G4lFcSY8BM10x8BfRm+8HZfxJN6e/KxW2ORwo36vJe7TK NAyIvtk1f3aUqv2ggE0JNotC38kTkIesZQ5n4cxdbs6mtmKeFVTu/DBZq7v4jjeBk2G3 tuQoT26tymwRCe1HOPo9ZakZ1TVcX/WRMjsLBJhMMXib9FgUnnXhzi6fgIhD9ziLciLh 5V6QJLSU+56dFboeDS/0y1XNYWnPoZoUlI/EJouYWYb7zqJ3F/PkSAXmbQr0kgoBbZTu zp4g== X-Gm-Message-State: AOJu0Yz9ODVab1Cy0iLk/dsahHeAhO8M1IpCsF98cB+kVIswuC5UpgJV 8Ntth/lgceFqpv1BdY2IKWctKw== X-Google-Smtp-Source: AGHT+IG8Jmh8P0iyl44gIl9qubzKl5aZ/eUbSsytTsFO7kh8ocYNSpfL5nu8e1Ica3/jCzLsKZTtmw== X-Received: by 2002:a05:6512:238d:b0:4fe:181f:2736 with SMTP id c13-20020a056512238d00b004fe181f2736mr6211669lfv.33.1693776579452; Sun, 03 Sep 2023 14:29:39 -0700 (PDT) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id eq11-20020a056512488b00b004ff8d9ed368sm1412352lfb.258.2023.09.03.14.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 14:29:39 -0700 (PDT) From: Dmitry Baryshkov To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Simon Ser , Janne Grunau , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Bjorn Andersson , Hans de Goede Subject: [PATCH v7 1/3] drm: Add HPD state to drm_connector_oob_hotplug_event() Date: Mon, 4 Sep 2023 00:29:35 +0300 Message-Id: <20230903212937.2876815-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> References: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Bjorn Andersson In some implementations, such as the Qualcomm platforms, the display driver has no way to query the current HPD state and as such it's impossible to distinguish between disconnect and attention events. Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD state. Also push the test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson Reviewed-by: Hans de Goede Acked-by: Heikki Krogerus Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_connector.c | 6 ++++-- .../gpu/drm/i915/display/intel_display_core.h | 3 +++ drivers/gpu/drm/i915/display/intel_dp.c | 17 ++++++++++++++--- drivers/usb/typec/altmodes/displayport.c | 17 +++++++++-------- include/drm/drm_connector.h | 6 ++++-- 5 files changed, 34 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index c44d5bcf1284..05fc29a54801 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -3051,6 +3051,7 @@ struct drm_connector *drm_connector_find_by_fwnode(st= ruct fwnode_handle *fwnode) /** * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to c= onnector * @connector_fwnode: fwnode_handle to report the event on + * @status: hot plug detect logical state * * On some hardware a hotplug event notification may come from outside the= display * driver / device. An example of this is some USB Type-C setups where the= hardware @@ -3060,7 +3061,8 @@ struct drm_connector *drm_connector_find_by_fwnode(st= ruct fwnode_handle *fwnode) * This function can be used to report these out-of-band events after obta= ining * a drm_connector reference through calling drm_connector_find_by_fwnode(= ). */ -void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnod= e) +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnod= e, + enum drm_connector_status status) { struct drm_connector *connector; =20 @@ -3069,7 +3071,7 @@ void drm_connector_oob_hotplug_event(struct fwnode_ha= ndle *connector_fwnode) return; =20 if (connector->funcs->oob_hotplug_event) - connector->funcs->oob_hotplug_event(connector); + connector->funcs->oob_hotplug_event(connector, status); =20 drm_connector_put(connector); } diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gp= u/drm/i915/display/intel_display_core.h index 53e5c33e08c3..ccfe27630fb6 100644 --- a/drivers/gpu/drm/i915/display/intel_display_core.h +++ b/drivers/gpu/drm/i915/display/intel_display_core.h @@ -175,6 +175,9 @@ struct intel_hotplug { /* Whether or not to count short HPD IRQs in HPD storms */ u8 hpd_short_storm_enabled; =20 + /* Last state reported by oob_hotplug_event for each encoder */ + unsigned long oob_hotplug_last_state; + /* * if we get a HPD irq from DP and a HPD irq from non-DP * the non-DP HPD could block the workqueue on a mode config diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915= /display/intel_dp.c index 12bd2f322e62..2af815b5c22b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5253,15 +5253,26 @@ static int intel_dp_connector_atomic_check(struct d= rm_connector *conn, return intel_modeset_synced_crtcs(state, conn); } =20 -static void intel_dp_oob_hotplug_event(struct drm_connector *connector) +static void intel_dp_oob_hotplug_event(struct drm_connector *connector, + enum drm_connector_status hpd_state) { struct intel_encoder *encoder =3D intel_attached_encoder(to_intel_connect= or(connector)); struct drm_i915_private *i915 =3D to_i915(connector->dev); + bool hpd_high =3D hpd_state =3D=3D connector_status_connected; + unsigned int hpd_pin =3D encoder->hpd_pin; + bool need_work =3D false; =20 spin_lock_irq(&i915->irq_lock); - i915->display.hotplug.event_bits |=3D BIT(encoder->hpd_pin); + if (hpd_high !=3D test_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_la= st_state)) { + i915->display.hotplug.event_bits |=3D BIT(hpd_pin); + + __assign_bit(hpd_pin, &i915->display.hotplug.oob_hotplug_last_state, hpd= _high); + need_work =3D true; + } spin_unlock_irq(&i915->irq_lock); - queue_delayed_work(i915->unordered_wq, &i915->display.hotplug.hotplug_wor= k, 0); + + if (need_work) + queue_delayed_work(i915->unordered_wq, &i915->display.hotplug.hotplug_wo= rk, 0); } =20 static const struct drm_connector_funcs intel_dp_connector_funcs =3D { diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/a= ltmodes/displayport.c index 426c88a516e5..29f40e658772 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -153,11 +153,11 @@ static int dp_altmode_status_update(struct dp_altmode= *dp) } } } else { - if (dp->hpd !=3D hpd) { - drm_connector_oob_hotplug_event(dp->connector_fwnode); - dp->hpd =3D hpd; - sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); - } + drm_connector_oob_hotplug_event(dp->connector_fwnode, + hpd ? connector_status_connected : + connector_status_disconnected); + dp->hpd =3D hpd; + sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); } =20 return ret; @@ -173,7 +173,8 @@ static int dp_altmode_configured(struct dp_altmode *dp) * configuration is complete to signal HPD. */ if (dp->pending_hpd) { - drm_connector_oob_hotplug_event(dp->connector_fwnode); + drm_connector_oob_hotplug_event(dp->connector_fwnode, + connector_status_connected); sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd"); dp->pending_hpd =3D false; } @@ -618,8 +619,8 @@ void dp_altmode_remove(struct typec_altmode *alt) cancel_work_sync(&dp->work); =20 if (dp->connector_fwnode) { - if (dp->hpd) - drm_connector_oob_hotplug_event(dp->connector_fwnode); + drm_connector_oob_hotplug_event(dp->connector_fwnode, + connector_status_disconnected); =20 fwnode_handle_put(dp->connector_fwnode); } diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index d300fde6c1a4..5a8115dca359 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -1327,7 +1327,8 @@ struct drm_connector_funcs { * This will get called when a hotplug-event for a drm-connector * has been received from a source outside the display driver / device. */ - void (*oob_hotplug_event)(struct drm_connector *connector); + void (*oob_hotplug_event)(struct drm_connector *connector, + enum drm_connector_status status); =20 /** * @debugfs_init: @@ -1971,7 +1972,8 @@ drm_connector_is_unregistered(struct drm_connector *c= onnector) DRM_CONNECTOR_UNREGISTERED; } =20 -void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnod= e); +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnod= e, + enum drm_connector_status status); const char *drm_get_connector_type_name(unsigned int connector_type); const char *drm_get_connector_status_name(enum drm_connector_status status= ); const char *drm_get_subpixel_order_name(enum subpixel_order order); --=20 2.39.2 From nobody Tue Dec 16 04:06:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F258CA0FF6 for ; Sun, 3 Sep 2023 21:29:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348802AbjICV3t (ORCPT ); Sun, 3 Sep 2023 17:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjICV3q (ORCPT ); Sun, 3 Sep 2023 17:29:46 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F591E5 for ; Sun, 3 Sep 2023 14:29:42 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500c37d479aso1277729e87.2 for ; Sun, 03 Sep 2023 14:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693776580; x=1694381380; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LTYtN9ceXzi2tGhWn5q5e7ybJcm3lf5yDMeSzJkSqgc=; b=oN1qyjNhPGdRsawgrQHtWWYdDlemWn3CPoDeosfFzdg7YHrqq/uvBrE+jWZfgJE6oo hEdkIKhFNGS4BJ6PfGTMvmoGuJrl+5BwvzyCh/Q/TMesGiebj+fFQBVo1QsUlunVgOK1 6ccNUSappj4mFhHj2YkWa4b1vTgCiyQhWZf27lal6wmkD6O8hB4T2joz98ghBkvaf/cA e8IfMi54Tdl3ab7S5CSzF+/8+PcKuoFSiF+m1ttHOtJSY2Wk6+PYGm4kJu/LllqtM1Z/ pdM5wa2w7Z7LRvz+BftSbj7bmqY1TuhIMqPo8T4uLn/pce7/rPR1vEg5nHVDHAdLG97v rl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693776580; x=1694381380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LTYtN9ceXzi2tGhWn5q5e7ybJcm3lf5yDMeSzJkSqgc=; b=LmfK7aoi7E+0t9swOwPaBBjJeCsZrUJUbAxMR3YAPWxZvBD38+k4F1D+Z7OyDY7up0 zvTid8dNi8P6H+uhpx1c9kO9Od8ezGYTx64ciX0opljPOJAZ5t7I5DGalePchijglMEM kJKXrPmCHz05EbdotMJxdG/9dwpnTx/P16Z/BcRGt1qgLjgupiOZnI8uZxR0dg+v64MI 4JCDuaWMb1rrAVMOr/rXErt7pLurjIKy4q6Ua6rM2gDHvBqBmq3/uuutJ6LrPE2MP10D e/mc5Z6kGTANpfDkyWKdfVqSgNf5EBjXCAnWHDALa0nQpg+E5/YdGV8Pvsyr61dl3Xhb 3DuQ== X-Gm-Message-State: AOJu0YwVsElyUdiN0BE6A6m9CpseiHt0fnB2XbiMHDJeLVes/Kx4s5vl kJSdIt4JD8+tCDvMmIlpG8WfMA== X-Google-Smtp-Source: AGHT+IHhuu1XpaE+PO25+uVWIsSs6HgoMj+d3EKB5ectySV1k+e2KdlfTqc8aDVm4kOQSBo9dpyfxQ== X-Received: by 2002:ac2:58ca:0:b0:4f4:d071:be48 with SMTP id u10-20020ac258ca000000b004f4d071be48mr4760118lfo.14.1693776580258; Sun, 03 Sep 2023 14:29:40 -0700 (PDT) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id eq11-20020a056512488b00b004ff8d9ed368sm1412352lfb.258.2023.09.03.14.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 14:29:39 -0700 (PDT) From: Dmitry Baryshkov To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Simon Ser , Janne Grunau , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v7 2/3] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb() Date: Mon, 4 Sep 2023 00:29:36 +0300 Message-Id: <20230903212937.2876815-3-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> References: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In some cases the bridge drivers would like to receive hotplug events even in the case new status is equal to the old status. In the DP case this is used to deliver "attention" messages to the DP host. Stop filtering the events in the drm_bridge_connector_hpd_cb() and let drivers decide whether they would like to receive the event or not. Reviewed-By: Janne Grunau Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_b= ridge_connector.c index 1da93d5a1f61..10b52224db37 100644 --- a/drivers/gpu/drm/drm_bridge_connector.c +++ b/drivers/gpu/drm/drm_bridge_connector.c @@ -113,16 +113,11 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, struct drm_bridge_connector *drm_bridge_connector =3D cb_data; struct drm_connector *connector =3D &drm_bridge_connector->base; struct drm_device *dev =3D connector->dev; - enum drm_connector_status old_status; =20 mutex_lock(&dev->mode_config.mutex); - old_status =3D connector->status; connector->status =3D status; mutex_unlock(&dev->mode_config.mutex); =20 - if (old_status =3D=3D status) - return; - drm_bridge_connector_hpd_notify(connector, status); =20 drm_kms_helper_connector_hotplug_event(connector); --=20 2.39.2 From nobody Tue Dec 16 04:06:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6076DC83F2D for ; Sun, 3 Sep 2023 21:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348885AbjICV3z (ORCPT ); Sun, 3 Sep 2023 17:29:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348734AbjICV3r (ORCPT ); Sun, 3 Sep 2023 17:29:47 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC1AA118 for ; Sun, 3 Sep 2023 14:29:42 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-500c63c9625so1400282e87.2 for ; Sun, 03 Sep 2023 14:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693776581; x=1694381381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D5QQwEFqCct7BAxDxlOQzyh1UFNTPO5xvPloHLAel3c=; b=bhqdKSGAszqeMRe9e1IFtBKgm5fxEVdjiR9uXlqGf1NCtWNW+rdz/D09zbsUy3ZBcM VJoLeBt6yHZauCOxg3+ZusooBODWSW9Cae5vWUCoDIdvJWsJOrvRr0uBjEb+T5iDkBHF GKkL6G7eqrjiiBU0DmYG2rM49W1CgcBuXShwsC5J+UG4yj5GdA4g1mN4wiKv8VrvHhe8 h+eb3CpT8s1TjGr/UTkNsQ/kdV6i0Vi7aOh7R+L1Fg8StGCuUT0CJ7MYuxqDTM7bReeU O1kOT001/B/sreMX5c5oxU87okpG60eCwKRcxlQ1k4okr2Ep2RVetKftoPdWnB50DUuW 8W5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693776581; x=1694381381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D5QQwEFqCct7BAxDxlOQzyh1UFNTPO5xvPloHLAel3c=; b=UmO4q/zEa937hTXCmyhlTfZGwFYt24KPXo+9rmX/+JK9KWQgDv10YyrFmURhSDakJy AxTk/F2l7/mJ5AtBwIOitJuNjdf4MS1OfgtbhAhvesQfugEcPlszdQN7AjeQQcvb4SB9 QdcwzO4lvKWZOeAGPd+IkQ4jhKFXXTWJ3VuptZLMrUvtTpG8QmSdkwleytkkzA9t47ko 7xPrPlbftp75JAGYer29JdyTG+GXHmVB4t99rlf2vPabSWYHkjq2xMEvnxY/2Zg5WDBL NzcuHHnI2il3XuMzmBFM2OacVlqmkw41aHgWJj8lx1NST7XfG/o4SGFl5ylmnSVhEM0w TnOg== X-Gm-Message-State: AOJu0YyAt3DwuYMi0dIQ3WxIQV4vf72sLZID8mY4AXfwMLw42DvMoKGp H9zkjsZH25UaPFRAOKJjKGFuxw== X-Google-Smtp-Source: AGHT+IFzGUwTyKGwD7PSfbMHsP+QYUbDM5UQr/fxVIRAAFQABie93pcvAKUcK3M3a83cjojEciNiLg== X-Received: by 2002:a05:6512:1316:b0:4fb:90c6:c31a with SMTP id x22-20020a056512131600b004fb90c6c31amr6277330lfu.14.1693776581063; Sun, 03 Sep 2023 14:29:41 -0700 (PDT) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id eq11-20020a056512488b00b004ff8d9ed368sm1412352lfb.258.2023.09.03.14.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 14:29:40 -0700 (PDT) From: Dmitry Baryshkov To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Simon Ser , Janne Grunau , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v7 3/3] drm/bridge_connector: implement oob_hotplug_event Date: Mon, 4 Sep 2023 00:29:37 +0300 Message-Id: <20230903212937.2876815-4-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> References: <20230903212937.2876815-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Implement the oob_hotplug_event() callback. Translate it to the HPD notification sent to the HPD bridge in the chain. Reviewed-by: Janne Grunau Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 31 +++++++++++++++++++++++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_b= ridge_connector.c index 10b52224db37..bf73960c2c2a 100644 --- a/drivers/gpu/drm/drm_bridge_connector.c +++ b/drivers/gpu/drm/drm_bridge_connector.c @@ -5,6 +5,8 @@ =20 #include #include +#include +#include #include =20 #include @@ -107,10 +109,9 @@ static void drm_bridge_connector_hpd_notify(struct drm= _connector *connector, } } =20 -static void drm_bridge_connector_hpd_cb(void *cb_data, - enum drm_connector_status status) +static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *d= rm_bridge_connector, + enum drm_connector_status status) { - struct drm_bridge_connector *drm_bridge_connector =3D cb_data; struct drm_connector *connector =3D &drm_bridge_connector->base; struct drm_device *dev =3D connector->dev; =20 @@ -123,6 +124,21 @@ static void drm_bridge_connector_hpd_cb(void *cb_data, drm_kms_helper_connector_hotplug_event(connector); } =20 +static void drm_bridge_connector_hpd_cb(void *cb_data, + enum drm_connector_status status) +{ + drm_bridge_connector_handle_hpd(cb_data, status); +} + +static void drm_bridge_connector_oob_hotplug_event(struct drm_connector *c= onnector, + enum drm_connector_status status) +{ + struct drm_bridge_connector *bridge_connector =3D + to_drm_bridge_connector(connector); + + drm_bridge_connector_handle_hpd(bridge_connector, status); +} + static void drm_bridge_connector_enable_hpd(struct drm_connector *connecto= r) { struct drm_bridge_connector *bridge_connector =3D @@ -191,6 +207,8 @@ static void drm_bridge_connector_destroy(struct drm_con= nector *connector) drm_connector_unregister(connector); drm_connector_cleanup(connector); =20 + fwnode_handle_put(connector->fwnode); + kfree(bridge_connector); } =20 @@ -216,6 +234,7 @@ static const struct drm_connector_funcs drm_bridge_conn= ector_funcs =3D { .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, .debugfs_init =3D drm_bridge_connector_debugfs_init, + .oob_hotplug_event =3D drm_bridge_connector_oob_hotplug_event, }; =20 /* -----------------------------------------------------------------------= ------ @@ -352,6 +371,12 @@ struct drm_connector *drm_bridge_connector_init(struct= drm_device *drm, if (!drm_bridge_get_next_bridge(bridge)) connector_type =3D bridge->type; =20 +#ifdef CONFIG_OF + if (!drm_bridge_get_next_bridge(bridge) && + bridge->of_node) + connector->fwnode =3D fwnode_handle_get(of_fwnode_handle(bridge->of_nod= e)); +#endif + if (bridge->ddc) ddc =3D bridge->ddc; =20 --=20 2.39.2