From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB366CA0FF6 for ; Sun, 3 Sep 2023 18:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344623AbjICSqU (ORCPT ); Sun, 3 Sep 2023 14:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245584AbjICSqS (ORCPT ); Sun, 3 Sep 2023 14:46:18 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0557110A for ; Sun, 3 Sep 2023 11:46:14 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-79564282cb1so26011239f.2 for ; Sun, 03 Sep 2023 11:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766773; x=1694371573; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=Dpk+pRW1/F5QDjr/xY35K0j2nPGFeux0fNw2MUYoFWMmAKCsF1DKJDjvBc88vc50Jy Nd1fNeMIg7vdiH/Jka4Wg0EPArGPzHz9XSoQtRsAgF304NNjuISrms956Ivec4Ih/0nf iuIERRt6NmLCin82QRPIPhVYxWJayCAbAmJa+oea8xUfbmOA2k5ZHZ2KHlZ2h6bSWyjl qIFJ7MHKA2dMbGHxr8X0PaucRPTPZV3qFyTPwGWyaJ7SV2JFl3wQZlCMvW2T0/DQ4K6M qoXsiYuN8Gqq5vKKU9dAz9aCQMikogbX+vxd3vRoosvhrUWGSGirEeU06ENZCnXuPafb Dkkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766773; x=1694371573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=D7gQ8wjLD9UoAV3Dpmskas4w7S67GTbFpmoIE605RN/kG9jx+j8F9l3NSd6jIx9VYp JOrjjf6PakuDxPnarKSprNdhEqN9UZuKGx3znFR8t1s9lvYOjpT8XwpmUNAQimO6lZ5G n447hKA+4E7c6EvXxNcueHcEn/cP7JjySlfrPtENG+oMHsyv+AOdRjDP/dQ/0b7VDUwd yoLGyzJeoA3TsC6IyjquhP++92fkqRsRVI1udeA1voYn4vpTU3ZvCiV4Ro+K3nDdHqs7 NKFH2oHISbbj64PRp4+nLVSTwraZ5khYfLd4XKmy0bYB0oyjAOicqTV5siajrpt7tKW9 zXuw== X-Gm-Message-State: AOJu0Yzm2k188RMQBrRvdLMwP6374ZaGOKgqA3S0r5QOVIrJ6I8ujEEm Ui5rvimrRZ3O+PJZPCVzefSkZer77WEhTQ== X-Google-Smtp-Source: AGHT+IFYCmR7Iv8xnRYnf/lKtlWv1bE7hNxZ00vdtzELzd9ulSSSQd6sJ4F8ae9sGd8UtxCQOEjWOw== X-Received: by 2002:a6b:ec16:0:b0:792:82f8:6f90 with SMTP id c22-20020a6bec16000000b0079282f86f90mr9317430ioh.16.1693766773070; Sun, 03 Sep 2023 11:46:13 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:12 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: [PATCH v2 1/6] drm_dbg: add trailing newlines to msgs Date: Sun, 3 Sep 2023 12:45:58 -0600 Message-ID: <20230903184607.272198-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connecto= r.c index f28725736237..14020585bdc0 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, voi= d *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:= %s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); } =20 --=20 2.41.0 From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F9BC71153 for ; Sun, 3 Sep 2023 18:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345033AbjICSqW (ORCPT ); Sun, 3 Sep 2023 14:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343686AbjICSqT (ORCPT ); Sun, 3 Sep 2023 14:46:19 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AC4810C for ; Sun, 3 Sep 2023 11:46:15 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-34dec9c77d4so3044325ab.0 for ; Sun, 03 Sep 2023 11:46:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766774; x=1694371574; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=k3upxpdE+n3eEtG5UDvl1fWBr8ywOcY4pq6/5laEhs50V4wEVXZf6gkcWDJDOE7rXg zywgJxOJUPwMJR0KlFA5xPcJqB+z8QYCJutV0QAdHs9Uu8ZjGFDEetrEm/wNms+pz8BN ydGRb180fzgOJs1aVx40sHKXQliVREXC3oqyYN8z5uDdJc2VhJJMPLkaRKotamcRvy6k JfEZIFPTZCQ4w/h4VURANPWuK5C68u1wmqYNHm9AkbIFwON8Hp7ONhhHpBoiKdo2Z3PP XccF5RDpLkBCNPrfWWAWko3HNhQbu13/FtQYYKrRRW/oi7ZtwDX0CMh8OB5sRs+PuOPq my4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766774; x=1694371574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=Q3yI9+QFuTAQjAIUmiJg56455KDoMhBUT5WS5KZE8xI6/Q5AmMoHlIN1Ic5SHMEJFX 54rz/Lhdc5XxatZaOWRcH5uicLrOXPJ6bMnFcrGMvilVH718manY9wgH4AwQxE9gHWMA tlxA9bMcvHTWiHdwgMlqo7vztJaZ2fONFHmpbnRQT0Lb+f1L8GtiWaOYQB+epyrJLqxe Nc0PMHvsux+lXN+i47IxDFGn51COPYeuH/dHboUxa6f31lyEDdIBiZU4L7Ha+19VEsKF PEGXSeQ3MD86gVD4M1mR9j7Fu540MnkzzDI2evMgtGhc0P4rbkg3dEjSwlbsLRdgOkOQ MUHw== X-Gm-Message-State: AOJu0Yw6xXUDvvV+3xAAp5+fDW/ouBddgQNtd5bSi/hmiy8wX3hwZgr9 eU/SJM7gHdv6YGb/YZ+lczRNad2L+QS0Hg== X-Google-Smtp-Source: AGHT+IHUzoCTyhxdX6icAGEBT8dXiH/ioOo1c7WiBYkDqk/qvBXBfPW/4NAojWOMT3RGaqLcGBJwug== X-Received: by 2002:a05:6e02:964:b0:34c:abcb:97e8 with SMTP id q4-20020a056e02096400b0034cabcb97e8mr7956738ilt.24.1693766774237; Sun, 03 Sep 2023 11:46:14 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:13 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Anitha Chrisanthus , Edmund Dea , David Airlie Subject: [PATCH v2 2/6] drm_dbg: add trailing newlines to msgs Date: Sun, 3 Sep 2023 12:45:59 -0600 Message-ID: <20230903184607.272198-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch =3D 0; vm.hsync_len =3D 28; =20 - drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d", + drm_dbg(dev, "%s : %dactive height=3D %d vbp=3D%d vfp=3D%d vsync-w=3D%d h= -active=3D%d h-bp=3D%d h-fp=3D%d hsync-l=3D%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp =3D mode->vsync_start - mode->vdisplay; =20 if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height =3D %d less than %d", + drm_dbg(dev, "height =3D %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width =3D %d less than %d", + drm_dbg(dev, "width =3D %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh =3D drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh =3D %d less than %d or greater than %d", + drm_dbg(dev, "refresh =3D %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } =20 if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp =3D %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp =3D %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } =20 diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plan= e.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *= plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format !=3D format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configurati= on\n"); return -EINVAL; } for (i =3D 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *pla= ne, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width !=3D fb->width || init_disp_cfg.height !=3D fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial co= nfiguration\n"); return -EINVAL; } can_position =3D (plane->type =3D=3D DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *p= lane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); --=20 2.41.0 From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28553C83F2C for ; Sun, 3 Sep 2023 18:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345297AbjICSqX (ORCPT ); Sun, 3 Sep 2023 14:46:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345063AbjICSqW (ORCPT ); Sun, 3 Sep 2023 14:46:22 -0400 Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D41E106 for ; Sun, 3 Sep 2023 11:46:19 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-34e15f33a72so2712725ab.3 for ; Sun, 03 Sep 2023 11:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766778; x=1694371578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NxH9YviFYJ/sVQ921jdxmjDcbIQzwn47fQGdVFEkDL8=; b=cq2HZh6b6GOnYbpYSHO1Dys1aYQihbKjqPAMpuzxFXKVDm/pdguK127Nq4DEJ5kens T0Z+zVXFtWI2oHobxBnkAo9UvFlq37hB4lVoqx0LIOIAlDXfg9Wt4vi5c0i+7keC+FvH AUv+ssSiLlSLmShjb5d7rn8V5jM56BooLPhSfIVfFxzk9JfDDk/0+HZAbbevd77S0Nej UJ1mKR7R4iC0/DF5JNnPyE6/h5D8Y9dZi9Iiu5gKRBQyet+jTvkjIvW4PKWrE36SHhMv 038MijQHxUSv8e2/Eqqi9qY5/v9FK3uCuw12atSxnc3A5KMLwDysrTdnyNYdiJhw642o Bp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766778; x=1694371578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NxH9YviFYJ/sVQ921jdxmjDcbIQzwn47fQGdVFEkDL8=; b=PbkR5aEeZBt4XFBir9R8UNk7K2Mcm1lEMNJL56ws8khrJ0/finOTPl+Oz8FqgwIQWi 2c+gePWOrp6Khb+5VG0kUAmRnBSW0tFdQY5beBWW/qd1u/hhQHuapZT2dZRh5OZrD1B0 jWIOShKipYZssDx+Tm9jL/cpdRB3SNYE4tEaXremtBtVyvPshjMk/hTSapsVKK4p4WZO hvP6/49ab8Z3jg581/SHFddgDRZOfTsNxXir+Zf83cDQtlVNE7vfswq36kBra775URaG y+2RcqpSFXCezKfhmGnWgDIFYH0GdTWozi+3vXsniuBe439hDPsPVN4QMtDxjTTbNaIt EyaA== X-Gm-Message-State: AOJu0Yzbp3Ba/jSq9qam6HG6CpMRoFaaoS2g686Yo8D0BP+Rkkb/E+3H FiVRf95eDY4ubhCcI1uQNxisGsiqvvdlQg== X-Google-Smtp-Source: AGHT+IFaoNhYGsbvB6jznT4bSDBnIoFY2jvJJdHmVHBwkTi3nPyjBv03yWffGFhGkV6csSuj+h269g== X-Received: by 2002:a92:dad2:0:b0:34d:e998:fb4f with SMTP id o18-20020a92dad2000000b0034de998fb4fmr7949087ilq.10.1693766778270; Sun, 03 Sep 2023 11:46:18 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:17 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Imre Deak , Radhakrishna Sripada , Mika Kahola , =?UTF-8?q?Jos=C3=A9=20Roberto=20de=20Souza?= , Ankit Nautiyal , Andrzej Hajda , Matthew Auld , Andi Shyti , "Jason A. Donenfeld" , Rob Clark , Chris Wilson , Fei Yang Subject: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs Date: Sun, 3 Sep 2023 12:46:00 -0600 Message-ID: <20230903184607.272198-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Reviewed-by: Andi Shyti =20 --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i91= 5/display/intel_ddi.c index 090f242e610c..0a196348e2d1 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -4171,7 +4171,7 @@ static int intel_ddi_compute_config_late(struct intel= _encoder *encoder, struct drm_connector *connector =3D conn_state->connector; u8 port_sync_transcoders =3D 0; =20 - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]", + drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n", encoder->base.base.id, encoder->base.name, crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name); =20 diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/d= rm/i915/gem/i915_gem_execbuffer.c index cfd7929587d8..29c40e8a7183 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1436,7 +1436,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { drm_dbg(&i915->drm, "reloc with multiple write domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, @@ -1447,7 +1447,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, & ~I915_GEM_GPU_DOMAINS)) { drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, --=20 2.41.0 From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8EBCA0FF3 for ; Sun, 3 Sep 2023 18:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345679AbjICSqa (ORCPT ); Sun, 3 Sep 2023 14:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345337AbjICSqY (ORCPT ); Sun, 3 Sep 2023 14:46:24 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5955F10C; Sun, 3 Sep 2023 11:46:20 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7926de0478eso33144739f.0; Sun, 03 Sep 2023 11:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766779; x=1694371579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VQ/W1vAuvct0eQaNfV42dDs6Is2Bz/K+5cHGfVn4Nlg=; b=pxXggN7K2cIPZVnbjYusU98adr1ZMQOKsZWZrvt0zCwmMzVzAoiU83hMA3LMU6NAPx BoJdQDi9U3oNtcJ7WwaGJNLB9GXEHcmGam+7QopzWx2LnvFmCen7KJjog1x6dUIqhcbq z8px5QTzhBTdyU9WQgKKq97M4fXd9qBfTqY/dvFfq6dh3aPgfiVtelMaskIIGZT/iZEd Ox/oHeo1DqdR7O+wQmAswhfbFB60O6oFuSWfy2WQ4ZPgEDmRqHSbBYt5Y9CMmkOEWX6W UlOLJuogZvjUgflvN6Te4o2jeSdZok946dSvPbfp62T1RVkafB85yjz5EqFxSxK8GYVn 4GPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766779; x=1694371579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQ/W1vAuvct0eQaNfV42dDs6Is2Bz/K+5cHGfVn4Nlg=; b=LUgw2O0RAd9mnYNzbI1e5QPfBfE4elH9oKhg08Rz6JkSblnGdEl+L0H82FLlBrpFmk k8XiwVquuBARKhuGwf4lIDuVl0OuLlpaQv3CUzDrubAevRhVB/sZZkN3e9XijFM4WW4A g4Y2nRaXlozy/tfWSkqBk46xIecQfwo4kUvr4NYRoXlpOSoDzkf8WlbgWlSgWN8aVsJf v00eE37mteVaCkTnO3BVrilc1rUJeE75VcMBDjVQqCUvaCWwpNE0gK10BZsr2vdRTAmm tWrBC9SCeDxxT4IfQraPlfq6KD3nQKbi7DSV8r9qY+46PChFsNGzaAfTIRD6Lx8xqTyj I6fg== X-Gm-Message-State: AOJu0YwF0ATHOHjIRfI0W2868GJe7MJvbeZbWl11Hy+K0eLP3kpqlmK0 JYIfihsZp06ZtTDSh8Y7oK0fufNf9v4svQ== X-Google-Smtp-Source: AGHT+IG0oYogHO+wAh1Qc2b0RpBbRi8d3sGxNY89NwIzDxZvPXy3apKKIsYkF1LHmvM+09NoaEvKYw== X-Received: by 2002:a05:6e02:184e:b0:34d:ecbb:9cc4 with SMTP id b14-20020a056e02184e00b0034decbb9cc4mr10979635ilv.3.1693766779453; Sun, 03 Sep 2023 11:46:19 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:19 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH v2 4/6] drm_dbg: add trailing newlines to msgs Date: Sun, 3 Sep 2023 12:46:01 -0600 Message-ID: <20230903184607.272198-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/msm/msm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..80166f702a0d 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, =20 for (i =3D 0; i < n; i++) { ret =3D msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, const struct msm_format *format; int ret, i, n; =20 - drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)", + drm_dbg_state(dev, "create framebuffer: mode_cmd=3D%p (%dx%d@%4.4s)\n", mode_cmd, mode_cmd->width, mode_cmd->height, (char *)&mode_cmd->pixel_format); =20 @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(str= uct drm_device *dev, =20 refcount_set(&msm_fb->dirtyfb, 1); =20 - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); =20 return fb; =20 --=20 2.41.0 From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 985C8C71153 for ; Sun, 3 Sep 2023 18:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345871AbjICSqc (ORCPT ); Sun, 3 Sep 2023 14:46:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345575AbjICSq0 (ORCPT ); Sun, 3 Sep 2023 14:46:26 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC3A10D for ; Sun, 3 Sep 2023 11:46:21 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-77acb04309dso37719639f.2 for ; Sun, 03 Sep 2023 11:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766780; x=1694371580; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=bIKzDZgjhLXoO2N8wuweL7NZXWqXE9GQb6QidYwcy3PpQ+cKEgSpLVRkMg8CSOvMu+ 8wnl0XsnEyWBs9jSO34FzJ6WawbG31/eaWOFmi87FmzMomMcxR/EP8TaMgVmVgp/1jUV 3dcyR8uexC97/syfYMI2Dz4tt9CWGZzowjMwv2/R2m+xfWRexIdJOInMONRTnosoRu1F kJEGmDQDPKPTcOHcdtr8gY1hpgs3b1UpbKGGZBT/+8nq4zeqVVXTz6hzjXmZf17zgIQH k+5GWWwpmK+7pq7WymiSxaKuklloM9aM31Xj1Y39cTlq0IVS27tDQzn+oaaoS+CSmO2S RbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766780; x=1694371580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=WZFZ6k1eClwEu1GGnI4QUT3HkClYLgCywcREXLKBXHmRGCUS7noELwRZYAhf0yX+Tk 17yGnurpAoft63UZtCypyXrnD8CUTss07t/evvqnAAYxpsZ9BAXCXctHWV2VTCidSM3D ATFnHdhFJbamInVPgLL64aH99kfhDulZZCFc7hCf9d6RoSigWC7q08+l7lsLHJj4G0CM 3Q4zQsnjcQe7Ttd1F83q0IYuNQktoRky/UH+etyz4faoIpnVHOciGWZQMU7ceR+bLTFu I6XotSBuu8i3jk+ZYMaPYwl8H7fZutYiWGQM6SgoauSVYhs/btFi2pCYjHTkeitPW88B Zt7Q== X-Gm-Message-State: AOJu0YxtfrAp+Jy9p8jgKUUHs0PdFusT6HuWLBmgQUSTOma/JWTZgmRu VhW9qsOF74K9o5vDo5LDjBQEN2Znsg2/EQ== X-Google-Smtp-Source: AGHT+IFezAhzBe8bHNafQV2ls3Rrm07SEuvb9e6ZJAhZmonaPCE5ktQ5RYLT+3Q1JAWulfB2inkf2w== X-Received: by 2002:a6b:5103:0:b0:792:9333:2cbf with SMTP id f3-20020a6b5103000000b0079293332cbfmr9837914iob.6.1693766780607; Sun, 03 Sep 2023 11:46:20 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:20 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Emma Anholt , Maxime Ripard , David Airlie Subject: [PATCH v2 5/6] drm_dbg: add trailing newlines to msgs Date: Sun, 3 Sep 2023 12:46:02 -0600 Message-ID: <20230903184607.272198-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *cr= tc, struct drm_encoder *encoder =3D vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev =3D crtc->dev; =20 - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crt= c, struct vc4_encoder *vc4_encoder =3D to_vc4_encoder(encoder); int idx; =20 - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); =20 if (!drm_dev_enter(dev, &idx)) --=20 2.41.0 From nobody Sun Feb 8 01:23:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A500CA0FF8 for ; Sun, 3 Sep 2023 18:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345926AbjICSqb (ORCPT ); Sun, 3 Sep 2023 14:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345583AbjICSq3 (ORCPT ); Sun, 3 Sep 2023 14:46:29 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF307110 for ; Sun, 3 Sep 2023 11:46:22 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-79536bc669dso37507939f.3 for ; Sun, 03 Sep 2023 11:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766782; x=1694371582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9+vShd9z6JIlJdMcVT9ozEMb7ECMtYhQaxypaqn+ojI=; b=GWQmeQHcVYcD+Soy3jBcWELYofBOHj0cBarxnmjclgCsxAMjDT1wx8wyLJfze7LUp6 hZEs+4jYNFGK8ccf1Vpt2VBntJ1cOcS7wNDLCaknHZi/5iuW+UaimRjhctxb6VDOUBhG tWmfkKwsTTNrntizmGSy+fWmlkKoUVhpMAvPLLUWJjeTThaoESUkErvxttchimU/tl09 wTmy0LTCTn87F1gFcgALpGNa3alwfLsOLw/GxA3sFfVW67T9Y+QuqZefJn3mbVpzTYbZ BpnK779Jl2t3VavLx7okiufTmRWz4YVodQfZGKRnX8Avn7YHkeTU98NR6MDqxXjEFXxa sPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766782; x=1694371582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+vShd9z6JIlJdMcVT9ozEMb7ECMtYhQaxypaqn+ojI=; b=K+UAyKzL3mJxfGbaPmpattH1hWjv8CzAio3RXBGk3J04j2D/ksveUoF63c7SNwN+6Y 4w221FleWicNhxLVJ3TsTEFcYC0yXNO0rh2lbMa95qipLz0yvYpf9derTUNi3eYqfXrm ySPLCWmdnFbO4rGO+rbe244g/E34vGauYIc7eoL2HzTGShW100eSNLYnQm60OytS39zR lu8nHRIlONxomXs98AxkBEdL74w6OUx2Zp5cFTAayKoeR3xPXTvuFzRctbyg/ULGT0Vv Byb+Gjm3EVCX9XAtebGuhsSDEuazoHL90t6o2tGZ9t4CWBHcW2HzJl/1J3t6QjfNGOTR EULA== X-Gm-Message-State: AOJu0YwexUiEES9x3+XEL3OTe8yShj4UCyIOxA3IY9EzBFNgBeINZJp0 AXC+JRoxpfRV+Xz3J4w6ZbXLwc1nubfsTQ== X-Google-Smtp-Source: AGHT+IGqOoyhaY6/BLxjGQwr9jgSrLCBNKR3l+qSBXjy+8E6+buexCVqqyAEqMiNiyX8+oyGCVjU2Q== X-Received: by 2002:a05:6e02:e12:b0:349:9993:f223 with SMTP id a18-20020a056e020e1200b003499993f223mr8706895ilk.23.1693766781766; Sun, 03 Sep 2023 11:46:21 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:21 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, daniel@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, Jim Cromie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Greg Kroah-Hartman Subject: [PATCH v2 6/6] drm: use correct ccflags-y syntax Date: Sun, 3 Sep 2023 12:46:03 -0600 Message-ID: <20230903184607.272198-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=3DY CONFIG_DYNAMIC_DEBUG_CORE=3DY, but CONFIG_DYNAMIC_DEBUG=3DN Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factor= y macro") Signed-off-by: Jim Cromie --- drivers/gpu/drm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 7a09a89b493b..013cde886326 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -3,7 +3,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. =20 -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) +=3D -DDYNAMIC_DEBUG_MODULE =20 drm-y :=3D \ drm_aperture.o \ --=20 2.41.0