From nobody Fri Dec 19 12:40:00 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E609CA0FE6 for ; Fri, 1 Sep 2023 13:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349769AbjIANhS (ORCPT ); Fri, 1 Sep 2023 09:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbjIANhR (ORCPT ); Fri, 1 Sep 2023 09:37:17 -0400 Received: from forward103b.mail.yandex.net (forward103b.mail.yandex.net [178.154.239.150]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C82CCDD for ; Fri, 1 Sep 2023 06:37:10 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net [IPv6:2a02:6b8:c08:2e14:0:640:2cd1:0]) by forward103b.mail.yandex.net (Yandex) with ESMTP id BCE3E600C9; Fri, 1 Sep 2023 16:37:03 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 1bTJsPiDbqM0-prEI6731; Fri, 01 Sep 2023 16:37:03 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itb.spb.ru; s=mail; t=1693575423; bh=Ba8JWc3C9psCW/rmvc3IHsDGaZyabBvdUWtlCB4rRX8=; h=Message-Id:Date:Cc:Subject:To:From; b=UrNdCmqqSOogo/OavfhMWwDrPKx8G1SaWm5o2i6XE+DQ7WQ2rF5o2IEANWoxn3sWr UIEqAIbCA5X6kvpeGf6E7Vmin6mLvsECllP4c4zRrqpBiwq1EOjNsR1SO/BK34+OkI NfQheI5H1w347KexyNmJ8fMPItl9hA2MPcS/8M7o= Authentication-Results: mail-nwsmtp-smtp-production-main-25.sas.yp-c.yandex.net; dkim=pass header.i=@itb.spb.ru From: Dembskiy Igor To: Alexey Khoroshilov Cc: Dembskiy Igor , Boris Brezillon , Richard Weinberger , Miquel Raynal , Akinobu Mita , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] mtd: tests: remove useless checks Date: Fri, 1 Sep 2023 16:36:41 +0300 Message-Id: <20230901133641.60817-1-dii@itb.spb.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return value of mtdtest_scan_for_bad_() is always 0. So it causes senseless checks in some functions such as mtd_subpagetest_init(). Fixes: 084db4b020c7 ("mtd: tests: introduce helper functions") Signed-off-by: Dembskiy Igor --- drivers/mtd/tests/oobtest.c | 2 -- drivers/mtd/tests/pagetest.c | 2 -- drivers/mtd/tests/readtest.c | 2 -- drivers/mtd/tests/speedtest.c | 3 +-- drivers/mtd/tests/stresstest.c | 2 -- drivers/mtd/tests/subpagetest.c | 2 -- drivers/mtd/tests/torturetest.c | 2 -- 7 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/mtd/tests/oobtest.c b/drivers/mtd/tests/oobtest.c index 13fed398937e..976f40a5656e 100644 --- a/drivers/mtd/tests/oobtest.c +++ b/drivers/mtd/tests/oobtest.c @@ -399,8 +399,6 @@ static int __init mtd_oobtest_init(void) pr_info("test 1 of 5\n"); =20 err =3D mtdtest_erase_good_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; =20 prandom_seed_state(&rnd_state, 1); err =3D write_whole_device(); diff --git a/drivers/mtd/tests/pagetest.c b/drivers/mtd/tests/pagetest.c index 8eb40b6e6dfa..a59ef88cdaf3 100644 --- a/drivers/mtd/tests/pagetest.c +++ b/drivers/mtd/tests/pagetest.c @@ -373,8 +373,6 @@ static int __init mtd_pagetest_init(void) if (!bbt) goto out; err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; =20 /* Erase all eraseblocks */ pr_info("erasing whole device\n"); diff --git a/drivers/mtd/tests/readtest.c b/drivers/mtd/tests/readtest.c index 99670ef91f2b..8bc52aca1b2a 100644 --- a/drivers/mtd/tests/readtest.c +++ b/drivers/mtd/tests/readtest.c @@ -162,8 +162,6 @@ static int __init mtd_readtest_init(void) if (!bbt) goto out; err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; =20 /* Read all eraseblocks 1 page at a time */ pr_info("testing page read\n"); diff --git a/drivers/mtd/tests/speedtest.c b/drivers/mtd/tests/speedtest.c index 075bce32caa5..978369f8d4c0 100644 --- a/drivers/mtd/tests/speedtest.c +++ b/drivers/mtd/tests/speedtest.c @@ -229,8 +229,7 @@ static int __init mtd_speedtest_init(void) if (!bbt) goto out; err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; + for (i =3D 0; i < ebcnt; i++) { if (!bbt[i]) goodebcnt++; diff --git a/drivers/mtd/tests/stresstest.c b/drivers/mtd/tests/stresstest.c index 8062098930d6..0a1fa8a2078e 100644 --- a/drivers/mtd/tests/stresstest.c +++ b/drivers/mtd/tests/stresstest.c @@ -189,8 +189,6 @@ static int __init mtd_stresstest_init(void) if (!bbt) goto out; err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; =20 /* Do operations */ pr_info("doing operations\n"); diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetes= t.c index 05250a080139..5ca93e169a25 100644 --- a/drivers/mtd/tests/subpagetest.c +++ b/drivers/mtd/tests/subpagetest.c @@ -319,8 +319,6 @@ static int __init mtd_subpagetest_init(void) goto out; =20 err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bbt, 0, ebcnt); - if (err) - goto out; =20 err =3D mtdtest_erase_good_eraseblocks(mtd, bbt, 0, ebcnt); if (err) diff --git a/drivers/mtd/tests/torturetest.c b/drivers/mtd/tests/torturetes= t.c index 841689b4d86d..46634198e19d 100644 --- a/drivers/mtd/tests/torturetest.c +++ b/drivers/mtd/tests/torturetest.c @@ -243,8 +243,6 @@ static int __init tort_init(void) } =20 err =3D mtdtest_scan_for_bad_eraseblocks(mtd, bad_ebs, eb, ebcnt); - if (err) - goto out; =20 start_timing(); while (1) { --=20 2.34.1