From nobody Thu Dec 18 19:12:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76385C83F1C for ; Wed, 30 Aug 2023 18:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245270AbjH3SwH (ORCPT ); Wed, 30 Aug 2023 14:52:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244769AbjH3N5p (ORCPT ); Wed, 30 Aug 2023 09:57:45 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF400C2 for ; Wed, 30 Aug 2023 06:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693403862; bh=BxyzFCZWmrBfXUbxKI5hpgIUfXerIGQlN4Xd8JmlKXY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WNYAvS3/NWcw6XUmXtRSU3QIarGWY0PURwgpv+hGiaYnJr1hkqSTwbbXoTOWnkj7h bo707kQwh1NlGqN7PNU8WKliDb+EAZxMZgbqB3jt6GU3BGUEdgRXn86vwyhoJXz8T1 la4LCpSlcUgv/uJWriTLTRXvQoBwVEa8FIDs+JhjXxb4YD38dbBTZ/dJfYf7lsPJuX Yn5sffu6chAOkZyQfgw6/oJIqefiRrCTBVkhctiOYMTQXHaD0B5H7vojKcwH/ziAVS hIqj1x7sFJgltOO8ZMxezwQNMyB63iracCKFcQgn5Kipz0hh+bpW8ywo9dP4IgVVFo I1D0dVDJH9vpg== Received: from localhost.localdomain (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 1D13624B2B0; Wed, 30 Aug 2023 20:57:38 +0700 (WIB) From: Ammar Faizi To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: Ammar Faizi , Nicholas Rosenberg , Alviro Iskandar Setiawan , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: [RFC PATCH v1 1/5] tools/nolibc: x86-64: Use `rep movsb` for `memcpy()` and `memmove()` Date: Wed, 30 Aug 2023 20:57:22 +0700 Message-Id: <20230830135726.1939997-2-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> References: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Simplify memcpy() and memmove() on the x86-64 arch. The x86-64 arch has a 'rep movsb' instruction, which can perform memcpy() using only a single instruction, given: %rdi =3D destination %rsi =3D source %rcx =3D length Additionally, it can also handle the overlapping case by setting DF=3D1 (backward copy), which can be used as the memmove() implementation. Before this patch: ``` 00000000000010ab : 10ab: 48 89 f8 mov %rdi,%rax 10ae: 31 c9 xor %ecx,%ecx 10b0: 48 39 f7 cmp %rsi,%rdi 10b3: 48 83 d1 ff adc $0xffffffffffffffff,%rcx 10b7: 48 85 d2 test %rdx,%rdx 10ba: 74 25 je 10e1 10bc: 48 83 c9 01 or $0x1,%rcx 10c0: 48 39 f0 cmp %rsi,%rax 10c3: 48 c7 c7 ff ff ff ff mov $0xffffffffffffffff,%rdi 10ca: 48 0f 43 fa cmovae %rdx,%rdi 10ce: 48 01 cf add %rcx,%rdi 10d1: 44 8a 04 3e mov (%rsi,%rdi,1),%r8b 10d5: 44 88 04 38 mov %r8b,(%rax,%rdi,1) 10d9: 48 01 cf add %rcx,%rdi 10dc: 48 ff ca dec %rdx 10df: 75 f0 jne 10d1 10e1: c3 ret 00000000000010e2 : 10e2: 48 89 f8 mov %rdi,%rax 10e5: 48 85 d2 test %rdx,%rdx 10e8: 74 12 je 10fc 10ea: 31 c9 xor %ecx,%ecx 10ec: 40 8a 3c 0e mov (%rsi,%rcx,1),%dil 10f0: 40 88 3c 08 mov %dil,(%rax,%rcx,1) 10f4: 48 ff c1 inc %rcx 10f7: 48 39 ca cmp %rcx,%rdx 10fa: 75 f0 jne 10ec 10fc: c3 ret ``` After this patch: ``` 0000000000001093 : 1093: 48 89 f8 mov %rdi,%rax 1096: 48 89 d1 mov %rdx,%rcx 1099: 48 8d 7c 0f ff lea -0x1(%rdi,%rcx,1),%rdi 109e: 48 8d 74 0e ff lea -0x1(%rsi,%rcx,1),%rsi 10a3: fd std 10a4: f3 a4 rep movsb %ds:(%rsi),%es:(%rdi) 10a6: fc cld 10a7: c3 ret 00000000000010a8 : 10a8: 48 89 f8 mov %rdi,%rax 10ab: 48 89 d1 mov %rdx,%rcx 10ae: f3 a4 rep movsb %ds:(%rsi),%es:(%rdi) 10b0: c3 ret ``` Signed-off-by: Ammar Faizi --- tools/include/nolibc/arch-x86_64.h | 28 ++++++++++++++++++++++++++++ tools/include/nolibc/string.h | 4 ++++ 2 files changed, 32 insertions(+) diff --git a/tools/include/nolibc/arch-x86_64.h b/tools/include/nolibc/arch= -x86_64.h index e5ccb926c90306b6..c5162170a2ccdff1 100644 --- a/tools/include/nolibc/arch-x86_64.h +++ b/tools/include/nolibc/arch-x86_64.h @@ -173,4 +173,32 @@ void __attribute__((weak, noreturn, optimize("Os", "om= it-frame-pointer"))) __no_ __builtin_unreachable(); } =20 +#define NOLIBC_ARCH_HAS_MEMMOVE +void *memmove(void *dst, const void *src, size_t len); + +#define NOLIBC_ARCH_HAS_MEMCPY +void *memcpy(void *dst, const void *src, size_t len); + +__asm__ ( +".section .text.nolibc_memmove\n" +".weak memmove\n" +"memmove:\n" + "movq %rdi, %rax\n" + "movq %rdx, %rcx\n" + "leaq -1(%rdi, %rcx), %rdi\n" + "leaq -1(%rsi, %rcx), %rsi\n" + "std\n" + "rep movsb\n" + "cld\n" + "retq\n" + +".section .text.nolibc_memcpy\n" +".weak memcpy\n" +"memcpy:\n" + "movq %rdi, %rax\n" + "movq %rdx, %rcx\n" + "rep movsb\n" + "retq\n" +); + #endif /* _NOLIBC_ARCH_X86_64_H */ diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index 0c2e06c7c4772bc6..6eca267ec6fa7177 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -49,6 +49,7 @@ void *_nolibc_memcpy_down(void *dst, const void *src, siz= e_t len) return dst; } =20 +#ifndef NOLIBC_ARCH_HAS_MEMMOVE /* might be ignored by the compiler without -ffreestanding, then found as * missing. */ @@ -72,13 +73,16 @@ void *memmove(void *dst, const void *src, size_t len) } return dst; } +#endif /* #ifndef NOLIBC_ARCH_HAS_MEMMOVE */ =20 +#ifndef NOLIBC_ARCH_HAS_MEMCPY /* must be exported, as it's used by libgcc on ARM */ __attribute__((weak,unused,section(".text.nolibc_memcpy"))) void *memcpy(void *dst, const void *src, size_t len) { return _nolibc_memcpy_up(dst, src, len); } +#endif /* #ifndef NOLIBC_ARCH_HAS_MEMCPY */ =20 /* might be ignored by the compiler without -ffreestanding, then found as * missing. --=20 Ammar Faizi From nobody Thu Dec 18 19:12:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F66C83F1D for ; Wed, 30 Aug 2023 19:14:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241968AbjH3TK7 (ORCPT ); Wed, 30 Aug 2023 15:10:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244770AbjH3N5t (ORCPT ); Wed, 30 Aug 2023 09:57:49 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB892C2 for ; Wed, 30 Aug 2023 06:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693403866; bh=nVJMnv3VCXXs9TgaAACyjEPEMdvWPuaWCwde2DJ1HJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=V9BTof8lCIK92dwQ2+z8QNcmYNiZGc9JvEryL2GwrA9Mnrg38AHNtUSdKoZDVI27O IFpMfYG4ijMEFBdHYCaf7KeBQRvYSlDGsMXk47lZMGfY7jM9hEzQoI1yjUOiX3gfw0 xaWHDW3wWAekUKcKOg2x0NT55pIsNL9ATbDnQGpXu2Yz3hts1BgyQ9aGCm/U+Ng6JK yiYnatLh6DdcgbHr+ulXbY4JNgcmqQzqtRsHTAhqXWNHh+VZ06t53adm30upnsqlr4 XI1SKifiy5fzhD+lxK6zc2r1CrI3o5Ko0GXkbMD0pXP+1LKpJpNdFeZ6UmE99m0k5q bsJJNgymS9X2w== Received: from localhost.localdomain (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 2C4A124B327; Wed, 30 Aug 2023 20:57:42 +0700 (WIB) From: Ammar Faizi To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: Ammar Faizi , Nicholas Rosenberg , Alviro Iskandar Setiawan , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: [RFC PATCH v1 2/5] tools/nolibc: x86-64: Use `rep stosb` for `memset()` Date: Wed, 30 Aug 2023 20:57:23 +0700 Message-Id: <20230830135726.1939997-3-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> References: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Simplify memset() on the x86-64 arch. The x86-64 arch has a 'rep stosb' instruction, which can perform memset() using only a single instruction, given: %al =3D value (just like the second argument of memset()) %rdi =3D destination %rcx =3D length Before this patch: ``` 00000000000010c9 : 10c9: 48 89 f8 mov %rdi,%rax 10cc: 48 85 d2 test %rdx,%rdx 10cf: 74 0e je 10df 10d1: 31 c9 xor %ecx,%ecx 10d3: 40 88 34 08 mov %sil,(%rax,%rcx,1) 10d7: 48 ff c1 inc %rcx 10da: 48 39 ca cmp %rcx,%rdx 10dd: 75 f4 jne 10d3 10df: c3 ret ``` After this patch: ``` 00000000000010b1 : 10b1: 48 89 f0 mov %rsi,%rax 10b4: 48 89 d1 mov %rdx,%rcx 10b7: 48 89 fa mov %rdi,%rdx 10ba: f3 aa rep stos %al,%es:(%rdi) 10bc: 48 89 d0 mov %rdx,%rax 10bf: c3 ret ``` Signed-off-by: Ammar Faizi --- tools/include/nolibc/arch-x86_64.h | 13 +++++++++++++ tools/include/nolibc/string.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/tools/include/nolibc/arch-x86_64.h b/tools/include/nolibc/arch= -x86_64.h index c5162170a2ccdff1..42f2674ad1ecdd64 100644 --- a/tools/include/nolibc/arch-x86_64.h +++ b/tools/include/nolibc/arch-x86_64.h @@ -179,6 +179,9 @@ void *memmove(void *dst, const void *src, size_t len); #define NOLIBC_ARCH_HAS_MEMCPY void *memcpy(void *dst, const void *src, size_t len); =20 +#define NOLIBC_ARCH_HAS_MEMSET +void *memset(void *dst, int c, size_t len); + __asm__ ( ".section .text.nolibc_memmove\n" ".weak memmove\n" @@ -199,6 +202,16 @@ __asm__ ( "movq %rdx, %rcx\n" "rep movsb\n" "retq\n" + +".section .text.nolibc_memset\n" +".weak memset\n" +"memset:\n" + "movq %rsi, %rax\n" + "movq %rdx, %rcx\n" + "movq %rdi, %rdx\n" + "rep stosb\n" + "movq %rdx, %rax\n" + "retq\n" ); =20 #endif /* _NOLIBC_ARCH_X86_64_H */ diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index 6eca267ec6fa7177..1bad6121ef8c4ab5 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -84,6 +84,7 @@ void *memcpy(void *dst, const void *src, size_t len) } #endif /* #ifndef NOLIBC_ARCH_HAS_MEMCPY */ =20 +#ifndef NOLIBC_ARCH_HAS_MEMSET /* might be ignored by the compiler without -ffreestanding, then found as * missing. */ @@ -99,6 +100,7 @@ void *memset(void *dst, int b, size_t len) } return dst; } +#endif /* #ifndef NOLIBC_ARCH_HAS_MEMSET */ =20 static __attribute__((unused)) char *strchr(const char *s, int c) --=20 Ammar Faizi From nobody Thu Dec 18 19:12:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5EDC83F01 for ; Wed, 30 Aug 2023 18:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233656AbjH3Sd0 (ORCPT ); Wed, 30 Aug 2023 14:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244771AbjH3N5x (ORCPT ); Wed, 30 Aug 2023 09:57:53 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1ED5C2 for ; Wed, 30 Aug 2023 06:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693403870; bh=+oMZFii0whVGbdwH8pUpekgq85QDy15fOQgKa9a73pQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tUranpan3lHKDejmmUM6IFSKipf93sVsIUWGiRLkuDyZJI5nSJHwKhP0mnLK5fP+3 uR1snhiBNUCgPaRvnbpDB/9DkkmlGeuEjomvpkqhRII9or/GSZLDnbley7ahM9qCM5 /FcdRKKwIgp2u/hSaEGM58shCpe+dNqrcFyma7k6WHSfCxh2q1lVgcJkFOLVzyNsRv kQTXEA2BKi6xSerLZUuqf9DGJ2Z9HLgwAQjCrevgjO3uq5iRmAYlKfG6f4u1yliVBm VFfSzcArGOrKbtrLtltVr6Ik3WZxU+mdIMp/U6nZyiuG8nR/ci0ytWjJL9tIhtBFfv lk4lwD92oEadA== Received: from localhost.localdomain (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 3CE9324B32D; Wed, 30 Aug 2023 20:57:46 +0700 (WIB) From: Ammar Faizi To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: Ammar Faizi , Nicholas Rosenberg , Alviro Iskandar Setiawan , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: [RFC PATCH v1 3/5] tools/nolibc: x86-64: Use `rep cmpsb` for `memcmp()` Date: Wed, 30 Aug 2023 20:57:24 +0700 Message-Id: <20230830135726.1939997-4-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> References: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Simplify memcmp() on the x86-64 arch. The x86-64 arch has a 'rep cmpsb' instruction, which can be used to implement the memcmp() function. %rdi =3D source 1 %rsi =3D source 2 %rcx =3D length Signed-off-by: Ammar Faizi --- tools/include/nolibc/arch-x86_64.h | 19 +++++++++++++++++++ tools/include/nolibc/string.h | 2 ++ 2 files changed, 21 insertions(+) diff --git a/tools/include/nolibc/arch-x86_64.h b/tools/include/nolibc/arch= -x86_64.h index 42f2674ad1ecdd64..6c1b54ba9f774e7b 100644 --- a/tools/include/nolibc/arch-x86_64.h +++ b/tools/include/nolibc/arch-x86_64.h @@ -214,4 +214,23 @@ __asm__ ( "retq\n" ); =20 +#define NOLIBC_ARCH_HAS_MEMCMP +static int memcmp(const void *s1, const void *s2, size_t n) +{ + const unsigned char *p1 =3D s1; + const unsigned char *p2 =3D s2; + + if (!n) + return 0; + + __asm__ volatile ( + "rep cmpsb" + : "+D"(p2), "+S"(p1), "+c"(n) + : "m"(*(const unsigned char (*)[n])s1), + "m"(*(const unsigned char (*)[n])s2) + ); + + return p1[-1] - p2[-1]; +} + #endif /* _NOLIBC_ARCH_X86_64_H */ diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index 1bad6121ef8c4ab5..3c941289d5dd0985 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -15,6 +15,7 @@ static void *malloc(size_t len); * As much as possible, please keep functions alphabetically sorted. */ =20 +#ifndef NOLIBC_ARCH_HAS_MEMCMP static __attribute__((unused)) int memcmp(const void *s1, const void *s2, size_t n) { @@ -26,6 +27,7 @@ int memcmp(const void *s1, const void *s2, size_t n) } return c1; } +#endif /* #ifndef NOLIBC_ARCH_HAS_MEMCMP */ =20 static __attribute__((unused)) void *_nolibc_memcpy_up(void *dst, const void *src, size_t len) --=20 Ammar Faizi From nobody Thu Dec 18 19:12:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D71C6FA8F for ; Wed, 30 Aug 2023 19:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229462AbjH3TIc (ORCPT ); Wed, 30 Aug 2023 15:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244772AbjH3N55 (ORCPT ); Wed, 30 Aug 2023 09:57:57 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E86A1C2 for ; Wed, 30 Aug 2023 06:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693403874; bh=cVbN3EplFTRxMSZG3fc6WmDpp7wPvxcyeQRTe1ZY1DE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=C4/5OtCGlK11vOW17d/9djJmGqftgbW7cqqBhK5B+Hp3Kupkb/Oq0Wo9YG0qDir+Z jU9kc5yu8OAXlSz0o7OpHIf6GhpL3YRkzrOznNDqWX8m8MXBv6+MVHb647Ubhdl/DP 78lQ49/teaCfi71H+Iq72NJ7ip4IruqPUIGjZgQSSDcQv9zNGRk4N8w9ExpBKjSdhH 1YY9CHrjvyYDE7k8w5HXpmIsdF9rzrDwTpkWAlS8Exukhtv6hbJrKkv6TTEMhusMwB 6vxQYQSECRQ5VkarrwFQqa++b463eDCSGsWWcypllDDSmGbz+um7IGEOeiDRaf5lOQ XQ9HhSz9MVctw== Received: from localhost.localdomain (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 5545924B331; Wed, 30 Aug 2023 20:57:51 +0700 (WIB) From: Ammar Faizi To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: Ammar Faizi , Nicholas Rosenberg , Alviro Iskandar Setiawan , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: [RFC PATCH v1 4/5] tools/nolibc: string: Remove the `_nolibc_memcpy_down()` function Date: Wed, 30 Aug 2023 20:57:25 +0700 Message-Id: <20230830135726.1939997-5-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> References: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This nolibc internal function is not used. Delete it. It was probably supposed to handle memmove(), but today the memmove() has its own implementation. Signed-off-by: Ammar Faizi --- tools/include/nolibc/string.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index 3c941289d5dd0985..b0d7d8e143f61741 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -41,16 +41,6 @@ void *_nolibc_memcpy_up(void *dst, const void *src, size= _t len) return dst; } =20 -static __attribute__((unused)) -void *_nolibc_memcpy_down(void *dst, const void *src, size_t len) -{ - while (len) { - len--; - ((char *)dst)[len] =3D ((const char *)src)[len]; - } - return dst; -} - #ifndef NOLIBC_ARCH_HAS_MEMMOVE /* might be ignored by the compiler without -ffreestanding, then found as * missing. --=20 Ammar Faizi From nobody Thu Dec 18 19:12:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F64FC83F18 for ; Wed, 30 Aug 2023 18:30:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbjH3Sah (ORCPT ); Wed, 30 Aug 2023 14:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244773AbjH3N6B (ORCPT ); Wed, 30 Aug 2023 09:58:01 -0400 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3623FC2 for ; Wed, 30 Aug 2023 06:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1693403878; bh=/YABsqbHD7MudnnQOTcU6MvoETFjlxMzuet8DJKii/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=stzm8KH+8URdY17DYLHw/KUfFXKYzqOeauSYTCPIJUmqKG0Qq1btzY9nfQwKpRI2K cyU7h0PCrU5zFSYGfzgu9DisCzWrPoUArXdQsDQzI1jwisiyyia2mASS1huhD3stzs FWErBBB6uXuSLzwTMEDWxWyY79N0ecvHge55Z2cfMeGGnsP7F6QUU5qC2rC9lKZZ9Y ed1hMGg0VmnlEnm0DZEUJbzjUfp5+2QoRatZsL2wNQ/TrbDxjx0ASGxkZmlDZhZdQq uNcKEmuFoqZz4+AuDziQLPje+ERaQeXtotowFQRu+7DmJfYClsD6D39AsVQZXMLSON 1Imyn02uZqU/g== Received: from localhost.localdomain (unknown [182.253.126.208]) by gnuweeb.org (Postfix) with ESMTPSA id 6ACE024B337; Wed, 30 Aug 2023 20:57:55 +0700 (WIB) From: Ammar Faizi To: Willy Tarreau , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Cc: Ammar Faizi , Nicholas Rosenberg , Alviro Iskandar Setiawan , Michael William Jonathan , GNU/Weeb Mailing List , Linux Kernel Mailing List Subject: [RFC PATCH v1 5/5] tools/nolibc: string: Remove the `_nolibc_memcpy_up()` function Date: Wed, 30 Aug 2023 20:57:26 +0700 Message-Id: <20230830135726.1939997-6-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> References: <20230830135726.1939997-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This function is only called by memcpy(), there is no real reason to have this wrapper. Delete this function and move the code to memcpy() directly. Signed-off-by: Ammar Faizi --- tools/include/nolibc/string.h | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/tools/include/nolibc/string.h b/tools/include/nolibc/string.h index b0d7d8e143f61741..920a0a6c922dbc42 100644 --- a/tools/include/nolibc/string.h +++ b/tools/include/nolibc/string.h @@ -29,18 +29,6 @@ int memcmp(const void *s1, const void *s2, size_t n) } #endif /* #ifndef NOLIBC_ARCH_HAS_MEMCMP */ =20 -static __attribute__((unused)) -void *_nolibc_memcpy_up(void *dst, const void *src, size_t len) -{ - size_t pos =3D 0; - - while (pos < len) { - ((char *)dst)[pos] =3D ((const char *)src)[pos]; - pos++; - } - return dst; -} - #ifndef NOLIBC_ARCH_HAS_MEMMOVE /* might be ignored by the compiler without -ffreestanding, then found as * missing. @@ -72,7 +60,13 @@ void *memmove(void *dst, const void *src, size_t len) __attribute__((weak,unused,section(".text.nolibc_memcpy"))) void *memcpy(void *dst, const void *src, size_t len) { - return _nolibc_memcpy_up(dst, src, len); + size_t pos =3D 0; + + while (pos < len) { + ((char *)dst)[pos] =3D ((const char *)src)[pos]; + pos++; + } + return dst; } #endif /* #ifndef NOLIBC_ARCH_HAS_MEMCPY */ =20 --=20 Ammar Faizi