From nobody Fri Dec 19 15:48:13 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB56BC83F16 for ; Tue, 29 Aug 2023 09:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234495AbjH2JOU (ORCPT ); Tue, 29 Aug 2023 05:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234497AbjH2JNu (ORCPT ); Tue, 29 Aug 2023 05:13:50 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73D7F19A for ; Tue, 29 Aug 2023 02:13:42 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2941C2186B; Tue, 29 Aug 2023 09:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693300421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eB9aR/U6RXS2ICVTlyDomYJuoXmtN3u/uV5XxMcbYuo=; b=Hpqoevjysf1nd1SZYQ6aepWzFXEDTEdcxmvOBeF5UIf0r8QPknKN+mUMTvOZ2/LSGc8AAw /blVeYyProyUL7FHWzfrc5NhTu7m4nt7aaRokpcYAMq3KUjEBUBoKSoEgjj9hZzS7eygKM h6D+VFqdaFS67jUdWMnHmKZz1q8Y2ak= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693300421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eB9aR/U6RXS2ICVTlyDomYJuoXmtN3u/uV5XxMcbYuo=; b=zxhdbhswoF+xnBjjhQZNxrT9am2KXkHQKth4H71nz1YFuqG+xMydTqyjpGcwLs8ZPmh9VP D0eBxqpIySVuyGDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1CFD913301; Tue, 29 Aug 2023 09:13:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id irPtBsW27WS8UwAAMHmgww (envelope-from ); Tue, 29 Aug 2023 09:13:41 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Hannes Reinecke , Sagi Grimberg , Jason Gunthorpe , James Smart , Chaitanya Kulkarni , Christoph Hellwig , Daniel Wagner Subject: [RFC v1 4/4] nvmet-discovery: Do not use invalid port Date: Tue, 29 Aug 2023 11:13:50 +0200 Message-ID: <20230829091350.16156-6-dwagner@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230829091350.16156-1-dwagner@suse.de> References: <20230829091350.16156-1-dwagner@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The port entry binding might not be existing and thus the req->port pointer is not valid. Reproducer: nvme/005 with active system nvmf-autoconnect systemd service. Signed-off-by: Daniel Wagner --- drivers/nvme/target/discovery.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discover= y.c index 668d257fa986..fc113057cb95 100644 --- a/drivers/nvme/target/discovery.c +++ b/drivers/nvme/target/discovery.c @@ -191,6 +191,15 @@ static void nvmet_execute_disc_get_log_page(struct nvm= et_req *req) goto out; } =20 + + /* No port assigned, portentrybinding is missing */ + if (!req->port) { + req->error_loc =3D + offsetof(struct nvme_get_log_page_command, lpo); + status =3D NVME_SC_INVALID_FIELD | NVME_SC_DNR; + goto out; + } + /* * Make sure we're passing at least a buffer of response header size. * If host provided data len is less than the header size, only the --=20 2.41.0