From nobody Thu Dec 18 16:32:45 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECF0C83F12 for ; Sun, 27 Aug 2023 13:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjH0NyV (ORCPT ); Sun, 27 Aug 2023 09:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbjH0Nxx (ORCPT ); Sun, 27 Aug 2023 09:53:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 197EFCE for ; Sun, 27 Aug 2023 06:53:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ABBA762BD9 for ; Sun, 27 Aug 2023 13:53:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 888A8C433CA; Sun, 27 Aug 2023 13:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693144430; bh=2bvndDeKIa1am5zfMWn8oY7XCThEt0L62331HK8Om4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HpsKqOzZidGunvuUuKkUzRb3nxHPc6vpjly9uclBMCkpdnASEMbh1YnJNIzuIbDs7 YwPRHtAGPCt0WsivqZnsO/4j80+ouaxH2miPPoKo+rWIj31qs9kXie4PLbSMlmHwCP MM1fG7LvhxkHPtPod8gs8W8m93I6nxiQdniWVkYsm3BfU6+paCY7ZtlP2O6vGb0Icc sjJb8ffbiBVdGNnWamtfou93biN5+pYsY+gWElJtkrWDnRLG18sNjH0gg3MaBiYRyu njcB1BQ9+akEOgCe7fu1pN/JXOGheQfy7Wxjb6nqDwuVHu/6SiVGMcZ7vtfZg4rf5f wZqSpIl1vo4+A== From: Jisheng Zhang To: Emil Renner Berthing , Samin Guo , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/2] net: stmmac: dwmac-starfive: improve error handling during probe Date: Sun, 27 Aug 2023 21:41:49 +0800 Message-Id: <20230827134150.2918-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230827134150.2918-1-jszhang@kernel.org> References: <20230827134150.2918-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After stmmac_probe_config_dt() succeeds, when error happens later, stmmac_remove_config_dt() needs to be called for proper error handling. Signed-off-by: Jisheng Zhang --- .../ethernet/stmicro/stmmac/dwmac-starfive.c | 34 ++++++++++++------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c b/drivers= /net/ethernet/stmicro/stmmac/dwmac-starfive.c index 892612564694..b68f42795eaa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c @@ -111,18 +111,24 @@ static int starfive_dwmac_probe(struct platform_devic= e *pdev) "dt configuration failed\n"); =20 dwmac =3D devm_kzalloc(&pdev->dev, sizeof(*dwmac), GFP_KERNEL); - if (!dwmac) - return -ENOMEM; + if (!dwmac) { + err =3D -ENOMEM; + goto err_remove_config_dt; + } =20 dwmac->clk_tx =3D devm_clk_get_enabled(&pdev->dev, "tx"); - if (IS_ERR(dwmac->clk_tx)) - return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->clk_tx), - "error getting tx clock\n"); + if (IS_ERR(dwmac->clk_tx)) { + err =3D dev_err_probe(&pdev->dev, PTR_ERR(dwmac->clk_tx), + "error getting tx clock\n"); + goto err_remove_config_dt; + } =20 clk_gtx =3D devm_clk_get_enabled(&pdev->dev, "gtx"); - if (IS_ERR(clk_gtx)) - return dev_err_probe(&pdev->dev, PTR_ERR(clk_gtx), - "error getting gtx clock\n"); + if (IS_ERR(clk_gtx)) { + err =3D dev_err_probe(&pdev->dev, PTR_ERR(clk_gtx), + "error getting gtx clock\n"); + goto err_remove_config_dt; + } =20 /* Generally, the rgmii_tx clock is provided by the internal clock, * which needs to match the corresponding clock frequency according @@ -139,15 +145,17 @@ static int starfive_dwmac_probe(struct platform_devic= e *pdev) =20 err =3D starfive_dwmac_set_mode(plat_dat); if (err) - return err; + goto err_remove_config_dt; =20 err =3D stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); - if (err) { - stmmac_remove_config_dt(pdev, plat_dat); - return err; - } + if (err) + goto err_remove_config_dt; =20 return 0; + +err_remove_config_dt: + stmmac_remove_config_dt(pdev, plat_dat); + return err; } =20 static const struct of_device_id starfive_dwmac_match[] =3D { --=20 2.40.1