From nobody Thu Dec 18 06:03:21 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015ACEE49A5 for ; Fri, 25 Aug 2023 19:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbjHYTFO (ORCPT ); Fri, 25 Aug 2023 15:05:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231292AbjHYTEl (ORCPT ); Fri, 25 Aug 2023 15:04:41 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9413F2137; Fri, 25 Aug 2023 12:04:23 -0700 (PDT) Received: from tundra.lovozera (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id 19AE640F1DD2; Fri, 25 Aug 2023 19:04:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 19AE640F1DD2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1692990260; bh=HOjQG4CO6mnS8bovh06OkveWowgxs5Vdjds2wSVYyBo=; h=From:To:Cc:Subject:Date:From; b=A4pejQaX5waupoG1rPPOAkeLrru+8B/2KDbQ4TvPAAl5gn8u4JLQKgM/2V7rjX+mv e1CgynrK6ktYFtiyRB9eIZu2GzdSZVKYCXJwKkRn6nju4SJRSMr4bjcENOXXyWrsD4 LH/2ry9plKHTqwhg1YhWJrD1N32b/Q5G4p2stMaU= From: Mikhail Kobuk To: Siva Reddy Kallam Cc: Mikhail Kobuk , Prashant Sreedharan , Michael Chan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Jean Delvare , Guenter Roeck , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, lvc-project@linuxtesting.org, Alexey Khoroshilov Subject: [PATCH] ethernet: tg3: remove unreachable code Date: Fri, 25 Aug 2023 22:04:41 +0300 Message-ID: <20230825190443.48375-1-m.kobuk@ispras.ru> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'tp->irq_max' value is either 1 [L16336] or 5 [L16354], as indicated in tg3_get_invariants(). Therefore, 'i' can't exceed 4 in tg3_init_one() that makes (i <=3D 4) always true. Moreover, 'intmbx' value set at the last iteration is not used later in it's scope. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 78f90dcf184b ("tg3: Move napi_add calls below tg3_get_invariants") Signed-off-by: Mikhail Kobuk Reviewed-by: Alexey Khoroshilov Reviewed-by: Michael Chan Reviewed-by: Simon Horman --- drivers/net/ethernet/broadcom/tg3.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/bro= adcom/tg3.c index 5ef073a79ce9..6b6da2484dfe 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -17792,10 +17792,7 @@ static int tg3_init_one(struct pci_dev *pdev, tnapi->tx_pending =3D TG3_DEF_TX_RING_PENDING; =20 tnapi->int_mbox =3D intmbx; - if (i <=3D 4) - intmbx +=3D 0x8; - else - intmbx +=3D 0x4; + intmbx +=3D 0x8; =20 tnapi->consmbox =3D rcvmbx; tnapi->prodmbox =3D sndmbx; --=20 2.42.0