From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B49EE49A3 for ; Fri, 25 Aug 2023 08:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243293AbjHYIMf (ORCPT ); Fri, 25 Aug 2023 04:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243459AbjHYIMT (ORCPT ); Fri, 25 Aug 2023 04:12:19 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFFBF1FF6 for ; Fri, 25 Aug 2023 01:12:15 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ff09632194so944564e87.2 for ; Fri, 25 Aug 2023 01:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951134; x=1693555934; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b+8MTCJJPEn/JGBNuu906jziHv3DlZsxUiatrimUoug=; b=GS9ZcTGr6eW5+Zq7vkkbvhEcpibZWQ4bE8pmXv4GoGIVZVtumdBnWg3aaSsIlpd8eZ OA8Dg6oHck9ZZK5gmQMipqBzNJtD7P6+127+CsUg0/KukeUbnDju+XvY9VTPWNiHfiHr 3Awf4WQHKw1q7nl4tEfdW2APtKyhMOFJOT3NRGM9FZvZp7pM4oYqPnR5halDlgk0CGy8 hHuZclux4yLY9+xGCR1fxz3SfSWT1/rTB3uNfjAaXaDX7QRQFPbF4b4va3xpM2k6qB+u baIyIWcC9n7gAjFCUrFzW6kHaXOn3lx+bs4EYVZyvU2CU4SRf0esWU+o8/S8qclzL3ID Nd2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951134; x=1693555934; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b+8MTCJJPEn/JGBNuu906jziHv3DlZsxUiatrimUoug=; b=bwyAS5rE++R4LrobxO7c8yj35znlqmWfuaMMwg126b+862DGYeUY35u9q3wL2D8tZ1 1th8iwyOWc1/arr5wYfIv95L7WVPuDr/LzqKPP7m8jLz1WuyjbzVCgpSQuT1pK6zTbQ+ htEW1iJhg2fiZIzzGDM+LC0vPrmD1G1YZ4CNec6rXPkSagQ3Nr2qyfViYn3i6PugQL+R 5WH+jRCQCzYBK/uBIY3zCjUwpZbsSUzZk8IxiUIRvrs1ZYMhIJBmGytIYw6m8w6MZfNY Q5Yr/cS1B/wwwNKIR2xDl0uFksJxzQ5XnkfhdLKR/XHwWGe9KkHvT6y611R5TIVRuCt9 fwqA== X-Gm-Message-State: AOJu0YyGCmgSKhDI99w8zfUpeHWAnx9oN+ABopOKZX9WPNk6x1JkHcXT 1AR4UxupM7R1J+90Uw7kLZrfbg== X-Google-Smtp-Source: AGHT+IFmnMm6qB463AlxIIOwocgb6x+Snv48XGIBxuceoO10VWRQRMRDhQd7hZBHJLCafnv2DouLkA== X-Received: by 2002:a05:6512:33c6:b0:4f8:631b:bf77 with SMTP id d6-20020a05651233c600b004f8631bbf77mr14929337lfg.22.1692951134067; Fri, 25 Aug 2023 01:12:14 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:13 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:11 +0200 Subject: [PATCH 1/7] ASoC: max9768: Convert to use GPIO descriptors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-1-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MAX9768 is pretty straight forward to convert to GPIO descriptors. To name the GPIO properties, I looke at the bindings in maxim,max9759.yaml which names these GPIO "mute" and "shutdown" respectively. No board files using platform data exist in the kernel, new users can use GPIO descriptor tables if desired. Signed-off-by: Linus Walleij --- include/sound/max9768.h | 4 ---- sound/soc/codecs/max9768.c | 45 +++++++++++++++++++++++-------------------= --- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/include/sound/max9768.h b/include/sound/max9768.h index 0f78b41d030e..8509ba0079b0 100644 --- a/include/sound/max9768.h +++ b/include/sound/max9768.h @@ -9,14 +9,10 @@ =20 /** * struct max9768_pdata - optional platform specific MAX9768 configuration - * @shdn_gpio: GPIO to SHDN pin. If not valid, pin must be hardwired HIGH - * @mute_gpio: GPIO to MUTE pin. If not valid, control for mute won't be a= dded * @flags: configuration flags, e.g. set classic PWM mode (check datasheet * regarding "filterless modulation" which is default). */ struct max9768_pdata { - int shdn_gpio; - int mute_gpio; unsigned flags; #define MAX9768_FLAG_CLASSIC_PWM (1 << 0) }; diff --git a/sound/soc/codecs/max9768.c b/sound/soc/codecs/max9768.c index d22b4ba51ed8..8d0ca1be99c0 100644 --- a/sound/soc/codecs/max9768.c +++ b/sound/soc/codecs/max9768.c @@ -9,7 +9,7 @@ #include #include #include -#include +#include #include =20 #include @@ -27,8 +27,8 @@ =20 struct max9768 { struct regmap *regmap; - int mute_gpio; - int shdn_gpio; + struct gpio_desc *mute; + struct gpio_desc *shdn; u32 flags; }; =20 @@ -42,7 +42,7 @@ static int max9768_get_gpio(struct snd_kcontrol *kcontrol, { struct snd_soc_component *c =3D snd_soc_kcontrol_component(kcontrol); struct max9768 *max9768 =3D snd_soc_component_get_drvdata(c); - int val =3D gpio_get_value_cansleep(max9768->mute_gpio); + int val =3D gpiod_get_value_cansleep(max9768->mute); =20 ucontrol->value.integer.value[0] =3D !val; =20 @@ -55,7 +55,7 @@ static int max9768_set_gpio(struct snd_kcontrol *kcontrol, struct snd_soc_component *c =3D snd_soc_kcontrol_component(kcontrol); struct max9768 *max9768 =3D snd_soc_component_get_drvdata(c); =20 - gpio_set_value_cansleep(max9768->mute_gpio, !ucontrol->value.integer.valu= e[0]); + gpiod_set_value_cansleep(max9768->mute, !ucontrol->value.integer.value[0]= ); =20 return 0; } @@ -138,7 +138,7 @@ static int max9768_probe(struct snd_soc_component *comp= onent) return ret; } =20 - if (gpio_is_valid(max9768->mute_gpio)) { + if (max9768->mute) { ret =3D snd_soc_add_component_controls(component, max9768_mute, ARRAY_SIZE(max9768_mute)); if (ret) @@ -171,28 +171,29 @@ static int max9768_i2c_probe(struct i2c_client *clien= t) { struct max9768 *max9768; struct max9768_pdata *pdata =3D client->dev.platform_data; - int err; =20 max9768 =3D devm_kzalloc(&client->dev, sizeof(*max9768), GFP_KERNEL); if (!max9768) return -ENOMEM; =20 - if (pdata) { - /* Mute on powerup to avoid clicks */ - err =3D devm_gpio_request_one(&client->dev, pdata->mute_gpio, - GPIOF_INIT_HIGH, "MAX9768 Mute"); - max9768->mute_gpio =3D err ?: pdata->mute_gpio; - - /* Activate chip by releasing shutdown, enables I2C */ - err =3D devm_gpio_request_one(&client->dev, pdata->shdn_gpio, - GPIOF_INIT_HIGH, "MAX9768 Shutdown"); - max9768->shdn_gpio =3D err ?: pdata->shdn_gpio; - + /* Mute on powerup to avoid clicks */ + max9768->mute =3D devm_gpiod_get_optional(&client->dev, + "mute", + GPIOD_OUT_HIGH); + if (IS_ERR(max9768->mute)) + return PTR_ERR(max9768->mute); + gpiod_set_consumer_name(max9768->mute, "MAX9768 Mute"); + + /* Activate chip by releasing shutdown, enables I2C */ + max9768->shdn =3D devm_gpiod_get_optional(&client->dev, + "shutdown", + GPIOD_OUT_HIGH); + if (IS_ERR(max9768->shdn)) + return PTR_ERR(max9768->shdn); + gpiod_set_consumer_name(max9768->shdn, "MAX9768 Shutdown"); + + if (pdata) max9768->flags =3D pdata->flags; - } else { - max9768->shdn_gpio =3D -EINVAL; - max9768->mute_gpio =3D -EINVAL; - } =20 i2c_set_clientdata(client, max9768); =20 --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B803FC7EE2C for ; Fri, 25 Aug 2023 08:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243404AbjHYIMi (ORCPT ); Fri, 25 Aug 2023 04:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243463AbjHYIMT (ORCPT ); Fri, 25 Aug 2023 04:12:19 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C1471FFD for ; Fri, 25 Aug 2023 01:12:16 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4ff88239785so973939e87.0 for ; Fri, 25 Aug 2023 01:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951135; x=1693555935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=UE6boKGPVqfXjOj6kezrHZuNuqoenlcbBk1UNq75Dzm0g2Pi9P0X9/2H+ehfTwgThp VeDtlpy3T7kyjtfxQ49VGYrCVg1ZGDaZYxuP7AY8TpexJxy7Bux81QenPI11jgpmOQQB JVxSqxJJEjUe8HksIlDdkS5iLxHuE6B7tLGJJomdLR82bq0GVOGDYZHgkUOArZcfkJqQ 1Wuo8wyJvkN/8Wj4DI+iLmCefZmkJSf2KrxDV3tY21KQxQkKDsCm3+SDcZv4Ax2HN2rW LwST9/gqyG3fK33e++9Rc6bfQWz+d4ZzvsxL3QMoUnToF6BIENTY6o0X1JPUvmD4y5sO UR8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951135; x=1693555935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dl5LD8wtUJwzoyPBhKwaRw4zVOgRkHeCisg4Hejkfc8=; b=iXs8y2N/XswyyKmpYbdlIr2vRlli2Eo/S7ISD8LBOYVUyH3Xgc6Ll8IaoHKqHYAFud eoFWzVcbjODXqI85gqRO4hN/jzQva5offdM2oucPyduIJNAbwALbNYJaCQ77zrJRFI/l 6wC9cBmybLdEgz53EYTqjTzz6zgl1V7VXmnjNGITYDYDo9tRIRM9HD9cnYsC9xwFBYdU ecUCZq0CrPsekJUbBWU+KTHjEvoNkQyxpyX6LxivE8xzsU6l883L8MfQ6+alh8dt6Veo TA45ywzIXUZ61CjC6YB+vr0LUiuNeZH9WSFILeTUZAPSjR2sNIoIlrEJwxM20ENBMFKI IUGg== X-Gm-Message-State: AOJu0Yw893BL0HD4hnjIYgdXGJ3B3De7oodEt44WGmUpLHx7c6U/Vfz0 dr2fR4aY29OfAuBxv9ZY3XVPKg== X-Google-Smtp-Source: AGHT+IGxHJkRNODVm8P/TbKsQyAV+vSBwvi23v8AHQLwDxjxd7+pzwYP7Kx6g7WRigVcKLEdglU1zg== X-Received: by 2002:a19:6451:0:b0:4fb:893e:8ffc with SMTP id b17-20020a196451000000b004fb893e8ffcmr11486265lfj.17.1692951134839; Fri, 25 Aug 2023 01:12:14 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:14 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:12 +0200 Subject: [PATCH 2/7] ASoC: max98357a: Drop pointless include MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-2-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98357a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 2a2b286f1747..cc811f58c9d2 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CB0EE49A5 for ; Fri, 25 Aug 2023 08:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243533AbjHYIMk (ORCPT ); Fri, 25 Aug 2023 04:12:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243492AbjHYIMU (ORCPT ); Fri, 25 Aug 2023 04:12:20 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6723D1FFF for ; Fri, 25 Aug 2023 01:12:17 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4ff8f2630e3so954466e87.1 for ; Fri, 25 Aug 2023 01:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951135; x=1693555935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=ZXicqbRubMjwCeZSDp32zGvSe2Cg8/FKjVonc3OsBRO2krXO9cvadTN+LEo+huL3zn OIhuzcmuZ3+DNGfyUWUCnuHFZT6ri6Nm07495TVslpIaSQ+NwKVr6zekLYT0PZSblQrs wagBfLfbz5NQpkh7nX06Io3lM54ZJt2f6MhCztCKdKx86JpxnpZlXLGy1+BQ1Im+EdaN AGZG/AsNNs0dYj56gsC/jkl6aRqlgLHWJ1hpp1h+Mfw6U8oU3wtq7mCeGrhqhOULtwHX 1BxTwnLpJ71GxdGgkFs12MOHXaxOu6FTOzDbnJZI20sPRMcQu5+jN9t8fL8hzsj5adyJ pXTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951135; x=1693555935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NBbRRSYAQA5xmq25ubQ8kHHlKCIWtZeRLr/sb85xuNU=; b=jEWlRoJXml/xE99ZaxxWw9KuD19jzcxtej2Me+AqgWc/NLYE7kVubk1J6E3R6bgDOP xQe5AZ1lD7nluGh/pB2i2z6/pTAIpnhEoDnuBkapuGSTNQEQPDK/5x4Jhonebx6L55ii TYqW7mVgQFEaflVqn6C6+OQVdyS0lNrbCA1ROT1Qs478N1AozictivU/9yiI8MVBHgCK TCOVVCJ00QiMtZ6mCocvIgFF+IuY8l9Xmlkiab3msVA15BzGbxRkn3FlDIReHhrvSyEc 3wAgnsV2JIBI7Vs1xQ09OwSiLUT50cMNGmnUSKAQ+0yQs2Aucs9yQKNuhveECNHpe4VD 2EZA== X-Gm-Message-State: AOJu0Yx1TAqwykpUZahRBgJrYYnnGOBNpLEB6UccqEPoatXv8O+/xKJ/ A6kdc81FKDKBkKEA/HJ5sXilIg== X-Google-Smtp-Source: AGHT+IEPLIDpD1w1RF98YcjynCIXKHZQox8F22rws/cF0RMIh/cKJbjBBRiwjVgcU5sTSiS7K0f0rA== X-Received: by 2002:a05:6512:615:b0:4fd:c923:db59 with SMTP id b21-20020a056512061500b004fdc923db59mr11392637lfe.15.1692951135669; Fri, 25 Aug 2023 01:12:15 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:15 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:13 +0200 Subject: [PATCH 3/7] ASoC: max98373: Convert to use GPIO descriptors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-3-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of relying on legacy interfaces, convert the driver to use GPIO descriptors. This is a straight-forward conversion, we support also sdw devices providing GPIO descriptor tables if they so desire. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98373-i2c.c | 17 ----------------- sound/soc/codecs/max98373.c | 35 +++++++++++++++++++---------------- sound/soc/codecs/max98373.h | 2 +- 3 files changed, 20 insertions(+), 34 deletions(-) diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2= c.c index 0fa5ceca62a2..e7ec7875c4a9 100644 --- a/sound/soc/codecs/max98373-i2c.c +++ b/sound/soc/codecs/max98373-i2c.c @@ -3,12 +3,10 @@ =20 #include #include -#include #include #include #include #include -#include #include #include #include @@ -560,21 +558,6 @@ static int max98373_i2c_probe(struct i2c_client *i2c) /* voltage/current slot & gpio configuration */ max98373_slot_config(&i2c->dev, max98373); =20 - /* Power on device */ - if (gpio_is_valid(max98373->reset_gpio)) { - ret =3D devm_gpio_request(&i2c->dev, max98373->reset_gpio, - "MAX98373_RESET"); - if (ret) { - dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", - __func__, max98373->reset_gpio); - return -EINVAL; - } - gpio_direction_output(max98373->reset_gpio, 0); - msleep(50); - gpio_direction_output(max98373->reset_gpio, 1); - msleep(20); - } - /* Check Revision ID */ ret =3D regmap_read(max98373->regmap, MAX98373_R21FF_REV_ID, ®); diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index fde055c6c894..33eb4576da23 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -12,9 +12,8 @@ #include #include #include -#include +#include #include -#include #include #include "max98373.h" =20 @@ -478,20 +477,24 @@ void max98373_slot_config(struct device *dev, max98373->i_slot =3D value & 0xF; else max98373->i_slot =3D 1; - if (dev->of_node) { - max98373->reset_gpio =3D of_get_named_gpio(dev->of_node, - "maxim,reset-gpio", 0); - if (!gpio_is_valid(max98373->reset_gpio)) { - dev_err(dev, "Looking up %s property in node %s failed %d\n", - "maxim,reset-gpio", dev->of_node->full_name, - max98373->reset_gpio); - } else { - dev_dbg(dev, "maxim,reset-gpio=3D%d", - max98373->reset_gpio); - } - } else { - /* this makes reset_gpio as invalid */ - max98373->reset_gpio =3D -1; + + /* This will assert RESET */ + max98373->reset =3D devm_gpiod_get_optional(dev, + "maxim,reset", + GPIOD_OUT_HIGH); + if (IS_ERR(max98373->reset)) { + dev_err(dev, "error %ld looking up RESET GPIO line\n", + PTR_ERR(max98373->reset)); + return; + } + + /* Cycle reset */ + if (max98373->reset) { + gpiod_set_consumer_name(max98373->reset ,"MAX98373_RESET"); + gpiod_direction_output(max98373->reset, 1); + msleep(50); + gpiod_direction_output(max98373->reset, 0); + msleep(20); } =20 if (!device_property_read_u32(dev, "maxim,spkfb-slot-no", &value)) diff --git a/sound/soc/codecs/max98373.h b/sound/soc/codecs/max98373.h index e1810b3b1620..af3b62217497 100644 --- a/sound/soc/codecs/max98373.h +++ b/sound/soc/codecs/max98373.h @@ -213,7 +213,7 @@ struct max98373_cache { =20 struct max98373_priv { struct regmap *regmap; - int reset_gpio; + struct gpio_desc *reset; unsigned int v_slot; unsigned int i_slot; unsigned int spkfb_slot; --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B15DEE49AB for ; Fri, 25 Aug 2023 08:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243574AbjHYIMl (ORCPT ); Fri, 25 Aug 2023 04:12:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243501AbjHYIMV (ORCPT ); Fri, 25 Aug 2023 04:12:21 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B1E31FF9 for ; Fri, 25 Aug 2023 01:12:18 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ff9b389677so916626e87.3 for ; Fri, 25 Aug 2023 01:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951136; x=1693555936; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nZvQIqiJILx7Vu44bdAP6xXOlwSKHGpCyi7z1wxsqaw=; b=YYmfBumd1OqmN1kcJfKuQGJb+t6phEs/bHy0wzfEWEPqcBhHzQFEh7HWO5r7zI3KzK rlE/o9gkuU4tb4GOeW4HKbUsN4tkJmcv9YMo41BmkTy+9R1GtaXSAsW3wVlwpfWsEaQj 8pklm/io7r+91riwH1xb5DOgZnUTBIZ0vR8JR1x2dqCZS97VqmBV8Ur1otWfoIshvjrz LkVGMccfYQkq52qo+UQfxt4+1PtThFLeIEJhJmU3qzaD2IjQ7a7EB360vPqny0hrF3W0 /mVzGnGBe1gq8JM9tvtCVn/0J5kT2aFW1S95QT0J17Uq8WsOaG7xNMP2r1qD5UbtS/5r Sk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951136; x=1693555936; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nZvQIqiJILx7Vu44bdAP6xXOlwSKHGpCyi7z1wxsqaw=; b=kVHk5LFwarZb2g8zDpZXezNqzhNgujHr46uq/1FYXFmlKs2t7xy1YdxgDFNk36w/EG NuCBHlISJmOWL8LWjDX5k6tfrJgu3fczaxsrxkQxSjg10DmlYMi74+vaArQ2TqwXD+nm dRomgyQvaMqeAp6UmPNpKTN6z4u8AE+gysq3FT+0xlzv8kZUrCi1lzdU+Eja28xwQjpY kbng080klfu5p1LUJ/VJznQM5+iipRxfoutEz9ANPVxzjRFhWcTBlSfwmDVJcNcf0f0G lV9eL99o4qJeVEHkRpU8PHGZ6uSUXevTFDcMPMZ70hXM1b/24ZSHcCUSNAPDalWQvYGF ic8g== X-Gm-Message-State: AOJu0YzV+qa1aZD0Z5yj1DKGnloOTsjhT1Xrw5Eqwx2dJ6cmHrq7bmZ8 eLa2ZXeHImBV6WTyK0YI/6toqQ== X-Google-Smtp-Source: AGHT+IG2PpNK4ugGGs+dTr6KbXE8uHau4dcclyQjik08hXAm1AW/KDfAXQLnuJhnsM+8CSpY83s9Ig== X-Received: by 2002:a05:6512:32a9:b0:500:a6c1:36f7 with SMTP id q9-20020a05651232a900b00500a6c136f7mr1030311lfe.3.1692951136501; Fri, 25 Aug 2023 01:12:16 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:16 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:14 +0200 Subject: [PATCH 4/7] ASoC: max98388: Correct the includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-4-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MAX98388 driver is using the modern GPIO descriptor API but uses legacy includes. Include the proper header instead. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98388.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98388.c b/sound/soc/codecs/max98388.c index cde5e85946cb..078adec29312 100644 --- a/sound/soc/codecs/max98388.c +++ b/sound/soc/codecs/max98388.c @@ -3,12 +3,11 @@ =20 #include #include -#include +#include #include #include #include #include -#include #include #include #include --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04CACEE49AD for ; Fri, 25 Aug 2023 08:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243600AbjHYIMm (ORCPT ); Fri, 25 Aug 2023 04:12:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243505AbjHYIMV (ORCPT ); Fri, 25 Aug 2023 04:12:21 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F4691FF6 for ; Fri, 25 Aug 2023 01:12:19 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe27849e6aso927800e87.1 for ; Fri, 25 Aug 2023 01:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951137; x=1693555937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=bPi55yZm+3mup9ggSLUCjMWmRb49okeCF+W/OznEmbeZRtK02YnHTszrQ5+Yy1lVJE FtbEsbpuiImJA7hZOJNZCCRgfo0YFxdKzRiKy5UEzNhL+4M53w7sMmYRHZOG7ewHXJF1 BGPt8tIiHS34hZgZkYVGV0pg3iYwr9/LpwQwMeStJUz3XwO4kMfB6XH/0W6V2Bmphf5o O3mmgi3GY25eEL+fFun4wUcaJCesVXoeNpS/trH8TQeIMS38WSV4b0MMNYAWKb0boreu 7cW/63vZlUtX245mPHNpyw782/X9SAa/rAKyRgmXzZkGLLnXiCqFdpQDiQmQsAIYCPVD +hDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951137; x=1693555937; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/HhJkYfqyaXs9yIGYFPPzlpsmAC+qKTgrrYF36b8es=; b=LqASPCuBgP7J27OrS8498qDAUA5fmdWZgCl5l6iuBoM5LL/L8hdXjM6xxeGCu/fFZm x9HGENqnZGY988F2bYwe+zB+0p4izj7YaBd1fjCSXzipKTWjfSBf0jPoevJvsjGF9J6/ wDTU3Gjkl7TgblBjGDO82xruzfkHa3bdjGdKvgfFenKOYnoFKOlNoN5nOZGbVtbKz0py OGU5oYkZC0cHYnSLdEA85o3QDUg4h7yUlrozcDZPkQD74tT1itU0ddRog9wjmnLyW066 KSQRNME6CvnLc2ayVFMspmU3iu0WeWwjjVv7AswfuzFEPLUF0HmWvkTkZlY9/0Sig1/J na5A== X-Gm-Message-State: AOJu0YxJySRzekZ3Sr8+ru+4PHyGLJhroeKCL4lbo2VkKz6jQ0rdNFk4 9fvyWapCQdkakMerx7kdppBKBw== X-Google-Smtp-Source: AGHT+IEyHJmheRscOX7UBeg6Z7DcJVfwt0W14guOb3+tSfGq9EVhRyrhY8ha1hu6hxSTW7rsulAyig== X-Received: by 2002:a05:6512:32cc:b0:4fd:fabf:b6ee with SMTP id f12-20020a05651232cc00b004fdfabfb6eemr14730764lfg.9.1692951137399; Fri, 25 Aug 2023 01:12:17 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:16 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:15 +0200 Subject: [PATCH 5/7] ASoC: max98396: Drop pointless include MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-5-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy header . Drop it. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98396.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/max98396.c b/sound/soc/codecs/max98396.c index 3a1d8c211f3c..e52bb2266fa1 100644 --- a/sound/soc/codecs/max98396.c +++ b/sound/soc/codecs/max98396.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include "max98396.h" =20 --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317ECEE49B3 for ; Fri, 25 Aug 2023 08:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243641AbjHYIMn (ORCPT ); Fri, 25 Aug 2023 04:12:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243519AbjHYIMW (ORCPT ); Fri, 25 Aug 2023 04:12:22 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF0061FF7 for ; Fri, 25 Aug 2023 01:12:19 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ffa248263cso972107e87.2 for ; Fri, 25 Aug 2023 01:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951138; x=1693555938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=44JIVg8xfT/EISToMUTEvN6PJWh2bmWBrdxrTpht5uo=; b=eFQD4cq8n2Fct8am3VeuEldkXRZ1tKBntwqnqD83Ex1Nr4ejqLxsjn7wE4+qyoKqKQ sVq0njntmTxoUdnoBWXC/4s+dCmMoE1cBOKu3QouzqfEJhaXa8ZCcBjYXWYI395Oor7R +hfvzByRJWEJGlkHOCaPtGggPLdnU2tvqLZS6fkeuOV4Kvc8Co+GB1fqqfydPWBYsfNC FEZZvAkN4PHfmxWWRgWzbEo0pHyn1XHZDXeTUSyHlUNBAn88ysXgTs32FDJEqsGRJAO7 kUMjWAkuXkUXM9Xcaz31hMYrJD/BMgNLztCapcSVPnuWja8QEQ8oDy1UzjIJmF+lu3xV kZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951138; x=1693555938; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=44JIVg8xfT/EISToMUTEvN6PJWh2bmWBrdxrTpht5uo=; b=gOcpy3grd9VDzefQ1HqZVfO3kFzqutFyD/y0BDjcvKWGeoOECokir5WaReJZCcPy7n YdeqCDTQdj/HIiWYcOvC16+jombLVtzzJlGCZ3KYDuelKs0fGHXica7beyJ2v/U8k3is ED5VVgbroN/7brcR2xO6n7sZk5Zt5JGzQODdBR7xhN7bih1O1x+wUPfZzjCrcjv4PsKy N3dnexNg6fYIVWeeytHZkt8hpZ/zvDfJiUgtqep8dn6h43ttZGieAGnNTFu49C0YdbYz 2Em6xEkZWrM20nYjiBYzkZ/N9+atNdXq+2g4uew3V0zhe+I+yT3HotR8mbRi24nJaV2G j1Jg== X-Gm-Message-State: AOJu0Yx1yhId6+FgtlocaTLhAgfLmgluEtffzI8svfnSfDoWFiwkAWGE TalGDG7sfab2eUqdkGnp2g9z4w== X-Google-Smtp-Source: AGHT+IEodFZz3bqeeFdOiK7hMl+uUlbSgt9vuSKj8ccHrNjvWe6heS8Ntxi3tANPFEcCQKm5bqj6mw== X-Received: by 2002:a05:6512:e99:b0:500:7de4:300e with SMTP id bi25-20020a0565120e9900b005007de4300emr13571895lfb.58.1692951138141; Fri, 25 Aug 2023 01:12:18 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:17 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:16 +0200 Subject: [PATCH 6/7] ASoC: max98520: Drop pointless includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-6-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy headers or . Drop them. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98520.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/max98520.c b/sound/soc/codecs/max98520.c index 8637fff307ad..edd05253d37c 100644 --- a/sound/soc/codecs/max98520.c +++ b/sound/soc/codecs/max98520.c @@ -11,10 +11,8 @@ #include #include #include -#include #include #include -#include #include #include "max98520.h" =20 --=20 2.34.1 From nobody Mon Feb 9 12:11:55 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C91EE49B2 for ; Fri, 25 Aug 2023 08:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243692AbjHYIMo (ORCPT ); Fri, 25 Aug 2023 04:12:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243513AbjHYIMW (ORCPT ); Fri, 25 Aug 2023 04:12:22 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7000CEE for ; Fri, 25 Aug 2023 01:12:20 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4ff882397ecso922011e87.3 for ; Fri, 25 Aug 2023 01:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692951139; x=1693555939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RoFqFLIfT/Pj/zYgo2TV8TIm3I2iaBuNZRSIlIfashI=; b=N8tOQE1+ggrtynhDr3biXEZNw1zz5cY70hzKKCVyFf+IMR1yXAXthVrO/VesE5LNY6 ZFTe+aebePO3TMPyUdOZVEzyfSEQc3DteeWzMyV2gwsGhB8kOMWjjZYb6Wf5JEfx1+lz 8TsDpUMI2g2nGjoUR29rC0agQh6w0db6a1QcHGvJg887QaBWx2t8czqalAywY0CXoOwg 40YCYGtu37bDDcAr4YtLIVR4Jy5MjaA0st0MTxF+h46IeoWNobjmX37+IvsTNDHZ9mjk M9aHhdvbtyHYBSZ+6mVz7bXGNAl4LlIbJ/3sigo6Emyc+iCyMEDtEpqqG2rHBisr8V3F 5fFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692951139; x=1693555939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RoFqFLIfT/Pj/zYgo2TV8TIm3I2iaBuNZRSIlIfashI=; b=Wq5b/kKHMXjU1vcy+bLdy69XvmdIU5R31imhhFIre+cvD33ttYzDA5Ok/N9DGwTtTP EYSRa8GmuRhKBVyvIZsABIKTkuOTfrD2eBBaCthESLOxWRMcer1nw9vBJhnlZYBI40+O rKDBKT7NWuikxGc3lAWaj7KaisR/YtlkTKajAwc2KyfHNlp49/xAxTAYm2Pde1qKAUuQ +20hGmnjxLvmeksqXmZNGaSqEW69ygeqnmu0nRLSouPyZZq6zTDrVSPemIoEIzxC8QPq SfbQWrTBToNsM5hXAAYoxO0fAPFxgRBYY9hkQAnWD+jTXagsl3krpkb2+Fjr2Ed6l17z sgNw== X-Gm-Message-State: AOJu0Yzqqq0A8UYxIEGyDgdeWTqRhhWm6kkiakPROWIrdoVDmrIKBv4A ItMw+fB7w8WV416XoTKx4PyoYg== X-Google-Smtp-Source: AGHT+IEjrTALuwMVuRJO/f49NCeBOByJE1JiQEqP9VZfv9t+k1WQ0Gs+avCqvnzSr9p3zL8bSAc/pA== X-Received: by 2002:a05:6512:3450:b0:4fb:99d9:6ba2 with SMTP id j16-20020a056512345000b004fb99d96ba2mr10022257lfr.24.1692951139010; Fri, 25 Aug 2023 01:12:19 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q28-20020ac2511c000000b004fe1a35fd15sm195559lfb.140.2023.08.25.01.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 01:12:18 -0700 (PDT) From: Linus Walleij Date: Fri, 25 Aug 2023 10:12:17 +0200 Subject: [PATCH 7/7] ASoC: max98927: Drop pointless includes MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230825-descriptors-asoc-max-v1-7-b212292b2f08@linaro.org> References: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> In-Reply-To: <20230825-descriptors-asoc-max-v1-0-b212292b2f08@linaro.org> To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver is already using solely GPIO descriptors and do not need to include the legacy headers or . Drop them. Signed-off-by: Linus Walleij --- sound/soc/codecs/max98927.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c index 776f23d38ac5..70db9d3ff5a5 100644 --- a/sound/soc/codecs/max98927.c +++ b/sound/soc/codecs/max98927.c @@ -15,9 +15,7 @@ #include #include #include -#include #include -#include #include #include "max98927.h" =20 --=20 2.34.1