From nobody Tue Dec 16 20:00:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D4F0C88CB9 for ; Thu, 24 Aug 2023 21:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243587AbjHXVNW (ORCPT ); Thu, 24 Aug 2023 17:13:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243618AbjHXVM7 (ORCPT ); Thu, 24 Aug 2023 17:12:59 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A6B21BCC for ; Thu, 24 Aug 2023 14:12:49 -0700 (PDT) Received: from localhost (unknown [81.18.92.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id DDB496607281; Thu, 24 Aug 2023 22:12:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1692911568; bh=ZEk4vxttkiExCnA+WQA0eWrX8wJNdUD6swJb0CzA9Uw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nzQyrE6j+7k2SQ4rJqt4CtrpRT0K7+LW9s+ZtLgre9uJKLDisAz/d59ApKK9SnQk2 75zBJv7S5knRqC5zuM19nchhsY8HS9nXTu5cdOdvTEt12w9FO7q5BDAhOmmRmjLc8S iqQWfCAEF6yT6SyAKuyN4A9z/beQUWvX/LTNcvYgqUAEG8MMq6TmG0inDEeyod1V0/ SnWM7ww97PyOyRr1knTgYRXguPIyIhiM5rl7glnUMBDLZSCXgkjs/+LAS94ywDR3cT nS45Bz8CRx+5tnK3654jvweplaEjZY+VQmZ72kHO2A20cUHw/ufwxoIOuBqtLJ8FF8 owJMK+HYXAZ0A== From: Cristian Ciocaltea To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH v2 1/2] ASoC: core: Do not error if a DAI link component is not found Date: Fri, 25 Aug 2023 00:12:40 +0300 Message-ID: <20230824211241.388201-2-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230824211241.388201-1-cristian.ciocaltea@collabora.com> References: <20230824211241.388201-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" A recent cleanup of soc_dai_link_sanity_check() is responsible for generating lots of confusing errors before returning -EPROBE_DEFER: acp5x_mach acp5x_mach.0: ASoC: Component acp5x_i2s_dma.0 not found for li= nk acp5x-8821-play [...] acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:00 not found for lin= k acp5x-CS35L41-Stereo [...] acp5x_mach acp5x_mach.0: ASoC: Component spi-VLV1776:01 not found for lin= k acp5x-CS35L41-Stereo Switch back to the initial behaviour of logging those messages on KERN_DEBUG level instead of KERN_ERR. Fixes: 0e66a2c69409 ("ASoC: soc-core.c: cleanup soc_dai_link_sanity_check()= ") Signed-off-by: Cristian Ciocaltea --- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index a5b96c17633a..75a9641349ee 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1003,7 +1003,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_c= ard *card, return -EINVAL; =20 component_not_find: - dev_err(card->dev, "ASoC: Component %s not found for link %s\n", dlc->nam= e, link->name); + dev_dbg(card->dev, "ASoC: Component %s not found for link %s\n", dlc->nam= e, link->name); return -EPROBE_DEFER; =20 dai_empty: --=20 2.41.0 From nobody Tue Dec 16 20:00:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B25C83003 for ; Thu, 24 Aug 2023 21:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243550AbjHXVNV (ORCPT ); Thu, 24 Aug 2023 17:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243628AbjHXVM7 (ORCPT ); Thu, 24 Aug 2023 17:12:59 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65751BE5 for ; Thu, 24 Aug 2023 14:12:51 -0700 (PDT) Received: from localhost (unknown [81.18.92.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id 936386607287; Thu, 24 Aug 2023 22:12:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1692911570; bh=d4zubvJCvoX5O/QaOHaUQJ+vrBBsgC/+w6pj/RAtno4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E62eTY9Qovw2dR/eYxINN9IWZpefYqNMtyqHE4yWoiEa2Y29560V/Wte9mfIEU9Sd E90RMuj60OxFx0Ijail4qTM640oNzkfG46AGIdHGP1wNPD4PfC7hMsH8eYsncBgGrG aWSrwABpgsq1kybqHpaM28SegUdPU5Jei7ncxMQKgcoj8/A/Fe7hNr8GskmUY3av3P uZmAPCssv337+vhieeX0FpUX58mRHVmxzIWG2w85/A8UaDrOtPHg/teswuevC7v8tA EuSbrm2O41XNo+JoiYIqVKNg3C0xMF6WJP8DtcCYswRnOjXXYKud6mtIzc04jJ2D33 2f29FLyuv7FJg== From: Cristian Ciocaltea To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: [PATCH v2 2/2] ASoC: core: Rename component_not_find label Date: Fri, 25 Aug 2023 00:12:41 +0300 Message-ID: <20230824211241.388201-3-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230824211241.388201-1-cristian.ciocaltea@collabora.com> References: <20230824211241.388201-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use the correct form of the verb in 'component_not_find' label, from soc_dai_link_sanity_check() function. Signed-off-by: Cristian Ciocaltea --- sound/soc/soc-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 75a9641349ee..cc442c52cdea 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -942,7 +942,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_car= d *card, * component list. */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } =20 /* Platform check */ @@ -963,7 +963,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_car= d *card, * component list. */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } =20 /* CPU check */ @@ -988,7 +988,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_car= d *card, * Defer card registration if Component is not added */ if (!soc_find_component(dlc)) - goto component_not_find; + goto component_not_found; } } =20 @@ -1002,7 +1002,7 @@ static int soc_dai_link_sanity_check(struct snd_soc_c= ard *card, dev_err(card->dev, "ASoC: Neither Component name/of_node are set for %s\n= ", link->name); return -EINVAL; =20 -component_not_find: +component_not_found: dev_dbg(card->dev, "ASoC: Component %s not found for link %s\n", dlc->nam= e, link->name); return -EPROBE_DEFER; =20 --=20 2.41.0