From nobody Thu Dec 18 17:06:34 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D0CC88CB2 for ; Thu, 24 Aug 2023 08:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240523AbjHXIpM (ORCPT ); Thu, 24 Aug 2023 04:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240598AbjHXIo6 (ORCPT ); Thu, 24 Aug 2023 04:44:58 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962041996 for ; Thu, 24 Aug 2023 01:44:31 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-68bec436514so526712b3a.1 for ; Thu, 24 Aug 2023 01:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692866671; x=1693471471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q0h2wCokTLJGZ1d7u4CaVmkJlNkioh2OoblHBPOXP7Y=; b=GU+s3fTu2FDxNiPO58MSm3Vxp4woxATRdJTPDCQwLL020xXBUtA+4rnYDfxN1W9Q7K fMuLfJgKDC1gIgYy2HB5IAbX899ZwGBQqGxFPKqBFZqHNIG+hjC2mladvuojiZu++ecW Knx30ngXQpHJi832AuCm9Uic2F+d+JhZ0xVqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692866671; x=1693471471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0h2wCokTLJGZ1d7u4CaVmkJlNkioh2OoblHBPOXP7Y=; b=lWFd2nI6LQOyYeJ+U+aJQxFQ7l8SAIJJMNeOIf0XYzI+zbFqEDPEfTy3hQ1gs1Ph1K AF8u1ji3hscWkIiiBN5ZM7J8/9xDQbRwG/AOJqm9c3BiIi32gBvlqLZtymwQX5dWF3pC BuxYn0SxrWiJRX7C6pxsqv/WA3AG0MYtWtYXr9IqMSYJM9uUfwo6F3PJd6wcuxhaetZN S2whzEMJrcVKKYsTV42Ml+0yEwONrTXHlfNpLDitVj5gCWkRbxFy2ccA+LLNL2igksX6 wj1daS/g3MADOeqn33YHR29uhnbWTsTTqRajvPhzXra8zpDIkU4NF3iGC6bPgedia9Bl AkAA== X-Gm-Message-State: AOJu0Yz7XdjPqo214kboLlAdYAXPULufeJzrq7LkC3YyptmwEFmHsi/2 bl6IPtxR69/22vkKf+kGqUrK5g== X-Google-Smtp-Source: AGHT+IHGBOkAybyBRvbwW8FZvSLHgn3d4Dl+7Q7Y2duNrnaif+0P80U7WBGBKSEy6npZMepLI1LnLg== X-Received: by 2002:a17:90b:a0e:b0:263:931b:bb5f with SMTP id gg14-20020a17090b0a0e00b00263931bbb5fmr11269635pjb.14.1692866671127; Thu, 24 Aug 2023 01:44:31 -0700 (PDT) Received: from datalore.c.googlers.com.com (148.175.199.104.bc.googleusercontent.com. [104.199.175.148]) by smtp.gmail.com with ESMTPSA id 12-20020a17090a194c00b00268188ea4b9sm1150216pjh.19.2023.08.24.01.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 01:44:30 -0700 (PDT) From: Brandon Pollack To: marius.vlad@collabora.com, jshargo@chromium.org Cc: corbet@lwn.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mairacanal@riseup.net, melissa.srw@gmail.com, mripard@kernel.org, rodrigosiqueiramelo@gmail.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mduggan@chromium.org, hirono@chromium.org, Brandon Pollack Subject: [PATCH v4 3/7] drm/vkms: Provide platform data when creating VKMS devices Date: Thu, 24 Aug 2023 08:40:34 +0000 Message-ID: <20230824084350.1062579-4-brpol@chromium.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824084350.1062579-1-brpol@chromium.org> References: <20230824084350.1062579-1-brpol@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jim Shargo This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c | 14 ++++++++++++-- drivers/gpu/drm/vkms/vkms_drv.h | 9 ++++++--- drivers/gpu/drm/vkms/vkms_output.c | 2 +- 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_dr= v.c index 65b1e2c52106..6c94c2b5d529 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -9,6 +9,7 @@ * the GPU in DRM API tests. */ =20 +#include "asm-generic/errno-base.h" #include #include #include @@ -171,12 +172,14 @@ static int vkms_modeset_init(struct vkms_device *vkms= dev) dev->mode_config.preferred_depth =3D 0; dev->mode_config.helper_private =3D &vkms_mode_config_helpers; =20 - return vkms_output_init(vkmsdev, 0); + return vkmsdev->is_default ? vkms_output_init_default(vkmsdev) : + -EINVAL; } =20 static int vkms_platform_probe(struct platform_device *pdev) { int ret; + struct vkms_device_setup *vkms_device_setup =3D pdev->dev.platform_data; struct vkms_device *vkms_device; void *grp; =20 @@ -195,6 +198,7 @@ static int vkms_platform_probe(struct platform_device *= pdev) vkms_device->config.cursor =3D enable_cursor; vkms_device->config.writeback =3D enable_writeback; vkms_device->config.overlay =3D enable_overlay; + vkms_device->is_default =3D vkms_device_setup->is_default; =20 ret =3D dma_coerce_mask_and_coherent(vkms_device->drm.dev, DMA_BIT_MASK(64)); @@ -258,6 +262,9 @@ static int __init vkms_init(void) { int ret; struct platform_device *pdev; + struct vkms_device_setup vkms_device_setup =3D { + .is_default =3D true, + }; =20 ret =3D platform_driver_register(&vkms_platform_driver); if (ret) { @@ -265,8 +272,11 @@ static int __init vkms_init(void) return ret; } =20 - pdev =3D platform_device_register_simple(DRIVER_NAME, -1, NULL, 0); + pdev =3D platform_device_register_data(NULL, DRIVER_NAME, 0, + &vkms_device_setup, + sizeof(vkms_device_setup)); if (IS_ERR(pdev)) { + DRM_ERROR("Unable to register default vkms device\n"); platform_driver_unregister(&vkms_platform_driver); return PTR_ERR(pdev); } diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index 761cd809617e..4262dcffd7e1 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -132,17 +132,20 @@ struct vkms_output { struct vkms_plane planes[VKMS_MAX_PLANES]; }; =20 -struct vkms_device; - struct vkms_config { bool writeback; bool cursor; bool overlay; }; =20 +struct vkms_device_setup { + bool is_default; +}; + struct vkms_device { struct drm_device drm; struct platform_device *platform; + bool is_default; struct vkms_output output; struct vkms_config config; }; @@ -166,7 +169,7 @@ struct vkms_crtc *vkms_crtc_init(struct vkms_device *vk= msdev, struct drm_plane *primary, struct drm_plane *cursor); =20 -int vkms_output_init(struct vkms_device *vkmsdev, int index); +int vkms_output_init_default(struct vkms_device *vkmsdev); =20 struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev, enum drm_plane_type type); diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms= _output.c index 86faf94f7408..bfc2e2362c6d 100644 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ b/drivers/gpu/drm/vkms/vkms_output.c @@ -80,7 +80,7 @@ static struct drm_encoder *vkms_encoder_init(struct vkms_= device *vkms_device) return encoder; } =20 -int vkms_output_init(struct vkms_device *vkmsdev, int index) +int vkms_output_init_default(struct vkms_device *vkmsdev) { struct vkms_output *output =3D &vkmsdev->output; struct drm_device *dev =3D &vkmsdev->drm; --=20 2.42.0.rc1.204.g551eb34607-goog