From nobody Thu Dec 18 16:51:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9A6C83003 for ; Thu, 24 Aug 2023 08:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236816AbjHXIpL (ORCPT ); Thu, 24 Aug 2023 04:45:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240558AbjHXIov (ORCPT ); Thu, 24 Aug 2023 04:44:51 -0400 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2594119BD for ; Thu, 24 Aug 2023 01:44:26 -0700 (PDT) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1c4cf775a14so4125992fac.3 for ; Thu, 24 Aug 2023 01:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692866665; x=1693471465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9xQIXi7bu5jPEvUoNFU5+d+V/znMEpTNbM7qk9XTFgo=; b=kFgLoYo0FaOPKhs1lmfd5DVoO9TE4PDNE/xQ+frAM88Hdn/OHiAcSwtXJ2oonkAZ5+ aLvg9qXf6lVzVfbvGHdhacDgjeNqj02nRCzW9NbdUA0kG335kP/AiB3B142z0WiyPcZi qL/RX+SXkjbuoowNNxcWj0/1YRMtuK/OGVxwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692866665; x=1693471465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9xQIXi7bu5jPEvUoNFU5+d+V/znMEpTNbM7qk9XTFgo=; b=X7Y2osDyOlIxh4Y3jCxHm9LFZUlcUjbhvQskixMRiCgzV88T6eBEIN4bTVdKrkUL2P SZLvx8soOYdLKKwsxtRsJTOGAWEep5DEThvZ4EIuSai8VkO7OzBZOXOzqnbTse2AkmXs FvvT4bah2iLud+Bat1S6G2agXEKzb+CC0HLhrlfdARWIfWRvKvU4A1wGxgDaBvGkDTuV 7slQIRORvodR82Q6kwbA8gDpqE7hksgIrXrSWnWuFmLicHf6J8HyKgEhieF+aBcNwhrj 4k68B+HB9nLDd9vtVuc3rvPNOngUiAw5a6teV0AWyF2gRlaGrWMfV4qz/5GuXaXdPPds 7hPg== X-Gm-Message-State: AOJu0Yw9hxN8/6S/vLu7k9HFgdYP9IwOfCmC7YA1NOeq5ey0e+agzNNI mNiL4pDQhvBlxcqMXM1J1i3iJA== X-Google-Smtp-Source: AGHT+IELrnL1C+ITWi0Dxq+NXA4mwtLfs4yEvI0u3Rk6eCKFUZHu/ZH0XBOzaVPkJU2vUPAjuqNFpw== X-Received: by 2002:a05:6870:64aa:b0:1bf:50e0:95d9 with SMTP id cz42-20020a05687064aa00b001bf50e095d9mr18745072oab.26.1692866665238; Thu, 24 Aug 2023 01:44:25 -0700 (PDT) Received: from datalore.c.googlers.com.com (148.175.199.104.bc.googleusercontent.com. [104.199.175.148]) by smtp.gmail.com with ESMTPSA id 12-20020a17090a194c00b00268188ea4b9sm1150216pjh.19.2023.08.24.01.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 01:44:24 -0700 (PDT) From: Brandon Pollack To: marius.vlad@collabora.com, jshargo@chromium.org Cc: corbet@lwn.net, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mairacanal@riseup.net, melissa.srw@gmail.com, mripard@kernel.org, rodrigosiqueiramelo@gmail.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mduggan@chromium.org, hirono@chromium.org, Brandon Pollack Subject: [PATCH v4 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects Date: Thu, 24 Aug 2023 08:40:32 +0000 Message-ID: <20230824084350.1062579-2-brpol@chromium.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog In-Reply-To: <20230824084350.1062579-1-brpol@chromium.org> References: <20230824084350.1062579-1-brpol@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jim Shargo This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c | 128 +++++++++++++++-------------- drivers/gpu/drm/vkms/vkms_drv.h | 4 +- drivers/gpu/drm/vkms/vkms_output.c | 6 +- 3 files changed, 71 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_dr= v.c index dd0af086e7fa..387c832f5dc9 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -9,10 +9,12 @@ * the GPU in DRM API tests. */ =20 +#include #include #include #include =20 +#include #include #include #include @@ -37,8 +39,6 @@ #define DRIVER_MAJOR 1 #define DRIVER_MINOR 0 =20 -static struct vkms_config *default_config; - static bool enable_cursor =3D true; module_param_named(enable_cursor, enable_cursor, bool, 0444); MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor support"); @@ -96,9 +96,9 @@ static int vkms_config_show(struct seq_file *m, void *dat= a) struct drm_device *dev =3D entry->dev; struct vkms_device *vkmsdev =3D drm_device_to_vkms_device(dev); =20 - seq_printf(m, "writeback=3D%d\n", vkmsdev->config->writeback); - seq_printf(m, "cursor=3D%d\n", vkmsdev->config->cursor); - seq_printf(m, "overlay=3D%d\n", vkmsdev->config->overlay); + seq_printf(m, "writeback=3D%d\n", vkmsdev->config.writeback); + seq_printf(m, "cursor=3D%d\n", vkmsdev->config.cursor); + seq_printf(m, "overlay=3D%d\n", vkmsdev->config.overlay); =20 return 0; } @@ -166,121 +166,127 @@ static int vkms_modeset_init(struct vkms_device *vk= msdev) dev->mode_config.cursor_height =3D 512; /* FIXME: There's a confusion between bpp and depth between this and * fbdev helpers. We have to go with 0, meaning "pick the default", - * which ix XRGB8888 in all cases. */ + * which ix XRGB8888 in all cases. + */ dev->mode_config.preferred_depth =3D 0; dev->mode_config.helper_private =3D &vkms_mode_config_helpers; =20 return vkms_output_init(vkmsdev, 0); } =20 -static int vkms_create(struct vkms_config *config) +static int vkms_platform_probe(struct platform_device *pdev) { int ret; - struct platform_device *pdev; struct vkms_device *vkms_device; + void *grp; =20 - pdev =3D platform_device_register_simple(DRIVER_NAME, -1, NULL, 0); - if (IS_ERR(pdev)) - return PTR_ERR(pdev); - - if (!devres_open_group(&pdev->dev, NULL, GFP_KERNEL)) { - ret =3D -ENOMEM; - goto out_unregister; - } + grp =3D devres_open_group(&pdev->dev, NULL, GFP_KERNEL); + if (!grp) + return -ENOMEM; =20 vkms_device =3D devm_drm_dev_alloc(&pdev->dev, &vkms_driver, struct vkms_device, drm); if (IS_ERR(vkms_device)) { ret =3D PTR_ERR(vkms_device); - goto out_devres; + goto out_release_group; } + vkms_device->platform =3D pdev; - vkms_device->config =3D config; - config->dev =3D vkms_device; + vkms_device->config.cursor =3D enable_cursor; + vkms_device->config.writeback =3D enable_writeback; + vkms_device->config.overlay =3D enable_overlay; =20 ret =3D dma_coerce_mask_and_coherent(vkms_device->drm.dev, DMA_BIT_MASK(64)); - if (ret) { DRM_ERROR("Could not initialize DMA support\n"); - goto out_devres; + goto out_release_group; } =20 ret =3D drm_vblank_init(&vkms_device->drm, 1); if (ret) { DRM_ERROR("Failed to vblank\n"); - goto out_devres; + goto out_release_group; } =20 ret =3D vkms_modeset_init(vkms_device); - if (ret) - goto out_devres; + if (ret) { + DRM_ERROR("Unable to initialize modesetting\n"); + goto out_release_group; + } =20 drm_debugfs_add_files(&vkms_device->drm, vkms_config_debugfs_list, ARRAY_SIZE(vkms_config_debugfs_list)); =20 ret =3D drm_dev_register(&vkms_device->drm, 0); - if (ret) - goto out_devres; + if (ret) { + DRM_ERROR("Unable to register device with id %d\n", pdev->id); + goto out_release_group; + } =20 drm_fbdev_generic_setup(&vkms_device->drm, 0); + platform_set_drvdata(pdev, vkms_device); + devres_close_group(&pdev->dev, grp); =20 return 0; =20 -out_devres: - devres_release_group(&pdev->dev, NULL); -out_unregister: - platform_device_unregister(pdev); +out_release_group: + devres_release_group(&pdev->dev, grp); return ret; } =20 -static int __init vkms_init(void) +static int vkms_platform_remove(struct platform_device *pdev) { - int ret; - struct vkms_config *config; - - config =3D kmalloc(sizeof(*config), GFP_KERNEL); - if (!config) - return -ENOMEM; - - default_config =3D config; + struct vkms_device *vkms_device; =20 - config->cursor =3D enable_cursor; - config->writeback =3D enable_writeback; - config->overlay =3D enable_overlay; + vkms_device =3D platform_get_drvdata(pdev); + if (!vkms_device) + return 0; =20 - ret =3D vkms_create(config); - if (ret) - kfree(config); - - return ret; + drm_dev_unregister(&vkms_device->drm); + drm_atomic_helper_shutdown(&vkms_device->drm); + return 0; } =20 -static void vkms_destroy(struct vkms_config *config) +static struct platform_driver vkms_platform_driver =3D { + .probe =3D vkms_platform_probe, + .remove =3D vkms_platform_remove, + .driver.name =3D DRIVER_NAME, +}; + +static int __init vkms_init(void) { + int ret; struct platform_device *pdev; =20 - if (!config->dev) { - DRM_INFO("vkms_device is NULL.\n"); - return; + ret =3D platform_driver_register(&vkms_platform_driver); + if (ret) { + DRM_ERROR("Unable to register platform driver\n"); + return ret; } =20 - pdev =3D config->dev->platform; - - drm_dev_unregister(&config->dev->drm); - drm_atomic_helper_shutdown(&config->dev->drm); - devres_release_group(&pdev->dev, NULL); - platform_device_unregister(pdev); + pdev =3D platform_device_register_simple(DRIVER_NAME, -1, NULL, 0); + if (IS_ERR(pdev)) { + platform_driver_unregister(&vkms_platform_driver); + return PTR_ERR(pdev); + } =20 - config->dev =3D NULL; + return 0; } =20 static void __exit vkms_exit(void) { - if (default_config->dev) - vkms_destroy(default_config); + struct device *dev; + + while ((dev =3D platform_find_device_by_driver( + NULL, &vkms_platform_driver.driver))) { + // platform_find_device_by_driver increments the refcount. Drop + // it so we don't leak memory. + put_device(dev); + platform_device_unregister(to_platform_device(dev)); + } =20 - kfree(default_config); + platform_driver_unregister(&vkms_platform_driver); } =20 module_init(vkms_init); diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index c7ae6c2ba1df..4c35d6305f2a 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -124,15 +124,13 @@ struct vkms_config { bool writeback; bool cursor; bool overlay; - /* only set when instantiated */ - struct vkms_device *dev; }; =20 struct vkms_device { struct drm_device drm; struct platform_device *platform; struct vkms_output output; - const struct vkms_config *config; + struct vkms_config config; }; =20 #define drm_crtc_to_vkms_output(target) \ diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms= _output.c index 5ce70dd946aa..963a64cf068b 100644 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ b/drivers/gpu/drm/vkms/vkms_output.c @@ -62,7 +62,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int ind= ex) if (IS_ERR(primary)) return PTR_ERR(primary); =20 - if (vkmsdev->config->overlay) { + if (vkmsdev->config.overlay) { for (n =3D 0; n < NUM_OVERLAY_PLANES; n++) { ret =3D vkms_add_overlay_plane(vkmsdev, index, crtc); if (ret) @@ -70,7 +70,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int ind= ex) } } =20 - if (vkmsdev->config->cursor) { + if (vkmsdev->config.cursor) { cursor =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_CURSOR, index); if (IS_ERR(cursor)) return PTR_ERR(cursor); @@ -103,7 +103,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int i= ndex) goto err_attach; } =20 - if (vkmsdev->config->writeback) { + if (vkmsdev->config.writeback) { writeback =3D vkms_enable_writeback_connector(vkmsdev); if (writeback) DRM_ERROR("Failed to init writeback connector\n"); --=20 2.42.0.rc1.204.g551eb34607-goog