From nobody Fri Sep 20 12:36:38 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DEADEE49A3 for ; Wed, 23 Aug 2023 13:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233871AbjHWNRv (ORCPT ); Wed, 23 Aug 2023 09:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235710AbjHWNRq (ORCPT ); Wed, 23 Aug 2023 09:17:46 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FC631981 for ; Wed, 23 Aug 2023 06:17:14 -0700 (PDT) Received: from lvc-arm12.ispras.local (unknown [83.149.199.126]) by mail.ispras.ru (Postfix) with ESMTPSA id ABAB840F1DF0; Wed, 23 Aug 2023 13:16:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru ABAB840F1DF0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1692796572; bh=sV7vYQTyiAy3nWGgqxmiyOUH3WUFfyCP18D7p2WE0W4=; h=From:To:Cc:Subject:Date:From; b=lr9dSMDK0+Z2UduJ9y/kFVIhW9+SRTiDbNkUlken3blmfvBYbdbLOJWl/PBxt7iqE MGWQwTw0lnclYj86DXDWr+nQ/YN5DDFdBqChE93J8wQbiMY2SaNHxhYtd43m+vJlUr all6a9W/shqONNfNY+r9Xpm5eAn0aUhf5xK9Gv4I= From: Katya Orlova To: Chun-Kuang Hu Cc: Katya Orlova , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lvc-project@linuxtesting.org Subject: [PATCH] drm/mediatek: mtk_drm_crtc: Avoid inappropriate kfree() in Date: Wed, 23 Aug 2023 16:15:38 +0300 Message-Id: <20230823131538.29222-1-e.orlova@ispras.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" mtk_drm_crtc_create() and mtk_drm_cmdq_pkt_destroy() are called with argument 'pkt' pointed to a field 'cmdq_handle' of 'mtk_crtc' structure. There is no need to kfree it. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 7627122fd1c0 ("drm/mediatek: Add cmdq_handle in mtk_crtc") Signed-off-by: Katya Orlova --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/medi= atek/mtk_drm_crtc.c index d40142842f85..ba7307efa675 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -117,7 +117,6 @@ static int mtk_drm_cmdq_pkt_create(struct cmdq_client *= client, struct cmdq_pkt * =20 pkt->va_base =3D kzalloc(size, GFP_KERNEL); if (!pkt->va_base) { - kfree(pkt); return -ENOMEM; } pkt->buf_size =3D size; @@ -129,7 +128,6 @@ static int mtk_drm_cmdq_pkt_create(struct cmdq_client *= client, struct cmdq_pkt * if (dma_mapping_error(dev, dma_addr)) { dev_err(dev, "dma map failed, size=3D%u\n", (u32)(u64)size); kfree(pkt->va_base); - kfree(pkt); return -ENOMEM; } =20 @@ -145,7 +143,6 @@ static void mtk_drm_cmdq_pkt_destroy(struct cmdq_pkt *p= kt) dma_unmap_single(client->chan->mbox->dev, pkt->pa_base, pkt->buf_size, DMA_TO_DEVICE); kfree(pkt->va_base); - kfree(pkt); } #endif =20 --=20 2.30.2